Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/44453/?format=api
{ "id": 44453, "url": "http://patchwork.dpdk.org/api/patches/44453/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/1536438666-22184-12-git-send-email-rasesh.mody@cavium.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1536438666-22184-12-git-send-email-rasesh.mody@cavium.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1536438666-22184-12-git-send-email-rasesh.mody@cavium.com", "date": "2018-09-08T20:31:00", "name": "[11/17] net/qede: fix flow director bug for IPv6 filter", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "d9c56b95f63458831dd959e3e0d2616678b7bf94", "submitter": { "id": 569, "url": "http://patchwork.dpdk.org/api/people/569/?format=api", "name": "Mody, Rasesh", "email": "rasesh.mody@cavium.com" }, "delegate": { "id": 319, "url": "http://patchwork.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/1536438666-22184-12-git-send-email-rasesh.mody@cavium.com/mbox/", "series": [ { "id": 1239, "url": "http://patchwork.dpdk.org/api/series/1239/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=1239", "date": "2018-09-08T20:30:49", "name": "net/qede: add enhancements and fixes", "version": 1, "mbox": "http://patchwork.dpdk.org/series/1239/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/44453/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/44453/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 4E3775F17;\n\tSat, 8 Sep 2018 22:32:06 +0200 (CEST)", "from NAM04-BN3-obe.outbound.protection.outlook.com\n\t(mail-eopbgr680074.outbound.protection.outlook.com [40.107.68.74])\n\tby dpdk.org (Postfix) with ESMTP id 972B35323;\n\tSat, 8 Sep 2018 22:31:55 +0200 (CEST)", "from cavium.com (198.186.1.5) by\n\tDM6PR07MB5372.namprd07.prod.outlook.com (2603:10b6:5:44::17) with\n\tMicrosoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n\t15.20.1101.18; Sat, 8 Sep 2018 20:31:53 +0000" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com;\n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n\tbh=0nE3fbT7SQ1civeYea8k8KqFfUhpdj8sG4BRPGZoDmY=;\n\tb=A3ZFSmBFwmVizgSkgyHG59A07MwZpJ7uUIz8wqQ0fsJdOiAubEtVCr32SP5P9lgzoCEs0AqXt8VUsW3x5diu5t3o44O7QDBHdWniYQ9dSw5H11QKaJA50Id/TQc44vPoQUkbUfcUgRtuyLjWhmXbcPm/YPQgT/hl3zFBufO+w5A=", "Authentication-Results": "spf=none (sender IP is )\n\tsmtp.mailfrom=Rasesh.Mody@cavium.com; ", "From": "Rasesh Mody <rasesh.mody@cavium.com>", "To": "dev@dpdk.org", "Cc": "Shahed Shaikh <shahed.shaikh@cavium.com>, ferruh.yigit@intel.com,\n\tDept-EngDPDKDev@cavium.com, stable@dpdk.org", "Date": "Sat, 8 Sep 2018 13:31:00 -0700", "Message-Id": "<1536438666-22184-12-git-send-email-rasesh.mody@cavium.com>", "X-Mailer": "git-send-email 1.7.10.3", "In-Reply-To": "<1536438666-22184-1-git-send-email-rasesh.mody@cavium.com>", "References": "<1536438666-22184-1-git-send-email-rasesh.mody@cavium.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-Originating-IP": "[198.186.1.5]", "X-ClientProxiedBy": "BYAPR02CA0031.namprd02.prod.outlook.com\n\t(2603:10b6:a02:ee::44) To DM6PR07MB5372.namprd07.prod.outlook.com\n\t(2603:10b6:5:44::17)", "X-MS-PublicTrafficType": "Email", "X-MS-Office365-Filtering-Correlation-Id": "94ba0b31-fba5-4a85-e63c-08d615ca1d1c", "X-Microsoft-Antispam": "BCL:0; PCL:0;\n\tRULEID:(7020095)(4652040)(8989137)(4534165)(4627221)(201703031133081)(201702281549075)(8990107)(5600074)(711020)(2017052603328)(7153060)(7193020);\n\tSRVR:DM6PR07MB5372; ", "X-Microsoft-Exchange-Diagnostics": [ "1; DM6PR07MB5372;\n\t3:xcNt6LlFAOY1RT7HDBvzl2OH2YtWBe1+WdyAy7Rs6fqkYKiOOYEGfJOW8o/vRrMuBDnlEhBOvNU+Ht59pqWA/FfnAiOp2IEmXCYiW79qh3aqLofaVx5Wp41LAyhRea3Qzx4wHZAkyu8fDa+bU3Hqv1bUJv2HOafhJPS2Yho0p1cDsicQ/Kf3TjeI/pKUFUsDGercxTEjsBNOjL2GmUrdx+PV4dvstoyvVi9Kf+BfCeSMDolDHpnxuCZChsQT6AfE;\n\t25:q4fUAIpaK4WsbeKek8rGw40bzq3bQmQgxJyEPgvr9ICZ23Tl0NQ3BPD++eznG0ut9PaCNmTajftFTIWn+jtcRirO373swHtWJLc593f/jJGdn3mzom1iAoEU1xA5losV8LnItDnSpTEeU15iHt3bPZDamet/31OCrxtLMbfsgVX/y067T54sY0AVpa2Gk11gV5Yb3JGqph0GQIKtzTfkMW/eLFBOKaFdm6hSxNQt3be5QkBNum5LG2ohU94OCXlg2Kli7vBWUSEirkCivfuY6G9iGjnwgzuSeSGMqCtfDnTDDo2VEs2fju7fwYV6ob0oVkYt8A4fcnLUqCCROsO28A==;\n\t31:UVnwqvrbKsBPSi4XlOka23RVVk+wsoWb2NexFEiNIzc95vS04aG+pbnZTjEJBSzqN0JJHWkJf5SfnCkDpzIEb/KsUn6V7i8SfylXC5IN1hUDty+h6Tp+7z5NEDPmRW6zIdbs2ySxbZ1j4t1lZeCbovHChlWwTTlvuzAMpobtOPeBKNiIvn9/oOui6429cYXvfDcORnG6MzZ+H0pPwBmK5q0jzHncFT1qOh1i39cDrGg=", "1; DM6PR07MB5372;\n\t20:osHwImoGtnHHwYXej0/teMMPMUUe1v+19zFLec7mujtH4C/g6Nl2ADZ0SNR1lWWwr28ESuvrcdrcG5+UgZlwE9MlXQgFzRiOOq85iV5ino7dA7ZhlYqVvBqP+bafpgXLoEmsCb2UMP+GjPSLZMaYd4uk1cRcYYJ1LIkaoNjfkW9YL473yZeu39pMrBTzAIsWIlcp4IgUE38TB/p8sVPfRXsMWsR2EyE+QRDMeAjc6DTqmXLnYhUP5ZhC9eLP1Lq5JFed5DA0PSP014CXsWTL5YTRVwbsbouM6akbJ9orjNzvutea1BPXrNXH2WnmWkjD8EtDZRvTtsYWpOHckupBecLJYA9wmJtlyyTXke6uPqw3gL9W06QTzlJkFDoRwD4cVrAwHB0WmKIyVX56FsMHVYEIx1aOwY1qhNeA51bHjF4tw3kXlOb/aRPV7FmkoZwq/uuJHwSV47giN1ItShJda+o3YkKczravc1vzOcEf0+fJp4HDn0FnP6nAm6YmxzpV;\n\t4:oz7aKpsqtjuaCk1kdYTthY46SA2OJy2F9ouaK5OVEBFsjUM+3dm6Hal5izkDKLqBVOID/DbtPxjm8d41o8358erRT6StKaP9q7SAE+XiqDDxQrV4EiiHWom+UK/7lRfiTHCJIrrwn5qWd+LpnCwhbk5yWOkXkTRj737DhljtJmokjpvz+F+FywB1AKT8Jk7u5IeopcTjZk0HIeuONlvA13VsQBSNXlHB39RRzf9EZsrFolv8Qz3X0fjEYHF68Y//qmaxm1Qg/dEz7fM96LjQMA==", "=?us-ascii?Q?1; DM6PR07MB5372;\n\t23:K3HXGHk2CAVpkrwBuChsanaPCidAtxo7Dyx07BMCe?=\n\tLzAnHA5yLzb4eQ8yVFXVA4PmoN4Gte/lt4hMFHVAyd5P2Gi9seGLAjmfaRgwzlQBRlAw070b2DaExltT1VxVOHVnuC4ihujRYy009TEGEyTNFuD4t8+JKlYod6Sy7cfMnJwElwxnoBpvpQ4TJHo3ef9HsaJhJ2mse0Y0XdEhxnijxJCg4JIr7E65P7Quotix/z9+2mGZcFtsPXy1C8GrIF7jKKwjNiRi43wHxspzPTstLjebd9SigwS0xkws+Z4FazFfiy1rklHstlpjLWQO9X/m4+BBKs4x6Pab7c5HcTzxHI6o6S15qRhvVaOpyJqRAIxAv1zFV5HxDlE3VfwWYlE6FOADTU+7RSue0BdVUP19qZ/xTh/dNThb6Ikzy2gj8zkOB0UCkMAQR3tmZsgLHVUPa/fVYk1mWrseTd8T1R69zL9Peobnfnt9T91nEvHotpInAN98TAqBGAyViUyz+duEPkNhBcjXZxd46qZKnqQGIqlfJz+gyCcR4kyNmctwpsCfGkvlzbJOI5qrN3qRQrHg1Zg/iLYGD85BUQSAlXYJ/lIl/D+KLxYFv3qcgOtp53fbHtaHmq1IR+jDIZGORXDfYVJwbxDMudgU+IjId4CI0vkHH2Pr4dhfi+Rmd5k7V/KLulJstq3i71EwfWBKf5fy9FqoEjzUgLkyR6dcSSToqsqQChLP16dWOuGRaC8rWKO0ZZnt4N6/E/pErNuhyWKP82eVJPu43ppe4rOOrTQKI/mdPWcc6/K8U3bhAkTs6fUMcQAHWb2KjsBVivPhh3C9DpRiy977EZakXcs0XEIgfKnxg3V5HWAgpDL0PlnPoVHAlA99BO7ZvsJvxBGvmUI71tGpTZdGD6POcLegmYxLmcHFo4hBKC6KyQAkb3FRlj46fVEOTNWPB+IjQ39uskjpigmf2dyEGI3Ug6Mh07kDkoVOlMexXAxHQzCKlBGGpOBHQfEp4xaloLdfiPWhoOL28WUHU9ttKk5FTHYePGjwdyQYdAFSiIioTXO0709cBJF+uN28hStsRadvdYsD+TisSgR3Lt3E6bevm3Q7SMCl2Z86QPYZ8uCr7fWQH+k1y2ijt3GenKgx2+Ul+AR+PW1j+LzY/s9OGrIJQFZXYO3ZHa9o3Y+g+SqAMWr8813CARJm3PoZxqDfRUppFkWaGZXFwdWamOhl+EzKEK3NG2S+0vwmhgqDWd8NlkDtT2liiMPUwhP86xuPEn4/CHL2YTzR5frM/5bBfZkvCDeQQ4ePg==", "1; DM6PR07MB5372;\n\t6:AlR7XXklS9HhIFqR930cDTtAR25EQ5r7AZUiSJJ/R5FnctYtPn/RZ2R2+u2UWc9WNXieiedYlst+ISLSLOp9EG0KXYJJS+Kp644iE0j+sEry2qBM/HwGXIM7fq35ZSzOolIA6ESfZfjGplrillsy20ZBXVw2suGA2X/7GWN5zkh9kRI0fqSIFB4DN6ZmjSYpg77EqilR+xUn7ndMrKdnY2mlR/dz+RalgtQLtw1zS5cvV5ADc1SvXCG4w8erJo7I0U0fLsH869NRTnMA4hwmkMzcteQver07nIKYugSjqeXRaTgL+DgOUcqzY6RkusQ9MB0hqI+L7fOO0miVKGUvKIk4UBpPZz5aMIa4/btDBixLGyc2sTTnSJU+T7o0Thphsk/j+GjgU7muHFLyOYsq3H4utrdw9WwT0PbVrlFxkqNXWHDf/Q0Z8v6OCaUwhIsRDXRGhazHEGwaswIWwippsg==;\n\t5:SsGrOXwf980AVgn4fR3Kq1s+pDS6Dax2Ocff+dj7rmyLKkwB7t/F23LkH5T6uFxY/ssPXxejtw4gL2Ab0Nn4EvjA80qCZNm3/Ds2dW7oJhKppqY80tt2DuL3qr840Ho426wd0q6qV5GhT6U2aYIzycpVHoQGv79YPmPFjwfOQKs=;\n\t7:0bhYTQCgvVjlnURnXrB9h1RqILTdmeVc2F0dBaXhDWvEsGQeDCWrTHR1nWvBKLqwWy9Vvx3nPjYXM67Ub36TwuUD4FSPr72LxNR5z7PcRXkbLmUAT2lYeFrjGSr65fZygj9ziTvoFlEbFma43WTRNnBVIXcJxDpxw59QOrqsMw/2ZGX+Nu1qis3aOnFpgZAwmjAc1azfVh78MoYBJaSO4Cu57B+SK8YxVx6gPe4jmn52AvwfSbZ+xQvesb2dQuTe" ], "X-MS-TrafficTypeDiagnostic": "DM6PR07MB5372:", "X-Microsoft-Antispam-PRVS": "<DM6PR07MB5372578850219D7DFEA9B9359F070@DM6PR07MB5372.namprd07.prod.outlook.com>", "X-Exchange-Antispam-Report-Test": "UriScan:;", "X-MS-Exchange-SenderADCheck": "1", "X-Exchange-Antispam-Report-CFA-Test": "BCL:0; PCL:0;\n\tRULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(823301075)(3002001)(10201501046)(3231311)(944501410)(52105095)(93006095)(93001095)(149027)(150027)(6041310)(20161123562045)(20161123564045)(20161123558120)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(201708071742011)(7699050);\n\tSRVR:DM6PR07MB5372; BCL:0; PCL:0; RULEID:; SRVR:DM6PR07MB5372; ", "X-Forefront-PRVS": "07891BF289", "X-Forefront-Antispam-Report": "SFV:NSPM;\n\tSFS:(10009020)(396003)(366004)(136003)(346002)(376002)(39860400002)(199004)(189003)(4720700003)(97736004)(2351001)(106356001)(105586002)(72206003)(66066001)(47776003)(4326008)(50466002)(48376002)(25786009)(305945005)(7736002)(2361001)(8676002)(478600001)(316002)(52116002)(69596002)(186003)(50226002)(44832011)(16526019)(486006)(21086003)(2906002)(55016002)(26005)(8936002)(476003)(956004)(81156014)(81166006)(86362001)(5660300001)(6666003)(36756003)(16586007)(11346002)(446003)(2616005)(76176011)(3846002)(6116002)(6916009)(68736007)(386003)(51416003)(53936002)(7696005);\n\tDIR:OUT; SFP:1101; SCL:1; SRVR:DM6PR07MB5372; H:cavium.com; FPR:;\n\tSPF:None; \n\tLANG:en; PTR:InfoNoRecords; A:1; MX:1; ", "Received-SPF": "None (protection.outlook.com: cavium.com does not designate\n\tpermitted sender hosts)", "X-Microsoft-Antispam-Message-Info": "8GCFrV43naLBFaE8wuuJfee28rwSd4Qzg5hG2dE8UKPwk2t9kcjE3omeShlYiSiYr8jW9+N0q/OjUxyP81cuqptjQLu9COtjSiIs7r3SDdoxztYo9eTMG4JduWFScP0MeAEvaII+V26baJlSai+Ic5aPv1gLaTb9ohwuweWLDscSYbX6O4CIX5icTldSZLOpYej9IkHcIQRpGpZvD4mhlBpzyK35GiYen1pqGEHEGWQ/MZQ7jHxEgv3p4tCbgjB+QbKumZ/s1sVrJ1CwfAeKNX1gWr1aCstgNQpSBMxc0s//ZU4gs7k+GdTYZyiLf68Ebz3zlR8A0Q3PpTdgImPx+B6f+G5SLfqPm4xisJIC6fQ=", "SpamDiagnosticOutput": "1:99", "SpamDiagnosticMetadata": "NSPM", "X-OriginatorOrg": "cavium.com", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "08 Sep 2018 20:31:53.1764\n\t(UTC)", "X-MS-Exchange-CrossTenant-Network-Message-Id": "94ba0b31-fba5-4a85-e63c-08d615ca1d1c", "X-MS-Exchange-CrossTenant-FromEntityHeader": "Hosted", "X-MS-Exchange-CrossTenant-Id": "711e4ccf-2e9b-4bcf-a551-4094005b6194", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "DM6PR07MB5372", "Subject": "[dpdk-dev] [PATCH 11/17] net/qede: fix flow director bug for IPv6\n\tfilter", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Shahed Shaikh <shahed.shaikh@cavium.com>\n\n- PMD does not fill vtc_flow field of IPv6 header while\n constructing a packet for IPv6 filter. Hence filter was\n not getting applied properly.\n- IPv6 addresses got swapped while copying src and dst addresses.\n- Same issue with UDP and TCP port ids.\n\nFixes: 622075356e8f (\"net/qede: support ntuple and flow director filter\")\nCc: stable@dpdk.org\n\nSigned-off-by: Shahed Shaikh <shahed.shaikh@cavium.com>\n---\n drivers/net/qede/qede_filter.c | 18 +++++++++++-------\n 1 file changed, 11 insertions(+), 7 deletions(-)", "diff": "diff --git a/drivers/net/qede/qede_filter.c b/drivers/net/qede/qede_filter.c\nindex b8460a0..4b709e6 100644\n--- a/drivers/net/qede/qede_filter.c\n+++ b/drivers/net/qede/qede_filter.c\n@@ -121,7 +121,7 @@\n #define QEDE_FDIR_IP_DEFAULT_VERSION_IHL\t(IP_VERSION | IP_HDRLEN)\n #define QEDE_FDIR_TCP_DEFAULT_DATAOFF\t\t(0x50)\n #define QEDE_FDIR_IPV4_DEF_TTL\t\t\t(64)\n-\n+#define QEDE_FDIR_IPV6_DEFAULT_VTC_FLOW\t\t(0x60000000)\n /* Sum of length of header types of L2, L3, L4.\n * L2 : ether_hdr + vlan_hdr + vxlan_hdr\n * L3 : ipv6_hdr\n@@ -445,24 +445,28 @@ void qede_fdir_dealloc_resc(struct rte_eth_dev *eth_dev)\n \t\tip6->proto = input->flow.ipv6_flow.proto ?\n \t\t\t\t\tinput->flow.ipv6_flow.proto :\n \t\t\t\t\tnext_proto[input->flow_type];\n-\t\trte_memcpy(&ip6->src_addr, &input->flow.ipv6_flow.dst_ip,\n+\t\tip6->vtc_flow =\n+\t\t\trte_cpu_to_be_32(QEDE_FDIR_IPV6_DEFAULT_VTC_FLOW);\n+\n+\t\trte_memcpy(&ip6->src_addr, &input->flow.ipv6_flow.src_ip,\n \t\t\t IPV6_ADDR_LEN);\n-\t\trte_memcpy(&ip6->dst_addr, &input->flow.ipv6_flow.src_ip,\n+\t\trte_memcpy(&ip6->dst_addr, &input->flow.ipv6_flow.dst_ip,\n \t\t\t IPV6_ADDR_LEN);\n \t\tlen += sizeof(struct ipv6_hdr);\n+\t\tparams->ipv6 = true;\n \n \t\traw_pkt = (uint8_t *)buff;\n \t\t/* UDP */\n \t\tif (input->flow_type == RTE_ETH_FLOW_NONFRAG_IPV6_UDP) {\n \t\t\tudp = (struct udp_hdr *)(raw_pkt + len);\n-\t\t\tudp->src_port = input->flow.udp6_flow.dst_port;\n-\t\t\tudp->dst_port = input->flow.udp6_flow.src_port;\n+\t\t\tudp->src_port = input->flow.udp6_flow.src_port;\n+\t\t\tudp->dst_port = input->flow.udp6_flow.dst_port;\n \t\t\tlen += sizeof(struct udp_hdr);\n \t\t\tparams->udp = true;\n \t\t} else { /* TCP */\n \t\t\ttcp = (struct tcp_hdr *)(raw_pkt + len);\n-\t\t\ttcp->src_port = input->flow.tcp4_flow.src_port;\n-\t\t\ttcp->dst_port = input->flow.tcp4_flow.dst_port;\n+\t\t\ttcp->src_port = input->flow.tcp6_flow.src_port;\n+\t\t\ttcp->dst_port = input->flow.tcp6_flow.dst_port;\n \t\t\ttcp->data_off = QEDE_FDIR_TCP_DEFAULT_DATAOFF;\n \t\t\tlen += sizeof(struct tcp_hdr);\n \t\t\tparams->tcp = true;\n", "prefixes": [ "11/17" ] }