Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/44472/?format=api
{ "id": 44472, "url": "http://patchwork.dpdk.org/api/patches/44472/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/1536572016-18134-2-git-send-email-arybchenko@solarflare.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1536572016-18134-2-git-send-email-arybchenko@solarflare.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1536572016-18134-2-git-send-email-arybchenko@solarflare.com", "date": "2018-09-10T09:33:00", "name": "[01/37] net/sfc/base: fix PreFAST warnings because of unused return", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "0e888d385b3e646df3496011b496b5f8948aac49", "submitter": { "id": 607, "url": "http://patchwork.dpdk.org/api/people/607/?format=api", "name": "Andrew Rybchenko", "email": "arybchenko@solarflare.com" }, "delegate": { "id": 319, "url": "http://patchwork.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/1536572016-18134-2-git-send-email-arybchenko@solarflare.com/mbox/", "series": [ { "id": 1244, "url": "http://patchwork.dpdk.org/api/series/1244/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=1244", "date": "2018-09-10T09:33:01", "name": "net/sfc: update base driver", "version": 1, "mbox": "http://patchwork.dpdk.org/series/1244/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/44472/comments/", "check": "warning", "checks": "http://patchwork.dpdk.org/api/patches/44472/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 90A034F9C;\n\tMon, 10 Sep 2018 11:34:03 +0200 (CEST)", "from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com\n\t[67.231.154.164]) by dpdk.org (Postfix) with ESMTP id 616EF4C90;\n\tMon, 10 Sep 2018 11:33:50 +0200 (CEST)", "from webmail.solarflare.com (webmail.solarflare.com\n\t[12.187.104.26])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby mx1-us1.ppe-hosted.com (Proofpoint Essentials ESMTP Server) with\n\tESMTPS id 771A3780055; Mon, 10 Sep 2018 09:33:49 +0000 (UTC)", "from ocex03.SolarFlarecom.com (10.20.40.36) by\n\tocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server\n\t(TLS) id 15.0.1395.4; Mon, 10 Sep 2018 02:33:46 -0700", "from opal.uk.solarflarecom.com (10.17.10.1) by\n\tocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server\n\t(TLS) id\n\t15.0.1395.4 via Frontend Transport; Mon, 10 Sep 2018 02:33:46 -0700", "from ukv-loginhost.uk.solarflarecom.com\n\t(ukv-loginhost.uk.solarflarecom.com [10.17.10.39])\n\tby opal.uk.solarflarecom.com (8.13.8/8.13.8) with ESMTP id\n\tw8A9Xic2023758; Mon, 10 Sep 2018 10:33:44 +0100", "from ukv-loginhost.uk.solarflarecom.com (localhost [127.0.0.1])\n\tby ukv-loginhost.uk.solarflarecom.com (Postfix) with ESMTP id\n\tB2CE21626D2; Mon, 10 Sep 2018 10:33:44 +0100 (BST)" ], "X-Virus-Scanned": "Proofpoint Essentials engine", "From": "Andrew Rybchenko <arybchenko@solarflare.com>", "To": "<dev@dpdk.org>", "CC": "Martin Harvey <mharvey@solarflare.com>, <stable@dpdk.org>", "Date": "Mon, 10 Sep 2018 10:33:00 +0100", "Message-ID": "<1536572016-18134-2-git-send-email-arybchenko@solarflare.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1536572016-18134-1-git-send-email-arybchenko@solarflare.com>", "References": "<1536572016-18134-1-git-send-email-arybchenko@solarflare.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-TM-AS-Product-Ver": "SMEX-12.5.0.1300-8.5.1010-24084.005", "X-TM-AS-Result": "No-2.872500-4.000000-10", "X-TMASE-MatchedRID": "YiUl3khqEFvXtNJCpndN7B+WEMjoO9WWTJDl9FKHbrkECNzb4lqeE4x7\n\tZjlScdFiJG7mrBlA0Wbr7SPT8Hk75q0ZS7JYIH8qdXu122+iJtqCxYB2hPS4vZ6fSoF3Lt+M0DM\n\t+v/G/NaMplgX7alUsZi9BcVjiFee6ODilBbykZNjN+qWlu2ZxaLuesBT0pDFRTUobVis5Bb/wWE\n\taNOnlY98kKsR0ZCHAYv3qMIf4+lJskQChizqpxHC0x8J2DopENo5KBmcJozDabKItl61J/yVE3W\n\tP5nX017SSluJg5SbDEqyYS0oyUVZpHRZMsyjF+nvORAMgyK5AgzdBmoFST/Jra6zf0LsBzQg4Dr\n\tK0YGtc17CLUSwCAWZuX32aKj/Z9MMWIiU4GP0CQTPQrqRHLSi71NuKS30BZnQIFIZLtsgG0DUH+\n\tnVLNyiCsqIP9TxvtJo1s8kG68toueqD9WtJkSIw==", "X-TM-AS-User-Approved-Sender": "No", "X-TM-AS-User-Blocked-Sender": "No", "X-TMASE-Result": "10-2.872500-4.000000", "X-TMASE-Version": "SMEX-12.5.0.1300-8.5.1010-24084.005", "X-MDID": "1536572030-2Nz5yW9pstVh", "Subject": "[dpdk-dev] [PATCH 01/37] net/sfc/base: fix PreFAST warnings because\n\tof unused return", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Martin Harvey <mharvey@solarflare.com>\n\nFixes: 19b64c6ac35f (\"net/sfc/base: import libefx base\")\nFixes: d96a34d165b1 (\"net/sfc/base: import NVRAM support\")\nFixes: e7cd430c864f (\"net/sfc/base: import SFN7xxx family support\")\nCc: stable@dpdk.org\n\nSigned-off-by: Martin Harvey <mharvey@solarflare.com>\nSigned-off-by: Andrew Rybchenko <arybchenko@solarflare.com>\n---\n drivers/net/sfc/base/ef10_filter.c | 47 ++++++++++++++++++++++++------\n drivers/net/sfc/base/ef10_mac.c | 2 +-\n drivers/net/sfc/base/ef10_nic.c | 4 +--\n drivers/net/sfc/base/ef10_nvram.c | 4 +--\n drivers/net/sfc/base/ef10_tx.c | 8 +++--\n drivers/net/sfc/base/efx_port.c | 2 +-\n 6 files changed, 49 insertions(+), 18 deletions(-)", "diff": "diff --git a/drivers/net/sfc/base/ef10_filter.c b/drivers/net/sfc/base/ef10_filter.c\nindex ae872853d..a4d97f99c 100644\n--- a/drivers/net/sfc/base/ef10_filter.c\n+++ b/drivers/net/sfc/base/ef10_filter.c\n@@ -1144,12 +1144,15 @@ ef10_filter_insert_unicast(\n \tefx_filter_spec_init_rx(&spec, EFX_FILTER_PRI_AUTO,\n \t filter_flags,\n \t eftp->eft_default_rxq);\n-\tefx_filter_spec_set_eth_local(&spec, EFX_FILTER_SPEC_VID_UNSPEC, addr);\n+\trc = efx_filter_spec_set_eth_local(&spec, EFX_FILTER_SPEC_VID_UNSPEC,\n+\t addr);\n+\tif (rc != 0)\n+\t\tgoto fail1;\n \n \trc = ef10_filter_add_internal(enp, &spec, B_TRUE,\n \t &eftp->eft_unicst_filter_indexes[eftp->eft_unicst_filter_count]);\n \tif (rc != 0)\n-\t\tgoto fail1;\n+\t\tgoto fail2;\n \n \teftp->eft_unicst_filter_count++;\n \tEFSYS_ASSERT(eftp->eft_unicst_filter_count <=\n@@ -1157,6 +1160,8 @@ ef10_filter_insert_unicast(\n \n \treturn (0);\n \n+fail2:\n+\tEFSYS_PROBE(fail2);\n fail1:\n \tEFSYS_PROBE1(fail1, efx_rc_t, rc);\n \treturn (rc);\n@@ -1175,11 +1180,13 @@ ef10_filter_insert_all_unicast(\n \tefx_filter_spec_init_rx(&spec, EFX_FILTER_PRI_AUTO,\n \t filter_flags,\n \t eftp->eft_default_rxq);\n-\tefx_filter_spec_set_uc_def(&spec);\n+\trc = efx_filter_spec_set_uc_def(&spec);\n+\tif (rc != 0)\n+\t\tgoto fail1;\n \trc = ef10_filter_add_internal(enp, &spec, B_TRUE,\n \t &eftp->eft_unicst_filter_indexes[eftp->eft_unicst_filter_count]);\n \tif (rc != 0)\n-\t\tgoto fail1;\n+\t\tgoto fail2;\n \n \teftp->eft_unicst_filter_count++;\n \tEFSYS_ASSERT(eftp->eft_unicst_filter_count <=\n@@ -1187,6 +1194,8 @@ ef10_filter_insert_all_unicast(\n \n \treturn (0);\n \n+fail2:\n+\tEFSYS_PROBE(fail2);\n fail1:\n \tEFSYS_PROBE1(fail1, efx_rc_t, rc);\n \treturn (rc);\n@@ -1228,9 +1237,21 @@ ef10_filter_insert_multicast_list(\n \t\t filter_flags,\n \t\t eftp->eft_default_rxq);\n \n-\t\tefx_filter_spec_set_eth_local(&spec,\n+\t\trc = efx_filter_spec_set_eth_local(&spec,\n \t\t EFX_FILTER_SPEC_VID_UNSPEC,\n \t\t &addrs[i * EFX_MAC_ADDR_LEN]);\n+\t\tif (rc != 0) {\n+\t\t\tif (rollback == B_TRUE) {\n+\t\t\t\t/* Only stop upon failure if told to rollback */\n+\t\t\t\tgoto rollback;\n+\t\t\t} else {\n+\t\t\t\t/*\n+\t\t\t\t * Don't try to add a filter with a corrupt\n+\t\t\t\t * specification.\n+\t\t\t\t */\n+\t\t\t\tcontinue;\n+\t\t\t}\n+\t\t}\n \n \t\trc = ef10_filter_add_internal(enp, &spec, B_TRUE,\n \t\t\t\t\t &filter_index);\n@@ -1253,8 +1274,12 @@ ef10_filter_insert_multicast_list(\n \t\t eftp->eft_default_rxq);\n \n \t\tEFX_MAC_BROADCAST_ADDR_SET(addr);\n-\t\tefx_filter_spec_set_eth_local(&spec, EFX_FILTER_SPEC_VID_UNSPEC,\n-\t\t addr);\n+\t\trc = efx_filter_spec_set_eth_local(&spec,\n+\t\t EFX_FILTER_SPEC_VID_UNSPEC, addr);\n+\t\tif ((rc != 0) && (rollback == B_TRUE)) {\n+\t\t\t/* Only stop upon failure if told to rollback */\n+\t\t\tgoto rollback;\n+\t\t}\n \n \t\trc = ef10_filter_add_internal(enp, &spec, B_TRUE,\n \t\t\t\t\t &filter_index);\n@@ -1302,12 +1327,14 @@ ef10_filter_insert_all_multicast(\n \tefx_filter_spec_init_rx(&spec, EFX_FILTER_PRI_AUTO,\n \t filter_flags,\n \t eftp->eft_default_rxq);\n-\tefx_filter_spec_set_mc_def(&spec);\n+\trc = efx_filter_spec_set_mc_def(&spec);\n+\tif (rc != 0)\n+\t\tgoto fail1;\n \n \trc = ef10_filter_add_internal(enp, &spec, B_TRUE,\n \t &eftp->eft_mulcst_filter_indexes[0]);\n \tif (rc != 0)\n-\t\tgoto fail1;\n+\t\tgoto fail2;\n \n \teftp->eft_mulcst_filter_count = 1;\n \teftp->eft_using_all_mulcst = B_TRUE;\n@@ -1318,6 +1345,8 @@ ef10_filter_insert_all_multicast(\n \n \treturn (0);\n \n+fail2:\n+\tEFSYS_PROBE(fail2);\n fail1:\n \tEFSYS_PROBE1(fail1, efx_rc_t, rc);\n \ndiff --git a/drivers/net/sfc/base/ef10_mac.c b/drivers/net/sfc/base/ef10_mac.c\nindex 1031e8369..c14010732 100644\n--- a/drivers/net/sfc/base/ef10_mac.c\n+++ b/drivers/net/sfc/base/ef10_mac.c\n@@ -412,7 +412,7 @@ ef10_mac_filter_default_rxq_clear(\n \n \tef10_filter_default_rxq_clear(enp);\n \n-\tefx_filter_reconfigure(enp, epp->ep_mac_addr,\n+\t(void) efx_filter_reconfigure(enp, epp->ep_mac_addr,\n \t\t\t\t epp->ep_all_unicst, epp->ep_mulcst,\n \t\t\t\t epp->ep_all_mulcst, epp->ep_brdcst,\n \t\t\t\t epp->ep_mulcst_addr_list,\ndiff --git a/drivers/net/sfc/base/ef10_nic.c b/drivers/net/sfc/base/ef10_nic.c\nindex 7dbf843bf..d1985b3c5 100644\n--- a/drivers/net/sfc/base/ef10_nic.c\n+++ b/drivers/net/sfc/base/ef10_nic.c\n@@ -806,7 +806,7 @@ ef10_nic_alloc_piobufs(\n \tfor (i = 0; i < enp->en_arch.ef10.ena_piobuf_count; i++) {\n \t\thandlep = &enp->en_arch.ef10.ena_piobuf_handle[i];\n \n-\t\tefx_mcdi_free_piobuf(enp, *handlep);\n+\t\t(void) efx_mcdi_free_piobuf(enp, *handlep);\n \t\t*handlep = EFX_PIOBUF_HANDLE_INVALID;\n \t}\n \tenp->en_arch.ef10.ena_piobuf_count = 0;\n@@ -823,7 +823,7 @@ ef10_nic_free_piobufs(\n \tfor (i = 0; i < enp->en_arch.ef10.ena_piobuf_count; i++) {\n \t\thandlep = &enp->en_arch.ef10.ena_piobuf_handle[i];\n \n-\t\tefx_mcdi_free_piobuf(enp, *handlep);\n+\t\t(void) efx_mcdi_free_piobuf(enp, *handlep);\n \t\t*handlep = EFX_PIOBUF_HANDLE_INVALID;\n \t}\n \tenp->en_arch.ef10.ena_piobuf_count = 0;\ndiff --git a/drivers/net/sfc/base/ef10_nvram.c b/drivers/net/sfc/base/ef10_nvram.c\nindex 2883ec8f4..0d885ccdf 100644\n--- a/drivers/net/sfc/base/ef10_nvram.c\n+++ b/drivers/net/sfc/base/ef10_nvram.c\n@@ -1808,7 +1808,7 @@ ef10_nvram_partn_write_segment_tlv(\n \t\tgoto fail7;\n \n \t/* Unlock the partition */\n-\tef10_nvram_partn_unlock(enp, partn, NULL);\n+\t(void) ef10_nvram_partn_unlock(enp, partn, NULL);\n \n \tEFSYS_KMEM_FREE(enp->en_esip, partn_size, partn_data);\n \n@@ -1823,7 +1823,7 @@ ef10_nvram_partn_write_segment_tlv(\n fail4:\n \tEFSYS_PROBE(fail4);\n \n-\tef10_nvram_partn_unlock(enp, partn, NULL);\n+\t(void) ef10_nvram_partn_unlock(enp, partn, NULL);\n fail3:\n \tEFSYS_PROBE(fail3);\n \ndiff --git a/drivers/net/sfc/base/ef10_tx.c b/drivers/net/sfc/base/ef10_tx.c\nindex 7d27f7100..b92cadcbf 100644\n--- a/drivers/net/sfc/base/ef10_tx.c\n+++ b/drivers/net/sfc/base/ef10_tx.c\n@@ -278,7 +278,7 @@ ef10_tx_qpio_enable(\n \n fail3:\n \tEFSYS_PROBE(fail3);\n-\tef10_nic_pio_free(enp, etp->et_pio_bufnum, etp->et_pio_blknum);\n+\t(void) ef10_nic_pio_free(enp, etp->et_pio_bufnum, etp->et_pio_blknum);\n fail2:\n \tEFSYS_PROBE(fail2);\n \tetp->et_pio_size = 0;\n@@ -296,10 +296,12 @@ ef10_tx_qpio_disable(\n \n \tif (etp->et_pio_size != 0) {\n \t\t/* Unlink the piobuf from this TXQ */\n-\t\tef10_nic_pio_unlink(enp, etp->et_index);\n+\t\tif (ef10_nic_pio_unlink(enp, etp->et_index) != 0)\n+\t\t\treturn;\n \n \t\t/* Free the sub-allocated PIO block */\n-\t\tef10_nic_pio_free(enp, etp->et_pio_bufnum, etp->et_pio_blknum);\n+\t\t(void) ef10_nic_pio_free(enp, etp->et_pio_bufnum,\n+\t\t etp->et_pio_blknum);\n \t\tetp->et_pio_size = 0;\n \t\tetp->et_pio_write_offset = 0;\n \t}\ndiff --git a/drivers/net/sfc/base/efx_port.c b/drivers/net/sfc/base/efx_port.c\nindex 33a1a0843..5fff932be 100644\n--- a/drivers/net/sfc/base/efx_port.c\n+++ b/drivers/net/sfc/base/efx_port.c\n@@ -37,7 +37,7 @@ efx_port_init(\n \tepp->ep_emop->emo_reconfigure(enp);\n \n \t/* Pick up current phy capababilities */\n-\tefx_port_poll(enp, NULL);\n+\t(void) efx_port_poll(enp, NULL);\n \n \t/*\n \t * Turn on the PHY if available, otherwise reset it, and\n", "prefixes": [ "01/37" ] }