Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/44923/?format=api
{ "id": 44923, "url": "http://patchwork.dpdk.org/api/patches/44923/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/bd24952bf432393eda31ef62396a107f07c63058.1537363687.git.anatoly.burakov@intel.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<bd24952bf432393eda31ef62396a107f07c63058.1537363687.git.anatoly.burakov@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/bd24952bf432393eda31ef62396a107f07c63058.1537363687.git.anatoly.burakov@intel.com", "date": "2018-09-19T13:56:28", "name": "[v2,04/20] mem: do not check for invalid socket ID", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "4c8d115f3d1ca61b5e450b24d771cb2ae545a08d", "submitter": { "id": 4, "url": "http://patchwork.dpdk.org/api/people/4/?format=api", "name": "Anatoly Burakov", "email": "anatoly.burakov@intel.com" }, "delegate": { "id": 1, "url": "http://patchwork.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/bd24952bf432393eda31ef62396a107f07c63058.1537363687.git.anatoly.burakov@intel.com/mbox/", "series": [ { "id": 1391, "url": "http://patchwork.dpdk.org/api/series/1391/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=1391", "date": "2018-09-19T13:56:25", "name": "Support externally allocated memory in DPDK", "version": 2, "mbox": "http://patchwork.dpdk.org/series/1391/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/44923/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/44923/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id DE486568A;\n\tWed, 19 Sep 2018 15:57:02 +0200 (CEST)", "from mga05.intel.com (mga05.intel.com [192.55.52.43])\n\tby dpdk.org (Postfix) with ESMTP id 72762200\n\tfor <dev@dpdk.org>; Wed, 19 Sep 2018 15:56:50 +0200 (CEST)", "from fmsmga002.fm.intel.com ([10.253.24.26])\n\tby fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t19 Sep 2018 06:56:49 -0700", "from irvmail001.ir.intel.com ([163.33.26.43])\n\tby fmsmga002.fm.intel.com with ESMTP; 19 Sep 2018 06:56:45 -0700", "from sivswdev01.ir.intel.com (sivswdev01.ir.intel.com\n\t[10.237.217.45])\n\tby irvmail001.ir.intel.com (8.14.3/8.13.6/MailSET/Hub) with ESMTP id\n\tw8JDujN0004985; Wed, 19 Sep 2018 14:56:45 +0100", "from sivswdev01.ir.intel.com (localhost [127.0.0.1])\n\tby sivswdev01.ir.intel.com with ESMTP id w8JDujHL023435;\n\tWed, 19 Sep 2018 14:56:45 +0100", "(from aburakov@localhost)\n\tby sivswdev01.ir.intel.com with LOCAL id w8JDujWV023431;\n\tWed, 19 Sep 2018 14:56:45 +0100" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.53,394,1531810800\"; d=\"scan'208\";a=\"87488473\"", "From": "Anatoly Burakov <anatoly.burakov@intel.com>", "To": "dev@dpdk.org", "Cc": "John McNamara <john.mcnamara@intel.com>,\n\tMarko Kovacevic <marko.kovacevic@intel.com>,\n\tlaszlo.madarassy@ericsson.com, laszlo.vadkerti@ericsson.com,\n\tandras.kovacs@ericsson.com, winnie.tian@ericsson.com,\n\tdaniel.andrasi@ericsson.com, janos.kobor@ericsson.com,\n\tgeza.koblo@ericsson.com, srinath.mannam@broadcom.com,\n\tscott.branden@broadcom.com, ajit.khaparde@broadcom.com,\n\tkeith.wiles@intel.com, bruce.richardson@intel.com, thomas@monjalon.net,\n\tshreyansh.jain@nxp.com, shahafs@mellanox.com", "Date": "Wed, 19 Sep 2018 14:56:28 +0100", "Message-Id": "<bd24952bf432393eda31ef62396a107f07c63058.1537363687.git.anatoly.burakov@intel.com>", "X-Mailer": "git-send-email 1.7.0.7", "In-Reply-To": [ "<cover.1537363686.git.anatoly.burakov@intel.com>", "<cover.1537363686.git.anatoly.burakov@intel.com>" ], "References": [ "<cover.1537363686.git.anatoly.burakov@intel.com>", "<cover.1536064999.git.anatoly.burakov@intel.com>\n\t<cover.1537363686.git.anatoly.burakov@intel.com>" ], "Subject": "[dpdk-dev] [PATCH v2 04/20] mem: do not check for invalid socket ID", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "We will be assigning \"invalid\" socket ID's to external heap, and\nmalloc will now be able to verify if a supplied socket ID is in\nfact a valid one, rendering parameter checks for sockets\nobsolete.\n\nThis changes the semantics of what we understand by \"socket ID\",\nso document the change in the release notes.\n\nSigned-off-by: Anatoly Burakov <anatoly.burakov@intel.com>\n---\n doc/guides/rel_notes/release_18_11.rst | 7 +++++++\n lib/librte_eal/common/eal_common_memzone.c | 8 +++++---\n lib/librte_eal/common/malloc_heap.c | 2 +-\n lib/librte_eal/common/rte_malloc.c | 4 ----\n 4 files changed, 13 insertions(+), 8 deletions(-)", "diff": "diff --git a/doc/guides/rel_notes/release_18_11.rst b/doc/guides/rel_notes/release_18_11.rst\nindex e2cbc82da..c04685d17 100644\n--- a/doc/guides/rel_notes/release_18_11.rst\n+++ b/doc/guides/rel_notes/release_18_11.rst\n@@ -75,6 +75,13 @@ API Changes\n users of memseg-walk-related functions, as they will now have to skip\n externally allocated segments in most cases if the intent is to only iterate\n over internal DPDK memory.\n+ - ``socket_id`` parameter across the entire DPDK has gained additional\n+ meaning, as some socket ID's will now be representing externally allocated\n+ memory. No changes will be required for existing code as backwards\n+ compatibility will be kept, and those who do not use this feature will not\n+ see these extra socket ID's. Any new API's must not check socket ID\n+ parameters themselves, and must instead leave it to the memory subsystem to\n+ decide whether socket ID is a valid one.\n \n ABI Changes\n -----------\ndiff --git a/lib/librte_eal/common/eal_common_memzone.c b/lib/librte_eal/common/eal_common_memzone.c\nindex 7300fe05d..b7081afbf 100644\n--- a/lib/librte_eal/common/eal_common_memzone.c\n+++ b/lib/librte_eal/common/eal_common_memzone.c\n@@ -120,13 +120,15 @@ memzone_reserve_aligned_thread_unsafe(const char *name, size_t len,\n \t\treturn NULL;\n \t}\n \n-\tif ((socket_id != SOCKET_ID_ANY) &&\n-\t (socket_id >= RTE_MAX_NUMA_NODES || socket_id < 0)) {\n+\tif ((socket_id != SOCKET_ID_ANY) && socket_id < 0) {\n \t\trte_errno = EINVAL;\n \t\treturn NULL;\n \t}\n \n-\tif (!rte_eal_has_hugepages())\n+\t/* only set socket to SOCKET_ID_ANY if we aren't allocating for an\n+\t * external heap.\n+\t */\n+\tif (!rte_eal_has_hugepages() && socket_id < RTE_MAX_NUMA_NODES)\n \t\tsocket_id = SOCKET_ID_ANY;\n \n \tcontig = (flags & RTE_MEMZONE_IOVA_CONTIG) != 0;\ndiff --git a/lib/librte_eal/common/malloc_heap.c b/lib/librte_eal/common/malloc_heap.c\nindex c4d303533..1dcb1de8f 100644\n--- a/lib/librte_eal/common/malloc_heap.c\n+++ b/lib/librte_eal/common/malloc_heap.c\n@@ -649,7 +649,7 @@ malloc_heap_alloc(const char *type, size_t size, int socket_arg,\n \tif (size == 0 || (align && !rte_is_power_of_2(align)))\n \t\treturn NULL;\n \n-\tif (!rte_eal_has_hugepages())\n+\tif (!rte_eal_has_hugepages() && socket_arg < RTE_MAX_NUMA_NODES)\n \t\tsocket_arg = SOCKET_ID_ANY;\n \n \tif (socket_arg == SOCKET_ID_ANY)\ndiff --git a/lib/librte_eal/common/rte_malloc.c b/lib/librte_eal/common/rte_malloc.c\nindex dfcdf380a..458c44ba6 100644\n--- a/lib/librte_eal/common/rte_malloc.c\n+++ b/lib/librte_eal/common/rte_malloc.c\n@@ -47,10 +47,6 @@ rte_malloc_socket(const char *type, size_t size, unsigned int align,\n \tif (!rte_eal_has_hugepages())\n \t\tsocket_arg = SOCKET_ID_ANY;\n \n-\t/* Check socket parameter */\n-\tif (socket_arg >= RTE_MAX_NUMA_NODES)\n-\t\treturn NULL;\n-\n \treturn malloc_heap_alloc(type, size, socket_arg, 0,\n \t\t\talign == 0 ? 1 : align, 0, false);\n }\n", "prefixes": [ "v2", "04/20" ] }