Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/45992/?format=api
{ "id": 45992, "url": "http://patchwork.dpdk.org/api/patches/45992/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20181003194039.7202-2-thomas@monjalon.net/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20181003194039.7202-2-thomas@monjalon.net>", "list_archive_url": "https://inbox.dpdk.org/dev/20181003194039.7202-2-thomas@monjalon.net", "date": "2018-10-03T19:40:39", "name": "[2/2] devargs: rename enum items with singular form", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "16f060381e7c5ca9569af6224c893957e67e56c2", "submitter": { "id": 685, "url": "http://patchwork.dpdk.org/api/people/685/?format=api", "name": "Thomas Monjalon", "email": "thomas@monjalon.net" }, "delegate": { "id": 1, "url": "http://patchwork.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20181003194039.7202-2-thomas@monjalon.net/mbox/", "series": [ { "id": 1676, "url": "http://patchwork.dpdk.org/api/series/1676/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=1676", "date": "2018-10-03T19:40:38", "name": "[1/2] bus/pci: rename devargs parameter id to addr", "version": 1, "mbox": "http://patchwork.dpdk.org/series/1676/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/45992/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/45992/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id B120F1B2AE;\n\tWed, 3 Oct 2018 21:40:53 +0200 (CEST)", "from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com\n\t[66.111.4.27]) by dpdk.org (Postfix) with ESMTP id DEE7A1B206\n\tfor <dev@dpdk.org>; Wed, 3 Oct 2018 21:40:50 +0200 (CEST)", "from compute1.internal (compute1.nyi.internal [10.202.2.41])\n\tby mailout.nyi.internal (Postfix) with ESMTP id 8535021F26;\n\tWed, 3 Oct 2018 15:40:50 -0400 (EDT)", "from mailfrontend2 ([10.202.2.163])\n\tby compute1.internal (MEProxy); Wed, 03 Oct 2018 15:40:50 -0400", "from xps.monjalon.net (184.203.134.77.rev.sfr.net [77.134.203.184])\n\tby mail.messagingengine.com (Postfix) with ESMTPA id CA996102E7;\n\tWed, 3 Oct 2018 15:40:49 -0400 (EDT)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=\n\tfrom:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding; s=mesmtp; bh=+n+lSrA2LX\n\tJ9Qt9FRqUWspO2cpmpo21HIRHss070WdQ=; b=E2/R69QK4GLXAaUOK7W+zEn7ff\n\ttWX15AysQNz6yJ10TztB2puw7nBtz0rTGUEV2vjMp+XlDdC3TAfhKxjeR3KTKUto\n\tFIjwax8luAusXtDre8tWvEFsxxADOD9b5NQ7IlhF6OtVJIA6uDClA8McMMNsQaFZ\n\tA3G4M2wypmT350mHY=", "v=1; a=rsa-sha256; c=relaxed/relaxed; d=\n\tmessagingengine.com; h=cc:content-transfer-encoding:date:from\n\t:in-reply-to:message-id:mime-version:references:subject:to\n\t:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=\n\tfm3; bh=+n+lSrA2LXJ9Qt9FRqUWspO2cpmpo21HIRHss070WdQ=; b=Xjh81gjA\n\tJqD1vss7htAIJfdZ4eILW1xgn81Y01P22L5q2eAeeKm837EYO/Ry+P5IWbnopPk5\n\tF7m8shFv3TosKSGJJCcq5DO//+echlYG+wOu07JXvjBqkFrGHSy9cYVXLvLx2RQh\n\tCGen0Ud16r1PxSMIKvgYE8Tjr9Vbt/rgKCnwFzD4nUZM3JJKCiu6KuwQ+qz2tb8h\n\tRwq0xjM8FDfejXvMaF1JnIARonClnVqe4LjKmOEJgJQkxibZJ+EcECPEhSS5R7gQ\n\tiyNjA/VP86nwWG/CAveeW9X6ce0vaV2aNXk1cIEjIWr904JMOR33RqZlbgeXMY3Y\n\t7JydKsgkm1c/uQ==" ], "X-ME-Sender": "<xms:Qhu1W93Qw6Ka_ibQA8rjU4Edz-s19g7xWfBzpNStnxDcG7cqXvXH3Q>", "X-ME-Proxy": "<xmx:Qhu1W2_mo8j2FnkrJHJc9e7YnL2d6OKh88w5Kb9rja1VDdHaSWD2Zg>\n\t<xmx:Qhu1W0a-OGhfbh4ML0WhgR8_KrO6QhwlJ1nZteE1GkbEd5tLQD_CKA>\n\t<xmx:Qhu1W9zRFsu_yU6A6GZZEXjpe_AZVHR3pxEuBD5iKr6yHmQr2o-VQw>\n\t<xmx:Qhu1W6-7frNT5Ad4BmsxO7ZRGyDcpjp84FtCK9anOk6yKd9YDx8CqA>\n\t<xmx:Qhu1Wxy6RNGeUAk178Hd62RhsvMFGnMRBDpt6clBLs-Rs62Klsqeaw>\n\t<xmx:Qhu1W3E7cyaNfd6ksZi36qQK23UgAswq_ilJ7zkAWJ41UGXO_mGlfA>", "From": "Thomas Monjalon <thomas@monjalon.net>", "To": "gaetan.rivet@6wind.com", "Cc": "dev@dpdk.org", "Date": "Wed, 3 Oct 2018 21:40:39 +0200", "Message-Id": "<20181003194039.7202-2-thomas@monjalon.net>", "X-Mailer": "git-send-email 2.19.0", "In-Reply-To": "<20181003194039.7202-1-thomas@monjalon.net>", "References": "<20181003194039.7202-1-thomas@monjalon.net>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH 2/2] devargs: rename enum items with singular form", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The enum names are *_params (plural form).\nAnd the items are also using the plural form: *_PARAMS_*.\nIt looks more natural to use the singular form *_PARAM_* for items.\n\nSigned-off-by: Thomas Monjalon <thomas@monjalon.net>\n---\n drivers/bus/pci/pci_params.c | 10 +++++-----\n drivers/bus/vdev/vdev_params.c | 4 ++--\n lib/librte_ethdev/rte_class_eth.c | 4 ++--\n 3 files changed, 9 insertions(+), 9 deletions(-)", "diff": "diff --git a/drivers/bus/pci/pci_params.c b/drivers/bus/pci/pci_params.c\nindex 77b722ba9..3192e9c96 100644\n--- a/drivers/bus/pci/pci_params.c\n+++ b/drivers/bus/pci/pci_params.c\n@@ -12,13 +12,13 @@\n #include \"private.h\"\n \n enum pci_params {\n-\tRTE_PCI_PARAMS_ADDR,\n-\tRTE_PCI_PARAMS_MAX,\n+\tRTE_PCI_PARAM_ADDR,\n+\tRTE_PCI_PARAM_MAX,\n };\n \n static const char * const pci_params_keys[] = {\n-\t[RTE_PCI_PARAMS_ADDR] = \"addr\",\n-\t[RTE_PCI_PARAMS_MAX] = NULL,\n+\t[RTE_PCI_PARAM_ADDR] = \"addr\",\n+\t[RTE_PCI_PARAM_MAX] = NULL,\n };\n \n static int\n@@ -47,7 +47,7 @@ pci_dev_match(const struct rte_device *dev,\n \t\treturn 0;\n \tpdev = RTE_DEV_TO_PCI_CONST(dev);\n \t/* if any field does not match. */\n-\tif (rte_kvargs_process(kvlist, pci_params_keys[RTE_PCI_PARAMS_ADDR],\n+\tif (rte_kvargs_process(kvlist, pci_params_keys[RTE_PCI_PARAM_ADDR],\n \t\t\t &pci_addr_kv_cmp,\n \t\t\t (void *)(intptr_t)&pdev->addr))\n \t\treturn 1;\ndiff --git a/drivers/bus/vdev/vdev_params.c b/drivers/bus/vdev/vdev_params.c\nindex 842a4684e..da270f2ec 100644\n--- a/drivers/bus/vdev/vdev_params.c\n+++ b/drivers/bus/vdev/vdev_params.c\n@@ -11,11 +11,11 @@\n #include \"vdev_private.h\"\n \n enum vdev_params {\n-\tRTE_VDEV_PARAMS_MAX,\n+\tRTE_VDEV_PARAM_MAX,\n };\n \n static const char * const vdev_params_keys[] = {\n-\t[RTE_VDEV_PARAMS_MAX] = NULL,\n+\t[RTE_VDEV_PARAM_MAX] = NULL,\n };\n \n static int\ndiff --git a/lib/librte_ethdev/rte_class_eth.c b/lib/librte_ethdev/rte_class_eth.c\nindex b6557db97..84b646291 100644\n--- a/lib/librte_ethdev/rte_class_eth.c\n+++ b/lib/librte_ethdev/rte_class_eth.c\n@@ -15,11 +15,11 @@\n #include \"ethdev_private.h\"\n \n enum eth_params {\n-\tRTE_ETH_PARAMS_MAX,\n+\tRTE_ETH_PARAM_MAX,\n };\n \n static const char * const eth_params_keys[] = {\n-\t[RTE_ETH_PARAMS_MAX] = NULL,\n+\t[RTE_ETH_PARAM_MAX] = NULL,\n };\n \n struct eth_dev_match_arg {\n", "prefixes": [ "2/2" ] }