Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/46620/?format=api
http://patchwork.dpdk.org/api/patches/46620/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20181011130655.5485-1-tiwei.bie@intel.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20181011130655.5485-1-tiwei.bie@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20181011130655.5485-1-tiwei.bie@intel.com", "date": "2018-10-11T13:06:55", "name": "vhost: fix notification for packed ring", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "9f492765a72fd95f96d07075f1e07a4c0308ed6f", "submitter": { "id": 617, "url": "http://patchwork.dpdk.org/api/people/617/?format=api", "name": "Tiwei Bie", "email": "tiwei.bie@intel.com" }, "delegate": { "id": 2642, "url": "http://patchwork.dpdk.org/api/users/2642/?format=api", "username": "mcoquelin", "first_name": "Maxime", "last_name": "Coquelin", "email": "maxime.coquelin@redhat.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20181011130655.5485-1-tiwei.bie@intel.com/mbox/", "series": [ { "id": 1837, "url": "http://patchwork.dpdk.org/api/series/1837/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=1837", "date": "2018-10-11T13:06:55", "name": "vhost: fix notification for packed ring", "version": 1, "mbox": "http://patchwork.dpdk.org/series/1837/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/46620/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/46620/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 5A1B71B557;\n\tThu, 11 Oct 2018 15:11:41 +0200 (CEST)", "from mga09.intel.com (mga09.intel.com [134.134.136.24])\n\tby dpdk.org (Postfix) with ESMTP id EEB721B4ED;\n\tThu, 11 Oct 2018 15:11:38 +0200 (CEST)", "from orsmga002.jf.intel.com ([10.7.209.21])\n\tby orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t11 Oct 2018 06:11:37 -0700", "from btwcube1.sh.intel.com ([10.67.104.158])\n\tby orsmga002.jf.intel.com with ESMTP; 11 Oct 2018 06:08:23 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.54,368,1534834800\"; d=\"scan'208\";a=\"99384570\"", "From": "Tiwei Bie <tiwei.bie@intel.com>", "To": "maxime.coquelin@redhat.com,\n\tzhihong.wang@intel.com,\n\tdev@dpdk.org", "Cc": "mst@redhat.com,\n\tjasowang@redhat.com,\n\tstable@dpdk.org", "Date": "Thu, 11 Oct 2018 21:06:55 +0800", "Message-Id": "<20181011130655.5485-1-tiwei.bie@intel.com>", "X-Mailer": "git-send-email 2.19.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH] vhost: fix notification for packed ring", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The notification can't be disabled in packed ring when\napplication tries to disable notification, because the\ndevice event flags field is overwritten by an unexpected\nvalue. This patch fixes this issue.\n\nFixes: b1cce26af1dc (\"vhost: add notification for packed ring\")\nCc: stable@dpdk.org\n\nSigned-off-by: Tiwei Bie <tiwei.bie@intel.com>\n---\n lib/librte_vhost/vhost.c | 7 +++++--\n 1 file changed, 5 insertions(+), 2 deletions(-)", "diff": "diff --git a/lib/librte_vhost/vhost.c b/lib/librte_vhost/vhost.c\nindex e62f4c594..c9270bdec 100644\n--- a/lib/librte_vhost/vhost.c\n+++ b/lib/librte_vhost/vhost.c\n@@ -667,8 +667,10 @@ vhost_enable_notify_packed(struct virtio_net *dev,\n {\n \tuint16_t flags;\n \n-\tif (!enable)\n-\t\tvq->device_event->flags = VRING_EVENT_F_DISABLE;\n+\tif (!enable) {\n+\t\tflags = VRING_EVENT_F_DISABLE;\n+\t\tgoto out;\n+\t}\n \n \tflags = VRING_EVENT_F_ENABLE;\n \tif (dev->features & (1ULL << VIRTIO_RING_F_EVENT_IDX)) {\n@@ -677,6 +679,7 @@ vhost_enable_notify_packed(struct virtio_net *dev,\n \t\t\tvq->avail_wrap_counter << 15;\n \t}\n \n+out:\n \trte_smp_wmb();\n \n \tvq->device_event->flags = flags;\n", "prefixes": [] }{ "id": 46620, "url": "