Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 46891,
    "url": "http://patchwork.dpdk.org/api/patches/46891/?format=api",
    "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20181016122717.66948-1-roy.fan.zhang@intel.com/",
    "project": {
        "id": 1,
        "url": "http://patchwork.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20181016122717.66948-1-roy.fan.zhang@intel.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20181016122717.66948-1-roy.fan.zhang@intel.com",
    "date": "2018-10-16T12:27:17",
    "name": "lib/rte_vhost: fix message handling",
    "commit_ref": null,
    "pull_url": null,
    "state": "rejected",
    "archived": true,
    "hash": "7f0bf8e861bb1e7759301865df7bdae3ce8b4db3",
    "submitter": {
        "id": 304,
        "url": "http://patchwork.dpdk.org/api/people/304/?format=api",
        "name": "Fan Zhang",
        "email": "roy.fan.zhang@intel.com"
    },
    "delegate": {
        "id": 2642,
        "url": "http://patchwork.dpdk.org/api/users/2642/?format=api",
        "username": "mcoquelin",
        "first_name": "Maxime",
        "last_name": "Coquelin",
        "email": "maxime.coquelin@redhat.com"
    },
    "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20181016122717.66948-1-roy.fan.zhang@intel.com/mbox/",
    "series": [
        {
            "id": 1921,
            "url": "http://patchwork.dpdk.org/api/series/1921/?format=api",
            "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=1921",
            "date": "2018-10-16T12:27:17",
            "name": "lib/rte_vhost: fix message handling",
            "version": 1,
            "mbox": "http://patchwork.dpdk.org/series/1921/mbox/"
        }
    ],
    "comments": "http://patchwork.dpdk.org/api/patches/46891/comments/",
    "check": "fail",
    "checks": "http://patchwork.dpdk.org/api/patches/46891/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 2FACD5F12;\n\tTue, 16 Oct 2018 14:27:22 +0200 (CEST)",
            "from mga06.intel.com (mga06.intel.com [134.134.136.31])\n\tby dpdk.org (Postfix) with ESMTP id A00B65B32\n\tfor <dev@dpdk.org>; Tue, 16 Oct 2018 14:27:20 +0200 (CEST)",
            "from orsmga006.jf.intel.com ([10.7.209.51])\n\tby orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t16 Oct 2018 05:27:19 -0700",
            "from silpixa00398673.ir.intel.com (HELO\n\tsilpixa00398673.ger.corp.intel.com) ([10.237.223.54])\n\tby orsmga006.jf.intel.com with ESMTP; 16 Oct 2018 05:27:18 -0700"
        ],
        "X-Amp-Result": "SKIPPED(no attachment in message)",
        "X-Amp-File-Uploaded": "False",
        "X-ExtLoop1": "1",
        "X-IronPort-AV": "E=Sophos;i=\"5.54,388,1534834800\"; d=\"scan'208\";a=\"83006005\"",
        "From": "Fan Zhang <roy.fan.zhang@intel.com>",
        "To": "dev@dpdk.org",
        "Cc": "maxime.coquelin@redhat.com,\n\tnicknickolaev@gmail.com",
        "Date": "Tue, 16 Oct 2018 13:27:17 +0100",
        "Message-Id": "<20181016122717.66948-1-roy.fan.zhang@intel.com>",
        "X-Mailer": "git-send-email 2.13.6",
        "Subject": "[dpdk-dev] [PATCH] lib/rte_vhost: fix message handling",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "This patch fixes the bugs introduced by the message handling rework\npatch. Previously some \"get\" message handlers did not have correct\nreturn and one if statement was wrong.\n\nFixes: 2f270595c05d (\"vhost: rework message handling as a callback array\")\nCc: nicknickolaev@gmail.com\n\nSigned-off-by: Fan Zhang <roy.fan.zhang@intel.com>\n---\n lib/librte_vhost/vhost_user.c | 6 +++---\n 1 file changed, 3 insertions(+), 3 deletions(-)",
    "diff": "diff --git a/lib/librte_vhost/vhost_user.c b/lib/librte_vhost/vhost_user.c\nindex 7ef3fb4a4..ac2912990 100644\n--- a/lib/librte_vhost/vhost_user.c\n+++ b/lib/librte_vhost/vhost_user.c\n@@ -1161,7 +1161,7 @@ vhost_user_get_vring_base(struct virtio_net **pdev,\n \n \tmsg->size = sizeof(msg->payload.state);\n \n-\treturn VH_RESULT_OK;\n+\treturn VH_RESULT_REPLY;\n }\n \n /*\n@@ -1218,7 +1218,7 @@ vhost_user_get_protocol_features(struct virtio_net **pdev,\n \tmsg->payload.u64 = protocol_features;\n \tmsg->size = sizeof(msg->payload.u64);\n \n-\treturn VH_RESULT_OK;\n+\treturn VH_RESULT_REPLY;\n }\n \n static int\n@@ -1803,7 +1803,7 @@ vhost_user_msg_handler(int vid, int fd)\n \t\tmsg.payload.u64 = !!ret;\n \t\tmsg.size = sizeof(msg.payload.u64);\n \t\tsend_vhost_reply(fd, &msg);\n-\t} else if (ret) {\n+\t} else if (ret < 0) {\n \t\tRTE_LOG(ERR, VHOST_CONFIG,\n \t\t\t\"vhost message handling failed.\\n\");\n \t\treturn -1;\n",
    "prefixes": []
}