Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/47061/?format=api
{ "id": 47061, "url": "http://patchwork.dpdk.org/api/patches/47061/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20181019020757.27698-2-thomas@monjalon.net/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20181019020757.27698-2-thomas@monjalon.net>", "list_archive_url": "https://inbox.dpdk.org/dev/20181019020757.27698-2-thomas@monjalon.net", "date": "2018-10-19T02:07:52", "name": "[v6,1/6] app/testpmd: update port list for multiple removals", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "94aae0db6e654cbd483d3549a508afd2b3180894", "submitter": { "id": 685, "url": "http://patchwork.dpdk.org/api/people/685/?format=api", "name": "Thomas Monjalon", "email": "thomas@monjalon.net" }, "delegate": { "id": 319, "url": "http://patchwork.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20181019020757.27698-2-thomas@monjalon.net/mbox/", "series": [ { "id": 1985, "url": "http://patchwork.dpdk.org/api/series/1985/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=1985", "date": "2018-10-19T02:07:52", "name": "[v6,1/6] app/testpmd: update port list for multiple removals", "version": 6, "mbox": "http://patchwork.dpdk.org/series/1985/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/47061/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/47061/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id C4B261B124;\n\tFri, 19 Oct 2018 04:08:05 +0200 (CEST)", "from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com\n\t[66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 1096D1B109\n\tfor <dev@dpdk.org>; Fri, 19 Oct 2018 04:08:03 +0200 (CEST)", "from compute1.internal (compute1.nyi.internal [10.202.2.41])\n\tby mailout.nyi.internal (Postfix) with ESMTP id 5D949229F2;\n\tThu, 18 Oct 2018 22:08:02 -0400 (EDT)", "from mailfrontend2 ([10.202.2.163])\n\tby compute1.internal (MEProxy); Thu, 18 Oct 2018 22:08:02 -0400", "from xps.monjalon.net (184.203.134.77.rev.sfr.net [77.134.203.184])\n\tby mail.messagingengine.com (Postfix) with ESMTPA id 3A870102E2;\n\tThu, 18 Oct 2018 22:08:01 -0400 (EDT)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=\n\tfrom:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding; s=mesmtp; bh=lJVaptiSfQ\n\tdgjUDDrYtlUXbLpx2am4KyCAMdidkdksE=; b=HTIPsJ4U1fybRzs20vPeY/vPqe\n\tFx3IXy7cxjOTsVHK7fcVnl3wDQNT/voeUsskABjfvoBrTd9w3g2AMx+99VFaYf3u\n\tUrw/87ojrKfnP3MFLsCEhgZwmcmj0DFQdz+nFoec6t7jnvIAJs0HqwEuh8UMTkVL\n\t/FbupgJKdPa6CbpNw=", "v=1; a=rsa-sha256; c=relaxed/relaxed; d=\n\tmessagingengine.com; h=cc:content-transfer-encoding:date:from\n\t:in-reply-to:message-id:mime-version:references:subject:to\n\t:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=\n\tfm1; bh=lJVaptiSfQdgjUDDrYtlUXbLpx2am4KyCAMdidkdksE=; b=Sv8w22Ow\n\twpA3kM7U3cEfJ3k5goZ3ZvR3Mix0KWdNHKSQAfVcRHQge2ng4iViGRNyVjJDfh/y\n\t4kqTb3T9ev2zQ0UUjKvgrKgdYI09HCTzpItDzBjdMhy1YjnLPBVAqzB7rkDHBTij\n\t7sQ78QiJw3FC8KLuR+2ENeJsGxf/W0kf4myGxxhnqSMS2hwuN6VWQPZq7FRLeK8K\n\tOED4pCza0whmOUG+Cp1INddbsT/mHWTUXKoYXtlX8TxhQNwuT4pb2+GyY3RVYVDe\n\tb5OzrwNZI/uS40RuWOR97+GI4SeYiwxx4vuGy+ivJHaGcCwuBSxBtoMzxdWbCBxb\n\tNcJLmwZIDM/ocw==" ], "X-ME-Sender": "<xms:gjzJW6KxFtjzzdn-d727OeO-OFMdXVv3G8lWIzEyHiNi7h6uP5mKrQ>", "X-ME-Proxy": "<xmx:gjzJW-juwjqx1kG3VeQZ754Ft8ptgMMHiriV-qY1t5NiZgmPSStwfQ>\n\t<xmx:gjzJW3N7TGRV8SZUSqzo8W68NRr--IejK9ADjbjqDVarOvd7jygQWw>\n\t<xmx:gjzJW9bzxvKoIXMHsenVWKM8J4r5BONpuhY6eVs0Af4rt2jJ4pqwgQ>\n\t<xmx:gjzJW088AcvGASfuqwfLQ30A1khv2dvetjsVVzEpgWylUnEdlngwnA>\n\t<xmx:gjzJW43WK_8rv20bsXViWv48xIBl8K3Ihyj7S2M18ja50uQxkaO09Q>\n\t<xmx:gjzJWzjWJlVh14Arbz_akZInsOqfIyBKYfbxYUNG5gZZUJEkXEF5mg>", "From": "Thomas Monjalon <thomas@monjalon.net>", "To": "ferruh.yigit@intel.com,\n\tarybchenko@solarflare.com", "Cc": "dev@dpdk.org, ophirmu@mellanox.com, bernard.iremonger@intel.com,\n\trahul.lakkireddy@chelsio.com, Wisam Jaddo <wisamm@mellanox.com>", "Date": "Fri, 19 Oct 2018 04:07:52 +0200", "Message-Id": "<20181019020757.27698-2-thomas@monjalon.net>", "X-Mailer": "git-send-email 2.19.0", "In-Reply-To": "<20181019020757.27698-1-thomas@monjalon.net>", "References": "<20180907233929.21950-1-thomas@monjalon.net>\n\t<20181019020757.27698-1-thomas@monjalon.net>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v6 1/6] app/testpmd: update port list for\n\tmultiple removals", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Wisam Jaddo <wisamm@mellanox.com>\n\nWhen detaching a port, the full rte_device is removed.\nIf the rte_device was hosting several ports,\nthe testpmd list of ports must be updated for multiple removals.\n\nSigned-off-by: Wisam Jaddo <wisamm@mellanox.com>\n---\n app/test-pmd/testpmd.c | 37 ++++++++++++++++++++++++++-----------\n 1 file changed, 26 insertions(+), 11 deletions(-)", "diff": "diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c\nindex 5dbbf783f..2c0b4a021 100644\n--- a/app/test-pmd/testpmd.c\n+++ b/app/test-pmd/testpmd.c\n@@ -2186,6 +2186,31 @@ stop_port(portid_t pid)\n \tprintf(\"Done\\n\");\n }\n \n+static void\n+remove_unused_fwd_ports(void)\n+{\n+\tint i;\n+\tint last_port_idx = nb_ports - 1;\n+\n+\tfor (i = 0; i <= last_port_idx; i++) { /* iterate in ports_ids */\n+\t\tif (rte_eth_devices[ports_ids[i]].state != RTE_ETH_DEV_UNUSED)\n+\t\t\tcontinue;\n+\t\t/* skip unused ports at the end */\n+\t\twhile (i <= last_port_idx &&\n+\t\t\t\trte_eth_devices[ports_ids[last_port_idx]].state\n+\t\t\t\t== RTE_ETH_DEV_UNUSED)\n+\t\t\tlast_port_idx--;\n+\t\tif (last_port_idx < i)\n+\t\t\tbreak;\n+\t\t/* overwrite unused port with last valid port */\n+\t\tports_ids[i] = ports_ids[last_port_idx];\n+\t\t/* decrease ports count */\n+\t\tlast_port_idx--;\n+\t}\n+\tnb_ports = rte_eth_dev_count_avail();\n+\tupdate_fwd_ports(RTE_MAX_ETHPORTS);\n+}\n+\n void\n close_port(portid_t pid)\n {\n@@ -2315,7 +2340,6 @@ void\n detach_port(portid_t port_id)\n {\n \tchar name[RTE_ETH_NAME_MAX_LEN];\n-\tuint16_t i;\n \n \tprintf(\"Detaching a port...\\n\");\n \n@@ -2332,16 +2356,7 @@ detach_port(portid_t port_id)\n \t\treturn;\n \t}\n \n-\tfor (i = 0; i < nb_ports; i++) {\n-\t\tif (ports_ids[i] == port_id) {\n-\t\t\tports_ids[i] = ports_ids[nb_ports-1];\n-\t\t\tports_ids[nb_ports-1] = 0;\n-\t\t\tbreak;\n-\t\t}\n-\t}\n-\tnb_ports = rte_eth_dev_count_avail();\n-\n-\tupdate_fwd_ports(RTE_MAX_ETHPORTS);\n+\tremove_unused_fwd_ports();\n \n \tprintf(\"Port %u is detached. Now total ports is %d\\n\",\n \t\t\tport_id, nb_ports);\n", "prefixes": [ "v6", "1/6" ] }