Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/47108/?format=api
{ "id": 47108, "url": "http://patchwork.dpdk.org/api/patches/47108/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20181022074741.32884-1-haiyue.wang@intel.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20181022074741.32884-1-haiyue.wang@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20181022074741.32884-1-haiyue.wang@intel.com", "date": "2018-10-22T07:47:41", "name": "[v1] net/i40e: enable the loopback function if it is X722 MAC", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "240624c416c50e255c98131846b860ddb23985e2", "submitter": { "id": 1044, "url": "http://patchwork.dpdk.org/api/people/1044/?format=api", "name": "Wang, Haiyue", "email": "haiyue.wang@intel.com" }, "delegate": { "id": 1540, "url": "http://patchwork.dpdk.org/api/users/1540/?format=api", "username": "qzhan15", "first_name": "Qi", "last_name": "Zhang", "email": "qi.z.zhang@intel.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20181022074741.32884-1-haiyue.wang@intel.com/mbox/", "series": [ { "id": 2004, "url": "http://patchwork.dpdk.org/api/series/2004/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=2004", "date": "2018-10-22T07:47:41", "name": "[v1] net/i40e: enable the loopback function if it is X722 MAC", "version": 1, "mbox": "http://patchwork.dpdk.org/series/2004/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/47108/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/47108/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id A852F4CC3;\n\tMon, 22 Oct 2018 09:49:05 +0200 (CEST)", "from mga18.intel.com (mga18.intel.com [134.134.136.126])\n\tby dpdk.org (Postfix) with ESMTP id 78AE04C99\n\tfor <dev@dpdk.org>; Mon, 22 Oct 2018 09:49:03 +0200 (CEST)", "from orsmga006.jf.intel.com ([10.7.209.51])\n\tby orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t22 Oct 2018 00:49:02 -0700", "from dpdk-s2600wfp.sh.intel.com ([10.67.111.114])\n\tby orsmga006.jf.intel.com with ESMTP; 22 Oct 2018 00:49:01 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.54,411,1534834800\"; d=\"scan'208\";a=\"84519613\"", "From": "Haiyue Wang <haiyue.wang@intel.com>", "To": "dev@dpdk.org, qi.z.zhang@intel.com, jingjing.wu@intel.com,\n\twenzhuo.lu@intel.com", "Cc": "andrey.chilikin@intel.com,\n\tHaiyue Wang <haiyue.wang@intel.com>", "Date": "Mon, 22 Oct 2018 15:47:41 +0800", "Message-Id": "<20181022074741.32884-1-haiyue.wang@intel.com>", "X-Mailer": "git-send-email 2.17.1", "Subject": "[dpdk-dev] [PATCH v1] net/i40e: enable the loopback function if it\n\tis X722 MAC", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "In FVL, there was an issue and it didn't support the loopback function\nbefore FW 5.0. For FPK (X722) it should work.\n\nSo it needs to distinguish between the devices by checking MAC type.\n\nFixes: 689bba33272d (i40e: add VEB switching support)\nFixes: bce83974ba2c (net/i40e: set Tx loopback from PF)\n\nSigned-off-by: Haiyue Wang <haiyue.wang@intel.com>\n---\n drivers/net/i40e/i40e_ethdev.c | 4 ++--\n drivers/net/i40e/rte_pmd_i40e.c | 2 +-\n 2 files changed, 3 insertions(+), 3 deletions(-)", "diff": "diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c\nindex f7a685c8c..ed5cd9c59 100644\n--- a/drivers/net/i40e/i40e_ethdev.c\n+++ b/drivers/net/i40e/i40e_ethdev.c\n@@ -5371,7 +5371,7 @@ i40e_enable_pf_lb(struct i40e_pf *pf)\n \tint ret;\n \n \t/* Use the FW API if FW >= v5.0 */\n-\tif (hw->aq.fw_maj_ver < 5) {\n+\tif (hw->aq.fw_maj_ver < 5 && hw->mac.type != I40E_MAC_X722) {\n \t\tPMD_INIT_LOG(ERR, \"FW < v5.0, cannot enable loopback\");\n \t\treturn;\n \t}\n@@ -5642,7 +5642,7 @@ i40e_vsi_setup(struct i40e_pf *pf,\n \t\tctxt.flags = I40E_AQ_VSI_TYPE_VF;\n \n \t\t/* Use the VEB configuration if FW >= v5.0 */\n-\t\tif (hw->aq.fw_maj_ver >= 5) {\n+\t\tif (hw->aq.fw_maj_ver >= 5 || hw->mac.type == I40E_MAC_X722) {\n \t\t\t/* Configure switch ID */\n \t\t\tctxt.info.valid_sections |=\n \t\t\trte_cpu_to_le_16(I40E_AQ_VSI_PROP_SWITCH_VALID);\ndiff --git a/drivers/net/i40e/rte_pmd_i40e.c b/drivers/net/i40e/rte_pmd_i40e.c\nindex bba62b1c5..7ce5d02fa 100644\n--- a/drivers/net/i40e/rte_pmd_i40e.c\n+++ b/drivers/net/i40e/rte_pmd_i40e.c\n@@ -338,7 +338,7 @@ i40e_vsi_set_tx_loopback(struct i40e_vsi *vsi, uint8_t on)\n \thw = I40E_VSI_TO_HW(vsi);\n \n \t/* Use the FW API if FW >= v5.0 */\n-\tif (hw->aq.fw_maj_ver < 5) {\n+\tif (hw->aq.fw_maj_ver < 5 && hw->mac.type != I40E_MAC_X722) {\n \t\tPMD_INIT_LOG(ERR, \"FW < v5.0, cannot enable loopback\");\n \t\treturn -ENOTSUP;\n \t}\n", "prefixes": [ "v1" ] }