Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/47424/?format=api
{ "id": 47424, "url": "http://patchwork.dpdk.org/api/patches/47424/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/0a032f701099558dfbe4c9684df90874583a4544.1540465344.git.anatoly.burakov@intel.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<0a032f701099558dfbe4c9684df90874583a4544.1540465344.git.anatoly.burakov@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/0a032f701099558dfbe4c9684df90874583a4544.1540465344.git.anatoly.burakov@intel.com", "date": "2018-10-25T11:06:34", "name": "malloc: fix external heap allocation in no huge mode", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "2cf8dd91d56297cc7d56ded901219ebeec5c244f", "submitter": { "id": 4, "url": "http://patchwork.dpdk.org/api/people/4/?format=api", "name": "Anatoly Burakov", "email": "anatoly.burakov@intel.com" }, "delegate": { "id": 1, "url": "http://patchwork.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/0a032f701099558dfbe4c9684df90874583a4544.1540465344.git.anatoly.burakov@intel.com/mbox/", "series": [ { "id": 2098, "url": "http://patchwork.dpdk.org/api/series/2098/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=2098", "date": "2018-10-25T11:06:34", "name": "malloc: fix external heap allocation in no huge mode", "version": 1, "mbox": "http://patchwork.dpdk.org/series/2098/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/47424/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/47424/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 0A1834F98;\n\tThu, 25 Oct 2018 13:06:39 +0200 (CEST)", "from mga06.intel.com (mga06.intel.com [134.134.136.31])\n\tby dpdk.org (Postfix) with ESMTP id 6C9204C95\n\tfor <dev@dpdk.org>; Thu, 25 Oct 2018 13:06:37 +0200 (CEST)", "from fmsmga003.fm.intel.com ([10.253.24.29])\n\tby orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t25 Oct 2018 04:06:36 -0700", "from irvmail001.ir.intel.com ([163.33.26.43])\n\tby FMSMGA003.fm.intel.com with ESMTP; 25 Oct 2018 04:06:35 -0700", "from sivswdev01.ir.intel.com (sivswdev01.ir.intel.com\n\t[10.237.217.45])\n\tby irvmail001.ir.intel.com (8.14.3/8.13.6/MailSET/Hub) with ESMTP id\n\tw9PB6YM3028349; Thu, 25 Oct 2018 12:06:34 +0100", "from sivswdev01.ir.intel.com (localhost [127.0.0.1])\n\tby sivswdev01.ir.intel.com with ESMTP id w9PB6Yvu013789;\n\tThu, 25 Oct 2018 12:06:34 +0100", "(from aburakov@localhost)\n\tby sivswdev01.ir.intel.com with LOCAL id w9PB6YQv013785;\n\tThu, 25 Oct 2018 12:06:34 +0100" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.54,424,1534834800\"; d=\"scan'208\";a=\"91138227\"", "From": "Anatoly Burakov <anatoly.burakov@intel.com>", "To": "dev@dpdk.org", "Cc": "laszlo.madarassy@ericsson.com, janos.kobor@ericsson.com", "Date": "Thu, 25 Oct 2018 12:06:34 +0100", "Message-Id": "<0a032f701099558dfbe4c9684df90874583a4544.1540465344.git.anatoly.burakov@intel.com>", "X-Mailer": "git-send-email 1.7.0.7", "Subject": "[dpdk-dev] [PATCH] malloc: fix external heap allocation in no huge\n\tmode", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "When no-huge mode is enabled, we always overwrite the socket ID to be\nSOCKET_ID_ANY in rte_malloc, because there is no NUMA awareness in no-huge\nmode. However, with external memory support, a socket ID may have other\nmeaning, and we cannot overwrite the socket ID in those cases.\n\nFixes: 65ff37b105f7 (\"malloc: add function to check if socket is external\")\n\nSigned-off-by: Anatoly Burakov <anatoly.burakov@intel.com>\n---\n lib/librte_eal/common/rte_malloc.c | 8 +++++++-\n 1 file changed, 7 insertions(+), 1 deletion(-)", "diff": "diff --git a/lib/librte_eal/common/rte_malloc.c b/lib/librte_eal/common/rte_malloc.c\nindex b27a8ad2e..9e61dc41b 100644\n--- a/lib/librte_eal/common/rte_malloc.c\n+++ b/lib/librte_eal/common/rte_malloc.c\n@@ -46,7 +46,13 @@ rte_malloc_socket(const char *type, size_t size, unsigned int align,\n \tif (size == 0 || (align && !rte_is_power_of_2(align)))\n \t\treturn NULL;\n \n-\tif (!rte_eal_has_hugepages())\n+\t/* if there are no hugepages and if we are not allocating from an\n+\t * external heap, use memory from any socket available. checking for\n+\t * socket being external may return -1 in case of invalid socket, but\n+\t * that's OK - if there are no hugepages, it doesn't matter.\n+\t */\n+\tif (rte_malloc_heap_socket_is_external(socket_arg) != 1 &&\n+\t\t\t\t!rte_eal_has_hugepages())\n \t\tsocket_arg = SOCKET_ID_ANY;\n \n \treturn malloc_heap_alloc(type, size, socket_arg, 0,\n", "prefixes": [] }