Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 47460,
    "url": "http://patchwork.dpdk.org/api/patches/47460/?format=api",
    "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20181026063314.100992-1-xiaolong.ye@intel.com/",
    "project": {
        "id": 1,
        "url": "http://patchwork.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20181026063314.100992-1-xiaolong.ye@intel.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20181026063314.100992-1-xiaolong.ye@intel.com",
    "date": "2018-10-26T06:33:14",
    "name": "[2/2] net/i40e: correct offload not supported mask",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "3bedc92e58d93321e66b121a5a8b58c9ee2c21d5",
    "submitter": {
        "id": 1120,
        "url": "http://patchwork.dpdk.org/api/people/1120/?format=api",
        "name": "Xiaolong Ye",
        "email": "xiaolong.ye@intel.com"
    },
    "delegate": {
        "id": 1540,
        "url": "http://patchwork.dpdk.org/api/users/1540/?format=api",
        "username": "qzhan15",
        "first_name": "Qi",
        "last_name": "Zhang",
        "email": "qi.z.zhang@intel.com"
    },
    "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20181026063314.100992-1-xiaolong.ye@intel.com/mbox/",
    "series": [
        {
            "id": 2109,
            "url": "http://patchwork.dpdk.org/api/series/2109/?format=api",
            "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=2109",
            "date": "2018-10-26T06:33:14",
            "name": null,
            "version": 1,
            "mbox": "http://patchwork.dpdk.org/series/2109/mbox/"
        }
    ],
    "comments": "http://patchwork.dpdk.org/api/patches/47460/comments/",
    "check": "success",
    "checks": "http://patchwork.dpdk.org/api/patches/47460/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 83A235F16;\n\tFri, 26 Oct 2018 08:33:33 +0200 (CEST)",
            "from mga12.intel.com (mga12.intel.com [192.55.52.136])\n\tby dpdk.org (Postfix) with ESMTP id 2320A5F0F\n\tfor <dev@dpdk.org>; Fri, 26 Oct 2018 08:33:30 +0200 (CEST)",
            "from orsmga001.jf.intel.com ([10.7.209.18])\n\tby fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t25 Oct 2018 23:33:30 -0700",
            "from yexl-server.sh.intel.com ([10.67.110.207])\n\tby orsmga001.jf.intel.com with ESMTP; 25 Oct 2018 23:33:28 -0700"
        ],
        "X-Amp-Result": "SKIPPED(no attachment in message)",
        "X-Amp-File-Uploaded": "False",
        "X-ExtLoop1": "1",
        "X-IronPort-AV": "E=Sophos;i=\"5.54,426,1534834800\"; d=\"scan'208\";a=\"102817779\"",
        "From": "Xiaolong Ye <xiaolong.ye@intel.com>",
        "To": "Qi Zhang <qi.z.zhang@intel.com>,\n\tBeilei Xing <beilei.xing@intel.com>",
        "Cc": "dev@dpdk.org, Xiaolong Ye <xiaolong.ye@intel.com>,\n\ttomaszx.kulasek@intel.com",
        "Date": "Fri, 26 Oct 2018 14:33:14 +0800",
        "Message-Id": "<20181026063314.100992-1-xiaolong.ye@intel.com>",
        "X-Mailer": "git-send-email 2.17.1",
        "Subject": "[dpdk-dev] [PATCH 2/2] net/i40e: correct offload not supported mask",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "Just as the name I40E_TX_OFFLOAD_NOTSUP_MASK indicates, it should be the\nmask of unsupported features (either not in PKT_TX_OFFLOAD_MASK or in\nI40E_TX_OFFLOAD_MASK), however, xor will not get desired result here,\nassume bit 0 of PKT_TX_OFFLOAD_MASK and I40E_TX_OFFLOAD_MAKS are 0 which\nmeans corresponding feature is not supported in both sides, then we get\nvalue of bit 0 of I40E_TX_OFFLOAD_NOTSUP_MASK which is 0 via xor, it\nimplies that it is supported which doesn't meet our expectation.\n\nCorrect it by a NOT-AND operation.\n\nFixes: 3f33e643e5c6 (\"net/i40e: add Tx preparation\")\n\nCc: tomaszx.kulasek@intel.com\nSigned-off-by: Xiaolong Ye <xiaolong.ye@intel.com>\n---\n drivers/net/i40e/i40e_rxtx.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)",
    "diff": "diff --git a/drivers/net/i40e/i40e_rxtx.c b/drivers/net/i40e/i40e_rxtx.c\nindex 8bfa25178..e76412207 100644\n--- a/drivers/net/i40e/i40e_rxtx.c\n+++ b/drivers/net/i40e/i40e_rxtx.c\n@@ -69,7 +69,7 @@\n \t\tI40E_TX_IEEE1588_TMST)\n \n #define I40E_TX_OFFLOAD_NOTSUP_MASK \\\n-\t\t(PKT_TX_OFFLOAD_MASK ^ I40E_TX_OFFLOAD_MASK)\n+\t\t~(PKT_TX_OFFLOAD_MASK & I40E_TX_OFFLOAD_MASK)\n \n static inline void\n i40e_rxd_to_vlan_tci(struct rte_mbuf *mb, volatile union i40e_rx_desc *rxdp)\n",
    "prefixes": [
        "2/2"
    ]
}