Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/47813/?format=api
{ "id": 47813, "url": "http://patchwork.dpdk.org/api/patches/47813/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/1541419874-31457-3-git-send-email-konstantin.ananyev@intel.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1541419874-31457-3-git-send-email-konstantin.ananyev@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1541419874-31457-3-git-send-email-konstantin.ananyev@intel.com", "date": "2018-11-05T12:11:14", "name": "[2/2] ip_frag: use key length for key comparision", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "ffd2239629c543f588a11ed2961fdaf397a55348", "submitter": { "id": 33, "url": "http://patchwork.dpdk.org/api/people/33/?format=api", "name": "Ananyev, Konstantin", "email": "konstantin.ananyev@intel.com" }, "delegate": { "id": 1, "url": "http://patchwork.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/1541419874-31457-3-git-send-email-konstantin.ananyev@intel.com/mbox/", "series": [ { "id": 2255, "url": "http://patchwork.dpdk.org/api/series/2255/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=2255", "date": "2018-11-05T12:11:14", "name": null, "version": 1, "mbox": "http://patchwork.dpdk.org/series/2255/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/47813/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/47813/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 80412532C;\n\tMon, 5 Nov 2018 13:11:32 +0100 (CET)", "from mga11.intel.com (mga11.intel.com [192.55.52.93])\n\tby dpdk.org (Postfix) with ESMTP id AE2A24CB5;\n\tMon, 5 Nov 2018 13:11:28 +0100 (CET)", "from fmsmga005.fm.intel.com ([10.253.24.32])\n\tby fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t05 Nov 2018 04:11:28 -0800", "from sivswdev02.ir.intel.com (HELO localhost.localdomain)\n\t([10.237.217.46])\n\tby fmsmga005.fm.intel.com with ESMTP; 05 Nov 2018 04:11:27 -0800" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.54,467,1534834800\"; d=\"scan'208\";a=\"277196449\"", "From": "Konstantin Ananyev <konstantin.ananyev@intel.com>", "To": "dev@dpdk.org", "Cc": "stable@dpdk.org, ryan.e.hall@intel.com, alexander.v.gutkin@intel.com,\n\tKonstantin Ananyev <konstantin.ananyev@intel.com>", "Date": "Mon, 5 Nov 2018 12:11:14 +0000", "Message-Id": "<1541419874-31457-3-git-send-email-konstantin.ananyev@intel.com>", "X-Mailer": "git-send-email 1.7.0.7", "In-Reply-To": "<1541413603-4792-1-git-send-email-konstantin.ananyev@intel.com>", "References": "<1541413603-4792-1-git-send-email-konstantin.ananyev@intel.com>", "Subject": "[dpdk-dev] [PATCH 2/2] ip_frag: use key length for key comparision", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Right now reassembly code relies on src_dst[] being all zeroes to\ndetermine is it free/occupied entry in the fragments table.\nThis is suboptimal and error prone - user can crash DPDK ip_reassembly\napp by something like the following scapy script:\nx=Ether(src=...,dst=...)/IP(dst='0.0.0.0',src='0.0.0.0',id=0)/('X'*1000)\nfrags=fragment(x, fragsize=500)\nsendp(frags, iface=...)\nTo overcome that issue and reduce overhead of\n'key invalidate' and 'key is empty' operations -\nadd key_len into keys comparision procedure.\n\nFixes: 4f1a8f633862 (\"ip_frag: add IPv6 reassembly\")\nCc: stable@dpdk.org\n\nReported-by: Ryan E Hall <ryan.e.hall@intel.com>\nReported-by: Alexander V Gutkin <alexander.v.gutkin@intel.com>\nSigned-off-by: Konstantin Ananyev <konstantin.ananyev@intel.com>\n---\n lib/librte_ip_frag/ip_frag_common.h | 14 ++++----------\n lib/librte_ip_frag/rte_ip_frag.h | 14 +++++++++++---\n 2 files changed, 15 insertions(+), 13 deletions(-)", "diff": "diff --git a/lib/librte_ip_frag/ip_frag_common.h b/lib/librte_ip_frag/ip_frag_common.h\nindex 0f62e2e16..a17a74076 100644\n--- a/lib/librte_ip_frag/ip_frag_common.h\n+++ b/lib/librte_ip_frag/ip_frag_common.h\n@@ -58,20 +58,14 @@ struct rte_mbuf *ipv6_frag_reassemble(struct ip_frag_pkt *fp);\n static inline int\n ip_frag_key_is_empty(const struct ip_frag_key * key)\n {\n-\tuint32_t i;\n-\tfor (i = 0; i < RTE_MIN(key->key_len, RTE_DIM(key->src_dst)); i++)\n-\t\tif (key->src_dst[i] != 0)\n-\t\t\treturn 0;\n-\treturn 1;\n+\treturn (key->key_len == 0);\n }\n \n-/* empty the key */\n+/* invalidate the key */\n static inline void\n ip_frag_key_invalidate(struct ip_frag_key * key)\n {\n-\tuint32_t i;\n-\tfor (i = 0; i < key->key_len; i++)\n-\t\tkey->src_dst[i] = 0;\n+\tkey->key_len = 0;\n }\n \n /* compare two keys */\n@@ -80,7 +74,7 @@ ip_frag_key_cmp(const struct ip_frag_key * k1, const struct ip_frag_key * k2)\n {\n \tuint32_t i;\n \tuint64_t val;\n-\tval = k1->id ^ k2->id;\n+\tval = k1->id_key_len ^ k2->id_key_len;\n \tfor (i = 0; i < k1->key_len; i++)\n \t\tval |= k1->src_dst[i] ^ k2->src_dst[i];\n \treturn val;\ndiff --git a/lib/librte_ip_frag/rte_ip_frag.h b/lib/librte_ip_frag/rte_ip_frag.h\nindex 7f425f610..a4ccaf9d1 100644\n--- a/lib/librte_ip_frag/rte_ip_frag.h\n+++ b/lib/librte_ip_frag/rte_ip_frag.h\n@@ -44,9 +44,17 @@ struct ip_frag {\n \n /** @internal <src addr, dst_addr, id> to uniquely identify fragmented datagram. */\n struct ip_frag_key {\n-\tuint64_t src_dst[4]; /**< src address, first 8 bytes used for IPv4 */\n-\tuint32_t id; /**< dst address */\n-\tuint32_t key_len; /**< src/dst key length */\n+\tuint64_t src_dst[4];\n+\t/**< src and dst address, only first 8 bytes used for IPv4 */\n+\tRTE_STD_C11\n+\tunion {\n+\t\tuint64_t id_key_len; /**< combined for easy fetch */\n+\t\t__extension__\n+\t\tstruct {\n+\t\t\tuint32_t id; /**< packet id */\n+\t\t\tuint32_t key_len; /**< src/dst key length */\n+\t\t};\n+\t};\n };\n \n /**\n", "prefixes": [ "2/2" ] }