Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/47940/?format=api
{ "id": 47940, "url": "http://patchwork.dpdk.org/api/patches/47940/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/9c2fc1a970820a780ecf050bb8b669d9bcd64e7b.1541677243.git.anatoly.burakov@intel.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<9c2fc1a970820a780ecf050bb8b669d9bcd64e7b.1541677243.git.anatoly.burakov@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/9c2fc1a970820a780ecf050bb8b669d9bcd64e7b.1541677243.git.anatoly.burakov@intel.com", "date": "2018-11-08T11:44:16", "name": "test: add missing cleanup to one of the failure paths", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "17e0517eb2059a9c73389ae0134d268ed8e4bac2", "submitter": { "id": 4, "url": "http://patchwork.dpdk.org/api/people/4/?format=api", "name": "Anatoly Burakov", "email": "anatoly.burakov@intel.com" }, "delegate": { "id": 1, "url": "http://patchwork.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/9c2fc1a970820a780ecf050bb8b669d9bcd64e7b.1541677243.git.anatoly.burakov@intel.com/mbox/", "series": [ { "id": 2324, "url": "http://patchwork.dpdk.org/api/series/2324/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=2324", "date": "2018-11-08T11:44:16", "name": "test: add missing cleanup to one of the failure paths", "version": 1, "mbox": "http://patchwork.dpdk.org/series/2324/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/47940/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/47940/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id A6E42493D;\n\tThu, 8 Nov 2018 12:44:20 +0100 (CET)", "from mga01.intel.com (mga01.intel.com [192.55.52.88])\n\tby dpdk.org (Postfix) with ESMTP id 0CBBB239\n\tfor <dev@dpdk.org>; Thu, 8 Nov 2018 12:44:18 +0100 (CET)", "from orsmga004.jf.intel.com ([10.7.209.38])\n\tby fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t08 Nov 2018 03:44:18 -0800", "from irvmail001.ir.intel.com ([163.33.26.43])\n\tby orsmga004.jf.intel.com with ESMTP; 08 Nov 2018 03:44:17 -0800", "from sivswdev01.ir.intel.com (sivswdev01.ir.intel.com\n\t[10.237.217.45])\n\tby irvmail001.ir.intel.com (8.14.3/8.13.6/MailSET/Hub) with ESMTP id\n\twA8BiGKd012971; Thu, 8 Nov 2018 11:44:16 GMT", "from sivswdev01.ir.intel.com (localhost [127.0.0.1])\n\tby sivswdev01.ir.intel.com with ESMTP id wA8BiGEr006020;\n\tThu, 8 Nov 2018 11:44:16 GMT", "(from aburakov@localhost)\n\tby sivswdev01.ir.intel.com with LOCAL id wA8BiGc0006015;\n\tThu, 8 Nov 2018 11:44:16 GMT" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.54,478,1534834800\"; d=\"scan'208\";a=\"248023525\"", "From": "Anatoly Burakov <anatoly.burakov@intel.com>", "To": "dev@dpdk.org", "Cc": "bruce.richardson@intel.com", "Date": "Thu, 8 Nov 2018 11:44:16 +0000", "Message-Id": "<9c2fc1a970820a780ecf050bb8b669d9bcd64e7b.1541677243.git.anatoly.burakov@intel.com>", "X-Mailer": "git-send-email 1.7.0.7", "Subject": "[dpdk-dev] [PATCH] test: add missing cleanup to one of the failure\n\tpaths", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "One of the failure paths were not updated to clean up on exit,\nmost likely due to rebase error. Fix the failure path to clean\nup instead of simply exiting.\n\nFixes: 3f9e31d71d63 (\"test: clean up on exit\")\n\nSigned-off-by: Anatoly Burakov <anatoly.burakov@intel.com>\n---\n test/test/test.c | 6 ++++--\n 1 file changed, 4 insertions(+), 2 deletions(-)", "diff": "diff --git a/test/test/test.c b/test/test/test.c\nindex 24df6299e..12fabd0ba 100644\n--- a/test/test/test.c\n+++ b/test/test/test.c\n@@ -102,8 +102,10 @@ main(int argc, char **argv)\n \t\t/* merge argc/argv and the environment args */\n \t\tall_argc = argc + eargc;\n \t\tall_argv = malloc(sizeof(*all_argv) * (all_argc + 1));\n-\t\tif (all_argv == NULL)\n-\t\t\treturn -1;\n+\t\tif (all_argv == NULL) {\n+\t\t\tret = -1;\n+\t\t\tgoto out;\n+\t\t}\n \n \t\tfor (i = 0; i < argc; i++)\n \t\t\tall_argv[i] = argv[i];\n", "prefixes": [] }