Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/48014/?format=api
{ "id": 48014, "url": "http://patchwork.dpdk.org/api/patches/48014/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/03A7D9A58FAFB54FBB01FEE199D7308A0134B8EE1F@wdc1exchmbxp02.hq.corp.viasat.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<03A7D9A58FAFB54FBB01FEE199D7308A0134B8EE1F@wdc1exchmbxp02.hq.corp.viasat.com>", "list_archive_url": "https://inbox.dpdk.org/dev/03A7D9A58FAFB54FBB01FEE199D7308A0134B8EE1F@wdc1exchmbxp02.hq.corp.viasat.com", "date": "2018-11-12T23:33:01", "name": "[1/1] eal: Don't fail secondary if primary is missing tailqs", "commit_ref": null, "pull_url": null, "state": "rejected", "archived": true, "hash": "5d7e7b806ca1df492845d81966a0d1b635379034", "submitter": { "id": 1163, "url": "http://patchwork.dpdk.org/api/people/1163/?format=api", "name": "Burdick, Cliff", "email": "Cliff.Burdick@viasat.com" }, "delegate": { "id": 1, "url": "http://patchwork.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/03A7D9A58FAFB54FBB01FEE199D7308A0134B8EE1F@wdc1exchmbxp02.hq.corp.viasat.com/mbox/", "series": [ { "id": 2366, "url": "http://patchwork.dpdk.org/api/series/2366/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=2366", "date": "2018-11-12T23:33:01", "name": "[1/1] eal: Don't fail secondary if primary is missing tailqs", "version": 1, "mbox": "http://patchwork.dpdk.org/series/2366/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/48014/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/48014/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 15262201;\n\tTue, 13 Nov 2018 00:33:05 +0100 (CET)", "from mta-us-central-02.viasat.com (mta-us-central-02.viasat.com\n\t[8.37.103.59]) by dpdk.org (Postfix) with ESMTP id E32821D7\n\tfor <dev@dpdk.org>; Tue, 13 Nov 2018 00:33:03 +0100 (CET)", "from pps.filterd (wdc1mta01.viasat.com [127.0.0.1])\n\tby wdc1mta01.viasat.com (8.16.0.22/8.16.0.22) with SMTP id\n\twACNUx5e022702 for <dev@dpdk.org>; Mon, 12 Nov 2018 23:33:02 GMT" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=viasat.com;\n\th=from : to : subject :\n\tdate : message-id : content-type : mime-version; s=pp1;\n\tbh=7lnmTqKQtATQyh+4cQ5L76UdpvQFPWE7gPKDArLHf54=;\n\tb=eHXKdve0JGOtdr0ltlrYUg5HgDMOF5rB5gOi/IDdPhxzVbMK9jBsbY5HQQWThCWA6HNX\n\tD60qfz8fBaOQ74Ij8Rm3KoN4DaA0UJjGP0sLTulunWhN6fUlQtqa+ZRAVKqZim8i7KjA\n\tV990+Q3KZKydwScgLkFP0N4rDa9Gh5UB7zJQaOcgT8sGbLlgY4rV8WP0vUKcbje7AwgK\n\tE1AU5hVHnmwO61df4Ck60OtD/DwezgHyF6U5BCutPZUu4XoWtltlZAe4It+Ih3OGEjdv\n\tNGK1PieCLyxFTDjMTcegz0Y4btOuYwGOSp9xs9BaMnjJ9j3iZEXasYVbhPoEJQWQKTtM\n\tOw== ", "From": "\"Burdick, Cliff\" <Cliff.Burdick@viasat.com>", "To": "\"dev@dpdk.org\" <dev@dpdk.org>", "Thread-Topic": "[PATCH 1/1] eal: Don't fail secondary if primary is missing\n\ttailqs", "Thread-Index": "AdR632/vnvJ3U124TOeqdBTRFJxhhA==", "Date": "Mon, 12 Nov 2018 23:33:01 +0000", "Message-ID": "<03A7D9A58FAFB54FBB01FEE199D7308A0134B8EE1F@wdc1exchmbxp02.hq.corp.viasat.com>", "Accept-Language": "en-US", "Content-Language": "en-US", "X-MS-Has-Attach": "", "X-MS-TNEF-Correlator": "", "MIME-Version": "1.0", "X-Proofpoint-Virus-Version": "vendor=fsecure engine=2.50.10434:, ,\n\tdefinitions=2018-11-12_15:, , signatures=0", "X-Proofpoint-Spam-Details": "rule=outbound_notspam policy=outbound score=0\n\tpriorityscore=1501\n\tmalwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0\n\tclxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0\n\tmlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx\n\tscancount=1 engine=8.0.1-1807170000 definitions=main-1811120202", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "quoted-printable", "X-Content-Filtered-By": "Mailman/MimeDel 2.1.15", "Subject": "[dpdk-dev] [PATCH 1/1] eal: Don't fail secondary if primary is\n\tmissing tailqs", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "This patch was submitted by Jean Tourrilhes over two years ago, but didn't receive any responses. I hit the same issue recently when trying to use cgo (Golang) as a primary process linked to libdpdk.a against a C++ application linked against the same library. The history of the patch is here:\n\nhttps://dev.dpdk.narkive.com/ZM3a7QD1/dpdk-dev-bug-static-constructors-considered-evil\n\nand the original patch is here:\n\nhttp://mails.dpdk.org/archives/dev/2016-September/047332.html\n\nCan someone please give this another look? I don't see any other way to do a workaround short of applying this patch.\n\n\nSigned-off-by: Cliff Burdick cliff.burdick@viasat.com<mailto:cliff.burdick@viasat.com>\n\n---\nlib/librte_eal/common/eal_common_tailqs.c | 15 ++++++++++++---\n1 file changed, 12 insertions(+), 3 deletions(-)\n\n if (t->head == NULL) {\n RTE_LOG(ERR, EAL,\n \"Cannot initialize tailq: %s\\n\", t->name);\n- /* no need to TAILQ_REMOVE, we are going to panic in\n- * rte_eal_init() */\n- goto fail;\n+ if (rte_eal_process_type() == RTE_PROC_PRIMARY) {\n+ /* no need to TAILQ_REMOVE, we are going\n+ * to panic in rte_eal_init() */\n+ goto fail;\n+ } else {\n+ /* This means our list of constructor is\n+ * no the same as primary. Just remove\n+ * that missing tailq and continue */\n+ TAILQ_REMOVE(&rte_tailq_elem_head, t, next);\n+ }\n }\n }", "diff": "diff --git a/lib/librte_eal/common/eal_common_tailqs.c b/lib/librte_eal/common/eal_common_tailqs.c\nindex bb08ec8..6960d06 100644\n--- a/lib/librte_eal/common/eal_common_tailqs.c\n+++ b/lib/librte_eal/common/eal_common_tailqs.c\n@@ -143,6 +143,8 @@ rte_eal_tailq_update(struct rte_tailq_elem *t)\n t->head = rte_eal_tailq_create(t->name);\n } else {\n t->head = rte_eal_tailq_lookup(t->name);\n+ if (t->head != NULL)\n+ rte_tailqs_count++;\n }\n}\n@@ -188,9 +190,16 @@ rte_eal_tailqs_init(void)\n", "prefixes": [ "1/1" ] }