Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/48049/?format=api
{ "id": 48049, "url": "http://patchwork.dpdk.org/api/patches/48049/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/8fb8fa187d7f5843904129b22383a2a6fe404797.1542132003.git.anatoly.burakov@intel.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<8fb8fa187d7f5843904129b22383a2a6fe404797.1542132003.git.anatoly.burakov@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/8fb8fa187d7f5843904129b22383a2a6fe404797.1542132003.git.anatoly.burakov@intel.com", "date": "2018-11-13T18:03:52", "name": "[v2] eal/mp: remove rte_panic and profanity", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "306f5f8a70027f08150f5299ed1198b050f0f872", "submitter": { "id": 4, "url": "http://patchwork.dpdk.org/api/people/4/?format=api", "name": "Anatoly Burakov", "email": "anatoly.burakov@intel.com" }, "delegate": { "id": 1, "url": "http://patchwork.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/8fb8fa187d7f5843904129b22383a2a6fe404797.1542132003.git.anatoly.burakov@intel.com/mbox/", "series": [ { "id": 2394, "url": "http://patchwork.dpdk.org/api/series/2394/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=2394", "date": "2018-11-13T18:03:52", "name": "[v2] eal/mp: remove rte_panic and profanity", "version": 2, "mbox": "http://patchwork.dpdk.org/series/2394/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/48049/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/48049/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 5102A493D;\n\tTue, 13 Nov 2018 19:03:57 +0100 (CET)", "from mga02.intel.com (mga02.intel.com [134.134.136.20])\n\tby dpdk.org (Postfix) with ESMTP id 1E6072D13;\n\tTue, 13 Nov 2018 19:03:54 +0100 (CET)", "from fmsmga004.fm.intel.com ([10.253.24.48])\n\tby orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t13 Nov 2018 10:03:54 -0800", "from irvmail001.ir.intel.com ([163.33.26.43])\n\tby fmsmga004.fm.intel.com with ESMTP; 13 Nov 2018 10:03:52 -0800", "from sivswdev01.ir.intel.com (sivswdev01.ir.intel.com\n\t[10.237.217.45])\n\tby irvmail001.ir.intel.com (8.14.3/8.13.6/MailSET/Hub) with ESMTP id\n\twADI3qKm000996; Tue, 13 Nov 2018 18:03:52 GMT", "from sivswdev01.ir.intel.com (localhost [127.0.0.1])\n\tby sivswdev01.ir.intel.com with ESMTP id wADI3q1K006649;\n\tTue, 13 Nov 2018 18:03:52 GMT", "(from aburakov@localhost)\n\tby sivswdev01.ir.intel.com with LOCAL id wADI3qOl006645;\n\tTue, 13 Nov 2018 18:03:52 GMT" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.56,229,1539673200\"; d=\"scan'208\";a=\"105942781\"", "From": "Anatoly Burakov <anatoly.burakov@intel.com>", "To": "dev@dpdk.org", "Cc": "stable@dpdk.org, stephen@networkplumber.org,\n\tStephen Hemminger <sthemmin@microsoft.com>", "Date": "Tue, 13 Nov 2018 18:03:52 +0000", "Message-Id": "<8fb8fa187d7f5843904129b22383a2a6fe404797.1542132003.git.anatoly.burakov@intel.com>", "X-Mailer": "git-send-email 1.7.0.7", "In-Reply-To": "<7632620e2d7fbf772965b2d15b8187df6648a375.1540565496.git.anatoly.burakov@intel.com>", "References": "<7632620e2d7fbf772965b2d15b8187df6648a375.1540565496.git.anatoly.burakov@intel.com>", "Subject": "[dpdk-dev] [PATCH v2] eal/mp: remove rte_panic and profanity", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "EAL should not crash when setting alarm fails. Also, remove the\nprofanity in error message.\n\nFixes: daf9bfca717e (\"ipc: remove thread for async requests\")\n\nCc: stable@dpdk.org\nCc: stephen@networkplumber.org\n\nSigned-off-by: Stephen Hemminger <sthemmin@microsoft.com>\nSigned-off-by: Anatoly Burakov <anatoly.burakov@intel.com>\n---\n\nNotes:\n v2: fix uninitialized variable\n\n lib/librte_eal/common/eal_common_proc.c | 31 ++++++++++++++++++-------\n 1 file changed, 23 insertions(+), 8 deletions(-)", "diff": "diff --git a/lib/librte_eal/common/eal_common_proc.c b/lib/librte_eal/common/eal_common_proc.c\nindex 97663d3ba..f65ef56c0 100644\n--- a/lib/librte_eal/common/eal_common_proc.c\n+++ b/lib/librte_eal/common/eal_common_proc.c\n@@ -800,7 +800,7 @@ mp_request_async(const char *dst, struct rte_mp_msg *req,\n {\n \tstruct rte_mp_msg *reply_msg;\n \tstruct pending_request *pending_req, *exist;\n-\tint ret;\n+\tint ret = -1;\n \n \tpending_req = calloc(1, sizeof(*pending_req));\n \treply_msg = calloc(1, sizeof(*reply_msg));\n@@ -827,6 +827,28 @@ mp_request_async(const char *dst, struct rte_mp_msg *req,\n \t\tgoto fail;\n \t}\n \n+\t/*\n+\t * set the alarm before sending message. there are two possible error\n+\t * scenarios to consider here:\n+\t *\n+\t * - if the alarm set fails, we free the memory right there\n+\t * - if the alarm set succeeds but sending message fails, then the alarm\n+\t * will trigger and clean up the memory\n+\t *\n+\t * Even if the alarm triggers too early (i.e. immediately), we're still\n+\t * holding the lock to pending requests queue, so the interrupt thread\n+\t * will just spin until we release the lock, and either release the\n+\t * memory, or doesn't find any pending requests in the queue because we\n+\t * never added any due to send message failure.\n+\t */\n+\tif (rte_eal_alarm_set(ts->tv_sec * 1000000 + ts->tv_nsec / 1000,\n+\t\t\t async_reply_handle, pending_req) < 0) {\n+\t\tRTE_LOG(ERR, EAL, \"Fail to set alarm for request %s:%s\\n\",\n+\t\t\tdst, req->name);\n+\t\tret = -1;\n+\t\tgoto fail;\n+\t}\n+\n \tret = send_msg(dst, req, MP_REQ);\n \tif (ret < 0) {\n \t\tRTE_LOG(ERR, EAL, \"Fail to send request %s:%s\\n\",\n@@ -841,13 +863,6 @@ mp_request_async(const char *dst, struct rte_mp_msg *req,\n \n \tparam->user_reply.nb_sent++;\n \n-\tif (rte_eal_alarm_set(ts->tv_sec * 1000000 + ts->tv_nsec / 1000,\n-\t\t\t async_reply_handle, pending_req) < 0) {\n-\t\tRTE_LOG(ERR, EAL, \"Fail to set alarm for request %s:%s\\n\",\n-\t\t\tdst, req->name);\n-\t\trte_panic(\"Fix the above shit to properly free all memory\\n\");\n-\t}\n-\n \treturn 0;\n fail:\n \tfree(pending_req);\n", "prefixes": [ "v2" ] }