Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/48073/?format=api
{ "id": 48073, "url": "http://patchwork.dpdk.org/api/patches/48073/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/9eb826f80f19422153d5a0ab611fb467a94eded0.1542197039.git.anatoly.burakov@intel.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<9eb826f80f19422153d5a0ab611fb467a94eded0.1542197039.git.anatoly.burakov@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/9eb826f80f19422153d5a0ab611fb467a94eded0.1542197039.git.anatoly.burakov@intel.com", "date": "2018-11-14T12:11:53", "name": "bitmap: deprecate rte_bsf64", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "2235110c044e71ba44e5c916c198a47f8bb2d3d5", "submitter": { "id": 4, "url": "http://patchwork.dpdk.org/api/people/4/?format=api", "name": "Anatoly Burakov", "email": "anatoly.burakov@intel.com" }, "delegate": { "id": 1, "url": "http://patchwork.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/9eb826f80f19422153d5a0ab611fb467a94eded0.1542197039.git.anatoly.burakov@intel.com/mbox/", "series": [ { "id": 2414, "url": "http://patchwork.dpdk.org/api/series/2414/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=2414", "date": "2018-11-14T12:11:53", "name": "bitmap: deprecate rte_bsf64", "version": 1, "mbox": "http://patchwork.dpdk.org/series/2414/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/48073/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/48073/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 2D4D67EC7;\n\tWed, 14 Nov 2018 13:12:08 +0100 (CET)", "from mga12.intel.com (mga12.intel.com [192.55.52.136])\n\tby dpdk.org (Postfix) with ESMTP id E63B87D52\n\tfor <dev@dpdk.org>; Wed, 14 Nov 2018 13:12:05 +0100 (CET)", "from orsmga007.jf.intel.com ([10.7.209.58])\n\tby fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t14 Nov 2018 04:12:05 -0800", "from irvmail001.ir.intel.com ([163.33.26.43])\n\tby orsmga007.jf.intel.com with ESMTP; 14 Nov 2018 04:12:02 -0800", "from sivswdev01.ir.intel.com (sivswdev01.ir.intel.com\n\t[10.237.217.45])\n\tby irvmail001.ir.intel.com (8.14.3/8.13.6/MailSET/Hub) with ESMTP id\n\twAECC2SV024243; Wed, 14 Nov 2018 12:12:02 GMT", "from sivswdev01.ir.intel.com (localhost [127.0.0.1])\n\tby sivswdev01.ir.intel.com with ESMTP id wAECC1Es031847;\n\tWed, 14 Nov 2018 12:12:01 GMT", "(from aburakov@localhost)\n\tby sivswdev01.ir.intel.com with LOCAL id wAECBr01031788;\n\tWed, 14 Nov 2018 12:11:53 GMT" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.56,232,1539673200\"; d=\"scan'208\";a=\"89211251\"", "From": "Anatoly Burakov <anatoly.burakov@intel.com>", "To": "dev@dpdk.org", "Cc": "Neil Horman <nhorman@tuxdriver.com>,\n\tJohn McNamara <john.mcnamara@intel.com>,\n\tMarko Kovacevic <marko.kovacevic@intel.com>,\n\tCristian Dumitrescu <cristian.dumitrescu@intel.com>,\n\tthomas@monjalon.net, bruce.richardson@intel.com,\n\tferruh.yigit@intel.com, jasvinder.singh@intel.com", "Date": "Wed, 14 Nov 2018 12:11:53 +0000", "Message-Id": "<9eb826f80f19422153d5a0ab611fb467a94eded0.1542197039.git.anatoly.burakov@intel.com>", "X-Mailer": "git-send-email 1.7.0.7", "Subject": "[dpdk-dev] [PATCH] bitmap: deprecate rte_bsf64", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The rte_bsf64 in rte_bitmap.h has a global namespace but does not\nfollow convention of existing rte_bsf32 function in rte_common.h.\n\nTherefore, deprecate the current rte_bsf64 and introduce a new\nrte_bitmap_bsf64 function that will do the same thing.\n\nIn later release cycles, rte_bsf64 will be removed from rte_bitmap.h\nand a proper rte_bsf64 implementation will be added to rte_common.h.\n\nSigned-off-by: Anatoly Burakov <anatoly.burakov@intel.com>\n---\n doc/guides/rel_notes/deprecation.rst | 5 +++++\n lib/librte_eal/common/include/rte_bitmap.h | 16 ++++++++++------\n 2 files changed, 15 insertions(+), 6 deletions(-)", "diff": "diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst\nindex 34b28234c..63793979d 100644\n--- a/doc/guides/rel_notes/deprecation.rst\n+++ b/doc/guides/rel_notes/deprecation.rst\n@@ -22,6 +22,11 @@ Deprecation Notices\n \n + ``rte_eal_devargs_type_count``\n \n+* eal: function ``rte_bsf64`` in ``rte_bitmap.h`` has been renamed to\n+ ``rte_bitmap_bsf64``, and a new ``rte_bsf64`` function will be added in\n+ release 19.05 in ``rte_common.h`` that follows convention set by existing\n+ ``rte_bsf32`` function.\n+\n * pci: Several exposed functions are misnamed.\n The following functions are deprecated starting from v17.11 and are replaced:\n \ndiff --git a/lib/librte_eal/common/include/rte_bitmap.h b/lib/librte_eal/common/include/rte_bitmap.h\nindex 7a36ce73c..fd4f0aa78 100644\n--- a/lib/librte_eal/common/include/rte_bitmap.h\n+++ b/lib/librte_eal/common/include/rte_bitmap.h\n@@ -100,7 +100,7 @@ __rte_bitmap_index2_set(struct rte_bitmap *bmp)\n #if RTE_BITMAP_OPTIMIZATIONS\n \n static inline int\n-rte_bsf64(uint64_t slab, uint32_t *pos)\n+rte_bitmap_bsf64(uint64_t slab, uint32_t *pos)\n {\n \tif (likely(slab == 0)) {\n \t\treturn 0;\n@@ -113,7 +113,7 @@ rte_bsf64(uint64_t slab, uint32_t *pos)\n #else\n \n static inline int\n-rte_bsf64(uint64_t slab, uint32_t *pos)\n+rte_bitmap_bsf64(uint64_t slab, uint32_t *pos)\n {\n \tuint64_t mask;\n \tuint32_t i;\n@@ -134,6 +134,12 @@ rte_bsf64(uint64_t slab, uint32_t *pos)\n \n #endif\n \n+static inline int __rte_deprecated\n+rte_bsf64(uint64_t slab, uint32_t *pos)\n+{\n+\treturn rte_bitmap_bsf64(slab, pos);\n+}\n+\n static inline uint32_t\n __rte_bitmap_get_memory_footprint(uint32_t n_bits,\n \tuint32_t *array1_byte_offset, uint32_t *array1_slabs,\n@@ -439,9 +445,8 @@ __rte_bitmap_scan_search(struct rte_bitmap *bmp)\n \tvalue1 = bmp->array1[bmp->index1];\n \tvalue1 &= __rte_bitmap_mask1_get(bmp);\n \n-\tif (rte_bsf64(value1, &bmp->offset1)) {\n+\tif (rte_bitmap_bsf64(value1, &bmp->offset1))\n \t\treturn 1;\n-\t}\n \n \t__rte_bitmap_index1_inc(bmp);\n \tbmp->offset1 = 0;\n@@ -450,9 +455,8 @@ __rte_bitmap_scan_search(struct rte_bitmap *bmp)\n \tfor (i = 0; i < bmp->array1_size; i ++, __rte_bitmap_index1_inc(bmp)) {\n \t\tvalue1 = bmp->array1[bmp->index1];\n \n-\t\tif (rte_bsf64(value1, &bmp->offset1)) {\n+\t\tif (rte_bitmap_bsf64(value1, &bmp->offset1))\n \t\t\treturn 1;\n-\t\t}\n \t}\n \n \treturn 0;\n", "prefixes": [] }