Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/48082/?format=api
{ "id": 48082, "url": "http://patchwork.dpdk.org/api/patches/48082/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/fbc68e4e563904b7758950cc50ecf0f753f4ec53.1542212598.git.anatoly.burakov@intel.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<fbc68e4e563904b7758950cc50ecf0f753f4ec53.1542212598.git.anatoly.burakov@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/fbc68e4e563904b7758950cc50ecf0f753f4ec53.1542212598.git.anatoly.burakov@intel.com", "date": "2018-11-14T16:30:19", "name": "[v2,1/5] bitmap: remove useless code", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "c62037cf787776d81beacf1c70545be1d233a898", "submitter": { "id": 4, "url": "http://patchwork.dpdk.org/api/people/4/?format=api", "name": "Anatoly Burakov", "email": "anatoly.burakov@intel.com" }, "delegate": { "id": 1, "url": "http://patchwork.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/fbc68e4e563904b7758950cc50ecf0f753f4ec53.1542212598.git.anatoly.burakov@intel.com/mbox/", "series": [ { "id": 2423, "url": "http://patchwork.dpdk.org/api/series/2423/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=2423", "date": "2018-11-14T16:30:19", "name": "[v2,1/5] bitmap: remove useless code", "version": 2, "mbox": "http://patchwork.dpdk.org/series/2423/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/48082/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/48082/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 0C8021B147;\n\tWed, 14 Nov 2018 17:30:29 +0100 (CET)", "from mga02.intel.com (mga02.intel.com [134.134.136.20])\n\tby dpdk.org (Postfix) with ESMTP id D63651B144\n\tfor <dev@dpdk.org>; Wed, 14 Nov 2018 17:30:27 +0100 (CET)", "from orsmga005.jf.intel.com ([10.7.209.41])\n\tby orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t14 Nov 2018 08:30:26 -0800", "from irvmail001.ir.intel.com ([163.33.26.43])\n\tby orsmga005.jf.intel.com with ESMTP; 14 Nov 2018 08:30:24 -0800", "from sivswdev01.ir.intel.com (sivswdev01.ir.intel.com\n\t[10.237.217.45])\n\tby irvmail001.ir.intel.com (8.14.3/8.13.6/MailSET/Hub) with ESMTP id\n\twAEGUObn029206; Wed, 14 Nov 2018 16:30:24 GMT", "from sivswdev01.ir.intel.com (localhost [127.0.0.1])\n\tby sivswdev01.ir.intel.com with ESMTP id wAEGUO64007142;\n\tWed, 14 Nov 2018 16:30:24 GMT", "(from aburakov@localhost)\n\tby sivswdev01.ir.intel.com with LOCAL id wAEGUN7d007136;\n\tWed, 14 Nov 2018 16:30:23 GMT" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.56,233,1539673200\"; d=\"scan'208\";a=\"273971204\"", "From": "Anatoly Burakov <anatoly.burakov@intel.com>", "To": "dev@dpdk.org", "Cc": "Cristian Dumitrescu <cristian.dumitrescu@intel.com>, thomas@monjalon.net,\n\tbruce.richardson@intel.com, ferruh.yigit@intel.com,\n\tjasvinder.singh@intel.com", "Date": "Wed, 14 Nov 2018 16:30:19 +0000", "Message-Id": "<fbc68e4e563904b7758950cc50ecf0f753f4ec53.1542212598.git.anatoly.burakov@intel.com>", "X-Mailer": "git-send-email 1.7.0.7", "In-Reply-To": "<9eb826f80f19422153d5a0ab611fb467a94eded0.1542197039.git.anatoly.burakov@intel.com>", "References": "<9eb826f80f19422153d5a0ab611fb467a94eded0.1542197039.git.anatoly.burakov@intel.com>", "Subject": "[dpdk-dev] [PATCH v2 1/5] bitmap: remove useless code", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "RTE_BITMAP_OPTIMIZATIONS was never set to 0 and makes no sense\nanyway, so remove all code related to it. Also, drop the \"likely\"\nfor bsf64 code, because it's a generic function and we cannot\nmake any assumptions about likely values of incoming arguments.\n\nSigned-off-by: Anatoly Burakov <anatoly.burakov@intel.com>\n---\n lib/librte_eal/common/include/rte_bitmap.h | 33 +---------------------\n 1 file changed, 1 insertion(+), 32 deletions(-)", "diff": "diff --git a/lib/librte_eal/common/include/rte_bitmap.h b/lib/librte_eal/common/include/rte_bitmap.h\nindex 7a36ce73c..d2ed6204c 100644\n--- a/lib/librte_eal/common/include/rte_bitmap.h\n+++ b/lib/librte_eal/common/include/rte_bitmap.h\n@@ -43,10 +43,6 @@ extern \"C\" {\n #include <rte_branch_prediction.h>\n #include <rte_prefetch.h>\n \n-#ifndef RTE_BITMAP_OPTIMIZATIONS\n-#define RTE_BITMAP_OPTIMIZATIONS\t\t 1\n-#endif\n-\n /* Slab */\n #define RTE_BITMAP_SLAB_BIT_SIZE 64\n #define RTE_BITMAP_SLAB_BIT_SIZE_LOG2 6\n@@ -97,43 +93,16 @@ __rte_bitmap_index2_set(struct rte_bitmap *bmp)\n \tbmp->index2 = (((bmp->index1 << RTE_BITMAP_SLAB_BIT_SIZE_LOG2) + bmp->offset1) << RTE_BITMAP_CL_SLAB_SIZE_LOG2);\n }\n \n-#if RTE_BITMAP_OPTIMIZATIONS\n-\n static inline int\n rte_bsf64(uint64_t slab, uint32_t *pos)\n {\n-\tif (likely(slab == 0)) {\n+\tif (slab == 0)\n \t\treturn 0;\n-\t}\n \n \t*pos = __builtin_ctzll(slab);\n \treturn 1;\n }\n \n-#else\n-\n-static inline int\n-rte_bsf64(uint64_t slab, uint32_t *pos)\n-{\n-\tuint64_t mask;\n-\tuint32_t i;\n-\n-\tif (likely(slab == 0)) {\n-\t\treturn 0;\n-\t}\n-\n-\tfor (i = 0, mask = 1; i < RTE_BITMAP_SLAB_BIT_SIZE; i ++, mask <<= 1) {\n-\t\tif (unlikely(slab & mask)) {\n-\t\t\t*pos = i;\n-\t\t\treturn 1;\n-\t\t}\n-\t}\n-\n-\treturn 0;\n-}\n-\n-#endif\n-\n static inline uint32_t\n __rte_bitmap_get_memory_footprint(uint32_t n_bits,\n \tuint32_t *array1_byte_offset, uint32_t *array1_slabs,\n", "prefixes": [ "v2", "1/5" ] }