Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/48338/?format=api
{ "id": 48338, "url": "http://patchwork.dpdk.org/api/patches/48338/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/294f089848bf803ff134979c612bbf28e0e2e6b9.1543229588.git.anatoly.burakov@intel.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<294f089848bf803ff134979c612bbf28e0e2e6b9.1543229588.git.anatoly.burakov@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/294f089848bf803ff134979c612bbf28e0e2e6b9.1543229588.git.anatoly.burakov@intel.com", "date": "2018-11-26T10:57:03", "name": "mem: fix division by zero in no-NUMA mode", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "db5f1bfcc184a5da81c901c7f65896347c46f6a3", "submitter": { "id": 4, "url": "http://patchwork.dpdk.org/api/people/4/?format=api", "name": "Anatoly Burakov", "email": "anatoly.burakov@intel.com" }, "delegate": null, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/294f089848bf803ff134979c612bbf28e0e2e6b9.1543229588.git.anatoly.burakov@intel.com/mbox/", "series": [ { "id": 2568, "url": "http://patchwork.dpdk.org/api/series/2568/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=2568", "date": "2018-11-26T10:57:03", "name": "mem: fix division by zero in no-NUMA mode", "version": 1, "mbox": "http://patchwork.dpdk.org/series/2568/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/48338/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/48338/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 2BD651B6C7;\n\tMon, 26 Nov 2018 11:57:08 +0100 (CET)", "from mga03.intel.com (mga03.intel.com [134.134.136.65])\n\tby dpdk.org (Postfix) with ESMTP id 3E9561B5F0;\n\tMon, 26 Nov 2018 11:57:05 +0100 (CET)", "from orsmga003.jf.intel.com ([10.7.209.27])\n\tby orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t26 Nov 2018 02:57:04 -0800", "from irvmail001.ir.intel.com ([163.33.26.43])\n\tby orsmga003.jf.intel.com with ESMTP; 26 Nov 2018 02:57:04 -0800", "from sivswdev01.ir.intel.com (sivswdev01.ir.intel.com\n\t[10.237.217.45])\n\tby irvmail001.ir.intel.com (8.14.3/8.13.6/MailSET/Hub) with ESMTP id\n\twAQAv35w019518; Mon, 26 Nov 2018 10:57:03 GMT", "from sivswdev01.ir.intel.com (localhost [127.0.0.1])\n\tby sivswdev01.ir.intel.com with ESMTP id wAQAv3Tx006825;\n\tMon, 26 Nov 2018 10:57:03 GMT", "(from aburakov@localhost)\n\tby sivswdev01.ir.intel.com with LOCAL id wAQAv3KK006821;\n\tMon, 26 Nov 2018 10:57:03 GMT" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.56,281,1539673200\"; d=\"scan'208\";a=\"103202070\"", "From": "Anatoly Burakov <anatoly.burakov@intel.com>", "To": "dev@dpdk.org", "Cc": "thomas@monjalon.net, stable@dpdk.org", "Date": "Mon, 26 Nov 2018 10:57:03 +0000", "Message-Id": "<294f089848bf803ff134979c612bbf28e0e2e6b9.1543229588.git.anatoly.burakov@intel.com>", "X-Mailer": "git-send-email 1.7.0.7", "Subject": "[dpdk-dev] [PATCH] mem: fix division by zero in no-NUMA mode", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "When RTE_EAL_NUMA_AWARE_HUGEPAGES is set to \"n\", not all memtypes\nwill be valid, because we skip some due to not supporting other\nNUMA nodes, leading to a division by zero error down the line\nbecause the necessary memtype fields weren't populated.\n\nFix it by limiting number of memtypes to number of memtypes we\nhave actually created.\n\nFixes: 1dd342d0fdc4 (\"mem: improve segment list preallocation\")\nCc: stable@dpdk.org\n\nSigned-off-by: Anatoly Burakov <anatoly.burakov@intel.com>\n---\n lib/librte_eal/linuxapp/eal/eal_memory.c | 2 ++\n 1 file changed, 2 insertions(+)", "diff": "diff --git a/lib/librte_eal/linuxapp/eal/eal_memory.c b/lib/librte_eal/linuxapp/eal/eal_memory.c\nindex 6f94621d4..32feb415d 100644\n--- a/lib/librte_eal/linuxapp/eal/eal_memory.c\n+++ b/lib/librte_eal/linuxapp/eal/eal_memory.c\n@@ -2230,6 +2230,8 @@ memseg_primary_init(void)\n \t\t\t\tsocket_id, hugepage_sz);\n \t\t}\n \t}\n+\t/* number of memtypes could have been lower due to no NUMA support */\n+\tn_memtypes = cur_type;\n \n \t/* set up limits for types */\n \tmax_mem = (uint64_t)RTE_MAX_MEM_MB << 20;\n", "prefixes": [] }