Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/48649/?format=api
{ "id": 48649, "url": "http://patchwork.dpdk.org/api/patches/48649/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/4934d38eb70f2951f9212bd4d7e35ceb9d982321.1544546857.git.anatoly.burakov@intel.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<4934d38eb70f2951f9212bd4d7e35ceb9d982321.1544546857.git.anatoly.burakov@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/4934d38eb70f2951f9212bd4d7e35ceb9d982321.1544546857.git.anatoly.burakov@intel.com", "date": "2018-12-11T16:48:28", "name": "[v2] malloc: fix duplicate mem event notification", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "20a9239bdff6c76a5ebf97b269ff56b3d844748b", "submitter": { "id": 4, "url": "http://patchwork.dpdk.org/api/people/4/?format=api", "name": "Anatoly Burakov", "email": "anatoly.burakov@intel.com" }, "delegate": { "id": 1, "url": "http://patchwork.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/4934d38eb70f2951f9212bd4d7e35ceb9d982321.1544546857.git.anatoly.burakov@intel.com/mbox/", "series": [ { "id": 2731, "url": "http://patchwork.dpdk.org/api/series/2731/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=2731", "date": "2018-12-11T16:48:28", "name": "[v2] malloc: fix duplicate mem event notification", "version": 2, "mbox": "http://patchwork.dpdk.org/series/2731/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/48649/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/48649/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 266345B26;\n\tTue, 11 Dec 2018 17:48:32 +0100 (CET)", "from mga18.intel.com (mga18.intel.com [134.134.136.126])\n\tby dpdk.org (Postfix) with ESMTP id D220F2C12;\n\tTue, 11 Dec 2018 17:48:30 +0100 (CET)", "from fmsmga008.fm.intel.com ([10.253.24.58])\n\tby orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t11 Dec 2018 08:48:29 -0800", "from irvmail001.ir.intel.com ([163.33.26.43])\n\tby fmsmga008.fm.intel.com with ESMTP; 11 Dec 2018 08:48:28 -0800", "from sivswdev05.ir.intel.com (sivswdev05.ir.intel.com\n\t[10.243.17.64])\n\tby irvmail001.ir.intel.com (8.14.3/8.13.6/MailSET/Hub) with ESMTP id\n\twBBGmSI7026944; Tue, 11 Dec 2018 16:48:28 GMT", "from sivswdev05.ir.intel.com (localhost [127.0.0.1])\n\tby sivswdev05.ir.intel.com with ESMTP id wBBGmSjV008195;\n\tTue, 11 Dec 2018 16:48:28 GMT", "(from aburakov@localhost)\n\tby sivswdev05.ir.intel.com with LOCAL id wBBGmSKN008191;\n\tTue, 11 Dec 2018 16:48:28 GMT" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.56,342,1539673200\"; d=\"scan'208\";a=\"108717796\"", "From": "Anatoly Burakov <anatoly.burakov@intel.com>", "To": "dev@dpdk.org", "Cc": "keith.wiles@intel.com, stable@dpdk.org", "Date": "Tue, 11 Dec 2018 16:48:28 +0000", "Message-Id": "<4934d38eb70f2951f9212bd4d7e35ceb9d982321.1544546857.git.anatoly.burakov@intel.com>", "X-Mailer": "git-send-email 1.7.0.7", "In-Reply-To": "<a3807707cec73b13b25cdd623440fbcb61f02134.1543501068.git.anatoly.burakov@intel.com>", "References": "<a3807707cec73b13b25cdd623440fbcb61f02134.1543501068.git.anatoly.burakov@intel.com>", "Subject": "[dpdk-dev] [PATCH v2] malloc: fix duplicate mem event notification", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "We already trigger a mem event notification inside the walk function,\nno need to do it twice.\n\nFixes: f32c7c9de961 (\"malloc: enable event callbacks for external memory\")\nCc: stable@dpdk.org\n\nSigned-off-by: Anatoly Burakov <anatoly.burakov@intel.com>\n---\n\nNotes:\n v2:\n - Fixed code style\n\n lib/librte_eal/common/rte_malloc.c | 7 +------\n 1 file changed, 1 insertion(+), 6 deletions(-)", "diff": "diff --git a/lib/librte_eal/common/rte_malloc.c b/lib/librte_eal/common/rte_malloc.c\nindex 0da5ad5e8..5f07b981a 100644\n--- a/lib/librte_eal/common/rte_malloc.c\n+++ b/lib/librte_eal/common/rte_malloc.c\n@@ -517,13 +517,8 @@ sync_memory(const char *heap_name, void *va_addr, size_t len, bool attach)\n \tif (wa.result < 0) {\n \t\trte_errno = -wa.result;\n \t\tret = -1;\n-\t} else {\n-\t\t/* notify all subscribers that a new memory area was added */\n-\t\tif (attach)\n-\t\t\teal_memalloc_mem_event_notify(RTE_MEM_EVENT_ALLOC,\n-\t\t\t\t\tva_addr, len);\n+\t} else\n \t\tret = 0;\n-\t}\n unlock:\n \trte_rwlock_read_unlock(&mcfg->memory_hotplug_lock);\n \treturn ret;\n", "prefixes": [ "v2" ] }