Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/48916/?format=api
{ "id": 48916, "url": "http://patchwork.dpdk.org/api/patches/48916/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/1544805623-18150-5-git-send-email-konstantin.ananyev@intel.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1544805623-18150-5-git-send-email-konstantin.ananyev@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1544805623-18150-5-git-send-email-konstantin.ananyev@intel.com", "date": "2018-12-14T16:40:18", "name": "[v4,4/9] examples/ipsec-secgw: fix outbound codepath for single SA", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "27c244d4ce26abd5d9df6050a784ffed61366e78", "submitter": { "id": 33, "url": "http://patchwork.dpdk.org/api/people/33/?format=api", "name": "Ananyev, Konstantin", "email": "konstantin.ananyev@intel.com" }, "delegate": { "id": 1, "url": "http://patchwork.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/1544805623-18150-5-git-send-email-konstantin.ananyev@intel.com/mbox/", "series": [ { "id": 2796, "url": "http://patchwork.dpdk.org/api/series/2796/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=2796", "date": "2018-12-14T16:40:18", "name": null, "version": 4, "mbox": "http://patchwork.dpdk.org/series/2796/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/48916/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/48916/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 75FC21B955;\n\tFri, 14 Dec 2018 17:40:40 +0100 (CET)", "from mga06.intel.com (mga06.intel.com [134.134.136.31])\n\tby dpdk.org (Postfix) with ESMTP id A99C01B5D7\n\tfor <dev@dpdk.org>; Fri, 14 Dec 2018 17:40:34 +0100 (CET)", "from orsmga008.jf.intel.com ([10.7.209.65])\n\tby orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t14 Dec 2018 08:40:34 -0800", "from sivswdev08.ir.intel.com (HELO localhost.localdomain)\n\t([10.237.217.47])\n\tby orsmga008.jf.intel.com with ESMTP; 14 Dec 2018 08:40:32 -0800" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.56,353,1539673200\"; d=\"scan'208\";a=\"101573816\"", "From": "Konstantin Ananyev <konstantin.ananyev@intel.com>", "To": "dev@dpdk.org", "Cc": "akhil.goyal@nxp.com, radu.nicolau@intel.com,\n\tKonstantin Ananyev <konstantin.ananyev@intel.com>", "Date": "Fri, 14 Dec 2018 16:40:18 +0000", "Message-Id": "<1544805623-18150-5-git-send-email-konstantin.ananyev@intel.com>", "X-Mailer": "git-send-email 1.7.0.7", "In-Reply-To": "<1544111691-7481-1-git-send-email-konstantin.ananyev@intel.com>", "References": "<1544111691-7481-1-git-send-email-konstantin.ananyev@intel.com>", "Subject": "[dpdk-dev] [PATCH v4 4/9] examples/ipsec-secgw: fix outbound\n\tcodepath for single SA", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Looking at process_pkts_outbound_nosp() there seems few issues:\n- accessing mbuf after it was freed\n- invoking ipsec_outbound() for ipv4 packets only\n- copying number of packets, but not the mbuf pointers itself\n\nthat patch provides fixes for that issues.\n\nFixes: 906257e965b7 (\"examples/ipsec-secgw: support IPv6\")\n\nSigned-off-by: Konstantin Ananyev <konstantin.ananyev@intel.com>\nAcked-by: Radu Nicolau <radu.nicolau@intel.com>\n---\n examples/ipsec-secgw/ipsec-secgw.c | 32 ++++++++++++++++++++----------\n 1 file changed, 22 insertions(+), 10 deletions(-)", "diff": "diff --git a/examples/ipsec-secgw/ipsec-secgw.c b/examples/ipsec-secgw/ipsec-secgw.c\nindex 62443172a..d1da2d5ce 100644\n--- a/examples/ipsec-secgw/ipsec-secgw.c\n+++ b/examples/ipsec-secgw/ipsec-secgw.c\n@@ -616,32 +616,44 @@ process_pkts_outbound_nosp(struct ipsec_ctx *ipsec_ctx,\n \t\tstruct ipsec_traffic *traffic)\n {\n \tstruct rte_mbuf *m;\n-\tuint32_t nb_pkts_out, i;\n+\tuint32_t nb_pkts_out, i, n;\n \tstruct ip *ip;\n \n \t/* Drop any IPsec traffic from protected ports */\n \tfor (i = 0; i < traffic->ipsec.num; i++)\n \t\trte_pktmbuf_free(traffic->ipsec.pkts[i]);\n \n-\ttraffic->ipsec.num = 0;\n+\tn = 0;\n \n-\tfor (i = 0; i < traffic->ip4.num; i++)\n-\t\ttraffic->ip4.res[i] = single_sa_idx;\n+\tfor (i = 0; i < traffic->ip4.num; i++) {\n+\t\ttraffic->ipsec.pkts[n] = traffic->ip4.pkts[i];\n+\t\ttraffic->ipsec.res[n++] = single_sa_idx;\n+\t}\n \n-\tfor (i = 0; i < traffic->ip6.num; i++)\n-\t\ttraffic->ip6.res[i] = single_sa_idx;\n+\tfor (i = 0; i < traffic->ip6.num; i++) {\n+\t\ttraffic->ipsec.pkts[n] = traffic->ip6.pkts[i];\n+\t\ttraffic->ipsec.res[n++] = single_sa_idx;\n+\t}\n+\n+\ttraffic->ip4.num = 0;\n+\ttraffic->ip6.num = 0;\n+\ttraffic->ipsec.num = n;\n \n-\tnb_pkts_out = ipsec_outbound(ipsec_ctx, traffic->ip4.pkts,\n-\t\t\ttraffic->ip4.res, traffic->ip4.num,\n+\tnb_pkts_out = ipsec_outbound(ipsec_ctx, traffic->ipsec.pkts,\n+\t\t\ttraffic->ipsec.res, traffic->ipsec.num,\n \t\t\tMAX_PKT_BURST);\n \n \t/* They all sue the same SA (ip4 or ip6 tunnel) */\n \tm = traffic->ipsec.pkts[i];\n \tip = rte_pktmbuf_mtod(m, struct ip *);\n-\tif (ip->ip_v == IPVERSION)\n+\tif (ip->ip_v == IPVERSION) {\n \t\ttraffic->ip4.num = nb_pkts_out;\n-\telse\n+\t\tfor (i = 0; i < nb_pkts_out; i++)\n+\t\t\ttraffic->ip4.pkts[i] = traffic->ipsec.pkts[i];\n+\t} else {\n \t\ttraffic->ip6.num = nb_pkts_out;\n+\t\ttraffic->ip6.pkts[i] = traffic->ipsec.pkts[i];\n+\t}\n }\n \n static inline int32_t\n", "prefixes": [ "v4", "4/9" ] }