Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/4901/?format=api
{ "id": 4901, "url": "http://patchwork.dpdk.org/api/patches/4901/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/1432643987-8916-9-git-send-email-maciejx.t.gajdzica@intel.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1432643987-8916-9-git-send-email-maciejx.t.gajdzica@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1432643987-8916-9-git-send-email-maciejx.t.gajdzica@intel.com", "date": "2015-05-26T12:39:45", "name": "[dpdk-dev,v3,08/10] table: added hash_lru table stats", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "7835aaae227423fe71a0677d5d64deea2bdfec97", "submitter": { "id": 18, "url": "http://patchwork.dpdk.org/api/people/18/?format=api", "name": "Maciej Gajdzica", "email": "maciejx.t.gajdzica@intel.com" }, "delegate": null, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/1432643987-8916-9-git-send-email-maciejx.t.gajdzica@intel.com/mbox/", "series": [], "comments": "http://patchwork.dpdk.org/api/patches/4901/comments/", "check": "pending", "checks": "http://patchwork.dpdk.org/api/patches/4901/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id E755DB3D6;\n\tTue, 26 May 2015 15:27:11 +0200 (CEST)", "from mga11.intel.com (mga11.intel.com [192.55.52.93])\n\tby dpdk.org (Postfix) with ESMTP id C48A9B38D\n\tfor <dev@dpdk.org>; Tue, 26 May 2015 15:27:09 +0200 (CEST)", "from orsmga002.jf.intel.com ([10.7.209.21])\n\tby fmsmga102.fm.intel.com with ESMTP; 26 May 2015 06:27:10 -0700", "from unknown (HELO stargo) ([10.217.248.233])\n\tby orsmga002.jf.intel.com with SMTP; 26 May 2015 06:27:06 -0700", "by stargo (sSMTP sendmail emulation);\n\tTue, 26 May 2015 15:19:10 +0200" ], "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.13,498,1427785200\"; d=\"scan'208\";a=\"735399537\"", "From": "Maciej Gajdzica <maciejx.t.gajdzica@intel.com>", "To": "dev@dpdk.org", "Date": "Tue, 26 May 2015 14:39:45 +0200", "Message-Id": "<1432643987-8916-9-git-send-email-maciejx.t.gajdzica@intel.com>", "X-Mailer": "git-send-email 1.9.1", "In-Reply-To": "<1432643987-8916-1-git-send-email-maciejx.t.gajdzica@intel.com>", "References": "<1432643987-8916-1-git-send-email-maciejx.t.gajdzica@intel.com>", "Subject": "[dpdk-dev] [PATCH v3 08/10] table: added hash_lru table stats", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Added statistics for hash_lru table.\n\nSigned-off-by: Maciej Gajdzica <maciejx.t.gajdzica@intel.com>\n---\n lib/librte_table/rte_table_hash_lru.c | 44 +++++++++++++++++++++++++++++++++\n 1 file changed, 44 insertions(+)", "diff": "diff --git a/lib/librte_table/rte_table_hash_lru.c b/lib/librte_table/rte_table_hash_lru.c\nindex c9a8afd..30ed19f 100644\n--- a/lib/librte_table/rte_table_hash_lru.c\n+++ b/lib/librte_table/rte_table_hash_lru.c\n@@ -45,6 +45,20 @@\n \n #define KEYS_PER_BUCKET\t4\n \n+#if RTE_LOG_LEVEL == RTE_LOG_DEBUG\n+\n+#define RTE_TABLE_HASH_LRU_STATS_PKTS_IN_ADD(table, val) \\\n+\ttable->stats.n_pkts_in += val\n+#define RTE_TABLE_HASH_LRU_STATS_PKTS_LOOKUP_MISS(table, val) \\\n+\ttable->stats.n_pkts_lookup_miss += val\n+\n+#else\n+\n+#define RTE_TABLE_HASH_LRU_STATS_PKTS_IN_ADD(table, val)\n+#define RTE_TABLE_HASH_LRU_STATS_PKTS_LOOKUP_MISS(table, val)\n+\n+#endif\n+\n struct bucket {\n \tunion {\n \t\tstruct bucket *next;\n@@ -63,6 +77,8 @@ struct grinder {\n };\n \n struct rte_table_hash {\n+\tstruct rte_table_stats stats;\n+\n \t/* Input parameters */\n \tuint32_t key_size;\n \tuint32_t entry_size;\n@@ -368,6 +384,9 @@ static int rte_table_hash_lru_lookup_unoptimized(\n \tstruct rte_table_hash *t = (struct rte_table_hash *) table;\n \tuint64_t pkts_mask_out = 0;\n \n+\t__rte_unused uint32_t n_pkts_in = __builtin_popcountll(pkts_mask);\n+\tRTE_TABLE_HASH_LRU_STATS_PKTS_IN_ADD(t, n_pkts_in);\n+\n \tfor ( ; pkts_mask; ) {\n \t\tstruct bucket *bkt;\n \t\tstruct rte_mbuf *pkt;\n@@ -412,6 +431,7 @@ static int rte_table_hash_lru_lookup_unoptimized(\n \t}\n \n \t*lookup_hit_mask = pkts_mask_out;\n+\tRTE_TABLE_HASH_LRU_STATS_PKTS_LOOKUP_MISS(t, n_pkts_in - __builtin_popcountll(pkts_mask_out));\n \treturn 0;\n }\n \n@@ -804,6 +824,9 @@ static int rte_table_hash_lru_lookup(\n \tuint64_t pkts_mask_out = 0, pkts_mask_match_many = 0;\n \tint status = 0;\n \n+\t__rte_unused uint32_t n_pkts_in = __builtin_popcountll(pkts_mask);\n+\tRTE_TABLE_HASH_LRU_STATS_PKTS_IN_ADD(t, n_pkts_in);\n+\n \t/* Cannot run the pipeline with less than 7 packets */\n \tif (__builtin_popcountll(pkts_mask) < 7)\n \t\treturn rte_table_hash_lru_lookup_unoptimized(table, pkts,\n@@ -916,6 +939,7 @@ static int rte_table_hash_lru_lookup(\n \t}\n \n \t*lookup_hit_mask = pkts_mask_out;\n+\tRTE_TABLE_HASH_LRU_STATS_PKTS_LOOKUP_MISS(t, n_pkts_in - __builtin_popcountll(pkts_mask_out));\n \treturn status;\n }\n \n@@ -933,6 +957,9 @@ static int rte_table_hash_lru_lookup_dosig(\n \tuint64_t pkts_mask_out = 0, pkts_mask_match_many = 0;\n \tint status = 0;\n \n+\t__rte_unused uint32_t n_pkts_in = __builtin_popcountll(pkts_mask);\n+\tRTE_TABLE_HASH_LRU_STATS_PKTS_IN_ADD(t, n_pkts_in);\n+\n \t/* Cannot run the pipeline with less than 7 packets */\n \tif (__builtin_popcountll(pkts_mask) < 7)\n \t\treturn rte_table_hash_lru_lookup_unoptimized(table, pkts,\n@@ -1045,15 +1072,31 @@ static int rte_table_hash_lru_lookup_dosig(\n \t}\n \n \t*lookup_hit_mask = pkts_mask_out;\n+\tRTE_TABLE_HASH_LRU_STATS_PKTS_LOOKUP_MISS(t, n_pkts_in - __builtin_popcountll(pkts_mask_out));\n \treturn status;\n }\n \n+static int\n+rte_table_hash_lru_stats_read(void *table, struct rte_table_stats *stats, int clear)\n+{\n+\tstruct rte_table_hash *t = (struct rte_table_hash *) table;\n+\n+\tif (stats != NULL)\n+\t\tmemcpy(stats, &t->stats, sizeof(t->stats));\n+\n+\tif (clear)\n+\t\tmemset(&t->stats, 0, sizeof(t->stats));\n+\n+\treturn 0;\n+}\n+\n struct rte_table_ops rte_table_hash_lru_ops = {\n \t.f_create = rte_table_hash_lru_create,\n \t.f_free = rte_table_hash_lru_free,\n \t.f_add = rte_table_hash_lru_entry_add,\n \t.f_delete = rte_table_hash_lru_entry_delete,\n \t.f_lookup = rte_table_hash_lru_lookup,\n+\t.f_stats = rte_table_hash_lru_stats_read,\n };\n \n struct rte_table_ops rte_table_hash_lru_dosig_ops = {\n@@ -1062,4 +1105,5 @@ struct rte_table_ops rte_table_hash_lru_dosig_ops = {\n \t.f_add = rte_table_hash_lru_entry_add,\n \t.f_delete = rte_table_hash_lru_entry_delete,\n \t.f_lookup = rte_table_hash_lru_lookup_dosig,\n+\t.f_stats = rte_table_hash_lru_stats_read,\n };\n", "prefixes": [ "dpdk-dev", "v3", "08/10" ] }