Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/49075/?format=api
{ "id": 49075, "url": "http://patchwork.dpdk.org/api/patches/49075/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/201812181015.wBIAFlYk016726@ccmail04.silk.ntt-tx.co.jp/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<201812181015.wBIAFlYk016726@ccmail04.silk.ntt-tx.co.jp>", "list_archive_url": "https://inbox.dpdk.org/dev/201812181015.wBIAFlYk016726@ccmail04.silk.ntt-tx.co.jp", "date": "2018-12-18T10:14:30", "name": "vhost: delete freeing mac_addrs in eth_dev_close", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "9382e1932f6587972aae5ee006d9628a8f1f4a19", "submitter": { "id": 1156, "url": "http://patchwork.dpdk.org/api/people/1156/?format=api", "name": "Hideyuki Yamashita", "email": "yamashita.hideyuki@po.ntt-tx.co.jp" }, "delegate": { "id": 2642, "url": "http://patchwork.dpdk.org/api/users/2642/?format=api", "username": "mcoquelin", "first_name": "Maxime", "last_name": "Coquelin", "email": "maxime.coquelin@redhat.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/201812181015.wBIAFlYk016726@ccmail04.silk.ntt-tx.co.jp/mbox/", "series": [ { "id": 2843, "url": "http://patchwork.dpdk.org/api/series/2843/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=2843", "date": "2018-12-18T10:14:30", "name": "vhost: delete freeing mac_addrs in eth_dev_close", "version": 1, "mbox": "http://patchwork.dpdk.org/series/2843/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/49075/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/49075/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 53BAE1BB3E;\n\tTue, 18 Dec 2018 11:16:10 +0100 (CET)", "from mail04.ics.ntt-tx.co.jp (mail05.ics.ntt-tx.co.jp\n\t[210.232.35.69]) by dpdk.org (Postfix) with ESMTP id 6E3341B43B\n\tfor <dev@dpdk.org>; Tue, 18 Dec 2018 11:16:09 +0100 (CET)", "from gwchk03.silk.ntt-tx.co.jp (gwchk03.silk.ntt-tx.co.jp\n\t[10.107.0.111])\n\tby mail04.ics.ntt-tx.co.jp (unknown) with ESMTP id wBIAG8dO027784;\n\tTue, 18 Dec 2018 19:16:08 +0900", "(from root@localhost)\n\tby gwchk03.silk.ntt-tx.co.jp (unknown) id wBIAG8Vb017223;\n\tTue, 18 Dec 2018 19:16:08 +0900", "from gwchk.silk.ntt-tx.co.jp [10.107.0.110] \n\tby gwchk03.silk.ntt-tx.co.jp with ESMTP id VAA17222;\n\tTue, 18 Dec 2018 19:16:08 +0900", "from imss05.silk.ntt-tx.co.jp (localhost [127.0.0.1])\n\tby ccmail04.silk.ntt-tx.co.jp (unknown) with ESMTP id wBIAG7Ff016823; \n\tTue, 18 Dec 2018 19:16:07 +0900", "from imss05.silk.ntt-tx.co.jp (localhost [127.0.0.1])\n\tby imss05.silk.ntt-tx.co.jp (unknown) with ESMTP id wBIAG7FK016352;\n\tTue, 18 Dec 2018 19:16:07 +0900", "from ccmail04 (smtp03.silk.ntt-tx.co.jp [10.107.0.135]) by\n\timss05.silk.ntt-tx.co.jp (unknown) with SMTP id wBIAG702016349;\n\tTue, 18 Dec 2018 19:16:07 +0900" ], "Date": "Tue, 18 Dec 2018 19:14:30 +0900", "From": "Hideyuki Yamashita <yamashita.hideyuki@po.ntt-tx.co.jp>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"US-ASCII\"", "Content-Transfer-Encoding": "7bit", "X-Mailer": "Becky! ver. 2.74 [ja]", "X-CCMail7": "CC-Mail-V7.0.2-Client-Relayed", "Message-Id": "<201812181015.wBIAFlYk016726@ccmail04.silk.ntt-tx.co.jp>", "X-TM-AS-MML": "No", "X-CC-Mail-RelayStamp": "CC-Mail-V5.14-Server", "To": "dev@dpdk.org, ogawa.yasufumi@lab.ntt.co.jp", "Subject": "[dpdk-dev] [PATCH] vhost: delete freeing mac_addrs in eth_dev_close", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Hideyuki Yamashita <yamashita.hideyuki@po.ntt-tx.co.jp>\n\nWhen rte_dev_remove is called for vhost, eth_dev_close and\nrte_eth_dev_release_port is called.\nBoth eth_dev_close and rte_eth_dev_release_port calls rte_free\nfor same data area(mac_addrs) and thus causes double free.\nThis patch fixes this by deleting rte_free for mac_addrs.\n\nSigned-off-by: Hideyuki Yamashita <yamashita.hideyuki@po.ntt-tx.co.jp>\n---\n drivers/net/vhost/rte_eth_vhost.c | 1 -\n 1 file changed, 1 deletion(-)", "diff": "diff --git a/drivers/net/vhost/rte_eth_vhost.c b/drivers/net/vhost/rte_eth_vhost.c\nindex 42bdfcbd5..b2cda0483 100644\n--- a/drivers/net/vhost/rte_eth_vhost.c\n+++ b/drivers/net/vhost/rte_eth_vhost.c\n@@ -1000,7 +1000,6 @@ eth_dev_close(struct rte_eth_dev *dev)\n \t\tfor (i = 0; i < dev->data->nb_tx_queues; i++)\n \t\t\trte_free(dev->data->tx_queues[i]);\n \n-\trte_free(dev->data->mac_addrs);\n \tfree(internal->dev_name);\n \tfree(internal->iface_name);\n \trte_free(internal);\n", "prefixes": [] }