Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/49292/?format=api
{ "id": 49292, "url": "http://patchwork.dpdk.org/api/patches/49292/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20181227062233.30781-5-hemant.agrawal@nxp.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20181227062233.30781-5-hemant.agrawal@nxp.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20181227062233.30781-5-hemant.agrawal@nxp.com", "date": "2018-12-27T06:22:57", "name": "[04/20] net/dpaa2: fix bad check for not-null", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "5eb5e6724a44e21728c24afd14ad07147d6c2773", "submitter": { "id": 477, "url": "http://patchwork.dpdk.org/api/people/477/?format=api", "name": "Hemant Agrawal", "email": "hemant.agrawal@nxp.com" }, "delegate": { "id": 319, "url": "http://patchwork.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20181227062233.30781-5-hemant.agrawal@nxp.com/mbox/", "series": [ { "id": 2954, "url": "http://patchwork.dpdk.org/api/series/2954/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=2954", "date": "2018-12-27T06:22:50", "name": "NXP DPAA2 fixes and enhancements", "version": 1, "mbox": "http://patchwork.dpdk.org/series/2954/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/49292/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/49292/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id AE22A4CAB;\n\tThu, 27 Dec 2018 07:23:01 +0100 (CET)", "from EUR01-VE1-obe.outbound.protection.outlook.com\n\t(mail-eopbgr140077.outbound.protection.outlook.com [40.107.14.77])\n\tby dpdk.org (Postfix) with ESMTP id 67BCF4C8E;\n\tThu, 27 Dec 2018 07:22:58 +0100 (CET)", "from VI1PR0401MB2541.eurprd04.prod.outlook.com (10.168.65.19) by\n\tVI1PR0401MB2382.eurprd04.prod.outlook.com (10.169.134.11) with\n\tMicrosoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n\t15.20.1471.20; Thu, 27 Dec 2018 06:22:57 +0000", "from VI1PR0401MB2541.eurprd04.prod.outlook.com\n\t([fe80::555e:164:f8f0:dbb4]) by\n\tVI1PR0401MB2541.eurprd04.prod.outlook.com\n\t([fe80::555e:164:f8f0:dbb4%2]) with mapi id 15.20.1471.019;\n\tThu, 27 Dec 2018 06:22:57 +0000" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1;\n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n\tbh=9tH1Cj2moxYQmathpBY4iIEkUbhdykmvpCfgmba4TwI=;\n\tb=N6FruELJDaBO73AONtEd5hBgg7unIiuTRBYBWktOkJovCl1IMAP3Mf9/0/pDZopLBXgkf0zdzK3/tmvJugjqklIIq6gCItTQLmfhnsGcD5JkcRBWgNehY17lbL2D8Ko+efTYzSW/tYcNLAHjTdraidTZhfFULKkFTHMFY36RLoc=", "From": "Hemant Agrawal <hemant.agrawal@nxp.com>", "To": "\"dev@dpdk.org\" <dev@dpdk.org>", "CC": "\"ferruh.yigit@intel.com\" <ferruh.yigit@intel.com>, Shreyansh Jain\n\t<shreyansh.jain@nxp.com>, \"stable@dpdk.org\" <stable@dpdk.org>", "Thread-Topic": "[PATCH 04/20] net/dpaa2: fix bad check for not-null", "Thread-Index": "AQHUnayb/PWWkdoeG0yoMXAKYHyjBQ==", "Date": "Thu, 27 Dec 2018 06:22:57 +0000", "Message-ID": "<20181227062233.30781-5-hemant.agrawal@nxp.com>", "References": "<20181227062233.30781-1-hemant.agrawal@nxp.com>", "In-Reply-To": "<20181227062233.30781-1-hemant.agrawal@nxp.com>", "Accept-Language": "en-US", "Content-Language": "en-US", "X-MS-Has-Attach": "", "X-MS-TNEF-Correlator": "", "x-originating-ip": "[14.143.30.134]", "x-mailer": "git-send-email 2.17.1", "x-clientproxiedby": "BM1PR01CA0120.INDPRD01.PROD.OUTLOOK.COM\n\t(2603:1096:b00:40::14) To VI1PR0401MB2541.eurprd04.prod.outlook.com\n\t(2603:10a6:800:56::19)", "authentication-results": "spf=none (sender IP is )\n\tsmtp.mailfrom=hemant.agrawal@nxp.com; ", "x-ms-exchange-messagesentrepresentingtype": "1", "x-ms-publictraffictype": "Email", "x-microsoft-exchange-diagnostics": "1; VI1PR0401MB2382;\n\t6:L8vEk5f2UUoQq8XZ2RuKmtVfEC91imoB/RiBH9eJ7M3DiiXY4CY0I//CHc62fmtA1mFRo8sLjtjbjqwnviiSRzqg/1Lt24QCm6+mnBkiO3FhEY9KdOxMsXMCKJgVWu0byJwI5IxiWgu0pUVG3uMdbK04jbkdh0XVLLW7rJ0WhziYAJ8v1YLENYG5dC0lcZtVDNmmp4xquT7ck2NF3UsYE+dhqWyAIdNSM7b86DlKmIYPC9c+noxVfIor9EEikio64xX5CRb1hZ+UPBVYoPHXui8gQrMKz6ssgJeDmWM9ab9YjO8AHWfMXbZF6NFy3H80JPlfEnuvh1MYN/qNY7spmoBieIBB7g6KijxE1imEoeqn6YC3ti3L5lX/3pfjDLzDy79d0A8Pp17+/fugTxGatLsVNFZn8v6B77Z2IWvhptM9EK2Wvh6YYyyo3k1IFiGWbOf2FD6xMfnoE01V1KaJaQ==;\n\t5:x+DhVm1rVTiChZ/SJmryptEEZGo2YDVTM20kd+FFoSQW7sFKUUfFGwFb+s9yyyK7Pit4/RYuodbkZ071q8YB5qQiPaE66ppDfP2dSmU4B3yEcqT09dLs/ki4ZYQcG0o3tOuJqfmWmGc2eZm/qu6GFnOr/44Num9Ey/khFVg8nCk=;\n\t7:fPCb+PWoB7C0P36NOi5aVbE1espI5hyMZvP0WS1G/Gtm8BNnAIoXw5jnQMBT89McmtZjB15lB7rKbf0UwQWCe0tPPMKAZySUr+XC1k1ESZrNojrwMYcw+6B/7dtFbPXdnDDZ2sBIm5ouh4sbmxX7eA==", "x-ms-office365-filtering-correlation-id": "fb78260d-6290-44a4-b39e-08d66bc3bdf7", "x-ms-office365-filtering-ht": "Tenant", "x-microsoft-antispam": "BCL:0; PCL:0;\n\tRULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(7168020)(4627221)(201703031133081)(201702281549075)(8990200)(5600074)(711020)(4618075)(2017052603328)(7153060)(7193020);\n\tSRVR:VI1PR0401MB2382; ", "x-ms-traffictypediagnostic": "VI1PR0401MB2382:", "x-microsoft-antispam-prvs": "<VI1PR0401MB2382ACEFF4E04551321AFE7089B60@VI1PR0401MB2382.eurprd04.prod.outlook.com>", "x-exchange-antispam-report-cfa-test": "BCL:0; PCL:0;\n\tRULEID:(8211001083)(3230021)(908002)(999002)(5005026)(6040522)(2401047)(8121501046)(10201501046)(3002001)(93006095)(93001095)(3231475)(944501520)(52105112)(6055026)(6041310)(20161123560045)(20161123562045)(20161123564045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123558120)(201708071742011)(7699051)(76991095);\n\tSRVR:VI1PR0401MB2382; BCL:0; PCL:0; RULEID:; SRVR:VI1PR0401MB2382; ", "x-forefront-prvs": "0899B47777", "x-forefront-antispam-report": "SFV:NSPM;\n\tSFS:(10009020)(136003)(396003)(366004)(376002)(39860400002)(346002)(199004)(189003)(5660300001)(1076003)(26005)(76176011)(186003)(71200400001)(256004)(25786009)(105586002)(4326008)(6436002)(305945005)(11346002)(106356001)(446003)(44832011)(476003)(7736002)(55236004)(102836004)(78486014)(486006)(386003)(68736007)(52116002)(86362001)(6506007)(2616005)(71190400001)(66066001)(316002)(54906003)(6116002)(3846002)(2906002)(14454004)(36756003)(99286004)(50226002)(8936002)(1730700003)(81156014)(81166006)(8676002)(6512007)(53936002)(478600001)(97736004)(6486002)(6916009)(5640700003)(2351001)(2501003);\n\tDIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR0401MB2382;\n\tH:VI1PR0401MB2541.eurprd04.prod.outlook.com; FPR:; SPF:None; LANG:en; \n\tPTR:InfoNoRecords; A:1; MX:1; ", "received-spf": "None (protection.outlook.com: nxp.com does not designate\n\tpermitted sender hosts)", "x-ms-exchange-senderadcheck": "1", "x-microsoft-antispam-message-info": "05qtwwGxUPZi15b13Qy4BR/hCBsM3tqSXd4VpV+CMayxjFmROsr/7r3jfgy0HV+Vz1uF0unG3dSFlQHAL/dAjJU+uMe8tMA1le2sEwr7epnnfW9pn24BDVuyfbYjUOPKYs/wp6uEMCSDceFzOOo/vgWKCMLlrNwavxtjgRUlE1xVdoWZL07HLfI0YM7M8wyDUU+9QWFtRMbOY6hyX/OLyomB+moZPmTUNLYBSwbs+EPG02IMSXrv+nR/cgdpRjFxw9mILph4y1BNwcdde3q0uCt/m3YVOZOPWrHURcCceCU5bouJIqGtMG4m8KkFh/Hx", "spamdiagnosticoutput": "1:99", "spamdiagnosticmetadata": "NSPM", "Content-Type": "text/plain; charset=\"iso-8859-1\"", "Content-Transfer-Encoding": "quoted-printable", "MIME-Version": "1.0", "X-OriginatorOrg": "nxp.com", "X-MS-Exchange-CrossTenant-Network-Message-Id": "fb78260d-6290-44a4-b39e-08d66bc3bdf7", "X-MS-Exchange-CrossTenant-originalarrivaltime": "27 Dec 2018 06:22:57.3488\n\t(UTC)", "X-MS-Exchange-CrossTenant-fromentityheader": "Hosted", "X-MS-Exchange-CrossTenant-id": "686ea1d3-bc2b-4c6f-a92c-d99c5c301635", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "VI1PR0401MB2382", "Subject": "[dpdk-dev] [PATCH 04/20] net/dpaa2: fix bad check for not-null", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The check !dpaa2->cscn is not correct to check non-null value.\n\nFixes: 5d9a1e4d23fe (\"net/dpaa2: enhance queue memory cleanup\")\nCc: stable@dpdk.org\n\nSigned-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>\n---\n drivers/net/dpaa2/dpaa2_ethdev.c | 3 +--\n 1 file changed, 1 insertion(+), 2 deletions(-)", "diff": "diff --git a/drivers/net/dpaa2/dpaa2_ethdev.c b/drivers/net/dpaa2/dpaa2_ethdev.c\nindex fa71807e6..8d4ea1bca 100644\n--- a/drivers/net/dpaa2/dpaa2_ethdev.c\n+++ b/drivers/net/dpaa2/dpaa2_ethdev.c\n@@ -311,8 +311,7 @@ dpaa2_free_rx_tx_queues(struct rte_eth_dev *dev)\n \t\t/* cleanup tx queue cscn */\n \t\tfor (i = 0; i < priv->nb_tx_queues; i++) {\n \t\t\tdpaa2_q = (struct dpaa2_queue *)priv->tx_vq[i];\n-\t\t\tif (!dpaa2_q->cscn)\n-\t\t\t\trte_free(dpaa2_q->cscn);\n+\t\t\trte_free(dpaa2_q->cscn);\n \t\t}\n \t\t/*free memory for all queues (RX+TX) */\n \t\trte_free(priv->rx_vq[0]);\n", "prefixes": [ "04/20" ] }