Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/49294/?format=api
{ "id": 49294, "url": "http://patchwork.dpdk.org/api/patches/49294/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20181227062233.30781-7-hemant.agrawal@nxp.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20181227062233.30781-7-hemant.agrawal@nxp.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20181227062233.30781-7-hemant.agrawal@nxp.com", "date": "2018-12-27T06:23:00", "name": "[06/20] bus/fslmc: fix parse method for bus devices", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "e1ada6ebe46e805e52ec393375686ce104835431", "submitter": { "id": 477, "url": "http://patchwork.dpdk.org/api/people/477/?format=api", "name": "Hemant Agrawal", "email": "hemant.agrawal@nxp.com" }, "delegate": { "id": 319, "url": "http://patchwork.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20181227062233.30781-7-hemant.agrawal@nxp.com/mbox/", "series": [ { "id": 2954, "url": "http://patchwork.dpdk.org/api/series/2954/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=2954", "date": "2018-12-27T06:22:50", "name": "NXP DPAA2 fixes and enhancements", "version": 1, "mbox": "http://patchwork.dpdk.org/series/2954/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/49294/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/49294/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 1FE5D532C;\n\tThu, 27 Dec 2018 07:23:09 +0100 (CET)", "from EUR01-VE1-obe.outbound.protection.outlook.com\n\t(mail-eopbgr140082.outbound.protection.outlook.com [40.107.14.82])\n\tby dpdk.org (Postfix) with ESMTP id 6EC224C9D;\n\tThu, 27 Dec 2018 07:23:01 +0100 (CET)", "from VI1PR0401MB2541.eurprd04.prod.outlook.com (10.168.65.19) by\n\tVI1PR0401MB2382.eurprd04.prod.outlook.com (10.169.134.11) with\n\tMicrosoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n\t15.20.1471.20; Thu, 27 Dec 2018 06:23:00 +0000", "from VI1PR0401MB2541.eurprd04.prod.outlook.com\n\t([fe80::555e:164:f8f0:dbb4]) by\n\tVI1PR0401MB2541.eurprd04.prod.outlook.com\n\t([fe80::555e:164:f8f0:dbb4%2]) with mapi id 15.20.1471.019;\n\tThu, 27 Dec 2018 06:23:00 +0000" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1;\n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n\tbh=I0bsTyjNVHaT9Ai4Obi5phGJNXVmnnIhnzD7HILujSY=;\n\tb=k5vo4R3/kDXo0u+u/UFzepV1If/yHt68b9ZA36t116Xj5I9idNzs+PDB4f+T/MUyO0K9dmROpK6iwaTzETTtTolLGOejXakQUoFLg0eY2PaZIAG+8ekJykw6DPUGRIEvmjj9P1DFjfTJuZBXAdNFDUYGd4Ztzlc+12khyMn+wmg=", "From": "Hemant Agrawal <hemant.agrawal@nxp.com>", "To": "\"dev@dpdk.org\" <dev@dpdk.org>", "CC": "\"ferruh.yigit@intel.com\" <ferruh.yigit@intel.com>, Shreyansh Jain\n\t<shreyansh.jain@nxp.com>, \"stable@dpdk.org\" <stable@dpdk.org>", "Thread-Topic": "[PATCH 06/20] bus/fslmc: fix parse method for bus devices", "Thread-Index": "AQHUnaydCsxuxzBDukyUp3XV4RzuuA==", "Date": "Thu, 27 Dec 2018 06:23:00 +0000", "Message-ID": "<20181227062233.30781-7-hemant.agrawal@nxp.com>", "References": "<20181227062233.30781-1-hemant.agrawal@nxp.com>", "In-Reply-To": "<20181227062233.30781-1-hemant.agrawal@nxp.com>", "Accept-Language": "en-US", "Content-Language": "en-US", "X-MS-Has-Attach": "", "X-MS-TNEF-Correlator": "", "x-originating-ip": "[14.143.30.134]", "x-mailer": "git-send-email 2.17.1", "x-clientproxiedby": "BM1PR01CA0120.INDPRD01.PROD.OUTLOOK.COM\n\t(2603:1096:b00:40::14) To VI1PR0401MB2541.eurprd04.prod.outlook.com\n\t(2603:10a6:800:56::19)", "authentication-results": "spf=none (sender IP is )\n\tsmtp.mailfrom=hemant.agrawal@nxp.com; ", "x-ms-exchange-messagesentrepresentingtype": "1", "x-ms-publictraffictype": "Email", "x-microsoft-exchange-diagnostics": "1; VI1PR0401MB2382;\n\t6:hSM8N7fwrJRbNvgF2D8wZCWYatmvG/TjishRNsRtOo4bKcuDd3MeHoDWlQPKfsNKqmgU2cOWxTJFBCMVzI9seDTUNy9KQVOrBfaduBca95ophs2xRwfUiI6AtMLeyyeNrigrGxWZiP54DgXo1m85A9mjeatGLkNvh3JUan4evMTuy05bB6N/Vx1BbkB4eftkX5gO9Wl1ovqCiFhlZpElhlI6itlMxMTHNMEvsYBR57vgmzdESL6iDAxAN7YiHW5Dr+SfYKjfSAmbJiwI9ZhhDrpGI4uDp2qe5ellvTTKncEly5YtUhNlH7Y11nkN2PhXGCz0AfpnV5+GJJTf0J/ywzPa8fgwVOXArEmUxm3Zu49PmE42iWGTPFUAhbNAlTQoZ1DjZlQQml0F7lS4KYmaNTTLC9i2tVEvbaO5xGzn72YihXX6ncvSVOfCSgkkQcUwm2BRtu91yPY2anvouHdk1Q==;\n\t5:AZdiYt3MNXGwJvxfauSVGdaxcRyHoRKEiBZ0vfgWGjWr4x5Imd7nQvUL/DoXwgB8aTJ/E5Jyf37CNokshcz+H1UdYtE+zP0PR0MI8OaOtT/OnH1eiLEdIuAVTKr7OWeuTyTnRKehn4D1NLJYBPkOslniu3/5Nul60XtB3g398Mk=;\n\t7:gDkQJSg8ToGguyJ2yiL81pU4dnuZhsTSh4DE7M/xfg2c8s2PqB6SLh4kEDeqvdEzloxByb1x31OmUgriRw7nUeIZ0UQhxJsqPSd1TK9Ww3+1/ifgVBODk0kzodWk07b7X4KVdm8A/YPGLexRGt1Upw==", "x-ms-office365-filtering-correlation-id": "cae1144a-9eba-40ab-4aee-08d66bc3bfd9", "x-ms-office365-filtering-ht": "Tenant", "x-microsoft-antispam": "BCL:0; PCL:0;\n\tRULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(7168020)(4627221)(201703031133081)(201702281549075)(8990200)(5600074)(711020)(4618075)(2017052603328)(7153060)(7193020);\n\tSRVR:VI1PR0401MB2382; ", "x-ms-traffictypediagnostic": "VI1PR0401MB2382:", "x-microsoft-antispam-prvs": "<VI1PR0401MB23824EE019493FE9EC4A5CD089B60@VI1PR0401MB2382.eurprd04.prod.outlook.com>", "x-exchange-antispam-report-cfa-test": "BCL:0; PCL:0;\n\tRULEID:(8211001083)(3230021)(908002)(999002)(5005026)(6040522)(2401047)(8121501046)(10201501046)(3002001)(93006095)(93001095)(3231475)(944501520)(52105112)(6055026)(6041310)(20161123560045)(20161123562045)(20161123564045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123558120)(201708071742011)(7699051)(76991095);\n\tSRVR:VI1PR0401MB2382; BCL:0; PCL:0; RULEID:; SRVR:VI1PR0401MB2382; ", "x-forefront-prvs": "0899B47777", "x-forefront-antispam-report": "SFV:NSPM;\n\tSFS:(10009020)(136003)(396003)(366004)(376002)(39860400002)(346002)(199004)(189003)(5660300001)(1076003)(26005)(76176011)(186003)(71200400001)(256004)(25786009)(105586002)(4326008)(6436002)(305945005)(11346002)(106356001)(446003)(44832011)(476003)(7736002)(55236004)(102836004)(78486014)(486006)(386003)(68736007)(52116002)(86362001)(6506007)(2616005)(71190400001)(66066001)(316002)(54906003)(6116002)(3846002)(2906002)(14454004)(36756003)(99286004)(50226002)(8936002)(1730700003)(81156014)(81166006)(8676002)(6512007)(53936002)(478600001)(97736004)(6486002)(6916009)(5640700003)(2351001)(2501003);\n\tDIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR0401MB2382;\n\tH:VI1PR0401MB2541.eurprd04.prod.outlook.com; FPR:; SPF:None; LANG:en; \n\tPTR:InfoNoRecords; A:1; MX:1; ", "received-spf": "None (protection.outlook.com: nxp.com does not designate\n\tpermitted sender hosts)", "x-ms-exchange-senderadcheck": "1", "x-microsoft-antispam-message-info": "6uC+Nd0yW73j7s52jCxE1WBhPKg7SVtcnDkbiCMBhtrBG3shuLnSkqK8yhpkvzmA0NKwJKlc+W1En8/xvL23kSpTf0ZXIbzqLm+7IDuJn1CA6QNFD6FRrx2ZbRmisMZVY1u5Y0BZOBXIDQ5dcID+KaiN+trqVmtZUtNHEepgNopPdOeEN7b6DqPN1qbEo+zH5gtwXHKw7TO3DR6obL09AzxwY7Mc15azjkRo/VEIrNFStKRGIWeyny6iNeMLbHiM2aRXyhSkj9WsUn+JStnMT6bm4tDUJ7xoIQsqsB8oqIB/UeIhzdKP1IXpztjKwCrd", "spamdiagnosticoutput": "1:99", "spamdiagnosticmetadata": "NSPM", "Content-Type": "text/plain; charset=\"iso-8859-1\"", "Content-Transfer-Encoding": "quoted-printable", "MIME-Version": "1.0", "X-OriginatorOrg": "nxp.com", "X-MS-Exchange-CrossTenant-Network-Message-Id": "cae1144a-9eba-40ab-4aee-08d66bc3bfd9", "X-MS-Exchange-CrossTenant-originalarrivaltime": "27 Dec 2018 06:23:00.3956\n\t(UTC)", "X-MS-Exchange-CrossTenant-fromentityheader": "Hosted", "X-MS-Exchange-CrossTenant-id": "686ea1d3-bc2b-4c6f-a92c-d99c5c301635", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "VI1PR0401MB2382", "Subject": "[dpdk-dev] [PATCH 06/20] bus/fslmc: fix parse method for bus devices", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Shreyansh Jain <shreyansh.jain@nxp.com>\n\nCurrent code expects that bus->parse() would get a string containing\nthe name of the bus. That is incorrect. bus->parse() is expected\nto have strings like:\n dpni.1,key=val\n dpio.2,key=val\n\nwhen user passed:\n -b fslmc:dpni.1,key=val\n\nThis commit fixes this behavior.\n\nFixes: 50245be05d1a (\"bus/fslmc: support device blacklisting\")\nCc: stable@dpdk.org\n\nSigned-off-by: Shreyansh Jain <shreyansh.jain@nxp.com>\n---\n drivers/bus/fslmc/fslmc_bus.c | 33 +++++++++++++++++----------------\n 1 file changed, 17 insertions(+), 16 deletions(-)", "diff": "diff --git a/drivers/bus/fslmc/fslmc_bus.c b/drivers/bus/fslmc/fslmc_bus.c\nindex 89af9385a..565e0148f 100644\n--- a/drivers/bus/fslmc/fslmc_bus.c\n+++ b/drivers/bus/fslmc/fslmc_bus.c\n@@ -1,6 +1,6 @@\n /* SPDX-License-Identifier: BSD-3-Clause\n *\n- * Copyright 2016 NXP\n+ * Copyright 2016,2018 NXP\n *\n */\n \n@@ -227,20 +227,16 @@ static int\n rte_fslmc_parse(const char *name, void *addr)\n {\n \tuint16_t dev_id;\n-\tchar *t_ptr;\n-\tchar *sep = strchr(name, ':');\n+\tchar *t_ptr = NULL, *dname = NULL;\n \n-\tif (strncmp(name, RTE_STR(FSLMC_BUS_NAME),\n-\t\tstrlen(RTE_STR(FSLMC_BUS_NAME)))) {\n-\t\treturn -EINVAL;\n-\t}\n+\t/* 'name' is expected to contain name of device, for example, dpio.1,\n+\t * dpni.2, etc.\n+\t */\n \n-\tif (!sep) {\n-\t\tDPAA2_BUS_ERR(\"Incorrect device name observed\");\n+\tdname = strdup(name);\n+\tif (!dname)\n \t\treturn -EINVAL;\n-\t}\n-\n-\tt_ptr = (char *)(sep + 1);\n+\tt_ptr = dname;\n \n \tif (strncmp(\"dpni\", t_ptr, 4) &&\n \t strncmp(\"dpseci\", t_ptr, 6) &&\n@@ -251,24 +247,29 @@ rte_fslmc_parse(const char *name, void *addr)\n \t strncmp(\"dpmcp\", t_ptr, 5) &&\n \t strncmp(\"dpdmai\", t_ptr, 6)) {\n \t\tDPAA2_BUS_ERR(\"Unknown or unsupported device\");\n-\t\treturn -EINVAL;\n+\t\tgoto err_out;\n \t}\n \n \tt_ptr = strchr(name, '.');\n \tif (!t_ptr) {\n \t\tDPAA2_BUS_ERR(\"Incorrect device string observed (%s)\", t_ptr);\n-\t\treturn -EINVAL;\n+\t\tgoto err_out;\n \t}\n \n \tt_ptr = (char *)(t_ptr + 1);\n \tif (sscanf(t_ptr, \"%hu\", &dev_id) <= 0) {\n \t\tDPAA2_BUS_ERR(\"Incorrect device string observed (%s)\", t_ptr);\n-\t\treturn -EINVAL;\n+\t\tgoto err_out;\n \t}\n+\tfree(dname);\n \n \tif (addr)\n-\t\tstrcpy(addr, (char *)(sep + 1));\n+\t\tstrcpy(addr, name);\n+\n \treturn 0;\n+err_out:\n+\tfree(dname);\n+\treturn -EINVAL;\n }\n \n static int\n", "prefixes": [ "06/20" ] }