Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/49305/?format=api
{ "id": 49305, "url": "http://patchwork.dpdk.org/api/patches/49305/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20181227062233.30781-18-hemant.agrawal@nxp.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20181227062233.30781-18-hemant.agrawal@nxp.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20181227062233.30781-18-hemant.agrawal@nxp.com", "date": "2018-12-27T06:23:17", "name": "[17/20] mempool/dpaa2: support saving context of buffer pool", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "8e718ca8d72732d0580641a4e524a2a1ed9d097e", "submitter": { "id": 477, "url": "http://patchwork.dpdk.org/api/people/477/?format=api", "name": "Hemant Agrawal", "email": "hemant.agrawal@nxp.com" }, "delegate": { "id": 319, "url": "http://patchwork.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20181227062233.30781-18-hemant.agrawal@nxp.com/mbox/", "series": [ { "id": 2954, "url": "http://patchwork.dpdk.org/api/series/2954/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=2954", "date": "2018-12-27T06:22:50", "name": "NXP DPAA2 fixes and enhancements", "version": 1, "mbox": "http://patchwork.dpdk.org/series/2954/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/49305/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/49305/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 13EFA5F2F;\n\tThu, 27 Dec 2018 07:23:31 +0100 (CET)", "from EUR01-VE1-obe.outbound.protection.outlook.com\n\t(mail-eopbgr140048.outbound.protection.outlook.com [40.107.14.48])\n\tby dpdk.org (Postfix) with ESMTP id 618E45B16\n\tfor <dev@dpdk.org>; Thu, 27 Dec 2018 07:23:18 +0100 (CET)", "from VI1PR0401MB2541.eurprd04.prod.outlook.com (10.168.65.19) by\n\tVI1PR0401MB2382.eurprd04.prod.outlook.com (10.169.134.11) with\n\tMicrosoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n\t15.20.1471.20; Thu, 27 Dec 2018 06:23:17 +0000", "from VI1PR0401MB2541.eurprd04.prod.outlook.com\n\t([fe80::555e:164:f8f0:dbb4]) by\n\tVI1PR0401MB2541.eurprd04.prod.outlook.com\n\t([fe80::555e:164:f8f0:dbb4%2]) with mapi id 15.20.1471.019;\n\tThu, 27 Dec 2018 06:23:17 +0000" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1;\n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n\tbh=2aDGaNeeQ7vEGjoaQY/ePNElUBkrBoaoPpq/x/rBWPY=;\n\tb=JAtnGp3etAuQw1LKYG4jm5AA7+CgkQCIHKoY0fI6wpi9wNuqNh7+f6q9tskOPnQSyD70QjLDZWnzrL7QANezmZ5JCAZHSOTEAZ/VuzMrdjAHRtc5KIetJmjnYqcBpYbgoRvqffdoULI008w8XkOQ55TjMfw2DBzvvTqj29R7pD4=", "From": "Hemant Agrawal <hemant.agrawal@nxp.com>", "To": "\"dev@dpdk.org\" <dev@dpdk.org>", "CC": "\"ferruh.yigit@intel.com\" <ferruh.yigit@intel.com>, Shreyansh Jain\n\t<shreyansh.jain@nxp.com>", "Thread-Topic": "[PATCH 17/20] mempool/dpaa2: support saving context of buffer\n\tpool", "Thread-Index": "AQHUnaynDRQunqOOgUOhfrRgtrLVmQ==", "Date": "Thu, 27 Dec 2018 06:23:17 +0000", "Message-ID": "<20181227062233.30781-18-hemant.agrawal@nxp.com>", "References": "<20181227062233.30781-1-hemant.agrawal@nxp.com>", "In-Reply-To": "<20181227062233.30781-1-hemant.agrawal@nxp.com>", "Accept-Language": "en-US", "Content-Language": "en-US", "X-MS-Has-Attach": "", "X-MS-TNEF-Correlator": "", "x-originating-ip": "[14.143.30.134]", "x-mailer": "git-send-email 2.17.1", "x-clientproxiedby": "BM1PR01CA0120.INDPRD01.PROD.OUTLOOK.COM\n\t(2603:1096:b00:40::14) To VI1PR0401MB2541.eurprd04.prod.outlook.com\n\t(2603:10a6:800:56::19)", "authentication-results": "spf=none (sender IP is )\n\tsmtp.mailfrom=hemant.agrawal@nxp.com; ", "x-ms-exchange-messagesentrepresentingtype": "1", "x-ms-publictraffictype": "Email", "x-microsoft-exchange-diagnostics": "1; VI1PR0401MB2382;\n\t6:hbbiXO452s0T/B+iAbV7ahVrL1P9jiT/Yde8oc++CLhvKMlyiNVL/xwfMZfPjmLexdRsIJb1+oeqlbur7lfFWGL4jrxsVaJnDF6WcO3zZ77epT0AmgWgvqRAO4FSxvRg2RNpngyFOQKvrYUHAv9KTWRO84uJufM7BBK/0tasYZCymxw24v3fW4RyfnirCdpTBWkByjaFO7P4MEFB01XdKRHcx8qAxFrBUlFyQZcLD/2gd3fu2H1wJxqpElVETfkLo8W3ZSdpUfxZGoUPci/4HQ/Sjkazy29+VrQWgERzcQm+InWPQu1ne16M5CVsXRuiSq2euJ+YFN6puu/tyciAXby4eaelXRVbXm26Hl5zkulIkyHmuV1emQ7ZbXMhrNgOedb3SfR28IB4qwGbfccuSXWs1s6QHGUb2COIN8yjLCdZRoOAO+GhMOcvudFKLFVfCA0Rf6KNja7QR57go2tsNg==;\n\t5:95PB554PhIhD05PqHjr4WzkxLDdRttStrt1VxJ/EA51VSPIkRHeVnyl1+mMUsM/aTLypI/K+schhrRLNhgSW2yGDPCZII4C9YXwOLjwZMkIRUtNRXfEVK7rcv1F79JfH1RCjFvuRgJcgd4wRxZcRFl+ECxFVaiOnG71UeftLPWU=;\n\t7:gCUjq1j5wKGXuq4uaNzunJS4TwqWnkNPzc0TBmwjdvND1F5l1qGJmGbBrYzjAJu++ZUJ1G8MYX4ptreboDbZPDvqR5NCa30rcDwhpA/MPWyh2LhL372sWBBFwd+5fMGSMsJnv5LbZ0cxuyTkoRdGxg==", "x-ms-office365-filtering-correlation-id": "03b9f5d2-8a38-4ac3-d4ed-08d66bc3c9d9", "x-ms-office365-filtering-ht": "Tenant", "x-microsoft-antispam": "BCL:0; PCL:0;\n\tRULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(7168020)(4627221)(201703031133081)(201702281549075)(8990200)(5600074)(711020)(4618075)(2017052603328)(7153060)(7193020);\n\tSRVR:VI1PR0401MB2382; ", "x-ms-traffictypediagnostic": "VI1PR0401MB2382:", "x-microsoft-antispam-prvs": "<VI1PR0401MB23825C7A79B4B52BC8F2FD2689B60@VI1PR0401MB2382.eurprd04.prod.outlook.com>", "x-exchange-antispam-report-cfa-test": "BCL:0; PCL:0;\n\tRULEID:(8211001083)(3230021)(908002)(999002)(5005026)(6040522)(2401047)(8121501046)(10201501046)(3002001)(93006095)(93001095)(3231475)(944501520)(52105112)(6055026)(6041310)(20161123560045)(20161123562045)(20161123564045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123558120)(201708071742011)(7699051)(76991095);\n\tSRVR:VI1PR0401MB2382; BCL:0; PCL:0; RULEID:; SRVR:VI1PR0401MB2382; ", "x-forefront-prvs": "0899B47777", "x-forefront-antispam-report": "SFV:NSPM;\n\tSFS:(10009020)(136003)(396003)(366004)(376002)(39860400002)(346002)(199004)(189003)(5660300001)(1076003)(26005)(76176011)(186003)(71200400001)(256004)(25786009)(105586002)(4326008)(6436002)(305945005)(11346002)(106356001)(14444005)(446003)(44832011)(476003)(7736002)(55236004)(102836004)(78486014)(486006)(386003)(68736007)(52116002)(86362001)(6506007)(2616005)(71190400001)(66066001)(316002)(54906003)(6116002)(3846002)(2906002)(14454004)(36756003)(99286004)(50226002)(8936002)(1730700003)(81156014)(81166006)(8676002)(6512007)(53936002)(478600001)(97736004)(6486002)(6916009)(5640700003)(2351001)(2501003);\n\tDIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR0401MB2382;\n\tH:VI1PR0401MB2541.eurprd04.prod.outlook.com; FPR:; SPF:None; LANG:en; \n\tPTR:InfoNoRecords; A:1; MX:1; ", "received-spf": "None (protection.outlook.com: nxp.com does not designate\n\tpermitted sender hosts)", "x-ms-exchange-senderadcheck": "1", "x-microsoft-antispam-message-info": "DFpYOPzKDw3IHuNbbJ+Edw/2c97SLSmZnhDS8N6WQE7cWBsuaRcvNrUEnyQIlBeZOA00XYpey2ihGfJU4VT68PeyQHR2gCbqGG66+maP4na3GIztLSD221sezAXcSgPlTTvtuxrLNqMBbDjeWufgyCJEhzDpPyFOsySpG1yzlaecqL46673m1ZU4K2zKxs6gGrH+rPeRFNNrQ3ThRpQv5YgUqL5gwImV4mtxV6TerEgN7wkxV/sTOi4/l0bFj8Tu6QA2siTvl9D63+yypHN5kVIgyxlZ1iJZzxypsjj9l1lVm0Yzxz7qBITsYEzeGXBs", "spamdiagnosticoutput": "1:99", "spamdiagnosticmetadata": "NSPM", "Content-Type": "text/plain; charset=\"iso-8859-1\"", "Content-Transfer-Encoding": "quoted-printable", "MIME-Version": "1.0", "X-OriginatorOrg": "nxp.com", "X-MS-Exchange-CrossTenant-Network-Message-Id": "03b9f5d2-8a38-4ac3-d4ed-08d66bc3c9d9", "X-MS-Exchange-CrossTenant-originalarrivaltime": "27 Dec 2018 06:23:17.2388\n\t(UTC)", "X-MS-Exchange-CrossTenant-fromentityheader": "Hosted", "X-MS-Exchange-CrossTenant-id": "686ea1d3-bc2b-4c6f-a92c-d99c5c301635", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "VI1PR0401MB2382", "Subject": "[dpdk-dev] [PATCH 17/20] mempool/dpaa2: support saving context of\n\tbuffer pool", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Shreyansh Jain <shreyansh.jain@nxp.com>\n\nInitial design was to have the buffer pool per process where a\nglobal static array stores the bpids. But, in case of secondary\nprocesses, this would not allow the I/O threads to translate the\nbpid in Rx'd packets.\n\nThis patch moves the array to a global area (rte_malloc) and in\ncase of Rx thread not containing a valid reference to the array,\nreference is build using the handle avaialble in the dpaa2_queue.\n\nSigned-off-by: Shreyansh Jain <shreyansh.jain@nxp.com>\n---\n drivers/bus/fslmc/portal/dpaa2_hw_pvt.h | 1 +\n drivers/mempool/dpaa2/dpaa2_hw_mempool.c | 12 +++++++++++-\n drivers/mempool/dpaa2/dpaa2_hw_mempool.h | 2 +-\n drivers/net/dpaa2/dpaa2_ethdev.c | 1 +\n drivers/net/dpaa2/dpaa2_rxtx.c | 5 +++++\n 5 files changed, 19 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/bus/fslmc/portal/dpaa2_hw_pvt.h b/drivers/bus/fslmc/portal/dpaa2_hw_pvt.h\nindex efbeebef9..20c606dbe 100644\n--- a/drivers/bus/fslmc/portal/dpaa2_hw_pvt.h\n+++ b/drivers/bus/fslmc/portal/dpaa2_hw_pvt.h\n@@ -141,6 +141,7 @@ struct dpaa2_queue {\n \t};\n \tstruct rte_event ev;\n \tdpaa2_queue_cb_dqrr_t *cb;\n+\tstruct dpaa2_bp_info *bp_array;\n };\n \n struct swp_active_dqs {\ndiff --git a/drivers/mempool/dpaa2/dpaa2_hw_mempool.c b/drivers/mempool/dpaa2/dpaa2_hw_mempool.c\nindex 790cded80..335eae40e 100644\n--- a/drivers/mempool/dpaa2/dpaa2_hw_mempool.c\n+++ b/drivers/mempool/dpaa2/dpaa2_hw_mempool.c\n@@ -32,7 +32,7 @@\n \n #include <dpaax_iova_table.h>\n \n-struct dpaa2_bp_info rte_dpaa2_bpid_info[MAX_BPID];\n+struct dpaa2_bp_info *rte_dpaa2_bpid_info;\n static struct dpaa2_bp_list *h_bp_list;\n \n /* Dynamic logging identified for mempool */\n@@ -50,6 +50,16 @@ rte_hw_mbuf_create_pool(struct rte_mempool *mp)\n \n \tavail_dpbp = dpaa2_alloc_dpbp_dev();\n \n+\tif (rte_dpaa2_bpid_info == NULL) {\n+\t\trte_dpaa2_bpid_info = (struct dpaa2_bp_info *)rte_malloc(NULL,\n+\t\t\t\t sizeof(struct dpaa2_bp_info) * MAX_BPID,\n+\t\t\t\t RTE_CACHE_LINE_SIZE);\n+\t\tif (rte_dpaa2_bpid_info == NULL)\n+\t\t\treturn -ENOMEM;\n+\t\tmemset(rte_dpaa2_bpid_info, 0,\n+\t\t sizeof(struct dpaa2_bp_info) * MAX_BPID);\n+\t}\n+\n \tif (!avail_dpbp) {\n \t\tDPAA2_MEMPOOL_ERR(\"DPAA2 pool not available!\");\n \t\treturn -ENOENT;\ndiff --git a/drivers/mempool/dpaa2/dpaa2_hw_mempool.h b/drivers/mempool/dpaa2/dpaa2_hw_mempool.h\nindex 4d3468746..93694616e 100644\n--- a/drivers/mempool/dpaa2/dpaa2_hw_mempool.h\n+++ b/drivers/mempool/dpaa2/dpaa2_hw_mempool.h\n@@ -59,7 +59,7 @@ struct dpaa2_bp_info {\n #define mempool_to_bpinfo(mp) ((struct dpaa2_bp_info *)(mp)->pool_data)\n #define mempool_to_bpid(mp) ((mempool_to_bpinfo(mp))->bpid)\n \n-extern struct dpaa2_bp_info rte_dpaa2_bpid_info[MAX_BPID];\n+extern struct dpaa2_bp_info *rte_dpaa2_bpid_info;\n \n int rte_dpaa2_mbuf_alloc_bulk(struct rte_mempool *pool,\n \t\t void **obj_table, unsigned int count);\ndiff --git a/drivers/net/dpaa2/dpaa2_ethdev.c b/drivers/net/dpaa2/dpaa2_ethdev.c\nindex 861fbcd90..3a20158da 100644\n--- a/drivers/net/dpaa2/dpaa2_ethdev.c\n+++ b/drivers/net/dpaa2/dpaa2_ethdev.c\n@@ -485,6 +485,7 @@ dpaa2_dev_rx_queue_setup(struct rte_eth_dev *dev,\n \t}\n \tdpaa2_q = (struct dpaa2_queue *)priv->rx_vq[rx_queue_id];\n \tdpaa2_q->mb_pool = mb_pool; /**< mbuf pool to populate RX ring. */\n+\tdpaa2_q->bp_array = rte_dpaa2_bpid_info;\n \n \t/*Get the flow id from given VQ id*/\n \tflow_id = rx_queue_id % priv->nb_rx_queues;\ndiff --git a/drivers/net/dpaa2/dpaa2_rxtx.c b/drivers/net/dpaa2/dpaa2_rxtx.c\nindex 816ea00fd..6e2e8abd7 100644\n--- a/drivers/net/dpaa2/dpaa2_rxtx.c\n+++ b/drivers/net/dpaa2/dpaa2_rxtx.c\n@@ -518,6 +518,11 @@ dpaa2_dev_prefetch_rx(void *queue, struct rte_mbuf **bufs, uint16_t nb_pkts)\n \t\t\treturn 0;\n \t\t}\n \t}\n+\n+\tif (unlikely(!rte_dpaa2_bpid_info &&\n+\t\t rte_eal_process_type() == RTE_PROC_SECONDARY))\n+\t\trte_dpaa2_bpid_info = dpaa2_q->bp_array;\n+\n \tswp = DPAA2_PER_LCORE_ETHRX_PORTAL;\n \tpull_size = (nb_pkts > dpaa2_dqrr_size) ? dpaa2_dqrr_size : nb_pkts;\n \tif (unlikely(!q_storage->active_dqs)) {\n", "prefixes": [ "17/20" ] }