Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/50175/?format=api
{ "id": 50175, "url": "http://patchwork.dpdk.org/api/patches/50175/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/1549541873-17403-15-git-send-email-arybchenko@solarflare.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1549541873-17403-15-git-send-email-arybchenko@solarflare.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1549541873-17403-15-git-send-email-arybchenko@solarflare.com", "date": "2019-02-07T12:17:37", "name": "[14/30] net/sfc: move datapath TxQ handle to shared TxQ info", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "43653806240265b24972269b6b31820aa28b277e", "submitter": { "id": 607, "url": "http://patchwork.dpdk.org/api/people/607/?format=api", "name": "Andrew Rybchenko", "email": "arybchenko@solarflare.com" }, "delegate": { "id": 319, "url": "http://patchwork.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/1549541873-17403-15-git-send-email-arybchenko@solarflare.com/mbox/", "series": [ { "id": 3407, "url": "http://patchwork.dpdk.org/api/series/3407/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=3407", "date": "2019-02-07T12:17:25", "name": "net/sfc: improve multi-process support", "version": 1, "mbox": "http://patchwork.dpdk.org/series/3407/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/50175/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/50175/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id ACDDD1B506;\n\tThu, 7 Feb 2019 13:18:33 +0100 (CET)", "from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com\n\t[148.163.129.52]) by dpdk.org (Postfix) with ESMTP id BC8961B4AF\n\tfor <dev@dpdk.org>; Thu, 7 Feb 2019 13:18:15 +0100 (CET)", "from webmail.solarflare.com (webmail.solarflare.com\n\t[12.187.104.26])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby mx1-us3.ppe-hosted.com (Proofpoint Essentials ESMTP Server) with\n\tESMTPS id\n\tDE37A600067 for <dev@dpdk.org>; Thu, 7 Feb 2019 12:18:14 +0000 (UTC)", "from ocex03.SolarFlarecom.com (10.20.40.36) by\n\tocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server\n\t(TLS) id 15.0.1395.4; Thu, 7 Feb 2019 04:18:10 -0800", "from opal.uk.solarflarecom.com (10.17.10.1) by\n\tocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server\n\t(TLS) id\n\t15.0.1395.4 via Frontend Transport; Thu, 7 Feb 2019 04:18:10 -0800", "from ukv-loginhost.uk.solarflarecom.com\n\t(ukv-loginhost.uk.solarflarecom.com [10.17.10.39])\n\tby opal.uk.solarflarecom.com (8.13.8/8.13.8) with ESMTP id\n\tx17CI8DN013254 for <dev@dpdk.org>; Thu, 7 Feb 2019 12:18:08 GMT", "from ukv-loginhost.uk.solarflarecom.com (localhost [127.0.0.1])\n\tby ukv-loginhost.uk.solarflarecom.com (Postfix) with ESMTP id\n\tC10FA1613EB\n\tfor <dev@dpdk.org>; Thu, 7 Feb 2019 12:18:08 +0000 (GMT)" ], "X-Virus-Scanned": "Proofpoint Essentials engine", "From": "Andrew Rybchenko <arybchenko@solarflare.com>", "To": "<dev@dpdk.org>", "Date": "Thu, 7 Feb 2019 12:17:37 +0000", "Message-ID": "<1549541873-17403-15-git-send-email-arybchenko@solarflare.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1549541873-17403-1-git-send-email-arybchenko@solarflare.com>", "References": "<1549541873-17403-1-git-send-email-arybchenko@solarflare.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-TM-AS-Product-Ver": "SMEX-12.5.0.1300-8.5.1010-24412.006", "X-TM-AS-Result": "No-3.225500-4.000000-10", "X-TMASE-MatchedRID": "h1YlLWfQ7n4ccv8Iwgzq2gPZZctd3P4B/qxRV3rLqo3eQHDLQMNFIw4W\n\tI34Fe9tzIBOyfIQG7lIyy1N8n/3eDGAvsLJmtsvTzfqlpbtmcWh9LQinZ4QefPcjNeVeWlqY+gt\n\tHj7OwNO3DBRxZClZqwR6SK66/9c8eONw4z/gbKYJQdpJuKAVCSjl11XV393EV2UEzoo87bqVgun\n\tAAv9r7L3+B6ElP9OOAFEVS5Eh4mLaJyoXRieO2+wAD0FqlZdom0b4rJ92tmtF/d7a9VsfzMGYfz\n\tNl+uie3wL6SxPpr1/I=", "X-TM-AS-User-Approved-Sender": "No", "X-TM-AS-User-Blocked-Sender": "No", "X-TMASE-Result": "10--3.225500-4.000000", "X-TMASE-Version": "SMEX-12.5.0.1300-8.5.1010-24412.006", "X-MDID": "1549541895-FK5K4CMSO1Pk", "Subject": "[dpdk-dev] [PATCH 14/30] net/sfc: move datapath TxQ handle to\n\tshared TxQ info", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "If datapath supports multi-process, it should be possible to get\nits TxQ structure by the queue index.\n\nSigned-off-by: Andrew Rybchenko <arybchenko@solarflare.com>\n---\n drivers/net/sfc/sfc_ethdev.c | 2 +-\n drivers/net/sfc/sfc_tx.c | 14 +++++++-------\n drivers/net/sfc/sfc_tx.h | 2 +-\n 3 files changed, 9 insertions(+), 9 deletions(-)", "diff": "diff --git a/drivers/net/sfc/sfc_ethdev.c b/drivers/net/sfc/sfc_ethdev.c\nindex 5bc73d512..80a1d7a3d 100644\n--- a/drivers/net/sfc/sfc_ethdev.c\n+++ b/drivers/net/sfc/sfc_ethdev.c\n@@ -468,7 +468,7 @@ sfc_tx_queue_setup(struct rte_eth_dev *dev, uint16_t tx_queue_id,\n \tif (rc != 0)\n \t\tgoto fail_tx_qinit;\n \n-\tdev->data->tx_queues[tx_queue_id] = sa->txq_info[tx_queue_id].txq->dp;\n+\tdev->data->tx_queues[tx_queue_id] = sa->txq_info[tx_queue_id].dp;\n \n \tsfc_adapter_unlock(sa);\n \treturn 0;\ndiff --git a/drivers/net/sfc/sfc_tx.c b/drivers/net/sfc/sfc_tx.c\nindex f4fbffe0a..1ee4e78a1 100644\n--- a/drivers/net/sfc/sfc_tx.c\n+++ b/drivers/net/sfc/sfc_tx.c\n@@ -195,11 +195,11 @@ sfc_tx_qinit(struct sfc_adapter *sa, unsigned int sw_index,\n \n \trc = sa->priv.dp_tx->qcreate(sa->eth_dev->data->port_id, sw_index,\n \t\t\t\t &RTE_ETH_DEV_TO_PCI(sa->eth_dev)->addr,\n-\t\t\t\t socket_id, &info, &txq->dp);\n+\t\t\t\t socket_id, &info, &txq_info->dp);\n \tif (rc != 0)\n \t\tgoto fail_dp_tx_qinit;\n \n-\tevq->dp_txq = txq->dp;\n+\tevq->dp_txq = txq_info->dp;\n \n \ttxq_info->state = SFC_TXQ_INITIALIZED;\n \n@@ -243,8 +243,8 @@ sfc_tx_qfini(struct sfc_adapter *sa, unsigned int sw_index)\n \tSFC_ASSERT(txq != NULL);\n \tSFC_ASSERT(txq_info->state == SFC_TXQ_INITIALIZED);\n \n-\tsa->priv.dp_tx->qdestroy(txq->dp);\n-\ttxq->dp = NULL;\n+\tsa->priv.dp_tx->qdestroy(txq_info->dp);\n+\ttxq_info->dp = NULL;\n \n \ttxq_info->txq = NULL;\n \ttxq_info->entries = 0;\n@@ -466,7 +466,7 @@ sfc_tx_qstart(struct sfc_adapter *sa, unsigned int sw_index)\n \n \ttxq_info->state |= SFC_TXQ_STARTED;\n \n-\trc = sa->priv.dp_tx->qstart(txq->dp, evq->read_ptr, desc_index);\n+\trc = sa->priv.dp_tx->qstart(txq_info->dp, evq->read_ptr, desc_index);\n \tif (rc != 0)\n \t\tgoto fail_dp_qstart;\n \n@@ -511,7 +511,7 @@ sfc_tx_qstop(struct sfc_adapter *sa, unsigned int sw_index)\n \n \tSFC_ASSERT(txq_info->state & SFC_TXQ_STARTED);\n \n-\tsa->priv.dp_tx->qstop(txq->dp, &txq->evq->read_ptr);\n+\tsa->priv.dp_tx->qstop(txq_info->dp, &txq->evq->read_ptr);\n \n \t/*\n \t * Retry TX queue flushing in case of flush failed or\n@@ -548,7 +548,7 @@ sfc_tx_qstop(struct sfc_adapter *sa, unsigned int sw_index)\n \t\t\tsfc_notice(sa, \"TxQ %u flushed\", sw_index);\n \t}\n \n-\tsa->priv.dp_tx->qreap(txq->dp);\n+\tsa->priv.dp_tx->qreap(txq_info->dp);\n \n \ttxq_info->state = SFC_TXQ_INITIALIZED;\n \ndiff --git a/drivers/net/sfc/sfc_tx.h b/drivers/net/sfc/sfc_tx.h\nindex c3edd3a58..e5ea6df75 100644\n--- a/drivers/net/sfc/sfc_tx.h\n+++ b/drivers/net/sfc/sfc_tx.h\n@@ -54,7 +54,6 @@ struct sfc_txq {\n \tunsigned int\t\t\thw_index;\n \tstruct sfc_evq\t\t\t*evq;\n \tefsys_mem_t\t\t\tmem;\n-\tstruct sfc_dp_txq\t\t*dp;\n \tefx_txq_t\t\t\t*common;\n };\n \n@@ -109,6 +108,7 @@ struct sfc_txq_info {\n \tunsigned int\t\tstate;\n \tunsigned int\t\tentries;\n \tstruct sfc_txq\t\t*txq;\n+\tstruct sfc_dp_txq\t*dp;\n \tboolean_t\t\tdeferred_start;\n \tboolean_t\t\tdeferred_started;\n \tunsigned int\t\tfree_thresh;\n", "prefixes": [ "14/30" ] }