Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/50182/?format=api
{ "id": 50182, "url": "http://patchwork.dpdk.org/api/patches/50182/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/1549541873-17403-16-git-send-email-arybchenko@solarflare.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1549541873-17403-16-git-send-email-arybchenko@solarflare.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1549541873-17403-16-git-send-email-arybchenko@solarflare.com", "date": "2019-02-07T12:17:38", "name": "[15/30] net/sfc: support Tx descriptor status in secondary process", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "93021562ab09fad2e1d517fc5c5b3749a27b71ea", "submitter": { "id": 607, "url": "http://patchwork.dpdk.org/api/people/607/?format=api", "name": "Andrew Rybchenko", "email": "arybchenko@solarflare.com" }, "delegate": { "id": 319, "url": "http://patchwork.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/1549541873-17403-16-git-send-email-arybchenko@solarflare.com/mbox/", "series": [ { "id": 3407, "url": "http://patchwork.dpdk.org/api/series/3407/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=3407", "date": "2019-02-07T12:17:25", "name": "net/sfc: improve multi-process support", "version": 1, "mbox": "http://patchwork.dpdk.org/series/3407/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/50182/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/50182/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 1D9101B540;\n\tThu, 7 Feb 2019 13:18:41 +0100 (CET)", "from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com\n\t[148.163.129.52]) by dpdk.org (Postfix) with ESMTP id E66511B4BD\n\tfor <dev@dpdk.org>; Thu, 7 Feb 2019 13:18:16 +0100 (CET)", "from webmail.solarflare.com (webmail.solarflare.com\n\t[12.187.104.26])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby mx1-us3.ppe-hosted.com (Proofpoint Essentials ESMTP Server) with\n\tESMTPS id\n\t15EB4600053 for <dev@dpdk.org>; Thu, 7 Feb 2019 12:18:15 +0000 (UTC)", "from ocex03.SolarFlarecom.com (10.20.40.36) by\n\tocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server\n\t(TLS) id 15.0.1395.4; Thu, 7 Feb 2019 04:18:10 -0800", "from opal.uk.solarflarecom.com (10.17.10.1) by\n\tocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server\n\t(TLS) id\n\t15.0.1395.4 via Frontend Transport; Thu, 7 Feb 2019 04:18:10 -0800", "from ukv-loginhost.uk.solarflarecom.com\n\t(ukv-loginhost.uk.solarflarecom.com [10.17.10.39])\n\tby opal.uk.solarflarecom.com (8.13.8/8.13.8) with ESMTP id\n\tx17CI8rF013258 for <dev@dpdk.org>; Thu, 7 Feb 2019 12:18:08 GMT", "from ukv-loginhost.uk.solarflarecom.com (localhost [127.0.0.1])\n\tby ukv-loginhost.uk.solarflarecom.com (Postfix) with ESMTP id\n\tCE9821613E4\n\tfor <dev@dpdk.org>; Thu, 7 Feb 2019 12:18:08 +0000 (GMT)" ], "X-Virus-Scanned": "Proofpoint Essentials engine", "From": "Andrew Rybchenko <arybchenko@solarflare.com>", "To": "<dev@dpdk.org>", "Date": "Thu, 7 Feb 2019 12:17:38 +0000", "Message-ID": "<1549541873-17403-16-git-send-email-arybchenko@solarflare.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1549541873-17403-1-git-send-email-arybchenko@solarflare.com>", "References": "<1549541873-17403-1-git-send-email-arybchenko@solarflare.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-TM-AS-Product-Ver": "SMEX-12.5.0.1300-8.5.1010-24412.006", "X-TM-AS-Result": "No-5.194900-4.000000-10", "X-TMASE-MatchedRID": "TCPSmmY0AVPMHUInqqZ02h+WEMjoO9WWTJDl9FKHbrkaK6XhXABo9yH3\n\tfZSwSQ1serb3e1hTuhFzZI042SBkozW+K/PcvqBrsTcWkxuDrdKVKmGUZ/WnkQqiCYa6w8tvWTF\n\tH84r4cDQEvqH635UJYlgVldL/B76CHxPMjOKY7A8LbigRnpKlKWxlRJiH4397u4y55aOoCkxkvt\n\txnu2htzA+6zRbgLa/kIooLu5Vi3hvMvnwwvXCXZw==", "X-TM-AS-User-Approved-Sender": "No", "X-TM-AS-User-Blocked-Sender": "No", "X-TMASE-Result": "10--5.194900-4.000000", "X-TMASE-Version": "SMEX-12.5.0.1300-8.5.1010-24412.006", "X-MDID": "1549541895-fApsC92lcLzo", "Subject": "[dpdk-dev] [PATCH 15/30] net/sfc: support Tx descriptor status in\n\tsecondary process", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "If Tx datapath supports multi-process, secondary process should be\nable to use Tx descriptor status API.\n\nSigned-off-by: Andrew Rybchenko <arybchenko@solarflare.com>\n---\n doc/guides/rel_notes/release_19_05.rst | 1 +\n drivers/net/sfc/sfc_dp_tx.h | 3 +++\n drivers/net/sfc/sfc_ethdev.c | 11 +++++++++--\n drivers/net/sfc/sfc_tx.c | 15 +++++++++++++++\n 4 files changed, 28 insertions(+), 2 deletions(-)", "diff": "diff --git a/doc/guides/rel_notes/release_19_05.rst b/doc/guides/rel_notes/release_19_05.rst\nindex 93f28926a..6d65c8eae 100644\n--- a/doc/guides/rel_notes/release_19_05.rst\n+++ b/doc/guides/rel_notes/release_19_05.rst\n@@ -60,6 +60,7 @@ New Features\n \n * Added support for Rx descriptor status and related API in a secondary\n process.\n+ * Added support for Tx descriptor status API in a secondary process.\n \n \n Removed Items\ndiff --git a/drivers/net/sfc/sfc_dp_tx.h b/drivers/net/sfc/sfc_dp_tx.h\nindex c246871cd..fd492f21f 100644\n--- a/drivers/net/sfc/sfc_dp_tx.h\n+++ b/drivers/net/sfc/sfc_dp_tx.h\n@@ -182,6 +182,9 @@ sfc_dp_find_tx_by_caps(struct sfc_dp_list *head, unsigned int avail_caps)\n \treturn (p == NULL) ? NULL : container_of(p, struct sfc_dp_tx, dp);\n }\n \n+/** Get Tx datapath ops by the datapath TxQ handle */\n+const struct sfc_dp_tx *sfc_dp_tx_by_dp_txq(const struct sfc_dp_txq *dp_txq);\n+\n extern struct sfc_dp_tx sfc_efx_tx;\n extern struct sfc_dp_tx sfc_ef10_tx;\n extern struct sfc_dp_tx sfc_ef10_simple_tx;\ndiff --git a/drivers/net/sfc/sfc_ethdev.c b/drivers/net/sfc/sfc_ethdev.c\nindex 80a1d7a3d..c6e1e87ce 100644\n--- a/drivers/net/sfc/sfc_ethdev.c\n+++ b/drivers/net/sfc/sfc_ethdev.c\n@@ -1167,13 +1167,19 @@ sfc_rx_descriptor_status(void *queue, uint16_t offset)\n \treturn dp_rx->qdesc_status(dp_rxq, offset);\n }\n \n+/*\n+ * The function is used by the secondary process as well. It must not\n+ * use any process-local pointers from the adapter data.\n+ */\n static int\n sfc_tx_descriptor_status(void *queue, uint16_t offset)\n {\n \tstruct sfc_dp_txq *dp_txq = queue;\n-\tstruct sfc_txq *txq = sfc_txq_by_dp_txq(dp_txq);\n+\tconst struct sfc_dp_tx *dp_tx;\n+\n+\tdp_tx = sfc_dp_tx_by_dp_txq(dp_txq);\n \n-\treturn txq->evq->sa->priv.dp_tx->qdesc_status(dp_txq, offset);\n+\treturn dp_tx->qdesc_status(dp_txq, offset);\n }\n \n static int\n@@ -1896,6 +1902,7 @@ static const struct eth_dev_ops sfc_eth_dev_secondary_ops = {\n \t.rx_queue_count\t\t\t= sfc_rx_queue_count,\n \t.rx_descriptor_done\t\t= sfc_rx_descriptor_done,\n \t.rx_descriptor_status\t\t= sfc_rx_descriptor_status,\n+\t.tx_descriptor_status\t\t= sfc_tx_descriptor_status,\n \t.rxq_info_get\t\t\t= sfc_rx_queue_info_get,\n \t.txq_info_get\t\t\t= sfc_tx_queue_info_get,\n };\ndiff --git a/drivers/net/sfc/sfc_tx.c b/drivers/net/sfc/sfc_tx.c\nindex 1ee4e78a1..4357dbfd8 100644\n--- a/drivers/net/sfc/sfc_tx.c\n+++ b/drivers/net/sfc/sfc_tx.c\n@@ -854,6 +854,21 @@ sfc_efx_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts, uint16_t nb_pkts)\n \treturn pkts_sent;\n }\n \n+const struct sfc_dp_tx *\n+sfc_dp_tx_by_dp_txq(const struct sfc_dp_txq *dp_txq)\n+{\n+\tconst struct sfc_dp_queue *dpq = &dp_txq->dpq;\n+\tstruct rte_eth_dev *eth_dev;\n+\tstruct sfc_adapter_priv *sap;\n+\n+\tSFC_ASSERT(rte_eth_dev_is_valid_port(dpq->port_id));\n+\teth_dev = &rte_eth_devices[dpq->port_id];\n+\n+\tsap = sfc_adapter_priv_by_eth_dev(eth_dev);\n+\n+\treturn sap->dp_tx;\n+}\n+\n struct sfc_txq_info *\n sfc_txq_info_by_dp_txq(const struct sfc_dp_txq *dp_txq)\n {\n", "prefixes": [ "15/30" ] }