Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/50191/?format=api
{ "id": 50191, "url": "http://patchwork.dpdk.org/api/patches/50191/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/1549541873-17403-29-git-send-email-arybchenko@solarflare.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1549541873-17403-29-git-send-email-arybchenko@solarflare.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1549541873-17403-29-git-send-email-arybchenko@solarflare.com", "date": "2019-02-07T12:17:51", "name": "[28/30] net/sfc: remove adapter locks from secondary process ops", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "b430aa6bc7b2cce8ca5f8f282adb41b4e66a27aa", "submitter": { "id": 607, "url": "http://patchwork.dpdk.org/api/people/607/?format=api", "name": "Andrew Rybchenko", "email": "arybchenko@solarflare.com" }, "delegate": { "id": 319, "url": "http://patchwork.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/1549541873-17403-29-git-send-email-arybchenko@solarflare.com/mbox/", "series": [ { "id": 3407, "url": "http://patchwork.dpdk.org/api/series/3407/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=3407", "date": "2019-02-07T12:17:25", "name": "net/sfc: improve multi-process support", "version": 1, "mbox": "http://patchwork.dpdk.org/series/3407/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/50191/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/50191/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 9959E1B54F;\n\tThu, 7 Feb 2019 13:18:49 +0100 (CET)", "from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com\n\t[148.163.129.52]) by dpdk.org (Postfix) with ESMTP id 765A41B4CC\n\tfor <dev@dpdk.org>; Thu, 7 Feb 2019 13:18:19 +0100 (CET)", "from webmail.solarflare.com (webmail.solarflare.com\n\t[12.187.104.26])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby mx1-us3.ppe-hosted.com (Proofpoint Essentials ESMTP Server) with\n\tESMTPS id\n\t4FCE2600053 for <dev@dpdk.org>; Thu, 7 Feb 2019 12:18:18 +0000 (UTC)", "from ocex03.SolarFlarecom.com (10.20.40.36) by\n\tocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server\n\t(TLS) id 15.0.1395.4; Thu, 7 Feb 2019 04:18:11 -0800", "from opal.uk.solarflarecom.com (10.17.10.1) by\n\tocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server\n\t(TLS) id\n\t15.0.1395.4 via Frontend Transport; Thu, 7 Feb 2019 04:18:10 -0800", "from ukv-loginhost.uk.solarflarecom.com\n\t(ukv-loginhost.uk.solarflarecom.com [10.17.10.39])\n\tby opal.uk.solarflarecom.com (8.13.8/8.13.8) with ESMTP id\n\tx17CI9Aa013317 for <dev@dpdk.org>; Thu, 7 Feb 2019 12:18:09 GMT", "from ukv-loginhost.uk.solarflarecom.com (localhost [127.0.0.1])\n\tby ukv-loginhost.uk.solarflarecom.com (Postfix) with ESMTP id\n\t8D9111613E4\n\tfor <dev@dpdk.org>; Thu, 7 Feb 2019 12:18:09 +0000 (GMT)" ], "X-Virus-Scanned": "Proofpoint Essentials engine", "From": "Andrew Rybchenko <arybchenko@solarflare.com>", "To": "<dev@dpdk.org>", "Date": "Thu, 7 Feb 2019 12:17:51 +0000", "Message-ID": "<1549541873-17403-29-git-send-email-arybchenko@solarflare.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1549541873-17403-1-git-send-email-arybchenko@solarflare.com>", "References": "<1549541873-17403-1-git-send-email-arybchenko@solarflare.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-TM-AS-Product-Ver": "SMEX-12.5.0.1300-8.5.1010-24412.006", "X-TM-AS-Result": "No-4.329300-4.000000-10", "X-TMASE-MatchedRID": "jOVNzH0EbrFJI0Xw8qTX2wPZZctd3P4BSoCG4sefl8TDTXM3VzSaIoO3\n\tHyUMPRbHk6tRP5GDNQGYxn32XFJiM9E6qTfT4wP/2KB5OR2PHeHUqhJbkmLVe0X2ZslDQzOjhdO\n\tzGiAk/+wwbOiPxFco0ESTkIUbH6rsnuh7s4XRTZY49w4rSKMAfV1eWD1gEH06JLfQYoCQHFYHDd\n\tv9igj6FeLzNWBegCW2wgn7iDBesS0nRE+fI6etkibU5Wt5382wU9ix7ZuS7j7FXO6dwKpaO4FUM\n\tYXxD85/fSyvHNsvakURRFzifX871svQ/YByG8D1vkjLk9rOmsY29rfubKVwHaoWu33FSCn66r5P\n\tQhx29DUG0+3lZBNmQtq4RBohbjorp8vX8tInq8s=", "X-TM-AS-User-Approved-Sender": "No", "X-TM-AS-User-Blocked-Sender": "No", "X-TMASE-Result": "10--4.329300-4.000000", "X-TMASE-Version": "SMEX-12.5.0.1300-8.5.1010-24412.006", "X-MDID": "1549541898-o_lnEJj45054", "Subject": "[dpdk-dev] [PATCH 28/30] net/sfc: remove adapter locks from\n\tsecondary process ops", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Adapter lock will become primary process only.\n\nSigned-off-by: Andrew Rybchenko <arybchenko@solarflare.com>\n---\n drivers/net/sfc/sfc_ethdev.c | 20 --------------------\n 1 file changed, 20 deletions(-)", "diff": "diff --git a/drivers/net/sfc/sfc_ethdev.c b/drivers/net/sfc/sfc_ethdev.c\nindex c6bee09ee..6b00601fc 100644\n--- a/drivers/net/sfc/sfc_ethdev.c\n+++ b/drivers/net/sfc/sfc_ethdev.c\n@@ -1071,11 +1071,8 @@ sfc_rx_queue_info_get(struct rte_eth_dev *dev, uint16_t rx_queue_id,\n \t\t struct rte_eth_rxq_info *qinfo)\n {\n \tstruct sfc_adapter_shared *sas = sfc_adapter_shared_by_eth_dev(dev);\n-\tstruct sfc_adapter *sa = dev->data->dev_private;\n \tstruct sfc_rxq_info *rxq_info;\n \n-\tsfc_adapter_lock(sa);\n-\n \tSFC_ASSERT(rx_queue_id < sas->rxq_count);\n \n \trxq_info = &sas->rxq_info[rx_queue_id];\n@@ -1090,8 +1087,6 @@ sfc_rx_queue_info_get(struct rte_eth_dev *dev, uint16_t rx_queue_id,\n \t\tqinfo->scattered_rx = 1;\n \t}\n \tqinfo->nb_desc = rxq_info->entries;\n-\n-\tsfc_adapter_unlock(sa);\n }\n \n /*\n@@ -1103,11 +1098,8 @@ sfc_tx_queue_info_get(struct rte_eth_dev *dev, uint16_t tx_queue_id,\n \t\t struct rte_eth_txq_info *qinfo)\n {\n \tstruct sfc_adapter_shared *sas = sfc_adapter_shared_by_eth_dev(dev);\n-\tstruct sfc_adapter *sa = dev->data->dev_private;\n \tstruct sfc_txq_info *txq_info;\n \n-\tsfc_adapter_lock(sa);\n-\n \tSFC_ASSERT(tx_queue_id < sas->txq_count);\n \n \ttxq_info = &sas->txq_info[tx_queue_id];\n@@ -1118,8 +1110,6 @@ sfc_tx_queue_info_get(struct rte_eth_dev *dev, uint16_t tx_queue_id,\n \tqinfo->conf.tx_free_thresh = txq_info->free_thresh;\n \tqinfo->conf.tx_deferred_start = txq_info->deferred_start;\n \tqinfo->nb_desc = txq_info->entries;\n-\n-\tsfc_adapter_unlock(sa);\n }\n \n /*\n@@ -1421,14 +1411,11 @@ sfc_dev_rss_hash_conf_get(struct rte_eth_dev *dev,\n \t\t\t struct rte_eth_rss_conf *rss_conf)\n {\n \tstruct sfc_adapter_shared *sas = sfc_adapter_shared_by_eth_dev(dev);\n-\tstruct sfc_adapter *sa = dev->data->dev_private;\n \tstruct sfc_rss *rss = &sas->rss;\n \n \tif (rss->context_type != EFX_RX_SCALE_EXCLUSIVE)\n \t\treturn -ENOTSUP;\n \n-\tsfc_adapter_lock(sa);\n-\n \t/*\n \t * Mapping of hash configuration between RTE and EFX is not one-to-one,\n \t * hence, conversion is done here to derive a correct set of ETH_RSS\n@@ -1440,8 +1427,6 @@ sfc_dev_rss_hash_conf_get(struct rte_eth_dev *dev,\n \tif (rss_conf->rss_key != NULL)\n \t\trte_memcpy(rss_conf->rss_key, rss->key, EFX_RSS_KEY_SIZE);\n \n-\tsfc_adapter_unlock(sa);\n-\n \treturn 0;\n }\n \n@@ -1526,7 +1511,6 @@ sfc_dev_rss_reta_query(struct rte_eth_dev *dev,\n \t\t uint16_t reta_size)\n {\n \tstruct sfc_adapter_shared *sas = sfc_adapter_shared_by_eth_dev(dev);\n-\tstruct sfc_adapter *sa = dev->data->dev_private;\n \tstruct sfc_rss *rss = &sas->rss;\n \tint entry;\n \n@@ -1539,8 +1523,6 @@ sfc_dev_rss_reta_query(struct rte_eth_dev *dev,\n \tif (reta_size != EFX_RSS_TBL_SIZE)\n \t\treturn -EINVAL;\n \n-\tsfc_adapter_lock(sa);\n-\n \tfor (entry = 0; entry < reta_size; entry++) {\n \t\tint grp = entry / RTE_RETA_GROUP_SIZE;\n \t\tint grp_idx = entry % RTE_RETA_GROUP_SIZE;\n@@ -1549,8 +1531,6 @@ sfc_dev_rss_reta_query(struct rte_eth_dev *dev,\n \t\t\treta_conf[grp].reta[grp_idx] = rss->tbl[entry];\n \t}\n \n-\tsfc_adapter_unlock(sa);\n-\n \treturn 0;\n }\n \n", "prefixes": [ "28/30" ] }