Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 50268,
    "url": "http://patchwork.dpdk.org/api/patches/50268/?format=api",
    "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20180211085722.59717-1-georgina.sheehan@intel.com/",
    "project": {
        "id": 1,
        "url": "http://patchwork.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20180211085722.59717-1-georgina.sheehan@intel.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20180211085722.59717-1-georgina.sheehan@intel.com",
    "date": "2018-02-11T08:57:20",
    "name": "[v1,1/3] librte_pipeline: add support for DSCP action",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "6816c4b4a9786f86fa531e4903431a5589d1fc7d",
    "submitter": {
        "id": 1219,
        "url": "http://patchwork.dpdk.org/api/people/1219/?format=api",
        "name": "Sheehan,Georgina",
        "email": "georgina.sheehan@intel.com"
    },
    "delegate": {
        "id": 10018,
        "url": "http://patchwork.dpdk.org/api/users/10018/?format=api",
        "username": "cristian_dumitrescu",
        "first_name": "Cristian",
        "last_name": "Dumitrescu",
        "email": "cristian.dumitrescu@intel.com"
    },
    "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20180211085722.59717-1-georgina.sheehan@intel.com/mbox/",
    "series": [
        {
            "id": 3427,
            "url": "http://patchwork.dpdk.org/api/series/3427/?format=api",
            "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=3427",
            "date": "2018-02-11T08:57:20",
            "name": "[v1,1/3] librte_pipeline: add support for DSCP action",
            "version": 1,
            "mbox": "http://patchwork.dpdk.org/series/3427/mbox/"
        }
    ],
    "comments": "http://patchwork.dpdk.org/api/patches/50268/comments/",
    "check": "fail",
    "checks": "http://patchwork.dpdk.org/api/patches/50268/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 0AD371B0FC;\n\tTue, 12 Feb 2019 10:31:30 +0100 (CET)",
            "from mga02.intel.com (mga02.intel.com [134.134.136.20])\n\tby dpdk.org (Postfix) with ESMTP id CD1785F27\n\tfor <dev@dpdk.org>; Tue, 12 Feb 2019 10:31:28 +0100 (CET)",
            "from fmsmga004.fm.intel.com ([10.253.24.48])\n\tby orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t12 Feb 2019 01:31:27 -0800",
            "from silpixa00399837.ir.intel.com (HELO\n\tsilpixa00399837.ger.corp.intel.com) ([10.237.223.162])\n\tby fmsmga004.fm.intel.com with ESMTP; 12 Feb 2019 01:31:26 -0800"
        ],
        "X-Amp-Result": "SKIPPED(no attachment in message)",
        "X-Amp-File-Uploaded": "False",
        "X-ExtLoop1": "1",
        "X-IronPort-AV": "E=Sophos;i=\"5.58,361,1544515200\"; d=\"scan'208\";a=\"143527121\"",
        "From": "\"Sheehan,Georgina\" <georgina.sheehan@intel.com>",
        "To": "dev@dpdk.org",
        "Cc": "cristian.dumitrescu@intel.com,\n\tGeorgina Sheehan <georgina.sheehan@intel.com>",
        "Date": "Sun, 11 Feb 2018 08:57:20 +0000",
        "Message-Id": "<20180211085722.59717-1-georgina.sheehan@intel.com>",
        "X-Mailer": "git-send-email 2.17.1",
        "Subject": "[dpdk-dev] [PATCH v1 1/3] librte_pipeline: add support for DSCP\n\taction",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "From: Georgina Sheehan <georgina.sheehan@intel.com>\n\nThis allows the application to change the DSCP value of incoming packets\n\nSigned-off-by: Georgina Sheehan <georgina.sheehan@intel.com>\n---\n lib/librte_pipeline/rte_table_action.c | 133 +++++++++++++++++++++++++\n lib/librte_pipeline/rte_table_action.h |  20 ++++\n 2 files changed, 153 insertions(+)",
    "diff": "diff --git a/lib/librte_pipeline/rte_table_action.c b/lib/librte_pipeline/rte_table_action.c\nindex 8a2bb13dc..8f11a17e6 100644\n--- a/lib/librte_pipeline/rte_table_action.c\n+++ b/lib/librte_pipeline/rte_table_action.c\n@@ -2119,6 +2119,87 @@ pkt4_work_decap(struct rte_mbuf *mbuf0,\n \tmbuf3->pkt_len = pkt_len3 - n3;\n }\n \n+/**\n+ * RTE_TABLE_ACTION_DSCP\n+ */\n+\n+struct dscp_data {\n+\tuint8_t dscp_val;\n+} __attribute__((__packed__));\n+\n+static int\n+dscp_apply(void *data,\n+\tstruct rte_table_action_dscp_params *p)\n+{\n+\tstruct dscp_data *d = data;\n+\n+\td->dscp_val = (p->dscp_val & 0x3f) << 2;\n+\n+\treturn 0;\n+}\n+\n+static __rte_always_inline uint16_t\n+dscp_ipv4_checksum_update(uint16_t cksum0,\n+\tuint8_t dscp_old,\n+\tuint8_t dscp_new)\n+{\n+\tint32_t cksum1;\n+\tcksum1 = cksum0;\n+\tcksum1 = ~cksum1 & 0xFFFF;\n+\n+\t/* Subtract ip0 (one's complement logic) */\n+\tcksum1 -= ((uint16_t)dscp_old & 0xFFFF);\n+\tcksum1 = (cksum1 & 0xFFFF) + (cksum1 >> 16);\n+\tcksum1 = (cksum1 & 0xFFFF) + (cksum1 >> 16);\n+\n+\t/* Add ip1 (one's complement logic) */\n+\tcksum1 += ((uint16_t)dscp_new & 0xFFFF);\n+\tcksum1 = (cksum1 & 0xFFFF) + (cksum1 >> 16);\n+\tcksum1 = (cksum1 & 0xFFFF) + (cksum1 >> 16);\n+\n+\treturn (uint16_t)(~cksum1);\n+}\n+\n+static __rte_always_inline void\n+pkt_ipv4_work_dscp(struct ipv4_hdr *ip, struct dscp_data *data)\n+{\n+\tuint16_t ip_cksum;\n+\tuint8_t dscp;\n+\n+\tip->hdr_checksum = ntohs(ip->hdr_checksum);\n+\n+\tdscp = ip->type_of_service & 0x3;\n+\tdscp = ip->type_of_service | data->dscp_val;\n+\n+\tip_cksum = dscp_ipv4_checksum_update(ip->hdr_checksum,\n+\t\tip->type_of_service, dscp);\n+\n+\tip->type_of_service = dscp;\n+\n+\tip_cksum = ntohs(ip_cksum);\n+\n+\tip->hdr_checksum = ip_cksum;\n+}\n+\n+static __rte_always_inline void\n+pkt_ipv6_work_dscp(struct ipv6_hdr *ip, struct dscp_data *data)\n+{\n+\tip->vtc_flow = rte_ntohl(ip->vtc_flow);\n+\n+\tuint32_t dscp = data->dscp_val;\n+\n+\tdscp = dscp << 20;\n+\n+\tuint32_t vtc_flow;\n+\n+\tvtc_flow = ip->vtc_flow & 0xF03FFFFF;\n+\tvtc_flow = ip->vtc_flow | dscp;\n+\n+\tvtc_flow = rte_htonl(vtc_flow);\n+\n+\tip->vtc_flow = vtc_flow;\n+}\n+\n /**\n  * Action profile\n  */\n@@ -2138,6 +2219,7 @@ action_valid(enum rte_table_action_type action)\n \tcase RTE_TABLE_ACTION_SYM_CRYPTO:\n \tcase RTE_TABLE_ACTION_TAG:\n \tcase RTE_TABLE_ACTION_DECAP:\n+\tcase RTE_TABLE_ACTION_DSCP:\n \t\treturn 1;\n \tdefault:\n \t\treturn 0;\n@@ -2158,6 +2240,7 @@ struct ap_config {\n \tstruct rte_table_action_ttl_config ttl;\n \tstruct rte_table_action_stats_config stats;\n \tstruct rte_table_action_sym_crypto_config sym_crypto;\n+\tstruct rte_table_action_dscp_config dscp;\n };\n \n static size_t\n@@ -2180,6 +2263,8 @@ action_cfg_size(enum rte_table_action_type action)\n \t\treturn sizeof(struct rte_table_action_stats_config);\n \tcase RTE_TABLE_ACTION_SYM_CRYPTO:\n \t\treturn sizeof(struct rte_table_action_sym_crypto_config);\n+\tcase RTE_TABLE_ACTION_DSCP:\n+\t\treturn sizeof(struct rte_table_action_dscp_config);\n \tdefault:\n \t\treturn 0;\n \t}\n@@ -2213,6 +2298,9 @@ action_cfg_get(struct ap_config *ap_config,\n \n \tcase RTE_TABLE_ACTION_SYM_CRYPTO:\n \t\treturn &ap_config->sym_crypto;\n+\n+\tcase RTE_TABLE_ACTION_DSCP:\n+\t\treturn &ap_config->dscp;\n \tdefault:\n \t\treturn NULL;\n \t}\n@@ -2278,6 +2366,9 @@ action_data_size(enum rte_table_action_type action,\n \tcase RTE_TABLE_ACTION_DECAP:\n \t\treturn sizeof(struct decap_data);\n \n+\tcase RTE_TABLE_ACTION_DSCP:\n+\t\treturn sizeof(struct dscp_data);\n+\n \tdefault:\n \t\treturn 0;\n \t}\n@@ -2543,6 +2634,10 @@ rte_table_action_apply(struct rte_table_action *action,\n \t\treturn decap_apply(action_data,\n \t\t\taction_params);\n \n+\tcase RTE_TABLE_ACTION_DSCP:\n+\t\treturn dscp_apply(action_data,\n+\t\t\taction_params);\n+\n \tdefault:\n \t\treturn -EINVAL;\n \t}\n@@ -2939,6 +3034,17 @@ pkt_work(struct rte_mbuf *mbuf,\n \t\tpkt_work_tag(mbuf, data);\n \t}\n \n+\tif (cfg->action_mask & (1LLU << RTE_TABLE_ACTION_DSCP)) {\n+\t\tvoid *data =\n+\t\t\taction_data_get(table_entry, action,\n+\t\t\t\tRTE_TABLE_ACTION_DSCP);\n+\n+\t\tif (cfg->common.ip_version)\n+\t\t\tpkt_ipv4_work_dscp(ip, data);\n+\t\telse\n+\t\t\tpkt_ipv6_work_dscp(ip, data);\n+\t}\n+\n \treturn drop_mask;\n }\n \n@@ -3283,6 +3389,33 @@ pkt4_work(struct rte_mbuf **mbufs,\n \t\t\tdata0, data1, data2, data3);\n \t}\n \n+\tif (cfg->action_mask & (1LLU << RTE_TABLE_ACTION_DSCP)) {\n+\t\tvoid *data0 =\n+\t\t\taction_data_get(table_entry0, action,\n+\t\t\t\tRTE_TABLE_ACTION_DSCP);\n+\t\tvoid *data1 =\n+\t\t\taction_data_get(table_entry1, action,\n+\t\t\t\tRTE_TABLE_ACTION_DSCP);\n+\t\tvoid *data2 =\n+\t\t\taction_data_get(table_entry2, action,\n+\t\t\t\tRTE_TABLE_ACTION_DSCP);\n+\t\tvoid *data3 =\n+\t\t\taction_data_get(table_entry3, action,\n+\t\t\t\tRTE_TABLE_ACTION_DSCP);\n+\n+\t\tif (cfg->common.ip_version) {\n+\t\t\tpkt_ipv4_work_dscp(ip0, data0);\n+\t\t\tpkt_ipv4_work_dscp(ip1, data1);\n+\t\t\tpkt_ipv4_work_dscp(ip2, data2);\n+\t\t\tpkt_ipv4_work_dscp(ip3, data3);\n+\t\t} else {\n+\t\t\tpkt_ipv6_work_dscp(ip0, data0);\n+\t\t\tpkt_ipv6_work_dscp(ip1, data1);\n+\t\t\tpkt_ipv6_work_dscp(ip2, data2);\n+\t\t\tpkt_ipv6_work_dscp(ip3, data3);\n+\t\t}\n+\t}\n+\n \treturn drop_mask0 |\n \t\t(drop_mask1 << 1) |\n \t\t(drop_mask2 << 2) |\ndiff --git a/lib/librte_pipeline/rte_table_action.h b/lib/librte_pipeline/rte_table_action.h\nindex c96061291..28db53303 100644\n--- a/lib/librte_pipeline/rte_table_action.h\n+++ b/lib/librte_pipeline/rte_table_action.h\n@@ -102,6 +102,9 @@ enum rte_table_action_type {\n \n \t/** Packet decapsulations. */\n \tRTE_TABLE_ACTION_DECAP,\n+\n+\t/** Differentiated Services Code Point (DSCP) **/\n+\tRTE_TABLE_ACTION_DSCP,\n };\n \n /** Common action configuration (per table action profile). */\n@@ -794,6 +797,23 @@ struct rte_table_action_decap_params {\n \tuint16_t n;\n };\n \n+/**\n+ * RTE_TABLE_ACTION_DSCP\n+ */\n+/** DSCP action configuration (per table action profile). */\n+struct rte_table_action_dscp_config {\n+\t/** dscp length  */\n+\tuint8_t dscp_len;\n+\n+};\n+\n+/** DSCP action parameters (per table rule). */\n+struct rte_table_action_dscp_params {\n+\t/** dscp value to be set */\n+\tuint8_t dscp_val;\n+\n+};\n+\n /**\n  * Table action profile.\n  */\n",
    "prefixes": [
        "v1",
        "1/3"
    ]
}