Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/50273/?format=api
http://patchwork.dpdk.org/api/patches/50273/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20180211132905.7502-3-georgina.sheehan@intel.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20180211132905.7502-3-georgina.sheehan@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20180211132905.7502-3-georgina.sheehan@intel.com", "date": "2018-02-11T13:29:05", "name": "[v2,3/3] net/softnic: add support for DSCP action", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "238759d2630ce56a0b6ef420a9f2612d801be2b5", "submitter": { "id": 1219, "url": "http://patchwork.dpdk.org/api/people/1219/?format=api", "name": "Sheehan,Georgina", "email": "georgina.sheehan@intel.com" }, "delegate": { "id": 10018, "url": "http://patchwork.dpdk.org/api/users/10018/?format=api", "username": "cristian_dumitrescu", "first_name": "Cristian", "last_name": "Dumitrescu", "email": "cristian.dumitrescu@intel.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20180211132905.7502-3-georgina.sheehan@intel.com/mbox/", "series": [ { "id": 3428, "url": "http://patchwork.dpdk.org/api/series/3428/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=3428", "date": "2018-02-11T13:29:03", "name": "[v2,1/3] librte_pipeline: add support for DSCP action", "version": 2, "mbox": "http://patchwork.dpdk.org/series/3428/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/50273/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/50273/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 61B3E1B3A9;\n\tTue, 12 Feb 2019 15:03:19 +0100 (CET)", "from mga01.intel.com (mga01.intel.com [192.55.52.88])\n\tby dpdk.org (Postfix) with ESMTP id 94DBA1B3A5\n\tfor <dev@dpdk.org>; Tue, 12 Feb 2019 15:03:17 +0100 (CET)", "from orsmga004.jf.intel.com ([10.7.209.38])\n\tby fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t12 Feb 2019 06:03:16 -0800", "from silpixa00399837.ir.intel.com (HELO\n\tsilpixa00399837.ger.corp.intel.com) ([10.237.223.162])\n\tby orsmga004.jf.intel.com with ESMTP; 12 Feb 2019 06:03:16 -0800" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.58,362,1544515200\"; d=\"scan'208\";a=\"274432505\"", "From": "\"Sheehan,Georgina\" <georgina.sheehan@intel.com>", "To": "dev@dpdk.org", "Cc": "cristian.dumitrescu@intel.com,\n\tGeorgina Sheehan <georgina.sheehan@intel.com>", "Date": "Sun, 11 Feb 2018 13:29:05 +0000", "Message-Id": "<20180211132905.7502-3-georgina.sheehan@intel.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20180211132905.7502-1-georgina.sheehan@intel.com>", "References": "<20180211085722.59717-1-georgina.sheehan@intel.com>\n\t<20180211132905.7502-1-georgina.sheehan@intel.com>", "Subject": "[dpdk-dev] [PATCH v2 3/3] net/softnic: add support for DSCP action", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Georgina Sheehan <georgina.sheehan@intel.com>\n\nThis allows the application to change the DSCP value of incoming packets\n\nv2: Added in call of function parse_table_action_dscp in softnic cli file\n\nSigned-off-by: Georgina Sheehan <georgina.sheehan@intel.com>\n---\n drivers/net/softnic/rte_eth_softnic_action.c | 14 ++++++\n drivers/net/softnic/rte_eth_softnic_cli.c | 48 +++++++++++++++++++\n .../net/softnic/rte_eth_softnic_internals.h | 2 +\n drivers/net/softnic/rte_eth_softnic_thread.c | 10 ++++\n 4 files changed, 74 insertions(+)", "diff": "diff --git a/drivers/net/softnic/rte_eth_softnic_action.c b/drivers/net/softnic/rte_eth_softnic_action.c\nindex 92c744dc9..98d03d5ef 100644\n--- a/drivers/net/softnic/rte_eth_softnic_action.c\n+++ b/drivers/net/softnic/rte_eth_softnic_action.c\n@@ -397,12 +397,26 @@ softnic_table_action_profile_create(struct pmd_internals *p,\n \t\t}\n \t}\n \n+\tif (params->action_mask & (1LLU << RTE_TABLE_ACTION_DSCP)) {\n+\t\tstatus = rte_table_action_profile_action_register(ap,\n+\t\t\tRTE_TABLE_ACTION_DSCP,\n+\t\t\t¶ms->dscp);\n+\n+\t\tif (status) {\n+\t\t\trte_table_action_profile_free(ap);\n+\t\t\treturn NULL;\n+\t\t}\n+\t}\n+\n+\n \tstatus = rte_table_action_profile_freeze(ap);\n \tif (status) {\n \t\trte_table_action_profile_free(ap);\n \t\treturn NULL;\n \t}\n \n+\n+\n \t/* Node allocation */\n \tprofile = calloc(1, sizeof(struct softnic_table_action_profile));\n \tif (profile == NULL) {\ndiff --git a/drivers/net/softnic/rte_eth_softnic_cli.c b/drivers/net/softnic/rte_eth_softnic_cli.c\nindex 76136c2e2..0e94cfc55 100644\n--- a/drivers/net/softnic/rte_eth_softnic_cli.c\n+++ b/drivers/net/softnic/rte_eth_softnic_cli.c\n@@ -1358,6 +1358,7 @@ cmd_port_in_action_profile(struct pmd_internals *softnic,\n * [time]\n * [tag]\n * [decap]\n+ * [dscp]\n *\n */\n static void\n@@ -1787,6 +1788,17 @@ cmd_table_action_profile(struct pmd_internals *softnic,\n \t\tt0 += 5;\n \t} /* sym_crypto */\n \n+\tif (t0 < n_tokens && (strcmp(tokens[t0], \"dscp\") == 0)) {\n+\t\tif (n_tokens < t0 + 1) {\n+\t\t\tsnprintf(out, out_size, MSG_ARG_MISMATCH,\n+\t\t\t\t\"table action profile dscp\");\n+\t\t\treturn;\n+\t\t}\n+\n+\t\tp.action_mask |= 1LLU << RTE_TABLE_ACTION_DSCP;\n+\t\tt0 += 1;\n+\t} /** DSCP **/\n+\n \tif (t0 < n_tokens) {\n \t\tsnprintf(out, out_size, MSG_ARG_MISMATCH, tokens[0]);\n \t\treturn;\n@@ -3432,6 +3444,7 @@ parse_match(char **tokens,\n * aead_algo <algo> aead_key <key> aead_iv <iv> aead_aad <aad>\n * digest_size <size>\n * data_offset <data_offset>]\n+ * [dscp <n>]\n *\n * where:\n * <pa> ::= g | y | r | drop\n@@ -4431,6 +4444,27 @@ parse_table_action_decap(char **tokens,\n \treturn 2;\n }\n \n+static uint32_t\n+parse_table_action_dscp(char **tokens,\n+\t\tuint32_t n_tokens,\n+\t\tstruct softnic_table_rule_action *a)\n+{\n+\tif (n_tokens < 2 ||\n+\t\tstrcmp(tokens[0], \"dscp\"))\n+\t\treturn 0;\n+\n+\tuint8_t dscp_val;\n+\n+\tif (softnic_parser_read_uint8(&dscp_val, tokens[1]))\n+\t\treturn 0;\n+\n+\ta->dscp.dscp_val = dscp_val;\n+\n+\ta->action_mask |= 1 << RTE_TABLE_ACTION_DSCP;\n+\n+\treturn 2;\n+}\n+\n static uint32_t\n parse_table_action(char **tokens,\n \tuint32_t n_tokens,\n@@ -4616,6 +4650,20 @@ parse_table_action(char **tokens,\n \t\tn_tokens -= n;\n \t}\n \n+\tif (n_tokens && (strcmp(tokens[0], \"dscp\") == 0)) {\n+\t\tuint32_t n;\n+\n+\t\tn = parse_table_action_dscp(tokens, n_tokens, a);\n+\t\tif (n == 0) {\n+\t\t\tsnprintf(out, out_size, MSG_ARG_INVALID,\n+\t\t\t\t\"action dscp\");\n+\t\t\treturn 0;\n+\t\t}\n+\n+\t\ttokens += n;\n+\t\tn_tokens -= n;\n+\t}\n+\n \tif (n_tokens0 - n_tokens == 1) {\n \t\tsnprintf(out, out_size, MSG_ARG_INVALID, \"action\");\n \t\treturn 0;\ndiff --git a/drivers/net/softnic/rte_eth_softnic_internals.h b/drivers/net/softnic/rte_eth_softnic_internals.h\nindex 415434d0d..67ba3ecf3 100644\n--- a/drivers/net/softnic/rte_eth_softnic_internals.h\n+++ b/drivers/net/softnic/rte_eth_softnic_internals.h\n@@ -333,6 +333,7 @@ struct softnic_table_action_profile_params {\n \tstruct rte_table_action_ttl_config ttl;\n \tstruct rte_table_action_stats_config stats;\n \tstruct rte_table_action_sym_crypto_config sym_crypto;\n+\tstruct rte_table_action_dscp_config dscp;\n };\n \n struct softnic_table_action_profile {\n@@ -962,6 +963,7 @@ struct softnic_table_rule_action {\n \tstruct rte_table_action_tag_params tag;\n \tstruct rte_table_action_decap_params decap;\n \tstruct rte_table_action_sym_crypto_params sym_crypto;\n+\tstruct rte_table_action_dscp_params dscp;\n };\n \n struct rte_flow {\ndiff --git a/drivers/net/softnic/rte_eth_softnic_thread.c b/drivers/net/softnic/rte_eth_softnic_thread.c\nindex 57989a5aa..e73d4a704 100644\n--- a/drivers/net/softnic/rte_eth_softnic_thread.c\n+++ b/drivers/net/softnic/rte_eth_softnic_thread.c\n@@ -2598,6 +2598,16 @@ action_convert(struct rte_table_action *a,\n \t\t\treturn status;\n \t}\n \n+\tif (action->action_mask & (1LLU << RTE_TABLE_ACTION_DSCP)) {\n+\t\tstatus = rte_table_action_apply(a,\n+\t\t\tdata,\n+\t\t\tRTE_TABLE_ACTION_DSCP,\n+\t\t\t&action->dscp);\n+\n+\t\tif (status)\n+\t\t\treturn status;\n+\t}\n+\n \treturn 0;\n }\n \n", "prefixes": [ "v2", "3/3" ] }{ "id": 50273, "url": "