Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/50767/?format=api
{ "id": 50767, "url": "http://patchwork.dpdk.org/api/patches/50767/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/5a6195428c5075be9041d685e054720c328f4e54.1551528549.git.igor.russkikh@aquantia.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<5a6195428c5075be9041d685e054720c328f4e54.1551528549.git.igor.russkikh@aquantia.com>", "list_archive_url": "https://inbox.dpdk.org/dev/5a6195428c5075be9041d685e054720c328f4e54.1551528549.git.igor.russkikh@aquantia.com", "date": "2019-03-02T12:10:55", "name": "[07/10] net/atlantic: fix link configuration", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "1cb6b3dd48324aabd60c8cd3da1be38fb69ee156", "submitter": { "id": 1124, "url": "http://patchwork.dpdk.org/api/people/1124/?format=api", "name": "Igor Russkikh", "email": "igor.russkikh@aquantia.com" }, "delegate": { "id": 319, "url": "http://patchwork.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/5a6195428c5075be9041d685e054720c328f4e54.1551528549.git.igor.russkikh@aquantia.com/mbox/", "series": [ { "id": 3614, "url": "http://patchwork.dpdk.org/api/series/3614/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=3614", "date": "2019-03-02T12:10:41", "name": "net/atlantic: bugfixes and code cleanup", "version": 1, "mbox": "http://patchwork.dpdk.org/series/3614/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/50767/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/50767/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 25B044F91;\n\tSat, 2 Mar 2019 13:10:58 +0100 (CET)", "from NAM04-CO1-obe.outbound.protection.outlook.com\n\t(mail-eopbgr690062.outbound.protection.outlook.com [40.107.69.62])\n\tby dpdk.org (Postfix) with ESMTP id 6C4E94CB5\n\tfor <dev@dpdk.org>; Sat, 2 Mar 2019 13:10:56 +0100 (CET)", "from DM6PR11MB3625.namprd11.prod.outlook.com (20.178.230.149) by\n\tDM6PR11MB3867.namprd11.prod.outlook.com (10.255.61.12) with Microsoft\n\tSMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n\t15.20.1665.16; Sat, 2 Mar 2019 12:10:55 +0000", "from DM6PR11MB3625.namprd11.prod.outlook.com\n\t([fe80::319e:4e9b:b376:5588]) by\n\tDM6PR11MB3625.namprd11.prod.outlook.com\n\t([fe80::319e:4e9b:b376:5588%4]) with mapi id 15.20.1643.019;\n\tSat, 2 Mar 2019 12:10:55 +0000" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=AQUANTIA1COM.onmicrosoft.com; s=selector1-aquantia-com;\n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n\tbh=P2qZ1NVGMAanEk30cu1WGwLlAPpWO0JKLe6msbS4d8w=;\n\tb=NbZIKQCWfhkb2X31b90jLjbZJm25jmvmiRH9clAJfDURTGzop3naewsZjKG2Xd4MweTbLQYOt6kPPx5xgHhvabGN/PdJYZfs9xFH10FKR0yraKGX9aXsBUbJkkk3Q8T33kQtu4PZvxOh2SqxsssATokHpBqn1xYeWufm46v4AwA=", "From": "Igor Russkikh <Igor.Russkikh@aquantia.com>", "To": "\"dev@dpdk.org\" <dev@dpdk.org>", "CC": "Pavel Belous <Pavel.Belous@aquantia.com>, Igor Russkikh\n\t<Igor.Russkikh@aquantia.com>", "Thread-Topic": "[PATCH 07/10] net/atlantic: fix link configuration", "Thread-Index": "AQHU0PD8mCpcOwyNpUGx5vavH138HA==", "Date": "Sat, 2 Mar 2019 12:10:55 +0000", "Message-ID": "<5a6195428c5075be9041d685e054720c328f4e54.1551528549.git.igor.russkikh@aquantia.com>", "References": "<cover.1551528549.git.igor.russkikh@aquantia.com>", "In-Reply-To": "<cover.1551528549.git.igor.russkikh@aquantia.com>", "Accept-Language": "en-US", "Content-Language": "en-US", "X-MS-Has-Attach": "", "X-MS-TNEF-Correlator": "", "x-clientproxiedby": "HE1P190CA0057.EURP190.PROD.OUTLOOK.COM\n\t(2603:10a6:7:52::46)\n\tTo DM6PR11MB3625.namprd11.prod.outlook.com\n\t(2603:10b6:5:13a::21)", "authentication-results": "spf=none (sender IP is )\n\tsmtp.mailfrom=Igor.Russkikh@aquantia.com; ", "x-ms-exchange-messagesentrepresentingtype": "1", "x-mailer": "git-send-email 2.17.1", "x-originating-ip": "[95.79.108.179]", "x-ms-publictraffictype": "Email", "x-ms-office365-filtering-correlation-id": "ec7369e7-926c-4bde-a4fa-08d69f081ebf", "x-microsoft-antispam": "BCL:0; PCL:0;\n\tRULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600127)(711020)(4605104)(2017052603328)(7153060)(7193020);\n\tSRVR:DM6PR11MB3867; ", "x-ms-traffictypediagnostic": "DM6PR11MB3867:", "x-microsoft-exchange-diagnostics": "=?iso-8859-1?Q?1; DM6PR11MB3867;\n\t23:NzIPUkl0PL6U0Ht/pyuqAsbPGv/784aa4WxQTxE?=\n\t=?iso-8859-1?q?nepx16Vq56GoOBMYgU/ErCv9x?=\n\t=?iso-8859-1?q?h/tX0ti9S+IphcYxfnHYcMzc8smSb+PIKFHSgzQc2xZhg3tJ9cw?=\n\t=?iso-8859-1?q?lFvRL3lQdBc8oQl9a4xYrcz1V4o5IF+ShudSwKPKbMZitRoZ8YJ?=\n\t=?iso-8859-1?q?vyzOPw+YN6NE4oW9rZNuoHJL3r28FEsiuUsjLJTQ41pIdYjcTuz?=\n\t=?iso-8859-1?q?1Z/fYgk/SF2G2nX7DxUZnLcDV4VpywoVCvpAyPQnTV4Q5037jre?=\n\t=?iso-8859-1?q?Fb5V3d7OWBBjuRpR1zOo5Ngx5XzWPrhHq0t5y+aoRwFGzIaMGfM?=\n\t=?iso-8859-1?q?Jg5XrjJKomZVNqtq5bY9EqmqacszGg2hSkZ49oyvUZp2rGHKqLb?=\n\t=?iso-8859-1?q?fsKRRmfZh2uJQV/+jKtsNe2C3HNM8DjytTue//ntBnuUoUaOvrj?=\n\t=?iso-8859-1?q?e+xNCKvm5RsbUeAnlGvMIvuyOijGK3S9wfsZT6P/v5OGhsrsEAR?=\n\t=?iso-8859-1?q?6JFtacaL+1HkkgnEPh8bfsBi86xrxMOMaYPSFBe0YKHnE4+p0OK?=\n\t=?iso-8859-1?q?VYSb3q1ON0ZThODeFNN1b54MhL5YLr+7ZHn5wGXcJpDT5vaCe1p?=\n\t=?iso-8859-1?q?U9/uEoWNGv/R5hn/lYyChvjWwzz/9RFqv2bkGXs8Ep4m7FOApma?=\n\t=?iso-8859-1?q?nKBLYvJilHnejtJ9kVejq69GFVU8KRI+AE6fQ7gnHqzG/9rZeF7?=\n\t=?iso-8859-1?q?bJG6T5PFuw/3d5gmOfmPW+ycOQIS0ToFT4qIfDBay3yKnVMjKbx?=\n\t=?iso-8859-1?q?ml3vhgWAf9Tq5Ej0iBA5v5Jx/+UBQPigQwsnlmUQJ4aM5Z66+4E?=\n\t=?iso-8859-1?q?SopL1pFRSswHWirRP2dvSERRgJpmKNINuo611cShn4N5e5Y9Kqg?=\n\t=?iso-8859-1?q?sWW/d5ttyfLi38X563vNTlMjQpnNptvEKyIEiuYRmxBe0Ue22c1?=\n\t=?iso-8859-1?q?gqGdSBO6CJVuWH99XBrAtQI8kKyI09TwcieaB2xC8z6K/YdxU8O?=\n\t=?iso-8859-1?q?u+4qvPp1dJLpQ3T5dtn0R2O9xBatDpeeJSwPAInhwZN5k4+d29c?=\n\t=?iso-8859-1?q?AwjQk5mH9ne/7hkcUe8Ob2LIxmrykum5ma7tjz3CVZzPqwIoqs4?=\n\t=?iso-8859-1?q?PqoW9zAekU/CmAZ8zAqMzYvCX6v64JZ1GzmkqI9kog96yCh2rGB?=\n\t=?iso-8859-1?q?6QpIQc21MAdAnQK7ciYQZEn2uVWH4yFZBd2/atkupXkBKPQcc/R?=\n\t=?iso-8859-1?q?+fXA2Y9IDffZX6Bb3jodYtBy4Bjn4Y3fGcGHrC3IRM+ubw8j0wz?=\n\t=?iso-8859-1?q?eAs5nYciEECuqbfUfOdtfyLbUXllUhXS29YzFum2ern4QSLBDAC?=\n\t=?iso-8859-1?q?8gl85uUnxbPpDJreLY+XTtXOntEilk9LhziZLzXgRSxHfRBk9O/?=\n\t=?iso-8859-1?q?U3pf+sgrlMs91SfQBeokCMDVrQA/2mLP6579HCOZ9XrcToZlNqk?=\n\t=?iso-8859-1?q?MBYRQqOcr8gFV+lbnbivVPwKQqAVPK21l+uw1nL7wvrlvJYU=3D?=", "x-microsoft-antispam-prvs": "<DM6PR11MB3867432C8C2253781335C80F98770@DM6PR11MB3867.namprd11.prod.outlook.com>", "x-forefront-prvs": "09645BAC66", "x-forefront-antispam-report": "SFV:NSPM;\n\tSFS:(10009020)(376002)(366004)(346002)(136003)(396003)(39850400004)(199004)(189003)(7736002)(8936002)(36756003)(256004)(1730700003)(71200400001)(6916009)(71190400001)(14444005)(8676002)(54906003)(106356001)(186003)(105586002)(4326008)(2501003)(26005)(305945005)(316002)(5660300002)(86362001)(97736004)(2906002)(102836004)(81156014)(81166006)(53936002)(52116002)(76176011)(3846002)(6506007)(386003)(6116002)(72206003)(6512007)(6436002)(14454004)(5640700003)(66066001)(6486002)(478600001)(25786009)(68736007)(99286004)(107886003)(11346002)(476003)(2616005)(446003)(486006)(2351001)(118296001)(50226002)(44832011);\n\tDIR:OUT; SFP:1101; SCL:1; SRVR:DM6PR11MB3867;\n\tH:DM6PR11MB3625.namprd11.prod.outlook.com; FPR:; SPF:None; LANG:en;\n\tPTR:InfoNoRecords; A:1; MX:1; ", "received-spf": "None (protection.outlook.com: aquantia.com does not designate\n\tpermitted sender hosts)", "x-ms-exchange-senderadcheck": "1", "x-microsoft-antispam-message-info": "KbDOqY0FQLA64eKSxpIqXuKnzlGjJIuOW6yJwQamxQ38uBjJVfjH38BsfM2Sw8y99vq7TE8GwGqMtwZnE7b/5TK7jsoX3DA9kSTxDuoT7KTXLN1uKHNrK2pvHE0SbvGVHvMZbcnlfjR+0qF1TzjMGZgc4aWg8x04fyhRQ7NFDbjO9D4ZnLrfsWkjJ+/Hf9NGgCILADWM3sOUR9Hj0iD9gPgvkGkA31ctOmQzBxQ2eWXk3LXRmiM4EKAEEihZwxq4UbHllDPUNp5iJUPwBSiY4W9l2EFCxfslrIEsv2WVPXMJnK/mFQ8uxEEZBPwFqdT0DhqE8zaVHtqXyUm86Gs+n7w0ceTXtFTzX3gvIt6UM8fuYxR0+Lp5I/baaK8xv7GjbAuLpfwdYcEzW/4CFlJllZ6irzROnfhArVeDN5qexb0=", "Content-Type": "text/plain; charset=\"iso-8859-1\"", "Content-Transfer-Encoding": "quoted-printable", "MIME-Version": "1.0", "X-OriginatorOrg": "aquantia.com", "X-MS-Exchange-CrossTenant-Network-Message-Id": "ec7369e7-926c-4bde-a4fa-08d69f081ebf", "X-MS-Exchange-CrossTenant-originalarrivaltime": "02 Mar 2019 12:10:53.2696\n\t(UTC)", "X-MS-Exchange-CrossTenant-fromentityheader": "Hosted", "X-MS-Exchange-CrossTenant-mailboxtype": "HOSTED", "X-MS-Exchange-CrossTenant-id": "83e2e134-991c-4ede-8ced-34d47e38e6b1", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "DM6PR11MB3867", "Subject": "[dpdk-dev] [PATCH 07/10] net/atlantic: fix link configuration", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "In case link speed is re configured after port start, it does not\ntakes the requested speed value, but instead just sets full autoneg\nmask.\n\nSigned-off-by: Igor Russkikh <igor.russkikh@aquantia.com>\n---\n drivers/net/atlantic/atl_ethdev.c | 44 ++++++++++++++-----------------\n 1 file changed, 20 insertions(+), 24 deletions(-)", "diff": "diff --git a/drivers/net/atlantic/atl_ethdev.c b/drivers/net/atlantic/atl_ethdev.c\nindex ae1babacf..ad4e5a717 100644\n--- a/drivers/net/atlantic/atl_ethdev.c\n+++ b/drivers/net/atlantic/atl_ethdev.c\n@@ -465,8 +465,6 @@ atl_dev_start(struct rte_eth_dev *dev)\n \tstruct rte_pci_device *pci_dev = RTE_ETH_DEV_TO_PCI(dev);\n \tstruct rte_intr_handle *intr_handle = &pci_dev->intr_handle;\n \tuint32_t intr_vector = 0;\n-\tuint32_t *link_speeds;\n-\tuint32_t speed = 0;\n \tint status;\n \tint err;\n \n@@ -543,6 +541,8 @@ atl_dev_start(struct rte_eth_dev *dev)\n \t\tgoto error;\n \t}\n \n+\terr = atl_dev_set_link_up(dev);\n+\n \terr = hw->aq_fw_ops->update_link_status(hw);\n \n \tif (err)\n@@ -550,26 +550,6 @@ atl_dev_start(struct rte_eth_dev *dev)\n \n \tdev->data->dev_link.link_status = hw->aq_link_status.mbps != 0;\n \n-\tlink_speeds = &dev->data->dev_conf.link_speeds;\n-\n-\tspeed = 0x0;\n-\n-\tif (*link_speeds == ETH_LINK_SPEED_AUTONEG) {\n-\t\tspeed = hw->aq_nic_cfg->link_speed_msk;\n-\t} else {\n-\t\tif (*link_speeds & ETH_LINK_SPEED_10G)\n-\t\t\tspeed |= AQ_NIC_RATE_10G;\n-\t\tif (*link_speeds & ETH_LINK_SPEED_5G)\n-\t\t\tspeed |= AQ_NIC_RATE_5G;\n-\t\tif (*link_speeds & ETH_LINK_SPEED_1G)\n-\t\t\tspeed |= AQ_NIC_RATE_1G;\n-\t\tif (*link_speeds & ETH_LINK_SPEED_2_5G)\n-\t\t\tspeed |= AQ_NIC_RATE_2G5;\n-\t\tif (*link_speeds & ETH_LINK_SPEED_100M)\n-\t\t\tspeed |= AQ_NIC_RATE_100M;\n-\t}\n-\n-\terr = hw->aq_fw_ops->set_link_speed(hw, speed);\n \tif (err)\n \t\tgoto error;\n \n@@ -657,9 +637,25 @@ static int\n atl_dev_set_link_up(struct rte_eth_dev *dev)\n {\n \tstruct aq_hw_s *hw = ATL_DEV_PRIVATE_TO_HW(dev->data->dev_private);\n+\tuint32_t link_speeds = dev->data->dev_conf.link_speeds;\n+\tuint32_t speed_mask = 0;\n+\n+\tif (link_speeds == ETH_LINK_SPEED_AUTONEG) {\n+\t\tspeed_mask = hw->aq_nic_cfg->link_speed_msk;\n+\t} else {\n+\t\tif (link_speeds & ETH_LINK_SPEED_10G)\n+\t\t\tspeed_mask |= AQ_NIC_RATE_10G;\n+\t\tif (link_speeds & ETH_LINK_SPEED_5G)\n+\t\t\tspeed_mask |= AQ_NIC_RATE_5G;\n+\t\tif (link_speeds & ETH_LINK_SPEED_1G)\n+\t\t\tspeed_mask |= AQ_NIC_RATE_1G;\n+\t\tif (link_speeds & ETH_LINK_SPEED_2_5G)\n+\t\t\tspeed_mask |= AQ_NIC_RATE_2G5;\n+\t\tif (link_speeds & ETH_LINK_SPEED_100M)\n+\t\t\tspeed_mask |= AQ_NIC_RATE_100M;\n+\t}\n \n-\treturn hw->aq_fw_ops->set_link_speed(hw,\n-\t\t\thw->aq_nic_cfg->link_speed_msk);\n+\treturn hw->aq_fw_ops->set_link_speed(hw, speed_mask);\n }\n \n /*\n", "prefixes": [ "07/10" ] }