Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/51433/?format=api
{ "id": 51433, "url": "http://patchwork.dpdk.org/api/patches/51433/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/1553149569-105555-3-git-send-email-wenzhuo.lu@intel.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1553149569-105555-3-git-send-email-wenzhuo.lu@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1553149569-105555-3-git-send-email-wenzhuo.lu@intel.com", "date": "2019-03-21T06:26:03", "name": "[v4,2/8] net/ice: add pointer for queue buffer release", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "d8864c380b5e1d9dea1c3c657f7356e9f0c1dc56", "submitter": { "id": 258, "url": "http://patchwork.dpdk.org/api/people/258/?format=api", "name": "Wenzhuo Lu", "email": "wenzhuo.lu@intel.com" }, "delegate": { "id": 1540, "url": "http://patchwork.dpdk.org/api/users/1540/?format=api", "username": "qzhan15", "first_name": "Qi", "last_name": "Zhang", "email": "qi.z.zhang@intel.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/1553149569-105555-3-git-send-email-wenzhuo.lu@intel.com/mbox/", "series": [ { "id": 3837, "url": "http://patchwork.dpdk.org/api/series/3837/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=3837", "date": "2019-03-21T06:26:01", "name": "Support vector instructions on ICE", "version": 4, "mbox": "http://patchwork.dpdk.org/series/3837/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/51433/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/51433/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 990421B427;\n\tThu, 21 Mar 2019 07:20:49 +0100 (CET)", "from mga06.intel.com (mga06.intel.com [134.134.136.31])\n\tby dpdk.org (Postfix) with ESMTP id 073901B3D7\n\tfor <dev@dpdk.org>; Thu, 21 Mar 2019 07:20:43 +0100 (CET)", "from orsmga007.jf.intel.com ([10.7.209.58])\n\tby orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t20 Mar 2019 23:20:43 -0700", "from dpdk26.sh.intel.com ([10.67.110.164])\n\tby orsmga007.jf.intel.com with ESMTP; 20 Mar 2019 23:20:42 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.60,251,1549958400\"; d=\"scan'208\";a=\"124512896\"", "From": "Wenzhuo Lu <wenzhuo.lu@intel.com>", "To": "dev@dpdk.org", "Cc": "Wenzhuo Lu <wenzhuo.lu@intel.com>", "Date": "Thu, 21 Mar 2019 14:26:03 +0800", "Message-Id": "<1553149569-105555-3-git-send-email-wenzhuo.lu@intel.com>", "X-Mailer": "git-send-email 1.9.3", "In-Reply-To": "<1553149569-105555-1-git-send-email-wenzhuo.lu@intel.com>", "References": "<1551340136-83843-1-git-send-email-wenzhuo.lu@intel.com>\n\t<1553149569-105555-1-git-send-email-wenzhuo.lu@intel.com>", "Subject": "[dpdk-dev] [PATCH v4 2/8] net/ice: add pointer for queue buffer\n\trelease", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Add function pointers of buffer releasing for RX and\nTX queues, for vector functions will be added for RX\nand TX.\n\nSigned-off-by: Wenzhuo Lu <wenzhuo.lu@intel.com>\n---\n drivers/net/ice/ice_rxtx.c | 24 +++++++++++++++---------\n drivers/net/ice/ice_rxtx.h | 5 +++++\n 2 files changed, 20 insertions(+), 9 deletions(-)", "diff": "diff --git a/drivers/net/ice/ice_rxtx.c b/drivers/net/ice/ice_rxtx.c\nindex c794ee8..d540ed1 100644\n--- a/drivers/net/ice/ice_rxtx.c\n+++ b/drivers/net/ice/ice_rxtx.c\n@@ -366,7 +366,7 @@\n \t\tPMD_DRV_LOG(ERR, \"Failed to switch RX queue %u on\",\n \t\t\t rx_queue_id);\n \n-\t\tice_rx_queue_release_mbufs(rxq);\n+\t\trxq->rx_rel_mbufs(rxq);\n \t\tice_reset_rx_queue(rxq);\n \t\treturn -EINVAL;\n \t}\n@@ -393,7 +393,7 @@\n \t\t\t\t rx_queue_id);\n \t\t\treturn -EINVAL;\n \t\t}\n-\t\tice_rx_queue_release_mbufs(rxq);\n+\t\trxq->rx_rel_mbufs(rxq);\n \t\tice_reset_rx_queue(rxq);\n \t\tdev->data->rx_queue_state[rx_queue_id] =\n \t\t\tRTE_ETH_QUEUE_STATE_STOPPED;\n@@ -555,7 +555,7 @@\n \t\treturn -EINVAL;\n \t}\n \n-\tice_tx_queue_release_mbufs(txq);\n+\ttxq->tx_rel_mbufs(txq);\n \tice_reset_tx_queue(txq);\n \tdev->data->tx_queue_state[tx_queue_id] = RTE_ETH_QUEUE_STATE_STOPPED;\n \n@@ -669,6 +669,7 @@\n \tice_reset_rx_queue(rxq);\n \trxq->q_set = TRUE;\n \tdev->data->rx_queues[queue_idx] = rxq;\n+\trxq->rx_rel_mbufs = ice_rx_queue_release_mbufs;\n \n \tuse_def_burst_func = ice_check_rx_burst_bulk_alloc_preconditions(rxq);\n \n@@ -701,7 +702,7 @@\n \t\treturn;\n \t}\n \n-\tice_rx_queue_release_mbufs(q);\n+\tq->rx_rel_mbufs(q);\n \trte_free(q->sw_ring);\n \trte_free(q);\n }\n@@ -866,6 +867,7 @@\n \tice_reset_tx_queue(txq);\n \ttxq->q_set = TRUE;\n \tdev->data->tx_queues[queue_idx] = txq;\n+\ttxq->tx_rel_mbufs = ice_tx_queue_release_mbufs;\n \n \treturn 0;\n }\n@@ -880,7 +882,7 @@\n \t\treturn;\n \t}\n \n-\tice_tx_queue_release_mbufs(q);\n+\tq->tx_rel_mbufs(q);\n \trte_free(q->sw_ring);\n \trte_free(q);\n }\n@@ -1552,18 +1554,22 @@\n void\n ice_clear_queues(struct rte_eth_dev *dev)\n {\n+\tstruct ice_rx_queue *rxq;\n+\tstruct ice_tx_queue *txq;\n \tuint16_t i;\n \n \tPMD_INIT_FUNC_TRACE();\n \n \tfor (i = 0; i < dev->data->nb_tx_queues; i++) {\n-\t\tice_tx_queue_release_mbufs(dev->data->tx_queues[i]);\n-\t\tice_reset_tx_queue(dev->data->tx_queues[i]);\n+\t\ttxq = dev->data->tx_queues[i];\n+\t\ttxq->tx_rel_mbufs(txq);\n+\t\tice_reset_tx_queue(txq);\n \t}\n \n \tfor (i = 0; i < dev->data->nb_rx_queues; i++) {\n-\t\tice_rx_queue_release_mbufs(dev->data->rx_queues[i]);\n-\t\tice_reset_rx_queue(dev->data->rx_queues[i]);\n+\t\trxq = dev->data->rx_queues[i];\n+\t\trxq->rx_rel_mbufs(rxq);\n+\t\tice_reset_rx_queue(rxq);\n \t}\n }\n \ndiff --git a/drivers/net/ice/ice_rxtx.h b/drivers/net/ice/ice_rxtx.h\nindex ec0e52e..78b4928 100644\n--- a/drivers/net/ice/ice_rxtx.h\n+++ b/drivers/net/ice/ice_rxtx.h\n@@ -27,6 +27,9 @@\n \n #define ICE_SUPPORT_CHAIN_NUM 5\n \n+typedef void (*ice_rx_release_mbufs_t)(struct ice_rx_queue *rxq);\n+typedef void (*ice_tx_release_mbufs_t)(struct ice_tx_queue *txq);\n+\n struct ice_rx_entry {\n \tstruct rte_mbuf *mbuf;\n };\n@@ -61,6 +64,7 @@ struct ice_rx_queue {\n \tuint16_t max_pkt_len; /* Maximum packet length */\n \tbool q_set; /* indicate if rx queue has been configured */\n \tbool rx_deferred_start; /* don't start this queue in dev start */\n+\tice_rx_release_mbufs_t rx_rel_mbufs;\n };\n \n struct ice_tx_entry {\n@@ -100,6 +104,7 @@ struct ice_tx_queue {\n \tuint16_t tx_next_rs;\n \tbool tx_deferred_start; /* don't start this queue in dev start */\n \tbool q_set; /* indicate if tx queue has been configured */\n+\tice_tx_release_mbufs_t tx_rel_mbufs;\n };\n \n /* Offload features */\n", "prefixes": [ "v4", "2/8" ] }