Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/51928/?format=api
http://patchwork.dpdk.org/api/patches/51928/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20190329163920.40415-1-david.hunt@intel.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190329163920.40415-1-david.hunt@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20190329163920.40415-1-david.hunt@intel.com", "date": "2019-03-29T16:39:20", "name": "[v2] lib/power: fix governor storage to trim newlines", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "3e2d861b2f14c18d5fbb1cf3380595f683f8dc92", "submitter": { "id": 342, "url": "http://patchwork.dpdk.org/api/people/342/?format=api", "name": "Hunt, David", "email": "david.hunt@intel.com" }, "delegate": { "id": 1, "url": "http://patchwork.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20190329163920.40415-1-david.hunt@intel.com/mbox/", "series": [ { "id": 4002, "url": "http://patchwork.dpdk.org/api/series/4002/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=4002", "date": "2019-03-29T16:39:20", "name": "[v2] lib/power: fix governor storage to trim newlines", "version": 2, "mbox": "http://patchwork.dpdk.org/series/4002/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/51928/comments/", "check": "fail", "checks": "http://patchwork.dpdk.org/api/patches/51928/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 0443D4C93;\n\tFri, 29 Mar 2019 17:39:32 +0100 (CET)", "from mga09.intel.com (mga09.intel.com [134.134.136.24])\n\tby dpdk.org (Postfix) with ESMTP id D0FFE2965;\n\tFri, 29 Mar 2019 17:39:29 +0100 (CET)", "from orsmga004.jf.intel.com ([10.7.209.38])\n\tby orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t29 Mar 2019 09:39:28 -0700", "from silpixa00399952.ir.intel.com (HELO\n\tsilpixa00399952.ger.corp.intel.com) ([10.237.223.64])\n\tby orsmga004.jf.intel.com with ESMTP; 29 Mar 2019 09:39:27 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.60,285,1549958400\"; d=\"scan'208\";a=\"287052957\"", "From": "David Hunt <david.hunt@intel.com>", "To": "dev@dpdk.org", "Cc": "david.hunt@intel.com,\n\tanatoly.burakov@intel.com,\n\tstable@dpdk.org", "Date": "Fri, 29 Mar 2019 16:39:20 +0000", "Message-Id": "<20190329163920.40415-1-david.hunt@intel.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20190329161142.39787-1-david.hunt@intel.com>", "References": "<20190329161142.39787-1-david.hunt@intel.com>", "Subject": "[dpdk-dev] [PATCH v2] lib/power: fix governor storage to trim\n\tnewlines", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Currently the Power Libray stores the governor name with an embedded\nnewline read from the scaling_governor sysfs file. This patch strips\nit out.\n\nFixes: 445c6528b55f (\"power: common interface for guest and host\")\nCc: stable@dpdk.org\n\nSigned-off-by: David Hunt <david.hunt@intel.com>\n---\n lib/librte_power/power_acpi_cpufreq.c | 2 ++\n lib/librte_power/power_pstate_cpufreq.c | 2 ++\n 2 files changed, 4 insertions(+)", "diff": "diff --git a/lib/librte_power/power_acpi_cpufreq.c b/lib/librte_power/power_acpi_cpufreq.c\nindex 45412f0b9..cdcb1f613 100644\n--- a/lib/librte_power/power_acpi_cpufreq.c\n+++ b/lib/librte_power/power_acpi_cpufreq.c\n@@ -147,6 +147,8 @@ power_set_governor_userspace(struct rte_power_info *pi)\n \n \ts = fgets(buf, sizeof(buf), f);\n \tFOPS_OR_NULL_GOTO(s, out);\n+\t/* Strip off terminating '\\n' */\n+\tstrtok(buf, \"\\n\");\n \n \t/* Check if current governor is userspace */\n \tif (strncmp(buf, POWER_GOVERNOR_USERSPACE,\ndiff --git a/lib/librte_power/power_pstate_cpufreq.c b/lib/librte_power/power_pstate_cpufreq.c\nindex 9c1a1625f..3e04e8040 100644\n--- a/lib/librte_power/power_pstate_cpufreq.c\n+++ b/lib/librte_power/power_pstate_cpufreq.c\n@@ -292,6 +292,8 @@ power_set_governor_performance(struct pstate_power_info *pi)\n \n \ts = fgets(buf, sizeof(buf), f);\n \tFOPS_OR_NULL_GOTO(s, out);\n+\t/* Strip off terminating '\\n' */\n+\tstrtok(buf, \"\\n\");\n \n \t/* Check if current governor is performance */\n \tif (strncmp(buf, POWER_GOVERNOR_PERF,\n", "prefixes": [ "v2" ] }{ "id": 51928, "url": "