Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/51979/?format=api
http://patchwork.dpdk.org/api/patches/51979/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20190401125656.7636-4-konstantin.ananyev@intel.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190401125656.7636-4-konstantin.ananyev@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20190401125656.7636-4-konstantin.ananyev@intel.com", "date": "2019-04-01T12:56:50", "name": "[v5,3/9] ipsec: change the order in filling crypto op", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "8ec3031461d0b60ce29cfe552f5b1465128ab7ce", "submitter": { "id": 33, "url": "http://patchwork.dpdk.org/api/people/33/?format=api", "name": "Ananyev, Konstantin", "email": "konstantin.ananyev@intel.com" }, "delegate": { "id": 6690, "url": "http://patchwork.dpdk.org/api/users/6690/?format=api", "username": "akhil", "first_name": "akhil", "last_name": "goyal", "email": "gakhil@marvell.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20190401125656.7636-4-konstantin.ananyev@intel.com/mbox/", "series": [ { "id": 4024, "url": "http://patchwork.dpdk.org/api/series/4024/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=4024", "date": "2019-04-01T12:56:47", "name": "Few small improvements for ipsec library", "version": 5, "mbox": "http://patchwork.dpdk.org/series/4024/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/51979/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/51979/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id E35204CAB;\n\tMon, 1 Apr 2019 14:57:25 +0200 (CEST)", "from mga01.intel.com (mga01.intel.com [192.55.52.88])\n\tby dpdk.org (Postfix) with ESMTP id EA5934C91\n\tfor <dev@dpdk.org>; Mon, 1 Apr 2019 14:57:22 +0200 (CEST)", "from fmsmga008.fm.intel.com ([10.253.24.58])\n\tby fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t01 Apr 2019 05:57:22 -0700", "from sivswdev08.ir.intel.com ([10.237.217.47])\n\tby fmsmga008.fm.intel.com with ESMTP; 01 Apr 2019 05:57:21 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.60,296,1549958400\"; d=\"scan'208\";a=\"136564322\"", "From": "Konstantin Ananyev <konstantin.ananyev@intel.com>", "To": "dev@dpdk.org", "Cc": "akhil.goyal@nxp.com, olivier.matz@6wind.com,\n\tKonstantin Ananyev <konstantin.ananyev@intel.com>", "Date": "Mon, 1 Apr 2019 13:56:50 +0100", "Message-Id": "<20190401125656.7636-4-konstantin.ananyev@intel.com>", "X-Mailer": "git-send-email 2.18.0", "In-Reply-To": "<20190401125656.7636-1-konstantin.ananyev@intel.com>", "References": "<20190329102726.27716-1-konstantin.ananyev@intel.com>\n\t<20190401125656.7636-1-konstantin.ananyev@intel.com>", "Subject": "[dpdk-dev] [PATCH v5 3/9] ipsec: change the order in filling crypto\n\top", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Right now we first fill crypto_sym_op part of crypto_op,\nthen in a separate cycle we fill crypto op fields.\nIt makes more sense to fill whole crypto-op in one go instead.\n\nSigned-off-by: Konstantin Ananyev <konstantin.ananyev@intel.com>\nAcked-by: Akhil Goyal <akhil.goyal@nxp.com>\n---\n lib/librte_ipsec/sa.c | 46 ++++++++++++++++++++-----------------------\n 1 file changed, 21 insertions(+), 25 deletions(-)", "diff": "diff --git a/lib/librte_ipsec/sa.c b/lib/librte_ipsec/sa.c\nindex 747c37002..97c0f8c61 100644\n--- a/lib/librte_ipsec/sa.c\n+++ b/lib/librte_ipsec/sa.c\n@@ -464,20 +464,17 @@ mbuf_bulk_copy(struct rte_mbuf *dst[], struct rte_mbuf * const src[],\n * setup crypto ops for LOOKASIDE_NONE (pure crypto) type of devices.\n */\n static inline void\n-lksd_none_cop_prepare(const struct rte_ipsec_session *ss,\n-\tstruct rte_mbuf *mb[], struct rte_crypto_op *cop[], uint16_t num)\n+lksd_none_cop_prepare(struct rte_crypto_op *cop,\n+\tstruct rte_cryptodev_sym_session *cs, struct rte_mbuf *mb)\n {\n-\tuint32_t i;\n \tstruct rte_crypto_sym_op *sop;\n \n-\tfor (i = 0; i != num; i++) {\n-\t\tsop = cop[i]->sym;\n-\t\tcop[i]->type = RTE_CRYPTO_OP_TYPE_SYMMETRIC;\n-\t\tcop[i]->status = RTE_CRYPTO_OP_STATUS_NOT_PROCESSED;\n-\t\tcop[i]->sess_type = RTE_CRYPTO_OP_WITH_SESSION;\n-\t\tsop->m_src = mb[i];\n-\t\t__rte_crypto_sym_op_attach_sym_session(sop, ss->crypto.ses);\n-\t}\n+\tsop = cop->sym;\n+\tcop->type = RTE_CRYPTO_OP_TYPE_SYMMETRIC;\n+\tcop->status = RTE_CRYPTO_OP_STATUS_NOT_PROCESSED;\n+\tcop->sess_type = RTE_CRYPTO_OP_WITH_SESSION;\n+\tsop->m_src = mb;\n+\t__rte_crypto_sym_op_attach_sym_session(sop, cs);\n }\n \n /*\n@@ -667,11 +664,13 @@ outb_tun_prepare(const struct rte_ipsec_session *ss, struct rte_mbuf *mb[],\n \tuint64_t sqn;\n \trte_be64_t sqc;\n \tstruct rte_ipsec_sa *sa;\n+\tstruct rte_cryptodev_sym_session *cs;\n \tunion sym_op_data icv;\n \tuint64_t iv[IPSEC_MAX_IV_QWORD];\n \tstruct rte_mbuf *dr[num];\n \n \tsa = ss->sa;\n+\tcs = ss->crypto.ses;\n \n \tn = num;\n \tsqn = esn_outb_update_sqn(sa, &n);\n@@ -689,10 +688,10 @@ outb_tun_prepare(const struct rte_ipsec_session *ss, struct rte_mbuf *mb[],\n \n \t\t/* success, setup crypto op */\n \t\tif (rc >= 0) {\n-\t\t\tmb[k] = mb[i];\n \t\t\toutb_pkt_xprepare(sa, sqc, &icv);\n+\t\t\tlksd_none_cop_prepare(cop[k], cs, mb[i]);\n \t\t\tesp_outb_cop_prepare(cop[k], sa, iv, &icv, 0, rc);\n-\t\t\tk++;\n+\t\t\tmb[k++] = mb[i];\n \t\t/* failure, put packet into the death-row */\n \t\t} else {\n \t\t\tdr[i - k] = mb[i];\n@@ -700,9 +699,6 @@ outb_tun_prepare(const struct rte_ipsec_session *ss, struct rte_mbuf *mb[],\n \t\t}\n \t}\n \n-\t/* update cops */\n-\tlksd_none_cop_prepare(ss, mb, cop, k);\n-\n \t /* copy not prepared mbufs beyond good ones */\n \tif (k != n && k != 0)\n \t\tmbuf_bulk_copy(mb + k, dr, n - k);\n@@ -803,11 +799,13 @@ outb_trs_prepare(const struct rte_ipsec_session *ss, struct rte_mbuf *mb[],\n \tuint64_t sqn;\n \trte_be64_t sqc;\n \tstruct rte_ipsec_sa *sa;\n+\tstruct rte_cryptodev_sym_session *cs;\n \tunion sym_op_data icv;\n \tuint64_t iv[IPSEC_MAX_IV_QWORD];\n \tstruct rte_mbuf *dr[num];\n \n \tsa = ss->sa;\n+\tcs = ss->crypto.ses;\n \n \tn = num;\n \tsqn = esn_outb_update_sqn(sa, &n);\n@@ -829,10 +827,10 @@ outb_trs_prepare(const struct rte_ipsec_session *ss, struct rte_mbuf *mb[],\n \n \t\t/* success, setup crypto op */\n \t\tif (rc >= 0) {\n-\t\t\tmb[k] = mb[i];\n \t\t\toutb_pkt_xprepare(sa, sqc, &icv);\n+\t\t\tlksd_none_cop_prepare(cop[k], cs, mb[i]);\n \t\t\tesp_outb_cop_prepare(cop[k], sa, iv, &icv, l2 + l3, rc);\n-\t\t\tk++;\n+\t\t\tmb[k++] = mb[i];\n \t\t/* failure, put packet into the death-row */\n \t\t} else {\n \t\t\tdr[i - k] = mb[i];\n@@ -840,9 +838,6 @@ outb_trs_prepare(const struct rte_ipsec_session *ss, struct rte_mbuf *mb[],\n \t\t}\n \t}\n \n-\t/* update cops */\n-\tlksd_none_cop_prepare(ss, mb, cop, k);\n-\n \t/* copy not prepared mbufs beyond good ones */\n \tif (k != n && k != 0)\n \t\tmbuf_bulk_copy(mb + k, dr, n - k);\n@@ -1021,11 +1016,13 @@ inb_pkt_prepare(const struct rte_ipsec_session *ss, struct rte_mbuf *mb[],\n \tint32_t rc;\n \tuint32_t i, k, hl;\n \tstruct rte_ipsec_sa *sa;\n+\tstruct rte_cryptodev_sym_session *cs;\n \tstruct replay_sqn *rsn;\n \tunion sym_op_data icv;\n \tstruct rte_mbuf *dr[num];\n \n \tsa = ss->sa;\n+\tcs = ss->crypto.ses;\n \trsn = rsn_acquire(sa);\n \n \tk = 0;\n@@ -1033,9 +1030,11 @@ inb_pkt_prepare(const struct rte_ipsec_session *ss, struct rte_mbuf *mb[],\n \n \t\thl = mb[i]->l2_len + mb[i]->l3_len;\n \t\trc = esp_inb_tun_pkt_prepare(sa, rsn, mb[i], hl, &icv);\n-\t\tif (rc >= 0)\n+\t\tif (rc >= 0) {\n+\t\t\tlksd_none_cop_prepare(cop[k], cs, mb[i]);\n \t\t\trc = esp_inb_tun_cop_prepare(cop[k], sa, mb[i], &icv,\n \t\t\t\thl, rc);\n+\t\t}\n \n \t\tif (rc == 0)\n \t\t\tmb[k++] = mb[i];\n@@ -1047,9 +1046,6 @@ inb_pkt_prepare(const struct rte_ipsec_session *ss, struct rte_mbuf *mb[],\n \n \trsn_release(sa, rsn);\n \n-\t/* update cops */\n-\tlksd_none_cop_prepare(ss, mb, cop, k);\n-\n \t/* copy not prepared mbufs beyond good ones */\n \tif (k != num && k != 0)\n \t\tmbuf_bulk_copy(mb + k, dr, num - k);\n", "prefixes": [ "v5", "3/9" ] }{ "id": 51979, "url": "