Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/52574/?format=api
{ "id": 52574, "url": "http://patchwork.dpdk.org/api/patches/52574/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/f3dd0dfabcab5077e6b21cf210fad3d1029c3731.1554894242.git.igor.russkikh@aquantia.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<f3dd0dfabcab5077e6b21cf210fad3d1029c3731.1554894242.git.igor.russkikh@aquantia.com>", "list_archive_url": "https://inbox.dpdk.org/dev/f3dd0dfabcab5077e6b21cf210fad3d1029c3731.1554894242.git.igor.russkikh@aquantia.com", "date": "2019-04-10T11:19:10", "name": "[08/10] net/atlantic: implement macsec statistics", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "e9f4c9992637e1ab778d9d9c5b6b5a9fed20a512", "submitter": { "id": 1124, "url": "http://patchwork.dpdk.org/api/people/1124/?format=api", "name": "Igor Russkikh", "email": "igor.russkikh@aquantia.com" }, "delegate": { "id": 319, "url": "http://patchwork.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/f3dd0dfabcab5077e6b21cf210fad3d1029c3731.1554894242.git.igor.russkikh@aquantia.com/mbox/", "series": [ { "id": 4234, "url": "http://patchwork.dpdk.org/api/series/4234/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=4234", "date": "2019-04-10T11:18:35", "name": "add MACSEC hw offload to atlantic PMD", "version": 1, "mbox": "http://patchwork.dpdk.org/series/4234/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/52574/comments/", "check": "warning", "checks": "http://patchwork.dpdk.org/api/patches/52574/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id CBE8069D4;\n\tWed, 10 Apr 2019 13:19:14 +0200 (CEST)", "from NAM03-CO1-obe.outbound.protection.outlook.com\n\t(mail-eopbgr790058.outbound.protection.outlook.com [40.107.79.58])\n\tby dpdk.org (Postfix) with ESMTP id B94936904\n\tfor <dev@dpdk.org>; Wed, 10 Apr 2019 13:19:12 +0200 (CEST)", "from BN8PR11MB3618.namprd11.prod.outlook.com (20.178.219.85) by\n\tBN8PR11MB3540.namprd11.prod.outlook.com (20.178.218.78) with\n\tMicrosoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n\t15.20.1771.21; Wed, 10 Apr 2019 11:19:11 +0000", "from BN8PR11MB3618.namprd11.prod.outlook.com\n\t([fe80::9d38:1845:842d:a489]) by\n\tBN8PR11MB3618.namprd11.prod.outlook.com\n\t([fe80::9d38:1845:842d:a489%3]) with mapi id 15.20.1771.016;\n\tWed, 10 Apr 2019 11:19:11 +0000" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=AQUANTIA1COM.onmicrosoft.com; s=selector1-aquantia-com;\n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n\tbh=zUdD0xlwxJqxhsANchdPnsSpb5XueKDnJDs3SWLIyeI=;\n\tb=Q25M9O920y/Y73oLpub7B6Pp+suirJKFCkXWSbVVys6TqFlVgNf7dlo7BHbZC9jeJ/riTiv7hOaxT14XNsJaU/Bp+zun5vc/6HsTv/M5YQAsU+OmCLJDd0gGBrOol2flVEm5LQUn3KVHgH8iRD9/6FYXmyNIw9C8DKbpihqEcvA=", "From": "Igor Russkikh <Igor.Russkikh@aquantia.com>", "To": "\"dev@dpdk.org\" <dev@dpdk.org>", "CC": "Pavel Belous <Pavel.Belous@aquantia.com>, Wenzhuo Lu\n\t<wenzhuo.lu@intel.com>, Jingjing Wu <jingjing.wu@intel.com>, Bernard\n\tIremonger <bernard.iremonger@intel.com>, John McNamara\n\t<john.mcnamara@intel.com>, Marko Kovacevic <marko.kovacevic@intel.com>,\n\tKonstantin Ananyev <konstantin.ananyev@intel.com>, Thomas Monjalon\n\t<thomas@monjalon.net>, Ferruh Yigit <ferruh.yigit@intel.com>, Andrew\n\tRybchenko <arybchenko@solarflare.com>, Igor Russkikh\n\t<Igor.Russkikh@aquantia.com>", "Thread-Topic": "[PATCH 08/10] net/atlantic: implement macsec statistics", "Thread-Index": "AQHU7484q6ACtC8G9k6GdvkqdWVZ5w==", "Date": "Wed, 10 Apr 2019 11:19:10 +0000", "Message-ID": "<f3dd0dfabcab5077e6b21cf210fad3d1029c3731.1554894242.git.igor.russkikh@aquantia.com>", "References": "<cover.1554894242.git.igor.russkikh@aquantia.com>", "In-Reply-To": "<cover.1554894242.git.igor.russkikh@aquantia.com>", "Accept-Language": "en-US", "Content-Language": "en-US", "X-MS-Has-Attach": "", "X-MS-TNEF-Correlator": "", "x-clientproxiedby": "BYAPR05CA0061.namprd05.prod.outlook.com\n\t(2603:10b6:a03:74::38) To BN8PR11MB3618.namprd11.prod.outlook.com\n\t(2603:10b6:408:85::21)", "authentication-results": "spf=none (sender IP is )\n\tsmtp.mailfrom=Igor.Russkikh@aquantia.com; ", "x-ms-exchange-messagesentrepresentingtype": "1", "x-mailer": "git-send-email 2.17.1", "x-originating-ip": "[95.79.108.179]", "x-ms-publictraffictype": "Email", "x-ms-office365-filtering-correlation-id": "9daf6084-5b5b-42f6-bff0-08d6bda65ae3", "x-microsoft-antispam": "BCL:0; PCL:0;\n\tRULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600139)(711020)(4605104)(2017052603328)(7193020);\n\tSRVR:BN8PR11MB3540; ", "x-ms-traffictypediagnostic": "BN8PR11MB3540:", "x-microsoft-antispam-prvs": "<BN8PR11MB3540E8C04F29D18F07AD1354982E0@BN8PR11MB3540.namprd11.prod.outlook.com>", "x-forefront-prvs": "00032065B2", "x-forefront-antispam-report": "SFV:NSPM;\n\tSFS:(10009020)(396003)(39850400004)(376002)(366004)(136003)(346002)(199004)(189003)(486006)(107886003)(6506007)(316002)(2616005)(386003)(54906003)(7416002)(53936002)(8936002)(68736007)(446003)(6916009)(476003)(72206003)(2501003)(105586002)(11346002)(44832011)(99286004)(2351001)(52116002)(186003)(26005)(118296001)(106356001)(14454004)(102836004)(76176011)(71200400001)(81156014)(7736002)(14444005)(8676002)(81166006)(25786009)(256004)(6116002)(5660300002)(71190400001)(1730700003)(5640700003)(2906002)(66066001)(6512007)(478600001)(6486002)(50226002)(305945005)(97736004)(4326008)(3846002)(36756003)(6436002)(86362001);\n\tDIR:OUT; SFP:1101; SCL:1; SRVR:BN8PR11MB3540;\n\tH:BN8PR11MB3618.namprd11.prod.outlook.com; FPR:; SPF:None; LANG:en;\n\tPTR:InfoNoRecords; A:1; MX:1; ", "received-spf": "None (protection.outlook.com: aquantia.com does not designate\n\tpermitted sender hosts)", "x-ms-exchange-senderadcheck": "1", "x-microsoft-antispam-message-info": "qF1aWz/kpEPogmjuvhqWoZu9q62fLqTgFksrol9+lR3b7m57ZI6pRXjiJ7gA6qtbjCwOZAYUNnEVnOrY4VuWmUP2nnmGIV6EZtkmgs2G8uKnvz/elbTKjSFZrp9S7HCCVWrrKLifIftqYAIv0c8rcedE4eg/cKpSCfs7YV9YuL2TON7OXsMF2gjgQhan50SuLvzRuacKWDsBNMzxHhlXoXaBJ6uCYVTQGtjEE+kVFaD84fGYjckFcEJpEqlYSaP/6BdKTNi0iQDu3e4Dkx5tNm6LsPLe+WEg+uFPd+CH8/8fzlsvVpUIsotSEG3sf6L+P87JH6RC22Ej5jZ9xsOGSDnPy89+SH9/uFcmtI5CYV5TkpHTTny1nEgYmlVgupG1qvuQoXyIKLmcFEVwyBxAgaiETeyJk74PUymdz3o+nmY=", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "base64", "MIME-Version": "1.0", "X-OriginatorOrg": "aquantia.com", "X-MS-Exchange-CrossTenant-Network-Message-Id": "9daf6084-5b5b-42f6-bff0-08d6bda65ae3", "X-MS-Exchange-CrossTenant-originalarrivaltime": "10 Apr 2019 11:19:10.9682\n\t(UTC)", "X-MS-Exchange-CrossTenant-fromentityheader": "Hosted", "X-MS-Exchange-CrossTenant-id": "83e2e134-991c-4ede-8ced-34d47e38e6b1", "X-MS-Exchange-CrossTenant-mailboxtype": "HOSTED", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "BN8PR11MB3540", "Subject": "[dpdk-dev] [PATCH 08/10] net/atlantic: implement macsec statistics", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Pavel Belous <pavel.belous@aquantia.com>\n\nWe add extra xstat fields to include macsec counters and stats\n\nSigned-off-by: Pavel Belous <pavel.belous@aquantia.com>\nSigned-off-by: Igor Russkikh <igor.russkikh@aquantia.com>\n---\n drivers/net/atlantic/atl_ethdev.c | 82 +++++++++++++++++++++++++++++--\n 1 file changed, 77 insertions(+), 5 deletions(-)", "diff": "diff --git a/drivers/net/atlantic/atl_ethdev.c b/drivers/net/atlantic/atl_ethdev.c\r\nindex 4a6975dcf104..439a165664af 100644\r\n--- a/drivers/net/atlantic/atl_ethdev.c\r\n+++ b/drivers/net/atlantic/atl_ethdev.c\r\n@@ -205,14 +205,27 @@ static const struct rte_eth_desc_lim tx_desc_lim = {\r\n \t.nb_mtu_seg_max = ATL_TX_MAX_SEG,\r\n };\r\n \r\n+enum atl_xstats_type {\r\n+\tXSTATS_TYPE_MSM = 0,\r\n+\tXSTATS_TYPE_MACSEC,\r\n+};\r\n+\r\n #define ATL_XSTATS_FIELD(name) { \\\r\n \t#name, \\\r\n-\toffsetof(struct aq_stats_s, name) \\\r\n+\toffsetof(struct aq_stats_s, name), \\\r\n+\tXSTATS_TYPE_MSM \\\r\n+}\r\n+\r\n+#define ATL_MACSEC_XSTATS_FIELD(name) { \\\r\n+\t#name, \\\r\n+\toffsetof(struct macsec_stats, name), \\\r\n+\tXSTATS_TYPE_MACSEC \\\r\n }\r\n \r\n struct atl_xstats_tbl_s {\r\n \tconst char *name;\r\n \tunsigned int offset;\r\n+\tenum atl_xstats_type type;\r\n };\r\n \r\n static struct atl_xstats_tbl_s atl_xstats_tbl[] = {\r\n@@ -230,6 +243,38 @@ static struct atl_xstats_tbl_s atl_xstats_tbl[] = {\r\n \tATL_XSTATS_FIELD(mbtc),\r\n \tATL_XSTATS_FIELD(bbrc),\r\n \tATL_XSTATS_FIELD(bbtc),\r\n+\t/* Ingress Common Counters */\r\n+\tATL_MACSEC_XSTATS_FIELD(in_ctl_pkts),\r\n+\tATL_MACSEC_XSTATS_FIELD(in_tagged_miss_pkts),\r\n+\tATL_MACSEC_XSTATS_FIELD(in_untagged_miss_pkts),\r\n+\tATL_MACSEC_XSTATS_FIELD(in_notag_pkts),\r\n+\tATL_MACSEC_XSTATS_FIELD(in_untagged_pkts),\r\n+\tATL_MACSEC_XSTATS_FIELD(in_bad_tag_pkts),\r\n+\tATL_MACSEC_XSTATS_FIELD(in_no_sci_pkts),\r\n+\tATL_MACSEC_XSTATS_FIELD(in_unknown_sci_pkts),\r\n+\t/* Ingress SA Counters */\r\n+\tATL_MACSEC_XSTATS_FIELD(in_untagged_hit_pkts),\r\n+\tATL_MACSEC_XSTATS_FIELD(in_not_using_sa),\r\n+\tATL_MACSEC_XSTATS_FIELD(in_unused_sa),\r\n+\tATL_MACSEC_XSTATS_FIELD(in_not_valid_pkts),\r\n+\tATL_MACSEC_XSTATS_FIELD(in_invalid_pkts),\r\n+\tATL_MACSEC_XSTATS_FIELD(in_ok_pkts),\r\n+\tATL_MACSEC_XSTATS_FIELD(in_unchecked_pkts),\r\n+\tATL_MACSEC_XSTATS_FIELD(in_validated_octets),\r\n+\tATL_MACSEC_XSTATS_FIELD(in_decrypted_octets),\r\n+\t/* Egress Common Counters */\r\n+\tATL_MACSEC_XSTATS_FIELD(out_ctl_pkts),\r\n+\tATL_MACSEC_XSTATS_FIELD(out_unknown_sa_pkts),\r\n+\tATL_MACSEC_XSTATS_FIELD(out_untagged_pkts),\r\n+\tATL_MACSEC_XSTATS_FIELD(out_too_long),\r\n+\t/* Egress SC Counters */\r\n+\tATL_MACSEC_XSTATS_FIELD(out_sc_protected_pkts),\r\n+\tATL_MACSEC_XSTATS_FIELD(out_sc_encrypted_pkts),\r\n+\t/* Egress SA Counters */\r\n+\tATL_MACSEC_XSTATS_FIELD(out_sa_hit_drop_redirect),\r\n+\tATL_MACSEC_XSTATS_FIELD(out_sa_protected2_pkts),\r\n+\tATL_MACSEC_XSTATS_FIELD(out_sa_protected_pkts),\r\n+\tATL_MACSEC_XSTATS_FIELD(out_sa_encrypted_pkts),\r\n };\r\n \r\n static const struct eth_dev_ops atl_eth_dev_ops = {\r\n@@ -987,19 +1032,46 @@ static int\r\n atl_dev_xstats_get(struct rte_eth_dev *dev, struct rte_eth_xstat *stats,\r\n \t\t unsigned int n)\r\n {\r\n-\tstruct atl_adapter *adapter = ATL_DEV_TO_ADAPTER(dev);\r\n+\tstruct atl_adapter *adapter =\r\n+\t(struct atl_adapter *)dev->data->dev_private;\r\n \tstruct aq_hw_s *hw = &adapter->hw;\r\n+\tstruct get_stats req = { 0 };\r\n+\tstruct macsec_msg_fw_request msg = { 0 };\r\n+\tstruct macsec_msg_fw_response resp = { 0 };\r\n+\tint err = -1;\r\n \tunsigned int i;\r\n \r\n \tif (!stats)\r\n \t\treturn 0;\r\n \r\n+\tif (hw->aq_fw_ops->send_macsec_req != NULL) {\r\n+\t\treq.ingress_sa_index = 0xff;\r\n+\t\treq.egress_sc_index = 0xff;\r\n+\t\treq.egress_sa_index = 0xff;\r\n+\r\n+\t\tmsg.msg_type = macsec_get_stats_msg;\r\n+\t\tmsg.stats = req;\r\n+\r\n+\t\terr = hw->aq_fw_ops->send_macsec_req(hw, &msg, &resp);\r\n+\t}\r\n+\r\n \tfor (i = 0; i < n && i < RTE_DIM(atl_xstats_tbl); i++) {\r\n \t\tstats[i].id = i;\r\n-\t\tstats[i].value = *(u64 *)((uint8_t *)&hw->curr_stats +\r\n-\t\t\t\t\tatl_xstats_tbl[i].offset);\r\n-\t}\r\n \r\n+\t\tswitch (atl_xstats_tbl[i].type) {\r\n+\t\tcase XSTATS_TYPE_MSM:\r\n+\t\t\tstats[i].value = *(u64 *)((uint8_t *)&hw->curr_stats +\r\n+\t\t\t\t\t atl_xstats_tbl[i].offset);\r\n+\t\t\tbreak;\r\n+\t\tcase XSTATS_TYPE_MACSEC:\r\n+\t\t\tif (err)\r\n+\t\t\t\tgoto done;\r\n+\t\t\tstats[i].value = *(u64 *)((uint8_t *)&resp.stats +\r\n+\t\t\t\t\t atl_xstats_tbl[i].offset);\r\n+\t\t\tbreak;\r\n+\t\t}\r\n+\t}\r\n+done:\r\n \treturn i;\r\n }\r\n \r\n", "prefixes": [ "08/10" ] }