Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/52601/?format=api
{ "id": 52601, "url": "http://patchwork.dpdk.org/api/patches/52601/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20190410140058.26782-2-ferruh.yigit@intel.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190410140058.26782-2-ferruh.yigit@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20190410140058.26782-2-ferruh.yigit@intel.com", "date": "2019-04-10T14:00:58", "name": "[2/2] build: fix crash by disabling AVX512 with binutils 2.31", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "a597fc07f9dd07fd4ac6a08defc01d98f6618627", "submitter": { "id": 324, "url": "http://patchwork.dpdk.org/api/people/324/?format=api", "name": "Ferruh Yigit", "email": "ferruh.yigit@intel.com" }, "delegate": { "id": 1, "url": "http://patchwork.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20190410140058.26782-2-ferruh.yigit@intel.com/mbox/", "series": [ { "id": 4243, "url": "http://patchwork.dpdk.org/api/series/4243/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=4243", "date": "2019-04-10T14:00:57", "name": "[1/2] build: fix meson binutils workaround", "version": 1, "mbox": "http://patchwork.dpdk.org/series/4243/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/52601/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/52601/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id F27A01B138;\n\tWed, 10 Apr 2019 16:01:10 +0200 (CEST)", "from mga07.intel.com (mga07.intel.com [134.134.136.100])\n\tby dpdk.org (Postfix) with ESMTP id 22F111B119;\n\tWed, 10 Apr 2019 16:01:05 +0200 (CEST)", "from orsmga003.jf.intel.com ([10.7.209.27])\n\tby orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t10 Apr 2019 07:01:05 -0700", "from silpixa00399752.ir.intel.com (HELO\n\tsilpixa00399752.ger.corp.intel.com) ([10.237.222.212])\n\tby orsmga003.jf.intel.com with ESMTP; 10 Apr 2019 07:01:04 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.60,332,1549958400\"; d=\"scan'208\";a=\"141574414\"", "From": "Ferruh Yigit <ferruh.yigit@intel.com>", "To": "Thomas Monjalon <thomas@monjalon.net>", "Cc": "dev@dpdk.org,\n\tstable@dpdk.org", "Date": "Wed, 10 Apr 2019 15:00:58 +0100", "Message-Id": "<20190410140058.26782-2-ferruh.yigit@intel.com>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20190410140058.26782-1-ferruh.yigit@intel.com>", "References": "<20190410140058.26782-1-ferruh.yigit@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH 2/2] build: fix crash by disabling AVX512 with\n\tbinutils 2.31", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "On Skylake platform, with native build, KNI kernel module crashes\nbecause of the corrupted values passed to kernel module.\n\nThe corruption occurs because the userspace kni library works\nunexpectedly. Compiler [1] is using AVX512 instructions and generated\nbinary is wrong [2].\n\nIt turned around gcc does its job correct, but gas is generating binary\nwrong. And expected binutils 2.30, 2.31 & 2.31.1 are affected. Issue has\nbeen fixed in binutils 2.32 with:\nCommit x86: don't mistakenly scale non-8-bit displacements\n\nAVX512 was already disabled with bintuils 2.30 [3], extending it to\n2.31 & 2.31.1 too.\n\n[1] gcc (GCC) 8.3.1 20190223 (Red Hat 8.3.1-2)\n\n[2] gcc bug: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=90028\n\n[3] Bugzilla ID 97 has the details.\n\nBugzilla ID: 249\nCc: stable@dpdk.org\n\nSigned-off-by: Ferruh Yigit <ferruh.yigit@intel.com>\n---\n config/x86/meson.build | 6 ++++++\n mk/toolchain/gcc/rte.toolchain-compat.mk | 9 ++++++++-\n 2 files changed, 14 insertions(+), 1 deletion(-)", "diff": "diff --git a/config/x86/meson.build b/config/x86/meson.build\nindex 692aebe7a..9e9d5dc8c 100644\n--- a/config/x86/meson.build\n+++ b/config/x86/meson.build\n@@ -10,6 +10,12 @@ if host_machine.system() != 'windows'\n \t\t\tmessage('Binutils 2.30 detected, disabling AVX512 support as workaround for bug #97')\n \t\tendif\n \tendif\n+\tif ldver.contains('2.31')\n+\t\tif cc.has_argument('-mno-avx512f')\n+\t\t\tmachine_args += '-mno-avx512f'\n+\t\t\tmessage('Binutils 2.31 detected, disabling AVX512 support as workaround for bug #249')\n+\t\tendif\n+\tendif\n endif\n \n # we require SSE4.2 for DPDK\ndiff --git a/mk/toolchain/gcc/rte.toolchain-compat.mk b/mk/toolchain/gcc/rte.toolchain-compat.mk\nindex df71e4a8b..ea40a11c0 100644\n--- a/mk/toolchain/gcc/rte.toolchain-compat.mk\n+++ b/mk/toolchain/gcc/rte.toolchain-compat.mk\n@@ -27,7 +27,14 @@ ifneq ($(filter 2.30%,$(LD_VERSION)),)\n FORCE_DISABLE_AVX512 := y\n # print warning only once for librte_eal\n ifneq ($(filter %librte_eal,$(CURDIR)),)\n-$(warning AVX512 support disabled because of ld 2.30. See Bug 97)\n+$(warning AVX512 support disabled because of binutils 2.30. See Bug 97)\n+endif\n+endif\n+ifneq ($(filter 2.31%,$(LD_VERSION)),)\n+FORCE_DISABLE_AVX512 := y\n+# print warning only once for librte_eal\n+ifneq ($(filter %librte_eal,$(CURDIR)),)\n+$(warning AVX512 support disabled because of binutils 2.31. See Bug 249)\n endif\n endif\n endif\n", "prefixes": [ "2/2" ] }