Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 52724,
    "url": "http://patchwork.dpdk.org/api/patches/52724/?format=api",
    "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/1555084091-24641-1-git-send-email-viacheslavo@mellanox.com/",
    "project": {
        "id": 1,
        "url": "http://patchwork.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<1555084091-24641-1-git-send-email-viacheslavo@mellanox.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/1555084091-24641-1-git-send-email-viacheslavo@mellanox.com",
    "date": "2019-04-12T15:48:11",
    "name": "[1/1] app/testpmd: fix port detach cleanup",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "6a435ad6127b8f355fb970a465e95505f3e11ceb",
    "submitter": {
        "id": 1102,
        "url": "http://patchwork.dpdk.org/api/people/1102/?format=api",
        "name": "Slava Ovsiienko",
        "email": "viacheslavo@mellanox.com"
    },
    "delegate": {
        "id": 319,
        "url": "http://patchwork.dpdk.org/api/users/319/?format=api",
        "username": "fyigit",
        "first_name": "Ferruh",
        "last_name": "Yigit",
        "email": "ferruh.yigit@amd.com"
    },
    "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/1555084091-24641-1-git-send-email-viacheslavo@mellanox.com/mbox/",
    "series": [
        {
            "id": 4291,
            "url": "http://patchwork.dpdk.org/api/series/4291/?format=api",
            "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=4291",
            "date": "2019-04-12T15:48:11",
            "name": "[1/1] app/testpmd: fix port detach cleanup",
            "version": 1,
            "mbox": "http://patchwork.dpdk.org/series/4291/mbox/"
        }
    ],
    "comments": "http://patchwork.dpdk.org/api/patches/52724/comments/",
    "check": "success",
    "checks": "http://patchwork.dpdk.org/api/patches/52724/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id C380C1B1F5;\n\tFri, 12 Apr 2019 17:48:18 +0200 (CEST)",
            "from mellanox.co.il (mail-il-dmz.mellanox.com [193.47.165.129])\n\tby dpdk.org (Postfix) with ESMTP id 61A9A1B1EB\n\tfor <dev@dpdk.org>; Fri, 12 Apr 2019 17:48:17 +0200 (CEST)",
            "from Internal Mail-Server by MTLPINE1 (envelope-from\n\tviacheslavo@mellanox.com)\n\twith ESMTPS (AES256-SHA encrypted); 12 Apr 2019 18:48:14 +0300",
            "from pegasus12.mtr.labs.mlnx. (pegasus12.mtr.labs.mlnx\n\t[10.210.17.40])\n\tby labmailer.mlnx (8.13.8/8.13.8) with ESMTP id x3CFmE1O018382;\n\tFri, 12 Apr 2019 18:48:14 +0300"
        ],
        "From": "Viacheslav Ovsiienko <viacheslavo@mellanox.com>",
        "To": "dev@dpdk.org",
        "Cc": "ferruh.yigit@intel.com",
        "Date": "Fri, 12 Apr 2019 15:48:11 +0000",
        "Message-Id": "<1555084091-24641-1-git-send-email-viacheslavo@mellanox.com>",
        "X-Mailer": "git-send-email 1.8.3.1",
        "Subject": "[dpdk-dev] [PATCH 1/1] app/testpmd: fix port detach cleanup",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "At port detach routine after calling the rte_dev_remove()\ntestpmd performs some cleanup, checking the statuses of\nremaining ports and closes the appropriate ones. The port\nscanning is based on the new sibling iterator which uses the\ninvalid (already closed) port for reference. This patch\nreplaces the foreach iterator and uses the device object for\nreference. It is worth to note this cleanup is not needed\nfor some drivers (at least for mlx5 and probably for others)\nand is preserved due to possible compatibility issues.\n\nFixes: 13302cd5bd63 (\"app/testpmd: use port sibling iterator in device cleanup\")\n\nSigned-off-by: Viacheslav Ovsiienko <viacheslavo@mellanox.com>\n---\n app/test-pmd/testpmd.c | 3 +--\n 1 file changed, 1 insertion(+), 2 deletions(-)",
    "diff": "diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c\nindex aeaa74c..739f96e 100644\n--- a/app/test-pmd/testpmd.c\n+++ b/app/test-pmd/testpmd.c\n@@ -2369,8 +2369,7 @@ struct extmem_param {\n \t\tTESTPMD_LOG(ERR, \"Failed to detach device %s\\n\", dev->name);\n \t\treturn;\n \t}\n-\n-\tRTE_ETH_FOREACH_DEV_SIBLING(sibling, port_id) {\n+\tRTE_ETH_FOREACH_DEV_OF(sibling, dev) {\n \t\t/* reset mapping between old ports and removed device */\n \t\trte_eth_devices[sibling].device = NULL;\n \t\tif (ports[sibling].port_status != RTE_PORT_CLOSED) {\n",
    "prefixes": [
        "1/1"
    ]
}