Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 5310,
    "url": "http://patchwork.dpdk.org/api/patches/5310/?format=api",
    "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/1433775616-6896-22-git-send-email-michalx.k.jastrzebski@intel.com/",
    "project": {
        "id": 1,
        "url": "http://patchwork.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<1433775616-6896-22-git-send-email-michalx.k.jastrzebski@intel.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/1433775616-6896-22-git-send-email-michalx.k.jastrzebski@intel.com",
    "date": "2015-06-08T15:00:12",
    "name": "[dpdk-dev,v4,07/10] table: added hash_key8 table stats",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "e93986a6c1b6c574018b233ca7247c3e1ed980c7",
    "submitter": {
        "id": 74,
        "url": "http://patchwork.dpdk.org/api/people/74/?format=api",
        "name": "Michal Jastrzebski",
        "email": "michalx.k.jastrzebski@intel.com"
    },
    "delegate": null,
    "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/1433775616-6896-22-git-send-email-michalx.k.jastrzebski@intel.com/mbox/",
    "series": [],
    "comments": "http://patchwork.dpdk.org/api/patches/5310/comments/",
    "check": "pending",
    "checks": "http://patchwork.dpdk.org/api/patches/5310/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 588E7C3D6;\n\tMon,  8 Jun 2015 17:06:12 +0200 (CEST)",
            "from mga01.intel.com (mga01.intel.com [192.55.52.88])\n\tby dpdk.org (Postfix) with ESMTP id E81F2C328\n\tfor <dev@dpdk.org>; Mon,  8 Jun 2015 17:06:09 +0200 (CEST)",
            "from orsmga002.jf.intel.com ([10.7.209.21])\n\tby fmsmga101.fm.intel.com with ESMTP; 08 Jun 2015 08:03:43 -0700",
            "from unknown (HELO Sent) ([10.217.248.178])\n\tby orsmga002.jf.intel.com with SMTP; 08 Jun 2015 08:03:40 -0700",
            "by Sent (sSMTP sendmail emulation); Mon, 08 Jun 2015 17:03:18 +0116"
        ],
        "X-ExtLoop1": "1",
        "X-IronPort-AV": "E=Sophos;i=\"5.13,574,1427785200\"; d=\"scan'208\";a=\"743026891\"",
        "From": "Michal Jastrzebski <michalx.k.jastrzebski@intel.com>",
        "To": "dev@dpdk.org",
        "Date": "Mon,  8 Jun 2015 17:00:12 +0200",
        "Message-Id": "<1433775616-6896-22-git-send-email-michalx.k.jastrzebski@intel.com>",
        "X-Mailer": "git-send-email 2.1.1",
        "In-Reply-To": "<1433775616-6896-1-git-send-email-michalx.k.jastrzebski@intel.com>",
        "References": "<1433775616-6896-1-git-send-email-michalx.k.jastrzebski@intel.com>",
        "Subject": "[dpdk-dev] [PATCH v4 07/10] table: added hash_key8 table stats",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "patches and discussions about DPDK <dev.dpdk.org>",
        "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "From: Maciej Gajdzica <maciejx.t.gajdzica@intel.com>\n\nAdded statistics for hash key8 table.\n\nSigned-off-by: Maciej Gajdzica <maciejx.t.gajdzica@intel.com>\n---\n lib/librte_table/rte_table_hash_key8.c |   52 ++++++++++++++++++++++++++++++++\n 1 file changed, 52 insertions(+)",
    "diff": "diff --git a/lib/librte_table/rte_table_hash_key8.c b/lib/librte_table/rte_table_hash_key8.c\nindex 6803eb2..374e3e3 100644\n--- a/lib/librte_table/rte_table_hash_key8.c\n+++ b/lib/librte_table/rte_table_hash_key8.c\n@@ -44,6 +44,20 @@\n \n #define RTE_TABLE_HASH_KEY_SIZE\t\t\t\t\t\t8\n \n+#ifdef RTE_TABLE_STATS_COLLECT\n+\n+#define RTE_TABLE_HASH_KEY8_STATS_PKTS_IN_ADD(table, val) \\\n+\ttable->stats.n_pkts_in += val\n+#define RTE_TABLE_HASH_KEY8_STATS_PKTS_LOOKUP_MISS(table, val) \\\n+\ttable->stats.n_pkts_lookup_miss += val\n+\n+#else\n+\n+#define RTE_TABLE_HASH_KEY8_STATS_PKTS_IN_ADD(table, val)\n+#define RTE_TABLE_HASH_KEY8_STATS_PKTS_LOOKUP_MISS(table, val)\n+\n+#endif\n+\n struct rte_bucket_4_8 {\n \t/* Cache line 0 */\n \tuint64_t signature;\n@@ -58,6 +72,8 @@ struct rte_bucket_4_8 {\n };\n \n struct rte_table_hash {\n+\tstruct rte_table_stats stats;\n+\n \t/* Input parameters */\n \tuint32_t n_buckets;\n \tuint32_t n_entries_per_bucket;\n@@ -846,6 +862,9 @@ rte_table_hash_lookup_key8_lru(\n \t\t\tpkt11_index, pkt20_index, pkt21_index;\n \tuint64_t pkts_mask_out = 0;\n \n+\t__rte_unused uint32_t n_pkts_in = __builtin_popcountll(pkts_mask);\n+\tRTE_TABLE_HASH_KEY8_STATS_PKTS_IN_ADD(f, n_pkts_in);\n+\n \t/* Cannot run the pipeline with less than 5 packets */\n \tif (__builtin_popcountll(pkts_mask) < 5) {\n \t\tfor ( ; pkts_mask; ) {\n@@ -860,6 +879,7 @@ rte_table_hash_lookup_key8_lru(\n \t\t}\n \n \t\t*lookup_hit_mask = pkts_mask_out;\n+\t\tRTE_TABLE_HASH_KEY8_STATS_PKTS_LOOKUP_MISS(f, n_pkts_in - __builtin_popcountll(pkts_mask_out));\n \t\treturn 0;\n \t}\n \n@@ -949,6 +969,7 @@ rte_table_hash_lookup_key8_lru(\n \t\tbucket20, bucket21, pkts_mask_out, entries, f);\n \n \t*lookup_hit_mask = pkts_mask_out;\n+\tRTE_TABLE_HASH_KEY8_STATS_PKTS_LOOKUP_MISS(f, n_pkts_in - __builtin_popcountll(pkts_mask_out));\n \treturn 0;\n } /* rte_table_hash_lookup_key8_lru() */\n \n@@ -967,6 +988,9 @@ rte_table_hash_lookup_key8_lru_dosig(\n \tuint32_t pkt11_index, pkt20_index, pkt21_index;\n \tuint64_t pkts_mask_out = 0;\n \n+\t__rte_unused uint32_t n_pkts_in = __builtin_popcountll(pkts_mask);\n+\tRTE_TABLE_HASH_KEY8_STATS_PKTS_IN_ADD(f, n_pkts_in);\n+\n \t/* Cannot run the pipeline with less than 5 packets */\n \tif (__builtin_popcountll(pkts_mask) < 5) {\n \t\tfor ( ; pkts_mask; ) {\n@@ -981,6 +1005,7 @@ rte_table_hash_lookup_key8_lru_dosig(\n \t\t}\n \n \t\t*lookup_hit_mask = pkts_mask_out;\n+\t\tRTE_TABLE_HASH_KEY8_STATS_PKTS_LOOKUP_MISS(f, n_pkts_in - __builtin_popcountll(pkts_mask_out));\n \t\treturn 0;\n \t}\n \n@@ -1070,6 +1095,7 @@ rte_table_hash_lookup_key8_lru_dosig(\n \t\tbucket20, bucket21, pkts_mask_out, entries, f);\n \n \t*lookup_hit_mask = pkts_mask_out;\n+\tRTE_TABLE_HASH_KEY8_STATS_PKTS_LOOKUP_MISS(f, n_pkts_in - __builtin_popcountll(pkts_mask_out));\n \treturn 0;\n } /* rte_table_hash_lookup_key8_lru_dosig() */\n \n@@ -1090,6 +1116,9 @@ rte_table_hash_lookup_key8_ext(\n \tstruct rte_bucket_4_8 *buckets[RTE_PORT_IN_BURST_SIZE_MAX];\n \tuint64_t *keys[RTE_PORT_IN_BURST_SIZE_MAX];\n \n+\t__rte_unused uint32_t n_pkts_in = __builtin_popcountll(pkts_mask);\n+\tRTE_TABLE_HASH_KEY8_STATS_PKTS_IN_ADD(f, n_pkts_in);\n+\n \t/* Cannot run the pipeline with less than 5 packets */\n \tif (__builtin_popcountll(pkts_mask) < 5) {\n \t\tfor ( ; pkts_mask; ) {\n@@ -1216,6 +1245,7 @@ grind_next_buckets:\n \t}\n \n \t*lookup_hit_mask = pkts_mask_out;\n+\tRTE_TABLE_HASH_KEY8_STATS_PKTS_LOOKUP_MISS(f, n_pkts_in - __builtin_popcountll(pkts_mask_out));\n \treturn 0;\n } /* rte_table_hash_lookup_key8_ext() */\n \n@@ -1236,6 +1266,9 @@ rte_table_hash_lookup_key8_ext_dosig(\n \tstruct rte_bucket_4_8 *buckets[RTE_PORT_IN_BURST_SIZE_MAX];\n \tuint64_t *keys[RTE_PORT_IN_BURST_SIZE_MAX];\n \n+\t__rte_unused uint32_t n_pkts_in = __builtin_popcountll(pkts_mask);\n+\tRTE_TABLE_HASH_KEY8_STATS_PKTS_IN_ADD(f, n_pkts_in);\n+\n \t/* Cannot run the pipeline with less than 5 packets */\n \tif (__builtin_popcountll(pkts_mask) < 5) {\n \t\tfor ( ; pkts_mask; ) {\n@@ -1362,15 +1395,31 @@ grind_next_buckets:\n \t}\n \n \t*lookup_hit_mask = pkts_mask_out;\n+\tRTE_TABLE_HASH_KEY8_STATS_PKTS_LOOKUP_MISS(f, n_pkts_in - __builtin_popcountll(pkts_mask_out));\n \treturn 0;\n } /* rte_table_hash_lookup_key8_dosig_ext() */\n \n+static int\n+rte_table_hash_key8_stats_read(void *table, struct rte_table_stats *stats, int clear)\n+{\n+\tstruct rte_table_hash *t = (struct rte_table_hash *) table;\n+\n+\tif (stats != NULL)\n+\t\tmemcpy(stats, &t->stats, sizeof(t->stats));\n+\n+\tif (clear)\n+\t\tmemset(&t->stats, 0, sizeof(t->stats));\n+\n+\treturn 0;\n+}\n+\n struct rte_table_ops rte_table_hash_key8_lru_ops = {\n \t.f_create = rte_table_hash_create_key8_lru,\n \t.f_free = rte_table_hash_free_key8_lru,\n \t.f_add = rte_table_hash_entry_add_key8_lru,\n \t.f_delete = rte_table_hash_entry_delete_key8_lru,\n \t.f_lookup = rte_table_hash_lookup_key8_lru,\n+\t.f_stats = rte_table_hash_key8_stats_read,\n };\n \n struct rte_table_ops rte_table_hash_key8_lru_dosig_ops = {\n@@ -1379,6 +1428,7 @@ struct rte_table_ops rte_table_hash_key8_lru_dosig_ops = {\n \t.f_add = rte_table_hash_entry_add_key8_lru,\n \t.f_delete = rte_table_hash_entry_delete_key8_lru,\n \t.f_lookup = rte_table_hash_lookup_key8_lru_dosig,\n+\t.f_stats = rte_table_hash_key8_stats_read,\n };\n \n struct rte_table_ops rte_table_hash_key8_ext_ops = {\n@@ -1387,6 +1437,7 @@ struct rte_table_ops rte_table_hash_key8_ext_ops = {\n \t.f_add = rte_table_hash_entry_add_key8_ext,\n \t.f_delete = rte_table_hash_entry_delete_key8_ext,\n \t.f_lookup = rte_table_hash_lookup_key8_ext,\n+\t.f_stats = rte_table_hash_key8_stats_read,\n };\n \n struct rte_table_ops rte_table_hash_key8_ext_dosig_ops = {\n@@ -1395,4 +1446,5 @@ struct rte_table_ops rte_table_hash_key8_ext_dosig_ops = {\n \t.f_add = rte_table_hash_entry_add_key8_ext,\n \t.f_delete = rte_table_hash_entry_delete_key8_ext,\n \t.f_lookup = rte_table_hash_lookup_key8_ext_dosig,\n+\t.f_stats = rte_table_hash_key8_stats_read,\n };\n",
    "prefixes": [
        "dpdk-dev",
        "v4",
        "07/10"
    ]
}