Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 53438,
    "url": "http://patchwork.dpdk.org/api/patches/53438/?format=api",
    "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20190515161948.70498-1-roy.fan.zhang@intel.com/",
    "project": {
        "id": 1,
        "url": "http://patchwork.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20190515161948.70498-1-roy.fan.zhang@intel.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20190515161948.70498-1-roy.fan.zhang@intel.com",
    "date": "2019-05-15T16:19:48",
    "name": "vhost/crypto: fix logically dead code",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "3941efa1284bbc58ff32a27e709450d8a89ec011",
    "submitter": {
        "id": 304,
        "url": "http://patchwork.dpdk.org/api/people/304/?format=api",
        "name": "Fan Zhang",
        "email": "roy.fan.zhang@intel.com"
    },
    "delegate": {
        "id": 2642,
        "url": "http://patchwork.dpdk.org/api/users/2642/?format=api",
        "username": "mcoquelin",
        "first_name": "Maxime",
        "last_name": "Coquelin",
        "email": "maxime.coquelin@redhat.com"
    },
    "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20190515161948.70498-1-roy.fan.zhang@intel.com/mbox/",
    "series": [
        {
            "id": 4675,
            "url": "http://patchwork.dpdk.org/api/series/4675/?format=api",
            "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=4675",
            "date": "2019-05-15T16:19:48",
            "name": "vhost/crypto: fix logically dead code",
            "version": 1,
            "mbox": "http://patchwork.dpdk.org/series/4675/mbox/"
        }
    ],
    "comments": "http://patchwork.dpdk.org/api/patches/53438/comments/",
    "check": "success",
    "checks": "http://patchwork.dpdk.org/api/patches/53438/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id ABEC634F0;\n\tWed, 15 May 2019 18:24:12 +0200 (CEST)",
            "from mga05.intel.com (mga05.intel.com [192.55.52.43])\n\tby dpdk.org (Postfix) with ESMTP id 92F282F7D;\n\tWed, 15 May 2019 18:24:10 +0200 (CEST)",
            "from orsmga003.jf.intel.com ([10.7.209.27])\n\tby fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t15 May 2019 09:24:09 -0700",
            "from silpixa00398673.ir.intel.com (HELO\n\tsilpixa00398673.ger.corp.intel.com) ([10.237.223.136])\n\tby orsmga003.jf.intel.com with ESMTP; 15 May 2019 09:24:06 -0700"
        ],
        "X-Amp-Result": "SKIPPED(no attachment in message)",
        "X-Amp-File-Uploaded": "False",
        "X-ExtLoop1": "1",
        "From": "Fan Zhang <roy.fan.zhang@intel.com>",
        "To": "dev@dpdk.org",
        "Cc": "maxime.coquelin@redhat.com, Fan Zhang <roy.fan.zhang@intel.com>,\n\tstable@dpdk.org",
        "Date": "Wed, 15 May 2019 17:19:48 +0100",
        "Message-Id": "<20190515161948.70498-1-roy.fan.zhang@intel.com>",
        "X-Mailer": "git-send-email 2.14.5",
        "Subject": "[dpdk-dev] [PATCH] vhost/crypto: fix logically dead code",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "This patch fixes a few same class bugs that causes the\nlogically dead code in vhost_crypto.\n\nCoverity issue: 277236\nCoverity issue: 277233\nCoverity issue: 277220\nCoverity issue: 277214\n\nFixes: 3bb595ecd682 (\"vhost/crypto: add request handler\")\nCc: stable@dpdk.org\n\nSigned-off-by: Fan Zhang <roy.fan.zhang@intel.com>\n---\n lib/librte_vhost/vhost_crypto.c | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)",
    "diff": "diff --git a/lib/librte_vhost/vhost_crypto.c b/lib/librte_vhost/vhost_crypto.c\nindex 0edf12d52..069b56108 100644\n--- a/lib/librte_vhost/vhost_crypto.c\n+++ b/lib/librte_vhost/vhost_crypto.c\n@@ -1024,7 +1024,7 @@ prepare_sym_chain_op(struct vhost_crypto *vcrypto, struct rte_crypto_op *op,\n \t\t}\n \t\tif (unlikely(copy_data(rte_pktmbuf_mtod(m_src, uint8_t *),\n \t\t\t\tvc_req, &desc, chain->para.src_data_len,\n-\t\t\t\tnb_descs, vq_size)) < 0) {\n+\t\t\t\tnb_descs, vq_size) < 0)) {\n \t\t\tret = VIRTIO_CRYPTO_BADMSG;\n \t\t\tgoto error_exit;\n \t\t}\n@@ -1598,7 +1598,7 @@ rte_vhost_crypto_fetch_requests(int vid, uint32_t qid,\n \t\t\top->sym->m_dst->data_off = 0;\n \n \t\t\tif (unlikely(vhost_crypto_process_one_req(vcrypto, vq,\n-\t\t\t\t\top, head, desc_idx)) < 0)\n+\t\t\t\t\top, head, desc_idx) < 0))\n \t\t\t\tbreak;\n \t\t}\n \n",
    "prefixes": []
}