Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/53747/?format=api
http://patchwork.dpdk.org/api/patches/53747/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20190528120553.2992-14-lukaszx.krakowiak@intel.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190528120553.2992-14-lukaszx.krakowiak@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20190528120553.2992-14-lukaszx.krakowiak@intel.com", "date": "2019-05-28T12:05:39", "name": "[13/27] sched: update grinder pipe and tc cache", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "db2074ce99ac5afcc5dd667e4e7bb99c04e6a4f5", "submitter": { "id": 1221, "url": "http://patchwork.dpdk.org/api/people/1221/?format=api", "name": "Lukasz Krakowiak", "email": "lukaszx.krakowiak@intel.com" }, "delegate": { "id": 10018, "url": "http://patchwork.dpdk.org/api/users/10018/?format=api", "username": "cristian_dumitrescu", "first_name": "Cristian", "last_name": "Dumitrescu", "email": "cristian.dumitrescu@intel.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20190528120553.2992-14-lukaszx.krakowiak@intel.com/mbox/", "series": [ { "id": 4794, "url": "http://patchwork.dpdk.org/api/series/4794/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=4794", "date": "2019-05-28T12:05:26", "name": "sched: feature enhancements", "version": 1, "mbox": "http://patchwork.dpdk.org/series/4794/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/53747/comments/", "check": "fail", "checks": "http://patchwork.dpdk.org/api/patches/53747/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 4A19D1B9C2;\n\tTue, 28 May 2019 14:08:40 +0200 (CEST)", "from mga09.intel.com (mga09.intel.com [134.134.136.24])\n\tby dpdk.org (Postfix) with ESMTP id 42A171B9A7\n\tfor <dev@dpdk.org>; Tue, 28 May 2019 14:08:28 +0200 (CEST)", "from fmsmga001.fm.intel.com ([10.253.24.23])\n\tby orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t28 May 2019 05:08:27 -0700", "from lkrakowx-mobl.ger.corp.intel.com ([10.103.104.99])\n\tby fmsmga001.fm.intel.com with ESMTP; 28 May 2019 05:08:26 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "From": "Lukasz Krakowiak <lukaszx.krakowiak@intel.com>", "To": "cristian.dumitrescu@intel.com", "Cc": "dev@dpdk.org, Jasvinder Singh <jasvinder.singh@intel.com>,\n\tAbraham Tovar <abrahamx.tovar@intel.com>,\n\tLukasz Krakowiak <lukaszx.krakowiak@intel.com>", "Date": "Tue, 28 May 2019 14:05:39 +0200", "Message-Id": "<20190528120553.2992-14-lukaszx.krakowiak@intel.com>", "X-Mailer": "git-send-email 2.19.2.windows.1", "In-Reply-To": "<20190528120553.2992-1-lukaszx.krakowiak@intel.com>", "References": "<20190528120553.2992-1-lukaszx.krakowiak@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH 13/27] sched: update grinder pipe and tc cache", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Jasvinder Singh <jasvinder.singh@intel.com>\n\nUpdate grinder pipe and tc cache population of scheduler to allow\nconfiguration flexiblity for pipe traffic classes and queues, and\nsubport level configuration of the pipe parameters.\n\nSigned-off-by: Jasvinder Singh <jasvinder.singh@intel.com>\nSigned-off-by: Abraham Tovar <abrahamx.tovar@intel.com>\nSigned-off-by: Lukasz Krakowiak <lukaszx.krakowiak@intel.com>\n---\n lib/librte_sched/rte_sched.c | 47 ++++++++++++++++--------------------\n 1 file changed, 21 insertions(+), 26 deletions(-)", "diff": "diff --git a/lib/librte_sched/rte_sched.c b/lib/librte_sched/rte_sched.c\nindex 6cfa73761..32a5121cd 100644\n--- a/lib/librte_sched/rte_sched.c\n+++ b/lib/librte_sched/rte_sched.c\n@@ -2174,9 +2174,10 @@ grinder_pipe_exists(struct rte_sched_port *port, uint32_t base_pipe)\n #endif /* RTE_SCHED_OPTIMIZATIONS */\n \n static inline void\n-grinder_pcache_populate(struct rte_sched_port *port, uint32_t pos, uint32_t bmp_pos, uint64_t bmp_slab)\n+grinder_pcache_populate(struct rte_sched_subport *subport, uint32_t pos,\n+\tuint32_t bmp_pos, uint64_t bmp_slab)\n {\n-\tstruct rte_sched_grinder *grinder = port->grinder + pos;\n+\tstruct rte_sched_grinder *grinder = subport->grinder + pos;\n \tuint16_t w[4];\n \n \tgrinder->pcache_w = 0;\n@@ -2205,34 +2206,28 @@ grinder_pcache_populate(struct rte_sched_port *port, uint32_t pos, uint32_t bmp_\n }\n \n static inline void\n-grinder_tccache_populate(struct rte_sched_port *port, uint32_t pos, uint32_t qindex, uint16_t qmask)\n+grinder_tccache_populate(struct rte_sched_subport *subport, uint32_t pos,\n+\tuint32_t qindex, uint16_t qmask)\n {\n-\tstruct rte_sched_grinder *grinder = port->grinder + pos;\n-\tuint8_t b[4];\n+\tstruct rte_sched_grinder *grinder = subport->grinder + pos;\n+\tuint32_t i;\n+\tuint8_t b;\n \n \tgrinder->tccache_w = 0;\n \tgrinder->tccache_r = 0;\n \n-\tb[0] = (uint8_t) (qmask & 0xF);\n-\tb[1] = (uint8_t) ((qmask >> 4) & 0xF);\n-\tb[2] = (uint8_t) ((qmask >> 8) & 0xF);\n-\tb[3] = (uint8_t) ((qmask >> 12) & 0xF);\n-\n-\tgrinder->tccache_qmask[grinder->tccache_w] = b[0];\n-\tgrinder->tccache_qindex[grinder->tccache_w] = qindex;\n-\tgrinder->tccache_w += (b[0] != 0);\n-\n-\tgrinder->tccache_qmask[grinder->tccache_w] = b[1];\n-\tgrinder->tccache_qindex[grinder->tccache_w] = qindex + 4;\n-\tgrinder->tccache_w += (b[1] != 0);\n-\n-\tgrinder->tccache_qmask[grinder->tccache_w] = b[2];\n-\tgrinder->tccache_qindex[grinder->tccache_w] = qindex + 8;\n-\tgrinder->tccache_w += (b[2] != 0);\n+\tfor (i = 0; i < RTE_SCHED_TRAFFIC_CLASS_BE; i++) {\n+\t\tb = (uint8_t) ((qmask >> i) & 0x1);\n+\t\tgrinder->tccache_qmask[grinder->tccache_w] = b;\n+\t\tgrinder->tccache_qindex[grinder->tccache_w] = qindex + i;\n+\t\tgrinder->tccache_w += (b != 0);\n+\t}\n \n-\tgrinder->tccache_qmask[grinder->tccache_w] = b[3];\n-\tgrinder->tccache_qindex[grinder->tccache_w] = qindex + 12;\n-\tgrinder->tccache_w += (b[3] != 0);\n+\tb = (uint8_t) (qmask >> (RTE_SCHED_TRAFFIC_CLASS_BE));\n+\tgrinder->tccache_qmask[grinder->tccache_w] = b;\n+\tgrinder->tccache_qindex[grinder->tccache_w] = qindex +\n+\t\tRTE_SCHED_TRAFFIC_CLASS_BE;\n+\tgrinder->tccache_w += (b != 0);\n }\n \n static inline int\n@@ -2304,7 +2299,7 @@ grinder_next_pipe(struct rte_sched_port *port, uint32_t pos)\n \t\tport->grinder_base_bmp_pos[pos] = bmp_pos;\n \n \t\t/* Install new pipe group into grinder's pipe cache */\n-\t\tgrinder_pcache_populate(port, pos, bmp_pos, bmp_slab);\n+\t\tgrinder_pcache_populate(port->subport, pos, bmp_pos, bmp_slab);\n \n \t\tpipe_qmask = grinder->pcache_qmask[0];\n \t\tpipe_qindex = grinder->pcache_qindex[0];\n@@ -2318,7 +2313,7 @@ grinder_next_pipe(struct rte_sched_port *port, uint32_t pos)\n \tgrinder->pipe_params = NULL; /* to be set after the pipe structure is prefetched */\n \tgrinder->productive = 0;\n \n-\tgrinder_tccache_populate(port, pos, pipe_qindex, pipe_qmask);\n+\tgrinder_tccache_populate(port->subport, pos, pipe_qindex, pipe_qmask);\n \tgrinder_next_tc(port, pos);\n \n \t/* Check for pipe exhaustion */\n", "prefixes": [ "13/27" ] }{ "id": 53747, "url": "