Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/56246/?format=api
{ "id": 56246, "url": "http://patchwork.dpdk.org/api/patches/56246/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20190708182614.1677-3-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190708182614.1677-3-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20190708182614.1677-3-stephen@networkplumber.org", "date": "2019-07-08T18:26:05", "name": "[v9,02/11] net/ether: add function to convert string to ethernet address", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "ed796cb1563fdd0fb5843a7aaaa035caa018e8e5", "submitter": { "id": 27, "url": "http://patchwork.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 319, "url": "http://patchwork.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20190708182614.1677-3-stephen@networkplumber.org/mbox/", "series": [ { "id": 5401, "url": "http://patchwork.dpdk.org/api/series/5401/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=5401", "date": "2019-07-08T18:26:03", "name": "ether: improvements and optimizations", "version": 9, "mbox": "http://patchwork.dpdk.org/series/5401/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/56246/comments/", "check": "warning", "checks": "http://patchwork.dpdk.org/api/patches/56246/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id CBD011B9B2;\n\tMon, 8 Jul 2019 20:26:29 +0200 (CEST)", "from mail-pf1-f174.google.com (mail-pf1-f174.google.com\n\t[209.85.210.174]) by dpdk.org (Postfix) with ESMTP id 375C7160\n\tfor <dev@dpdk.org>; Mon, 8 Jul 2019 20:26:25 +0200 (CEST)", "by mail-pf1-f174.google.com with SMTP id c73so3336191pfb.13\n\tfor <dev@dpdk.org>; Mon, 08 Jul 2019 11:26:25 -0700 (PDT)", "from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127])\n\tby smtp.gmail.com with ESMTPSA id\n\to15sm18769295pgj.18.2019.07.08.11.26.22\n\t(version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256);\n\tMon, 08 Jul 2019 11:26:23 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=networkplumber-org.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=MeK+yID5ssi0NPFn+Lh/3/mX9Sd3TlIiRDH9K1yPHnY=;\n\tb=QB/gRl78fRwFrh1C7CxqU/119z60jpU1boYPDIjZnWX6vKR2JFeS4c0MqJkZ0Jp2hF\n\tqIGgbaRx5xrioIqYqg51COHM9lbYfQQYitDYYd9xNj9IiblxHZfTgQiAPzZPrKQTcuXb\n\t0XFaGAFXcQSFPaTltBoZ9EWmxCFgYcq+vG2laxhOii5T7a+5zrDqeMJ/2yBjLicNbIWl\n\tUSxs7EsUsmOU/WtabglmT/1Lz420EWH6icRFjKALGPM9dEl+rGrLCo7TmJv2cv+Wvw+4\n\tNklBUmK8dVllriXhWMshb7XiB9tcsFc7wl0fJFsC9XFhh7Zzr3nJZLXiCReTzXkWmwoi\n\tDw1w==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=MeK+yID5ssi0NPFn+Lh/3/mX9Sd3TlIiRDH9K1yPHnY=;\n\tb=Wkc/J830QIzVweEIvQa3LZiLhdtTPVxif/17uPXjwh2Z97yfgGjZ6BPjQZFH9tD/Wu\n\t9j9BSEExMgTnivZTnSoQpKvHD1dEmmqBXXfKIzkAwkQrUX/sMjI9PGiyWtrw3CMRnGoC\n\tfrCbzaMgF1G60QWPmQxx3BZIc74hTZ9xWLwnkzBNUe9tVzIGZfBDVUMWzjBwTCuyUkpX\n\tP9Ya7jShv870cvaV8fP4x73w9zYsFIP2bRB8mQLZpR76zwbkGfI0/4mjJFlT79D/KTxY\n\t2MfWz9Elgk5UPs4IJYnUUdID5sb5q02sKOS7R6KMyPm3ik4hT2eHg1c9i7oSmy+zoSU2\n\tEaOQ==", "X-Gm-Message-State": "APjAAAUeVavS8nag63CDvHKVF4LReOzw/I3LcnhuO1KvCOrTO+lC6L9D\n\tAtGyz9kgDGLteBWaC1hkaFB5p+rujME=", "X-Google-Smtp-Source": "APXvYqwjpxg5gsxzGNXvxkup7ZSHeBQykqsy/LHU5Q2wPaKXvV2fXBSmUAX3NrUUZyfcdPAPeMJ/AQ==", "X-Received": "by 2002:a17:90a:2023:: with SMTP id\n\tn32mr26416932pjc.3.1562610384131; \n\tMon, 08 Jul 2019 11:26:24 -0700 (PDT)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>,\n\tAndrew Rybchenko <arybchenko@solarflare.com>", "Date": "Mon, 8 Jul 2019 11:26:05 -0700", "Message-Id": "<20190708182614.1677-3-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20190708182614.1677-1-stephen@networkplumber.org>", "References": "<20190516180427.17270-1-stephen@networkplumber.org>\n\t<20190708182614.1677-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v9 02/11] net/ether: add function to convert\n\tstring to ethernet address", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Make a function that can be used in place of eth_aton_r\nto convert a string to rte_ether_addr. This function\nallows both byte (xx:xx:xx:xx:xx:xx) and word (XXXX:XXXX:XXXX)\nformat and has the same lack of error handling as the original.\n\nThis also allows ethdev to no longer have a hard dependency\non the cmdline library.\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\nReviewed-by: Andrew Rybchenko <arybchenko@solarflare.com>\n---\n lib/librte_net/rte_ether.c | 49 ++++++++++++++++++++++++++++++\n lib/librte_net/rte_ether.h | 14 +++++++++\n lib/librte_net/rte_net_version.map | 1 +\n 3 files changed, 64 insertions(+)", "diff": "diff --git a/lib/librte_net/rte_ether.c b/lib/librte_net/rte_ether.c\nindex 974fe815b335..8d040173cfc6 100644\n--- a/lib/librte_net/rte_ether.c\n+++ b/lib/librte_net/rte_ether.c\n@@ -3,6 +3,7 @@\n */\n \n #include <rte_ether.h>\n+#include <rte_errno.h>\n \n void\n rte_eth_random_addr(uint8_t *addr)\n@@ -27,3 +28,51 @@ rte_ether_format_addr(char *buf, uint16_t size,\n \t\t eth_addr->addr_bytes[4],\n \t\t eth_addr->addr_bytes[5]);\n }\n+\n+/*\n+ * Like ether_aton_r but can handle either\n+ * XX:XX:XX:XX:XX:XX or XXXX:XXXX:XXXX\n+ */\n+int\n+rte_ether_unformat_addr(const char *s, struct rte_ether_addr *ea)\n+{\n+\tunsigned int o0, o1, o2, o3, o4, o5;\n+\tint n;\n+\n+\tn = sscanf(s, \"%x:%x:%x:%x:%x:%x\",\n+\t\t &o0, &o1, &o2, &o3, &o4, &o5);\n+\n+\tif (n == 6) {\n+\t\t/* Standard format XX:XX:XX:XX:XX:XX */\n+\t\tif (o0 > UINT8_MAX || o1 > UINT8_MAX || o2 > UINT8_MAX ||\n+\t\t o3 > UINT8_MAX || o4 > UINT8_MAX || o5 > UINT8_MAX) {\n+\t\t\trte_errno = ERANGE;\n+\t\t\treturn -1;\n+\t\t}\n+\n+\t\tea->addr_bytes[0] = o0;\n+\t\tea->addr_bytes[1] = o1;\n+\t\tea->addr_bytes[2] = o2;\n+\t\tea->addr_bytes[3] = o3;\n+\t\tea->addr_bytes[4] = o4;\n+\t\tea->addr_bytes[5] = o5;\n+\t} else if (n == 3) {\n+\t\t/* Support the format XXXX:XXXX:XXXX */\n+\t\tif (o0 > UINT16_MAX || o1 > UINT16_MAX || o2 > UINT16_MAX) {\n+\t\t\trte_errno = ERANGE;\n+\t\t\treturn -1;\n+\t\t}\n+\n+\t\tea->addr_bytes[0] = o0 >> 8;\n+\t\tea->addr_bytes[1] = o0 & 0xff;\n+\t\tea->addr_bytes[2] = o1 >> 8;\n+\t\tea->addr_bytes[3] = o1 & 0xff;\n+\t\tea->addr_bytes[4] = o2 >> 8;\n+\t\tea->addr_bytes[5] = o2 & 0xff;\n+\t} else {\n+\t\t/* unknown format */\n+\t\trte_errno = EINVAL;\n+\t\treturn -1;\n+\t}\n+\treturn 0;\n+}\ndiff --git a/lib/librte_net/rte_ether.h b/lib/librte_net/rte_ether.h\nindex df1a51462a37..77b4569b1ad4 100644\n--- a/lib/librte_net/rte_ether.h\n+++ b/lib/librte_net/rte_ether.h\n@@ -250,6 +250,20 @@ static inline void rte_ether_addr_copy(const struct rte_ether_addr *ea_from,\n void\n rte_ether_format_addr(char *buf, uint16_t size,\n \t\t const struct rte_ether_addr *eth_addr);\n+/**\n+ * Convert string with Ethernet address to an ether_addr.\n+ *\n+ * @param str\n+ * A pointer to buffer contains the formatted MAC address.\n+ * @param eth_addr\n+ * A pointer to a ether_addr structure.\n+ * @return\n+ * 0 if successful\n+ * -1 and sets rte_errno if invalid string\n+ */\n+int __rte_experimental\n+rte_ether_unformat_addr(const char *str, struct rte_ether_addr *eth_addr);\n+\n /**\n * Ethernet header: Contains the destination address, source address\n * and frame type.\ndiff --git a/lib/librte_net/rte_net_version.map b/lib/librte_net/rte_net_version.map\nindex f1e1b84ab491..f4c915069d57 100644\n--- a/lib/librte_net/rte_net_version.map\n+++ b/lib/librte_net/rte_net_version.map\n@@ -25,4 +25,5 @@ EXPERIMENTAL {\n \n \trte_net_make_rarp_packet;\n \trte_net_skip_ip6_ext;\n+\trte_ether_unformat_addr;\n };\n", "prefixes": [ "v9", "02/11" ] }