Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 56267,
    "url": "http://patchwork.dpdk.org/api/patches/56267/?format=api",
    "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/1562670596-27129-1-git-send-email-bernard.iremonger@intel.com/",
    "project": {
        "id": 1,
        "url": "http://patchwork.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<1562670596-27129-1-git-send-email-bernard.iremonger@intel.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/1562670596-27129-1-git-send-email-bernard.iremonger@intel.com",
    "date": "2019-07-09T11:09:56",
    "name": "librte_flow_classify: fix out-of-bounds access",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "664e4229da1ef6262fcae19b386cbda3839a930f",
    "submitter": {
        "id": 91,
        "url": "http://patchwork.dpdk.org/api/people/91/?format=api",
        "name": "Iremonger, Bernard",
        "email": "bernard.iremonger@intel.com"
    },
    "delegate": {
        "id": 1,
        "url": "http://patchwork.dpdk.org/api/users/1/?format=api",
        "username": "tmonjalo",
        "first_name": "Thomas",
        "last_name": "Monjalon",
        "email": "thomas@monjalon.net"
    },
    "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/1562670596-27129-1-git-send-email-bernard.iremonger@intel.com/mbox/",
    "series": [
        {
            "id": 5409,
            "url": "http://patchwork.dpdk.org/api/series/5409/?format=api",
            "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=5409",
            "date": "2019-07-09T11:09:56",
            "name": "librte_flow_classify: fix out-of-bounds access",
            "version": 1,
            "mbox": "http://patchwork.dpdk.org/series/5409/mbox/"
        }
    ],
    "comments": "http://patchwork.dpdk.org/api/patches/56267/comments/",
    "check": "fail",
    "checks": "http://patchwork.dpdk.org/api/patches/56267/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id ABB0A1B959;\n\tTue,  9 Jul 2019 13:10:04 +0200 (CEST)",
            "from mga18.intel.com (mga18.intel.com [134.134.136.126])\n\tby dpdk.org (Postfix) with ESMTP id 4519837A2;\n\tTue,  9 Jul 2019 13:10:02 +0200 (CEST)",
            "from fmsmga001.fm.intel.com ([10.253.24.23])\n\tby orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t09 Jul 2019 04:10:01 -0700",
            "from sivswdev08.ir.intel.com (HELO localhost.localdomain)\n\t([10.237.217.47])\n\tby fmsmga001.fm.intel.com with ESMTP; 09 Jul 2019 04:09:59 -0700"
        ],
        "X-Amp-Result": "SKIPPED(no attachment in message)",
        "X-Amp-File-Uploaded": "False",
        "X-ExtLoop1": "1",
        "X-IronPort-AV": "E=Sophos;i=\"5.63,470,1557212400\"; d=\"scan'208\";a=\"185891881\"",
        "From": "Bernard Iremonger <bernard.iremonger@intel.com>",
        "To": "dev@dpdk.org,\n\tjasvinder.singh@intel.com",
        "Cc": "Bernard Iremonger <bernard.iremonger@intel.com>,\n\tstable@dpdk.org",
        "Date": "Tue,  9 Jul 2019 12:09:56 +0100",
        "Message-Id": "<1562670596-27129-1-git-send-email-bernard.iremonger@intel.com>",
        "X-Mailer": "git-send-email 1.7.0.7",
        "Subject": "[dpdk-dev] [PATCH] librte_flow_classify: fix out-of-bounds access",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "This patch fixes the out-of-bounds coverity issue by removing the\noffending line of code at line 107 in rte_flow_classify_parse.c\nwhich is never executed.\n\nCoverity issue: 343454\n\nFixes: be41ac2a330f (\"flow_classify: introduce flow classify library\")\nCc: stable@dpdk.org\nSigned-off-by: Bernard Iremonger <bernard.iremonger@intel.com>\n---\n lib/librte_flow_classify/rte_flow_classify_parse.c | 2 --\n 1 file changed, 2 deletions(-)",
    "diff": "diff --git a/lib/librte_flow_classify/rte_flow_classify_parse.c b/lib/librte_flow_classify/rte_flow_classify_parse.c\nindex f65ceaf..4653302 100644\n--- a/lib/librte_flow_classify/rte_flow_classify_parse.c\n+++ b/lib/librte_flow_classify/rte_flow_classify_parse.c\n@@ -103,8 +103,6 @@ classify_pattern_skip_void_item(struct rte_flow_item *items,\n \t\t\tpb = pe;\n \t\t\tbreak;\n \t\t}\n-\n-\t\tpb = pe + 1;\n \t}\n \t/* Copy the END item. */\n \trte_memcpy(items, pe, sizeof(struct rte_flow_item));\n",
    "prefixes": []
}