Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/56346/?format=api
{ "id": 56346, "url": "http://patchwork.dpdk.org/api/patches/56346/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/1562866026-99504-1-git-send-email-haiyue.wang@intel.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1562866026-99504-1-git-send-email-haiyue.wang@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1562866026-99504-1-git-send-email-haiyue.wang@intel.com", "date": "2019-07-11T17:27:06", "name": "[v1] net/ice: use rx/tx DMA iova instead of phys_addr which is deprecated", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "ab57f66cf36461eca11da802db3645ce139fd015", "submitter": { "id": 1044, "url": "http://patchwork.dpdk.org/api/people/1044/?format=api", "name": "Wang, Haiyue", "email": "haiyue.wang@intel.com" }, "delegate": { "id": 1540, "url": "http://patchwork.dpdk.org/api/users/1540/?format=api", "username": "qzhan15", "first_name": "Qi", "last_name": "Zhang", "email": "qi.z.zhang@intel.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/1562866026-99504-1-git-send-email-haiyue.wang@intel.com/mbox/", "series": [ { "id": 5458, "url": "http://patchwork.dpdk.org/api/series/5458/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=5458", "date": "2019-07-11T17:27:06", "name": "[v1] net/ice: use rx/tx DMA iova instead of phys_addr which is deprecated", "version": 1, "mbox": "http://patchwork.dpdk.org/series/5458/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/56346/comments/", "check": "fail", "checks": "http://patchwork.dpdk.org/api/patches/56346/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 5A3635680;\n\tThu, 11 Jul 2019 19:31:41 +0200 (CEST)", "from mga04.intel.com (mga04.intel.com [192.55.52.120])\n\tby dpdk.org (Postfix) with ESMTP id D3FBB2BAB;\n\tThu, 11 Jul 2019 19:31:38 +0200 (CEST)", "from orsmga007.jf.intel.com ([10.7.209.58])\n\tby fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t11 Jul 2019 10:31:37 -0700", "from npg-dpdk-haiyue-1.sh.intel.com ([10.67.119.204])\n\tby orsmga007.jf.intel.com with ESMTP; 11 Jul 2019 10:31:36 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.63,479,1557212400\"; d=\"scan'208\";a=\"156889085\"", "From": "Haiyue Wang <haiyue.wang@intel.com>", "To": "dev@dpdk.org", "Cc": "Haiyue Wang <haiyue.wang@intel.com>,\n\tstable@dpdk.org", "Date": "Fri, 12 Jul 2019 01:27:06 +0800", "Message-Id": "<1562866026-99504-1-git-send-email-haiyue.wang@intel.com>", "X-Mailer": "git-send-email 2.7.4", "Subject": "[dpdk-dev] [PATCH v1] net/ice: use rx/tx DMA iova instead of\n\tphys_addr which is deprecated", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The phys_addr concept is deprecated in rte_memzone, change it to access\niova member, and use the type 'rte_iova_t'.\n\nAlso rename the rx/tx_ring_phys_addr definitions to rx/tx_ring_dma that\nmatches the IOVA concept design.\n\nFixes: 50370662b727 (\"net/ice: support device and queue ops\")\nCc: stable@dpdk.org\n\nSigned-off-by: Haiyue Wang <haiyue.wang@intel.com>\n---\n drivers/net/ice/ice_rxtx.c | 8 ++++----\n drivers/net/ice/ice_rxtx.h | 4 ++--\n 2 files changed, 6 insertions(+), 6 deletions(-)", "diff": "diff --git a/drivers/net/ice/ice_rxtx.c b/drivers/net/ice/ice_rxtx.c\nindex 035ed84..3353f23 100644\n--- a/drivers/net/ice/ice_rxtx.c\n+++ b/drivers/net/ice/ice_rxtx.c\n@@ -70,7 +70,7 @@ ice_program_hw_rx_queue(struct ice_rx_queue *rxq)\n \n \tmemset(&rx_ctx, 0, sizeof(rx_ctx));\n \n-\trx_ctx.base = rxq->rx_ring_phys_addr / ICE_QUEUE_BASE_ADDR_UNIT;\n+\trx_ctx.base = rxq->rx_ring_dma / ICE_QUEUE_BASE_ADDR_UNIT;\n \trx_ctx.qlen = rxq->nb_rx_desc;\n \trx_ctx.dbuf = rxq->rx_buf_len >> ICE_RLAN_CTX_DBUF_S;\n \trx_ctx.hbuf = rxq->rx_hdr_len >> ICE_RLAN_CTX_HBUF_S;\n@@ -442,7 +442,7 @@ ice_tx_queue_start(struct rte_eth_dev *dev, uint16_t tx_queue_id)\n \ttxq_elem.num_txqs = 1;\n \ttxq_elem.txqs[0].txq_id = rte_cpu_to_le_16(txq->reg_idx);\n \n-\ttx_ctx.base = txq->tx_ring_phys_addr / ICE_QUEUE_BASE_ADDR_UNIT;\n+\ttx_ctx.base = txq->tx_ring_dma / ICE_QUEUE_BASE_ADDR_UNIT;\n \ttx_ctx.qlen = txq->nb_tx_desc;\n \ttx_ctx.pf_num = hw->pf_id;\n \ttx_ctx.vmvf_type = ICE_TLAN_CTX_VMVF_TYPE_PF;\n@@ -663,7 +663,7 @@ ice_rx_queue_setup(struct rte_eth_dev *dev,\n \t/* Zero all the descriptors in the ring. */\n \tmemset(rz->addr, 0, ring_size);\n \n-\trxq->rx_ring_phys_addr = rz->phys_addr;\n+\trxq->rx_ring_dma = rz->iova;\n \trxq->rx_ring = (union ice_rx_desc *)rz->addr;\n \n #ifdef RTE_LIBRTE_ICE_RX_ALLOW_BULK_ALLOC\n@@ -881,7 +881,7 @@ ice_tx_queue_setup(struct rte_eth_dev *dev,\n \ttxq->vsi = vsi;\n \ttxq->tx_deferred_start = tx_conf->tx_deferred_start;\n \n-\ttxq->tx_ring_phys_addr = tz->phys_addr;\n+\ttxq->tx_ring_dma = tz->iova;\n \ttxq->tx_ring = (struct ice_tx_desc *)tz->addr;\n \n \t/* Allocate software ring */\ndiff --git a/drivers/net/ice/ice_rxtx.h b/drivers/net/ice/ice_rxtx.h\nindex 9040e3f..e921411 100644\n--- a/drivers/net/ice/ice_rxtx.h\n+++ b/drivers/net/ice/ice_rxtx.h\n@@ -46,7 +46,7 @@ struct ice_rx_entry {\n struct ice_rx_queue {\n \tstruct rte_mempool *mp; /* mbuf pool to populate RX ring */\n \tvolatile union ice_rx_desc *rx_ring;/* RX ring virtual address */\n-\tuint64_t rx_ring_phys_addr; /* RX ring DMA address */\n+\trte_iova_t rx_ring_dma; /* RX ring DMA address */\n \tstruct ice_rx_entry *sw_ring; /* address of RX soft ring */\n \tuint16_t nb_rx_desc; /* number of RX descriptors */\n \tuint16_t rx_free_thresh; /* max free RX desc to hold */\n@@ -87,7 +87,7 @@ struct ice_tx_entry {\n \n struct ice_tx_queue {\n \tuint16_t nb_tx_desc; /* number of TX descriptors */\n-\tuint64_t tx_ring_phys_addr; /* TX ring DMA address */\n+\trte_iova_t tx_ring_dma; /* TX ring DMA address */\n \tvolatile struct ice_tx_desc *tx_ring; /* TX ring virtual address */\n \tstruct ice_tx_entry *sw_ring; /* virtual address of SW ring */\n \tuint16_t tx_tail; /* current value of tail register */\n", "prefixes": [ "v1" ] }