Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/56360/?format=api
{ "id": 56360, "url": "http://patchwork.dpdk.org/api/patches/56360/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20190712030923.37832-2-ruifeng.wang@arm.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190712030923.37832-2-ruifeng.wang@arm.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20190712030923.37832-2-ruifeng.wang@arm.com", "date": "2019-07-12T03:09:18", "name": "[v5,1/6] lib/lpm: not inline unnecessary functions", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "26031403e4fb86cda28419ae2f6a2725c8974209", "submitter": { "id": 1198, "url": "http://patchwork.dpdk.org/api/people/1198/?format=api", "name": "Ruifeng Wang", "email": "ruifeng.wang@arm.com" }, "delegate": { "id": 1, "url": "http://patchwork.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20190712030923.37832-2-ruifeng.wang@arm.com/mbox/", "series": [ { "id": 5462, "url": "http://patchwork.dpdk.org/api/series/5462/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=5462", "date": "2019-07-12T03:09:17", "name": "LPM4 memory ordering changes", "version": 5, "mbox": "http://patchwork.dpdk.org/series/5462/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/56360/comments/", "check": "fail", "checks": "http://patchwork.dpdk.org/api/patches/56360/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 062CB3977;\n\tFri, 12 Jul 2019 05:10:02 +0200 (CEST)", "from foss.arm.com (foss.arm.com [217.140.110.172])\n\tby dpdk.org (Postfix) with ESMTP id 85D513772\n\tfor <dev@dpdk.org>; Fri, 12 Jul 2019 05:10:01 +0200 (CEST)", "from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])\n\tby usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id E59A12B;\n\tThu, 11 Jul 2019 20:10:00 -0700 (PDT)", "from net-arm-c2400-02.shanghai.arm.com\n\t(net-arm-c2400-02.shanghai.arm.com [10.169.40.42])\n\tby usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id\n\t5C2F43F246; Thu, 11 Jul 2019 20:09:59 -0700 (PDT)" ], "From": "Ruifeng Wang <ruifeng.wang@arm.com>", "To": "vladimir.medvedkin@intel.com,\n\tbruce.richardson@intel.com", "Cc": "dev@dpdk.org, honnappa.nagarahalli@arm.com, gavin.hu@arm.com, nd@arm.com,\n\tRuifeng Wang <ruifeng.wang@arm.com>", "Date": "Fri, 12 Jul 2019 11:09:18 +0800", "Message-Id": "<20190712030923.37832-2-ruifeng.wang@arm.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20190712030923.37832-1-ruifeng.wang@arm.com>", "References": "<20190605055451.30473-1-ruifeng.wang@arm.com>\n\t<20190712030923.37832-1-ruifeng.wang@arm.com>", "Subject": "[dpdk-dev] [PATCH v5 1/6] lib/lpm: not inline unnecessary functions", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Tests showed that the function inlining caused performance drop\non some x86 platforms with the memory ordering patches applied.\nBy force no-inline functions, the performance was better than\nbefore on x86 and no impact to arm64 platforms.\n\nBesides inlines of other functions are removed to let compiler\nto decide whether to inline.\n\nSuggested-by: Medvedkin Vladimir <vladimir.medvedkin@intel.com>\nSigned-off-by: Ruifeng Wang <ruifeng.wang@arm.com>\nReviewed-by: Gavin Hu <gavin.hu@arm.com>\n---\n lib/librte_lpm/rte_lpm.c | 46 ++++++++++++++++++++--------------------\n 1 file changed, 23 insertions(+), 23 deletions(-)", "diff": "diff --git a/lib/librte_lpm/rte_lpm.c b/lib/librte_lpm/rte_lpm.c\nindex 6b7b28a2e..18efa496c 100644\n--- a/lib/librte_lpm/rte_lpm.c\n+++ b/lib/librte_lpm/rte_lpm.c\n@@ -70,7 +70,7 @@ depth_to_mask(uint8_t depth)\n /*\n * Converts given depth value to its corresponding range value.\n */\n-static inline uint32_t __attribute__((pure))\n+static uint32_t __attribute__((pure))\n depth_to_range(uint8_t depth)\n {\n \tVERIFY_DEPTH(depth);\n@@ -399,7 +399,7 @@ MAP_STATIC_SYMBOL(void rte_lpm_free(struct rte_lpm *lpm),\n * are stored in the rule table from 0 - 31.\n * NOTE: Valid range for depth parameter is 1 .. 32 inclusive.\n */\n-static inline int32_t\n+static int32_t\n rule_add_v20(struct rte_lpm_v20 *lpm, uint32_t ip_masked, uint8_t depth,\n \tuint8_t next_hop)\n {\n@@ -471,7 +471,7 @@ rule_add_v20(struct rte_lpm_v20 *lpm, uint32_t ip_masked, uint8_t depth,\n \treturn rule_index;\n }\n \n-static inline int32_t\n+static int32_t\n rule_add_v1604(struct rte_lpm *lpm, uint32_t ip_masked, uint8_t depth,\n \tuint32_t next_hop)\n {\n@@ -547,7 +547,7 @@ rule_add_v1604(struct rte_lpm *lpm, uint32_t ip_masked, uint8_t depth,\n * Delete a rule from the rule table.\n * NOTE: Valid range for depth parameter is 1 .. 32 inclusive.\n */\n-static inline void\n+static void\n rule_delete_v20(struct rte_lpm_v20 *lpm, int32_t rule_index, uint8_t depth)\n {\n \tint i;\n@@ -570,7 +570,7 @@ rule_delete_v20(struct rte_lpm_v20 *lpm, int32_t rule_index, uint8_t depth)\n \tlpm->rule_info[depth - 1].used_rules--;\n }\n \n-static inline void\n+static void\n rule_delete_v1604(struct rte_lpm *lpm, int32_t rule_index, uint8_t depth)\n {\n \tint i;\n@@ -597,7 +597,7 @@ rule_delete_v1604(struct rte_lpm *lpm, int32_t rule_index, uint8_t depth)\n * Finds a rule in rule table.\n * NOTE: Valid range for depth parameter is 1 .. 32 inclusive.\n */\n-static inline int32_t\n+static int32_t\n rule_find_v20(struct rte_lpm_v20 *lpm, uint32_t ip_masked, uint8_t depth)\n {\n \tuint32_t rule_gindex, last_rule, rule_index;\n@@ -618,7 +618,7 @@ rule_find_v20(struct rte_lpm_v20 *lpm, uint32_t ip_masked, uint8_t depth)\n \treturn -EINVAL;\n }\n \n-static inline int32_t\n+static int32_t\n rule_find_v1604(struct rte_lpm *lpm, uint32_t ip_masked, uint8_t depth)\n {\n \tuint32_t rule_gindex, last_rule, rule_index;\n@@ -642,7 +642,7 @@ rule_find_v1604(struct rte_lpm *lpm, uint32_t ip_masked, uint8_t depth)\n /*\n * Find, clean and allocate a tbl8.\n */\n-static inline int32_t\n+static int32_t\n tbl8_alloc_v20(struct rte_lpm_tbl_entry_v20 *tbl8)\n {\n \tuint32_t group_idx; /* tbl8 group index. */\n@@ -669,7 +669,7 @@ tbl8_alloc_v20(struct rte_lpm_tbl_entry_v20 *tbl8)\n \treturn -ENOSPC;\n }\n \n-static inline int32_t\n+static int32_t\n tbl8_alloc_v1604(struct rte_lpm_tbl_entry *tbl8, uint32_t number_tbl8s)\n {\n \tuint32_t group_idx; /* tbl8 group index. */\n@@ -695,21 +695,21 @@ tbl8_alloc_v1604(struct rte_lpm_tbl_entry *tbl8, uint32_t number_tbl8s)\n \treturn -ENOSPC;\n }\n \n-static inline void\n+static void\n tbl8_free_v20(struct rte_lpm_tbl_entry_v20 *tbl8, uint32_t tbl8_group_start)\n {\n \t/* Set tbl8 group invalid*/\n \ttbl8[tbl8_group_start].valid_group = INVALID;\n }\n \n-static inline void\n+static void\n tbl8_free_v1604(struct rte_lpm_tbl_entry *tbl8, uint32_t tbl8_group_start)\n {\n \t/* Set tbl8 group invalid*/\n \ttbl8[tbl8_group_start].valid_group = INVALID;\n }\n \n-static inline int32_t\n+static __rte_noinline int32_t\n add_depth_small_v20(struct rte_lpm_v20 *lpm, uint32_t ip, uint8_t depth,\n \t\tuint8_t next_hop)\n {\n@@ -777,7 +777,7 @@ add_depth_small_v20(struct rte_lpm_v20 *lpm, uint32_t ip, uint8_t depth,\n \treturn 0;\n }\n \n-static inline int32_t\n+static __rte_noinline int32_t\n add_depth_small_v1604(struct rte_lpm *lpm, uint32_t ip, uint8_t depth,\n \t\tuint32_t next_hop)\n {\n@@ -846,7 +846,7 @@ add_depth_small_v1604(struct rte_lpm *lpm, uint32_t ip, uint8_t depth,\n \treturn 0;\n }\n \n-static inline int32_t\n+static __rte_noinline int32_t\n add_depth_big_v20(struct rte_lpm_v20 *lpm, uint32_t ip_masked, uint8_t depth,\n \t\tuint8_t next_hop)\n {\n@@ -971,7 +971,7 @@ add_depth_big_v20(struct rte_lpm_v20 *lpm, uint32_t ip_masked, uint8_t depth,\n \treturn 0;\n }\n \n-static inline int32_t\n+static __rte_noinline int32_t\n add_depth_big_v1604(struct rte_lpm *lpm, uint32_t ip_masked, uint8_t depth,\n \t\tuint32_t next_hop)\n {\n@@ -1244,7 +1244,7 @@ BIND_DEFAULT_SYMBOL(rte_lpm_is_rule_present, _v1604, 16.04);\n MAP_STATIC_SYMBOL(int rte_lpm_is_rule_present(struct rte_lpm *lpm, uint32_t ip,\n \t\tuint8_t depth, uint32_t *next_hop), rte_lpm_is_rule_present_v1604);\n \n-static inline int32_t\n+static int32_t\n find_previous_rule_v20(struct rte_lpm_v20 *lpm, uint32_t ip, uint8_t depth,\n \t\tuint8_t *sub_rule_depth)\n {\n@@ -1266,7 +1266,7 @@ find_previous_rule_v20(struct rte_lpm_v20 *lpm, uint32_t ip, uint8_t depth,\n \treturn -1;\n }\n \n-static inline int32_t\n+static int32_t\n find_previous_rule_v1604(struct rte_lpm *lpm, uint32_t ip, uint8_t depth,\n \t\tuint8_t *sub_rule_depth)\n {\n@@ -1288,7 +1288,7 @@ find_previous_rule_v1604(struct rte_lpm *lpm, uint32_t ip, uint8_t depth,\n \treturn -1;\n }\n \n-static inline int32_t\n+static int32_t\n delete_depth_small_v20(struct rte_lpm_v20 *lpm, uint32_t ip_masked,\n \tuint8_t depth, int32_t sub_rule_index, uint8_t sub_rule_depth)\n {\n@@ -1381,7 +1381,7 @@ delete_depth_small_v20(struct rte_lpm_v20 *lpm, uint32_t ip_masked,\n \treturn 0;\n }\n \n-static inline int32_t\n+static int32_t\n delete_depth_small_v1604(struct rte_lpm *lpm, uint32_t ip_masked,\n \tuint8_t depth, int32_t sub_rule_index, uint8_t sub_rule_depth)\n {\n@@ -1483,7 +1483,7 @@ delete_depth_small_v1604(struct rte_lpm *lpm, uint32_t ip_masked,\n * Return of value > -1 means tbl8 is in use but has all the same values and\n * thus can be recycled\n */\n-static inline int32_t\n+static int32_t\n tbl8_recycle_check_v20(struct rte_lpm_tbl_entry_v20 *tbl8,\n \t\tuint32_t tbl8_group_start)\n {\n@@ -1530,7 +1530,7 @@ tbl8_recycle_check_v20(struct rte_lpm_tbl_entry_v20 *tbl8,\n \treturn -EINVAL;\n }\n \n-static inline int32_t\n+static int32_t\n tbl8_recycle_check_v1604(struct rte_lpm_tbl_entry *tbl8,\n \t\tuint32_t tbl8_group_start)\n {\n@@ -1577,7 +1577,7 @@ tbl8_recycle_check_v1604(struct rte_lpm_tbl_entry *tbl8,\n \treturn -EINVAL;\n }\n \n-static inline int32_t\n+static int32_t\n delete_depth_big_v20(struct rte_lpm_v20 *lpm, uint32_t ip_masked,\n \tuint8_t depth, int32_t sub_rule_index, uint8_t sub_rule_depth)\n {\n@@ -1655,7 +1655,7 @@ delete_depth_big_v20(struct rte_lpm_v20 *lpm, uint32_t ip_masked,\n \treturn 0;\n }\n \n-static inline int32_t\n+static int32_t\n delete_depth_big_v1604(struct rte_lpm *lpm, uint32_t ip_masked,\n \tuint8_t depth, int32_t sub_rule_index, uint8_t sub_rule_depth)\n {\n", "prefixes": [ "v5", "1/6" ] }