Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/56387/?format=api
{ "id": 56387, "url": "http://patchwork.dpdk.org/api/patches/56387/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20190712090651.11824-1-david.hunt@intel.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190712090651.11824-1-david.hunt@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20190712090651.11824-1-david.hunt@intel.com", "date": "2019-07-12T09:06:51", "name": "[v1] examples/power: fix FreeBSD meson lib dependency", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "42b6d6caf8c8481abda1dd9df2fad5f822accd2b", "submitter": { "id": 342, "url": "http://patchwork.dpdk.org/api/people/342/?format=api", "name": "Hunt, David", "email": "david.hunt@intel.com" }, "delegate": { "id": 319, "url": "http://patchwork.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20190712090651.11824-1-david.hunt@intel.com/mbox/", "series": [ { "id": 5470, "url": "http://patchwork.dpdk.org/api/series/5470/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=5470", "date": "2019-07-12T09:06:51", "name": "[v1] examples/power: fix FreeBSD meson lib dependency", "version": 1, "mbox": "http://patchwork.dpdk.org/series/5470/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/56387/comments/", "check": "fail", "checks": "http://patchwork.dpdk.org/api/patches/56387/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id EA8521B9C6;\n\tFri, 12 Jul 2019 11:07:01 +0200 (CEST)", "from mga04.intel.com (mga04.intel.com [192.55.52.120])\n\tby dpdk.org (Postfix) with ESMTP id 16DE71B9AC\n\tfor <dev@dpdk.org>; Fri, 12 Jul 2019 11:06:59 +0200 (CEST)", "from fmsmga006.fm.intel.com ([10.253.24.20])\n\tby fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t12 Jul 2019 02:06:59 -0700", "from silpixa00399952.ir.intel.com (HELO\n\tsilpixa00399952.ger.corp.intel.com) ([10.237.222.88])\n\tby fmsmga006.fm.intel.com with ESMTP; 12 Jul 2019 02:06:58 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.63,481,1557212400\"; d=\"scan'208\";a=\"365550798\"", "From": "David Hunt <david.hunt@intel.com>", "To": "dev@dpdk.org", "Cc": "david.hunt@intel.com, bruce.richardson@intel.com, ferruh.yigit@intel.com", "Date": "Fri, 12 Jul 2019 10:06:51 +0100", "Message-Id": "<20190712090651.11824-1-david.hunt@intel.com>", "X-Mailer": "git-send-email 2.17.1", "Subject": "[dpdk-dev] [PATCH v1] examples/power: fix FreeBSD meson lib\n\tdependency", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Samples apps that depend on the power library should not build if\nthe power library is not present. So now the following apps will\ncheck to see if it's built, else skip building.\n* l3fwd-pwer\n* vm_power_manager\n* guest_cli\n\nFixes: e0130788576f (\"examples/power: support meson/ninja build\")\nFixes: 89f0711f9ddf (\"examples: build some samples with meson\")\nSigned-off-by: David Hunt <david.hunt@intel.com>\n---\n examples/l3fwd-power/meson.build | 6 ++++--\n examples/vm_power_manager/guest_cli/meson.build | 5 +++++\n examples/vm_power_manager/meson.build | 10 +++++++---\n 3 files changed, 16 insertions(+), 5 deletions(-)", "diff": "diff --git a/examples/l3fwd-power/meson.build b/examples/l3fwd-power/meson.build\nindex b38a7a0d7..d5a3d4bb2 100644\n--- a/examples/l3fwd-power/meson.build\n+++ b/examples/l3fwd-power/meson.build\n@@ -6,9 +6,11 @@\n # To build this example as a standalone application with an already-installed\n # DPDK instance, use 'make'\n \n-if not is_linux\n-\tbuild = false\n+if not dpdk_conf.has('RTE_LIBRTE_POWER')\n+ build = false\n+ subdir_done()\n endif\n+\n allow_experimental_apis = true\n deps += ['power', 'timer', 'lpm', 'hash', 'metrics']\n sources = files(\ndiff --git a/examples/vm_power_manager/guest_cli/meson.build b/examples/vm_power_manager/guest_cli/meson.build\nindex 9e821ceb8..38bd8d837 100644\n--- a/examples/vm_power_manager/guest_cli/meson.build\n+++ b/examples/vm_power_manager/guest_cli/meson.build\n@@ -10,6 +10,11 @@\n # vm_power_manager app because of the way the directories are parsed.\n name = 'guest_cli'\n \n+if not dpdk_conf.has('RTE_LIBRTE_POWER')\n+ build = false\n+ subdir_done()\n+endif\n+\n deps += ['power']\n \n sources = files(\ndiff --git a/examples/vm_power_manager/meson.build b/examples/vm_power_manager/meson.build\nindex f98445bc6..20a4a05b3 100644\n--- a/examples/vm_power_manager/meson.build\n+++ b/examples/vm_power_manager/meson.build\n@@ -6,6 +6,13 @@\n # To build this example as a standalone application with an already-installed\n # DPDK instance, use 'make'\n \n+if not dpdk_conf.has('RTE_LIBRTE_POWER')\n+\tbuild = false\n+\tsubdir_done()\n+endif\n+\n+deps += ['power']\n+\n if dpdk_conf.has('RTE_LIBRTE_BNXT_PMD')\n \tdeps += ['pmd_bnxt']\n endif\n@@ -18,9 +25,6 @@ if dpdk_conf.has('RTE_LIBRTE_IXGBE_PMD')\n \tdeps += ['pmd_ixgbe']\n endif\n \n-deps += ['power']\n-\n-\n sources = files(\n \t'channel_manager.c', 'channel_monitor.c', 'main.c', 'parse.c', 'power_manager.c', 'vm_power_cli.c'\n )\n", "prefixes": [ "v1" ] }