Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 56408,
    "url": "http://patchwork.dpdk.org/api/patches/56408/?format=api",
    "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20190712140402.8492-1-david.hunt@intel.com/",
    "project": {
        "id": 1,
        "url": "http://patchwork.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20190712140402.8492-1-david.hunt@intel.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20190712140402.8492-1-david.hunt@intel.com",
    "date": "2019-07-12T14:04:02",
    "name": "[v1] examples/vm_power: fix strcpy buffer overrun",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "907828874a04e1e6c75c2be4ff8613aac7deed1d",
    "submitter": {
        "id": 342,
        "url": "http://patchwork.dpdk.org/api/people/342/?format=api",
        "name": "Hunt, David",
        "email": "david.hunt@intel.com"
    },
    "delegate": {
        "id": 1,
        "url": "http://patchwork.dpdk.org/api/users/1/?format=api",
        "username": "tmonjalo",
        "first_name": "Thomas",
        "last_name": "Monjalon",
        "email": "thomas@monjalon.net"
    },
    "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20190712140402.8492-1-david.hunt@intel.com/mbox/",
    "series": [
        {
            "id": 5477,
            "url": "http://patchwork.dpdk.org/api/series/5477/?format=api",
            "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=5477",
            "date": "2019-07-12T14:04:02",
            "name": "[v1] examples/vm_power: fix strcpy buffer overrun",
            "version": 1,
            "mbox": "http://patchwork.dpdk.org/series/5477/mbox/"
        }
    ],
    "comments": "http://patchwork.dpdk.org/api/patches/56408/comments/",
    "check": "success",
    "checks": "http://patchwork.dpdk.org/api/patches/56408/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 99A6E1B9FA;\n\tFri, 12 Jul 2019 16:05:02 +0200 (CEST)",
            "from mga12.intel.com (mga12.intel.com [192.55.52.136])\n\tby dpdk.org (Postfix) with ESMTP id BC6822C23;\n\tFri, 12 Jul 2019 16:05:00 +0200 (CEST)",
            "from fmsmga006.fm.intel.com ([10.253.24.20])\n\tby fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t12 Jul 2019 07:04:59 -0700",
            "from silpixa00399952.ir.intel.com (HELO\n\tsilpixa00399952.ger.corp.intel.com) ([10.237.222.88])\n\tby fmsmga006.fm.intel.com with ESMTP; 12 Jul 2019 07:04:58 -0700"
        ],
        "X-Amp-Result": "SKIPPED(no attachment in message)",
        "X-Amp-File-Uploaded": "False",
        "X-ExtLoop1": "1",
        "X-IronPort-AV": "E=Sophos;i=\"5.63,482,1557212400\"; d=\"scan'208\";a=\"365618695\"",
        "From": "David Hunt <david.hunt@intel.com>",
        "To": "dev@dpdk.org",
        "Cc": "david.hunt@intel.com,\n\tstable@dpdk.org",
        "Date": "Fri, 12 Jul 2019 15:04:02 +0100",
        "Message-Id": "<20190712140402.8492-1-david.hunt@intel.com>",
        "X-Mailer": "git-send-email 2.17.1",
        "Subject": "[dpdk-dev] [PATCH v1] examples/vm_power: fix strcpy buffer overrun",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "replace strcpy with rte_strlcpy to prevent buffer overrun\nWith fix, attempting to use a VERY lonng vm name results in a nicely\ntruncated 32 character name rather than a segfault:\nSetting VM Name to [sdfdsfsfsdffdsdsasdsadasdakjshd]\n\nCc: stable@dpdk.org\nFixes: 59287933a0bb (\"examples/vm_power: add options to guest app\")\nSigned-off-by: David Hunt <david.hunt@intel.com>\n---\n examples/vm_power_manager/guest_cli/main.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)",
    "diff": "diff --git a/examples/vm_power_manager/guest_cli/main.c b/examples/vm_power_manager/guest_cli/main.c\nindex 36365b124..a18eb214a 100644\n--- a/examples/vm_power_manager/guest_cli/main.c\n+++ b/examples/vm_power_manager/guest_cli/main.c\n@@ -65,7 +65,7 @@ parse_args(int argc, char **argv)\n \t\tswitch (opt) {\n \t\t/* portmask */\n \t\tcase 'n':\n-\t\t\tstrcpy(policy->vm_name, optarg);\n+\t\t\trte_strlcpy(policy->vm_name, optarg, VM_MAX_NAME_SZ);\n \t\t\tprintf(\"Setting VM Name to [%s]\\n\", policy->vm_name);\n \t\t\tbreak;\n \t\tcase 'b':\n",
    "prefixes": [
        "v1"
    ]
}