Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 56784,
    "url": "http://patchwork.dpdk.org/api/patches/56784/?format=api",
    "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20190719133845.32432-5-olivier.matz@6wind.com/",
    "project": {
        "id": 1,
        "url": "http://patchwork.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20190719133845.32432-5-olivier.matz@6wind.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20190719133845.32432-5-olivier.matz@6wind.com",
    "date": "2019-07-19T13:38:45",
    "name": "[RFC,4/4] mempool: prevent objects from being across pages",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "a70339cac6d98708f8977e80bd27ba07ea33d083",
    "submitter": {
        "id": 8,
        "url": "http://patchwork.dpdk.org/api/people/8/?format=api",
        "name": "Olivier Matz",
        "email": "olivier.matz@6wind.com"
    },
    "delegate": {
        "id": 1,
        "url": "http://patchwork.dpdk.org/api/users/1/?format=api",
        "username": "tmonjalo",
        "first_name": "Thomas",
        "last_name": "Monjalon",
        "email": "thomas@monjalon.net"
    },
    "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20190719133845.32432-5-olivier.matz@6wind.com/mbox/",
    "series": [
        {
            "id": 5624,
            "url": "http://patchwork.dpdk.org/api/series/5624/?format=api",
            "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=5624",
            "date": "2019-07-19T13:38:41",
            "name": "mempool: avoid objects allocations across pages",
            "version": 1,
            "mbox": "http://patchwork.dpdk.org/series/5624/mbox/"
        }
    ],
    "comments": "http://patchwork.dpdk.org/api/patches/56784/comments/",
    "check": "success",
    "checks": "http://patchwork.dpdk.org/api/patches/56784/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 380951B959;\n\tFri, 19 Jul 2019 15:39:11 +0200 (CEST)",
            "from proxy.6wind.com (host.76.145.23.62.rev.coltfrance.com\n\t[62.23.145.76]) by dpdk.org (Postfix) with ESMTP id E68224D27\n\tfor <dev@dpdk.org>; Fri, 19 Jul 2019 15:38:59 +0200 (CEST)",
            "from glumotte.dev.6wind.com. (unknown [10.16.0.195])\n\tby proxy.6wind.com (Postfix) with ESMTP id C8FED2ED328;\n\tFri, 19 Jul 2019 15:38:59 +0200 (CEST)"
        ],
        "From": "Olivier Matz <olivier.matz@6wind.com>",
        "To": "Vamsi Krishna Attunuru <vattunuru@marvell.com>,\n\tdev@dpdk.org",
        "Cc": "Andrew Rybchenko <arybchenko@solarflare.com>,\n\tThomas Monjalon <thomas@monjalon.net>,\n\tAnatoly Burakov <anatoly.burakov@intel.com>,\n\tJerin Jacob Kollanukkaran <jerinj@marvell.com>,\n\tKokkilagadda <kirankumark@marvell.com>,\n\tFerruh Yigit <ferruh.yigit@intel.com>",
        "Date": "Fri, 19 Jul 2019 15:38:45 +0200",
        "Message-Id": "<20190719133845.32432-5-olivier.matz@6wind.com>",
        "X-Mailer": "git-send-email 2.11.0",
        "In-Reply-To": "<20190719133845.32432-1-olivier.matz@6wind.com>",
        "References": "<CH2PR18MB338160CD8EF16EEB45EED387A6C80@CH2PR18MB3381.namprd18.prod.outlook.com>\n\t<20190719133845.32432-1-olivier.matz@6wind.com>",
        "Subject": "[dpdk-dev] [RFC 4/4] mempool: prevent objects from being across\n\tpages",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "When using iova contiguous memory and objets smaller than page size,\nensure that objects are not located across several pages.\n\nSigned-off-by: Vamsi Krishna Attunuru <vattunuru@marvell.com>\nSigned-off-by: Olivier Matz <olivier.matz@6wind.com>\n---\n lib/librte_mempool/rte_mempool_ops_default.c | 39 ++++++++++++++++++++++++++--\n 1 file changed, 37 insertions(+), 2 deletions(-)",
    "diff": "diff --git a/lib/librte_mempool/rte_mempool_ops_default.c b/lib/librte_mempool/rte_mempool_ops_default.c\nindex 4e2bfc82d..2bbd67367 100644\n--- a/lib/librte_mempool/rte_mempool_ops_default.c\n+++ b/lib/librte_mempool/rte_mempool_ops_default.c\n@@ -45,19 +45,54 @@ rte_mempool_op_calc_mem_size_default(const struct rte_mempool *mp,\n \treturn mem_size;\n }\n \n+/* Returns -1 if object falls on a page boundary, else returns 0 */\n+static inline int\n+mempool_check_obj_bounds(void *obj, uint64_t pg_sz, size_t elt_sz)\n+{\n+\tuintptr_t page_end, elt_addr = (uintptr_t)obj;\n+\tuint32_t pg_shift;\n+\tuint64_t page_mask;\n+\n+\tif (pg_sz == 0)\n+\t\treturn 0;\n+\tif (elt_sz > pg_sz)\n+\t\treturn 0;\n+\n+\tpg_shift = rte_bsf32(pg_sz);\n+\tpage_mask =  ~((1ull << pg_shift) - 1);\n+\tpage_end = (elt_addr & page_mask) + pg_sz;\n+\n+\tif (elt_addr + elt_sz > page_end)\n+\t\treturn -1;\n+\n+\treturn 0;\n+}\n+\n int\n rte_mempool_op_populate_default(struct rte_mempool *mp, unsigned int max_objs,\n \t\tvoid *vaddr, rte_iova_t iova, size_t len,\n \t\trte_mempool_populate_obj_cb_t *obj_cb, void *obj_cb_arg)\n {\n-\tsize_t total_elt_sz;\n+\tsize_t total_elt_sz, pg_sz;\n \tsize_t off;\n \tunsigned int i;\n \tvoid *obj;\n \n+\trte_mempool_get_page_size(mp, &pg_sz);\n+\n \ttotal_elt_sz = mp->header_size + mp->elt_size + mp->trailer_size;\n \n-\tfor (off = 0, i = 0; off + total_elt_sz <= len && i < max_objs; i++) {\n+\tfor (off = 0, i = 0; i < max_objs; i++) {\n+\t\t/* align offset to next page start if required */\n+\t\tif (mempool_check_obj_bounds((char *)vaddr + off,\n+\t\t\t\t\t\tpg_sz, total_elt_sz) < 0) {\n+\t\t\toff += RTE_PTR_ALIGN_CEIL((char *)vaddr + off, pg_sz) -\n+\t\t\t\t((char *)vaddr + off);\n+\t\t}\n+\n+\t\tif (off + total_elt_sz > len)\n+\t\t\tbreak;\n+\n \t\toff += mp->header_size;\n \t\tobj = (char *)vaddr + off;\n \t\tobj_cb(mp, obj_cb_arg, obj,\n",
    "prefixes": [
        "RFC",
        "4/4"
    ]
}