Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/57085/?format=api
{ "id": 57085, "url": "http://patchwork.dpdk.org/api/patches/57085/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/1564046068-21905-8-git-send-email-david.marchand@redhat.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1564046068-21905-8-git-send-email-david.marchand@redhat.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1564046068-21905-8-git-send-email-david.marchand@redhat.com", "date": "2019-07-25T09:14:27", "name": "[7/8] net/ring: do not count unsent packets as errors", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "c043178af3defebde0c503a0171e07a39c364b31", "submitter": { "id": 1173, "url": "http://patchwork.dpdk.org/api/people/1173/?format=api", "name": "David Marchand", "email": "david.marchand@redhat.com" }, "delegate": { "id": 319, "url": "http://patchwork.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/1564046068-21905-8-git-send-email-david.marchand@redhat.com/mbox/", "series": [ { "id": 5740, "url": "http://patchwork.dpdk.org/api/series/5740/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=5740", "date": "2019-07-25T09:14:20", "name": "oerrors stats fixes for virtual pmds", "version": 1, "mbox": "http://patchwork.dpdk.org/series/5740/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/57085/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/57085/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 09D611C295;\n\tThu, 25 Jul 2019 11:15:08 +0200 (CEST)", "from mx1.redhat.com (mx1.redhat.com [209.132.183.28])\n\tby dpdk.org (Postfix) with ESMTP id F31DF1C2F1;\n\tThu, 25 Jul 2019 11:15:01 +0200 (CEST)", "from smtp.corp.redhat.com\n\t(int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 534473084246;\n\tThu, 25 Jul 2019 09:15:01 +0000 (UTC)", "from dmarchan.remote.csb (ovpn-204-235.brq.redhat.com\n\t[10.40.204.235])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 5728C60BEC;\n\tThu, 25 Jul 2019 09:14:59 +0000 (UTC)" ], "From": "David Marchand <david.marchand@redhat.com>", "To": "dev@dpdk.org", "Cc": "ferruh.yigit@intel.com, stable@dpdk.org,\n\tBruce Richardson <bruce.richardson@intel.com>", "Date": "Thu, 25 Jul 2019 11:14:27 +0200", "Message-Id": "<1564046068-21905-8-git-send-email-david.marchand@redhat.com>", "In-Reply-To": "<1564046068-21905-1-git-send-email-david.marchand@redhat.com>", "References": "<1564046068-21905-1-git-send-email-david.marchand@redhat.com>", "X-Scanned-By": "MIMEDefang 2.79 on 10.5.11.12", "X-Greylist": "Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.40]); Thu, 25 Jul 2019 09:15:01 +0000 (UTC)", "Subject": "[dpdk-dev] [PATCH 7/8] net/ring: do not count unsent packets as\n\terrors", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "err_pkts reflects the number of packets that the driver did not manage\nto send.\nThis is a temporary situation, those packets are not freed and the\napplication can still retry to send them later.\nHence, we can't count them as transmit failed.\n\nFixes: e1e4017751f1 (\"ring: add new driver\")\nCc: stable@dpdk.org\n\nSigned-off-by: David Marchand <david.marchand@redhat.com>\n---\n drivers/net/ring/rte_eth_ring.c | 4 +---\n 1 file changed, 1 insertion(+), 3 deletions(-)", "diff": "diff --git a/drivers/net/ring/rte_eth_ring.c b/drivers/net/ring/rte_eth_ring.c\nindex eb347bc..eef7606 100644\n--- a/drivers/net/ring/rte_eth_ring.c\n+++ b/drivers/net/ring/rte_eth_ring.c\n@@ -172,7 +172,7 @@ static int\n eth_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *stats)\n {\n \tunsigned int i;\n-\tunsigned long rx_total = 0, tx_total = 0, tx_err_total = 0;\n+\tunsigned long rx_total = 0, tx_total = 0;\n \tconst struct pmd_internals *internal = dev->data->dev_private;\n \n \tfor (i = 0; i < RTE_ETHDEV_QUEUE_STAT_CNTRS &&\n@@ -185,12 +185,10 @@ eth_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *stats)\n \t\t\ti < dev->data->nb_tx_queues; i++) {\n \t\tstats->q_opackets[i] = internal->tx_ring_queues[i].tx_pkts.cnt;\n \t\ttx_total += stats->q_opackets[i];\n-\t\ttx_err_total += internal->tx_ring_queues[i].err_pkts.cnt;\n \t}\n \n \tstats->ipackets = rx_total;\n \tstats->opackets = tx_total;\n-\tstats->oerrors = tx_err_total;\n \n \treturn 0;\n }\n", "prefixes": [ "7/8" ] }