Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/57226/?format=api
{ "id": 57226, "url": "http://patchwork.dpdk.org/api/patches/57226/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20190729121313.30639-6-vattunuru@marvell.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190729121313.30639-6-vattunuru@marvell.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20190729121313.30639-6-vattunuru@marvell.com", "date": "2019-07-29T12:13:13", "name": "[v9,5/5] kni: modify IOVA mode checks to support VA", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "c0994ecd02e92437af37170475da71cfe8babdfe", "submitter": { "id": 1277, "url": "http://patchwork.dpdk.org/api/people/1277/?format=api", "name": "Vamsi Krishna Attunuru", "email": "vattunuru@marvell.com" }, "delegate": { "id": 1, "url": "http://patchwork.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20190729121313.30639-6-vattunuru@marvell.com/mbox/", "series": [ { "id": 5808, "url": "http://patchwork.dpdk.org/api/series/5808/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=5808", "date": "2019-07-29T12:13:08", "name": "kni: add IOVA=VA support", "version": 9, "mbox": "http://patchwork.dpdk.org/series/5808/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/57226/comments/", "check": "fail", "checks": "http://patchwork.dpdk.org/api/patches/57226/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 1C2711BF6E;\n\tMon, 29 Jul 2019 14:13:55 +0200 (CEST)", "from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com\n\t[67.231.148.174]) by dpdk.org (Postfix) with ESMTP id 611D71BF51\n\tfor <dev@dpdk.org>; Mon, 29 Jul 2019 14:13:49 +0200 (CEST)", "from pps.filterd (m0045849.ppops.net [127.0.0.1])\n\tby mx0a-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id\n\tx6TCAOPx027447; Mon, 29 Jul 2019 05:13:47 -0700", "from sc-exch03.marvell.com ([199.233.58.183])\n\tby mx0a-0016f401.pphosted.com with ESMTP id 2u0kyq0183-1\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); \n\tMon, 29 Jul 2019 05:13:47 -0700", "from SC-EXCH01.marvell.com (10.93.176.81) by SC-EXCH03.marvell.com\n\t(10.93.176.83) with Microsoft SMTP Server (TLS) id 15.0.1367.3;\n\tMon, 29 Jul 2019 05:13:46 -0700", "from maili.marvell.com (10.93.176.43) by SC-EXCH01.marvell.com\n\t(10.93.176.81) with Microsoft SMTP Server id 15.0.1367.3 via Frontend\n\tTransport; Mon, 29 Jul 2019 05:13:46 -0700", "from hyd1vattunuru-dt.caveonetworks.com (unknown [10.29.52.72])\n\tby maili.marvell.com (Postfix) with ESMTP id 81B0B3F703F;\n\tMon, 29 Jul 2019 05:13:43 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com;\n\th=from : to : cc :\n\tsubject : date : message-id : in-reply-to : references : mime-version\n\t: content-type; s=pfpt0818;\n\tbh=gpbLxqJAkOvx79mmhbKBWdL78pgaTGoUMwxzEdCMjXo=; \n\tb=K8ixG2j4/On8LAZFz003fjlx2UxUYxolVoUEZRJvsb6kRiNRxofTA5O+NuDtivXasNJv\n\tAZ3DSGTMAt5vzK/J8swQB27Xm7RzAWGEG/LCNAdW8kNUFZx2ucinF7ZR6mOjAoV0kk0C\n\tCt+YlzWTyBwIBrhEyvSUwmPBk+NtsY6btqBgNRNUrjClR5QEeAGbgiSH/Us6cZjvVrPG\n\tw+M3qhWJmbwN8AddmCrgDsMlTluB1svDoPQCrfHAJgALfHIJvIm4R0egSFBTdfFYnhhK\n\t61dzOhM3vDEh7tQlGG3NIcPuPdHJDBZGm/JuVAK5CaQb2cT0iD+3Dtzlk7peAs+d4i1a\n\tpw== ", "From": "<vattunuru@marvell.com>", "To": "<dev@dpdk.org>", "CC": "<thomas@monjalon.net>, <jerinj@marvell.com>, <olivier.matz@6wind.com>,\n\t<ferruh.yigit@intel.com>, <anatoly.burakov@intel.com>,\n\t<arybchenko@solarflare.com>, <kirankumark@marvell.com>, Vamsi Attunuru\n\t<vattunuru@marvell.com>", "Date": "Mon, 29 Jul 2019 17:43:13 +0530", "Message-ID": "<20190729121313.30639-6-vattunuru@marvell.com>", "X-Mailer": "git-send-email 2.8.4", "In-Reply-To": "<20190729121313.30639-1-vattunuru@marvell.com>", "References": "<20190723053821.30227-1-vattunuru@marvell.com>\n\t<20190729121313.30639-1-vattunuru@marvell.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-Proofpoint-Virus-Version": "vendor=fsecure engine=2.50.10434:5.22.84,1.0.8\n\tdefinitions=2019-07-29_06:2019-07-29,2019-07-29 signatures=0", "Subject": "[dpdk-dev] [PATCH v9 5/5] kni: modify IOVA mode checks to support VA", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Vamsi Attunuru <vattunuru@marvell.com>\n\nPatch addresses checks in KNI and eal that enforce IOVA=PA when\nIOVA=VA mode is enabled, since KNI kernel module supports VA\nmode for kernel versions >= 4.4.0.\n\nUpdated KNI documentation with above details.\n\nSigned-off-by: Vamsi Attunuru <vattunuru@marvell.com>\nSigned-off-by: Kiran Kumar K <kirankumark@marvell.com>\n---\n doc/guides/prog_guide/kernel_nic_interface.rst | 8 ++++++++\n lib/librte_eal/linux/eal/eal.c | 4 +++-\n lib/librte_kni/rte_kni.c | 5 -----\n 3 files changed, 11 insertions(+), 6 deletions(-)", "diff": "diff --git a/doc/guides/prog_guide/kernel_nic_interface.rst b/doc/guides/prog_guide/kernel_nic_interface.rst\nindex 38369b3..fd2ce63 100644\n--- a/doc/guides/prog_guide/kernel_nic_interface.rst\n+++ b/doc/guides/prog_guide/kernel_nic_interface.rst\n@@ -291,6 +291,14 @@ The sk_buff is then freed and the mbuf sent in the tx_q FIFO.\n The DPDK TX thread dequeues the mbuf and sends it to the PMD via ``rte_eth_tx_burst()``.\n It then puts the mbuf back in the cache.\n \n+IOVA = VA: Support\n+------------------\n+\n+KNI can be operated in IOVA as VA scheme when following criteria are fullfilled\n+\n+- LINUX_VERSION_CODE >= KERNEL_VERSION(4, 4, 0)\n+- eal param `--iova-mode va` is passed or bus IOVA scheme is set to RTE_IOVA_VA\n+\n Ethtool\n -------\n \ndiff --git a/lib/librte_eal/linux/eal/eal.c b/lib/librte_eal/linux/eal/eal.c\nindex 34db787..428425d 100644\n--- a/lib/librte_eal/linux/eal/eal.c\n+++ b/lib/librte_eal/linux/eal/eal.c\n@@ -1068,12 +1068,14 @@ rte_eal_init(int argc, char **argv)\n \t\t/* Workaround for KNI which requires physical address to work */\n \t\tif (iova_mode == RTE_IOVA_VA &&\n \t\t\t\trte_eal_check_module(\"rte_kni\") == 1) {\n+#if KERNEL_VERSION(4, 4, 0) > LINUX_VERSION_CODE\n \t\t\tif (phys_addrs) {\n \t\t\t\tiova_mode = RTE_IOVA_PA;\n-\t\t\t\tRTE_LOG(WARNING, EAL, \"Forcing IOVA as 'PA' because KNI module is loaded\\n\");\n+\t\t\t\tRTE_LOG(WARNING, EAL, \"Forcing IOVA as 'PA' because KNI module does not support VA\\n\");\n \t\t\t} else {\n \t\t\t\tRTE_LOG(DEBUG, EAL, \"KNI can not work since physical addresses are unavailable\\n\");\n \t\t\t}\n+#endif\n \t\t}\n #endif\n \t\trte_eal_get_configuration()->iova_mode = iova_mode;\ndiff --git a/lib/librte_kni/rte_kni.c b/lib/librte_kni/rte_kni.c\nindex 15dda45..c77d76f 100644\n--- a/lib/librte_kni/rte_kni.c\n+++ b/lib/librte_kni/rte_kni.c\n@@ -99,11 +99,6 @@ static volatile int kni_fd = -1;\n int\n rte_kni_init(unsigned int max_kni_ifaces __rte_unused)\n {\n-\tif (rte_eal_iova_mode() != RTE_IOVA_PA) {\n-\t\tRTE_LOG(ERR, KNI, \"KNI requires IOVA as PA\\n\");\n-\t\treturn -1;\n-\t}\n-\n \t/* Check FD and open */\n \tif (kni_fd < 0) {\n \t\tkni_fd = open(\"/dev/\" KNI_DEVICE, O_RDWR);\n", "prefixes": [ "v9", "5/5" ] }