Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/57743/?format=api
{ "id": 57743, "url": "http://patchwork.dpdk.org/api/patches/57743/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/1566214919-32250-3-git-send-email-david.marchand@redhat.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1566214919-32250-3-git-send-email-david.marchand@redhat.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1566214919-32250-3-git-send-email-david.marchand@redhat.com", "date": "2019-08-19T11:41:50", "name": "[02/11] log: define logtype register wrapper for drivers", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "5c989f460be960060f2598b9ccbdf7f93d362dbc", "submitter": { "id": 1173, "url": "http://patchwork.dpdk.org/api/people/1173/?format=api", "name": "David Marchand", "email": "david.marchand@redhat.com" }, "delegate": { "id": 1, "url": "http://patchwork.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/1566214919-32250-3-git-send-email-david.marchand@redhat.com/mbox/", "series": [ { "id": 6072, "url": "http://patchwork.dpdk.org/api/series/6072/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=6072", "date": "2019-08-19T11:41:48", "name": "Fixing log levels for dynamically loaded drivers", "version": 1, "mbox": "http://patchwork.dpdk.org/series/6072/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/57743/comments/", "check": "fail", "checks": "http://patchwork.dpdk.org/api/patches/57743/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id E8C091BEBE;\n\tMon, 19 Aug 2019 13:42:19 +0200 (CEST)", "from mx1.redhat.com (mx1.redhat.com [209.132.183.28])\n\tby dpdk.org (Postfix) with ESMTP id 663B91BEB5\n\tfor <dev@dpdk.org>; Mon, 19 Aug 2019 13:42:17 +0200 (CEST)", "from smtp.corp.redhat.com\n\t(int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id DDB8A190C107\n\tfor <dev@dpdk.org>; Mon, 19 Aug 2019 11:42:16 +0000 (UTC)", "from dmarchan.remote.csb (ovpn-204-32.brq.redhat.com\n\t[10.40.204.32])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 2219D1001B14\n\tfor <dev@dpdk.org>; Mon, 19 Aug 2019 11:42:15 +0000 (UTC)" ], "From": "David Marchand <david.marchand@redhat.com>", "To": "dev@dpdk.org", "Date": "Mon, 19 Aug 2019 13:41:50 +0200", "Message-Id": "<1566214919-32250-3-git-send-email-david.marchand@redhat.com>", "In-Reply-To": "<1566214919-32250-1-git-send-email-david.marchand@redhat.com>", "References": "<1566214919-32250-1-git-send-email-david.marchand@redhat.com>", "X-Scanned-By": "MIMEDefang 2.84 on 10.5.11.22", "X-Greylist": "Sender IP whitelisted, not delayed by milter-greylist-4.6.2\n\t(mx1.redhat.com [10.5.110.70]); Mon, 19 Aug 2019 11:42:16 +0000 (UTC)", "Subject": "[dpdk-dev] [PATCH 02/11] log: define logtype register wrapper for\n\tdrivers", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The function rte_log_register_type_and_pick_level() fills a gap for\ndynamically loaded code (especially drivers) who would not pick up\nthe log level passed at startup.\n\nLet's promote it to stable and export it for use by drivers via\na wrapper.\n\nSigned-off-by: David Marchand <david.marchand@redhat.com>\n---\n lib/librte_eal/common/include/rte_log.h | 12 ++++++++----\n lib/librte_eal/rte_eal_version.map | 8 +++++++-\n 2 files changed, 15 insertions(+), 5 deletions(-)", "diff": "diff --git a/lib/librte_eal/common/include/rte_log.h b/lib/librte_eal/common/include/rte_log.h\nindex cbb4184..c3aff00 100644\n--- a/lib/librte_eal/common/include/rte_log.h\n+++ b/lib/librte_eal/common/include/rte_log.h\n@@ -209,9 +209,6 @@ int rte_log_cur_msg_logtype(void);\n int rte_log_register(const char *name);\n \n /**\n- * @warning\n- * @b EXPERIMENTAL: this API may change without prior notice\n- *\n * Register a dynamic log type and try to pick its level from EAL options\n *\n * rte_log_register() is called inside. If successful, the function tries\n@@ -227,9 +224,16 @@ int rte_log_register(const char *name);\n * - >=0: the newly registered log type\n * - <0: rte_log_register() error value\n */\n-__rte_experimental\n int rte_log_register_type_and_pick_level(const char *name, uint32_t level_def);\n \n+#define RTE_LOG_REGISTER(token, name, level, fallback) \\\n+RTE_INIT(token##_init) \\\n+{ \\\n+\ttoken = rte_log_register_type_and_pick_level(name, level); \\\n+\tif (token < 0) \\\n+\t\ttoken = fallback; \\\n+}\n+\n /**\n * Dump log information.\n *\ndiff --git a/lib/librte_eal/rte_eal_version.map b/lib/librte_eal/rte_eal_version.map\nindex 7cbf82d..7326e92 100644\n--- a/lib/librte_eal/rte_eal_version.map\n+++ b/lib/librte_eal/rte_eal_version.map\n@@ -312,6 +312,13 @@ DPDK_19.08 {\n \n } DPDK_19.05;\n \n+DPDK_19.11 {\n+\tglobal:\n+\n+\trte_log_register_type_and_pick_level;\n+\n+} DPDK_19.08;\n+\n EXPERIMENTAL {\n \tglobal:\n \n@@ -342,7 +349,6 @@ EXPERIMENTAL {\n \trte_fbarray_is_used;\n \trte_fbarray_set_free;\n \trte_fbarray_set_used;\n-\trte_log_register_type_and_pick_level;\n \trte_malloc_dump_heaps;\n \trte_mem_alloc_validator_register;\n \trte_mem_alloc_validator_unregister;\n", "prefixes": [ "02/11" ] }