Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/57744/?format=api
{ "id": 57744, "url": "http://patchwork.dpdk.org/api/patches/57744/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/1566214919-32250-4-git-send-email-david.marchand@redhat.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1566214919-32250-4-git-send-email-david.marchand@redhat.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1566214919-32250-4-git-send-email-david.marchand@redhat.com", "date": "2019-08-19T11:41:51", "name": "[03/11] drivers/baseband: use new logtype wrapper", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "0bd0d3365d4dbc14c7c7fcb25cf4b134d6c207a8", "submitter": { "id": 1173, "url": "http://patchwork.dpdk.org/api/people/1173/?format=api", "name": "David Marchand", "email": "david.marchand@redhat.com" }, "delegate": { "id": 1, "url": "http://patchwork.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/1566214919-32250-4-git-send-email-david.marchand@redhat.com/mbox/", "series": [ { "id": 6072, "url": "http://patchwork.dpdk.org/api/series/6072/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=6072", "date": "2019-08-19T11:41:48", "name": "Fixing log levels for dynamically loaded drivers", "version": 1, "mbox": "http://patchwork.dpdk.org/series/6072/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/57744/comments/", "check": "fail", "checks": "http://patchwork.dpdk.org/api/patches/57744/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id A29931BEC2;\n\tMon, 19 Aug 2019 13:42:21 +0200 (CEST)", "from mx1.redhat.com (mx1.redhat.com [209.132.183.28])\n\tby dpdk.org (Postfix) with ESMTP id 58E401BEB9\n\tfor <dev@dpdk.org>; Mon, 19 Aug 2019 13:42:19 +0200 (CEST)", "from smtp.corp.redhat.com\n\t(int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id B44A57BDAC;\n\tMon, 19 Aug 2019 11:42:18 +0000 (UTC)", "from dmarchan.remote.csb (ovpn-204-32.brq.redhat.com\n\t[10.40.204.32])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id A4E661001B17;\n\tMon, 19 Aug 2019 11:42:17 +0000 (UTC)" ], "From": "David Marchand <david.marchand@redhat.com>", "To": "dev@dpdk.org", "Cc": "Nicolas Chautru <nicolas.chautru@intel.com>", "Date": "Mon, 19 Aug 2019 13:41:51 +0200", "Message-Id": "<1566214919-32250-4-git-send-email-david.marchand@redhat.com>", "In-Reply-To": "<1566214919-32250-1-git-send-email-david.marchand@redhat.com>", "References": "<1566214919-32250-1-git-send-email-david.marchand@redhat.com>", "X-Scanned-By": "MIMEDefang 2.84 on 10.5.11.22", "X-Greylist": "Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.26]); Mon, 19 Aug 2019 11:42:18 +0000 (UTC)", "Subject": "[dpdk-dev] [PATCH 03/11] drivers/baseband: use new logtype wrapper", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Make use of the newly introduced wrapper.\n\nSigned-off-by: David Marchand <david.marchand@redhat.com>\n---\n drivers/baseband/fpga_lte_fec/fpga_lte_fec.c | 11 ++++-------\n drivers/baseband/null/bbdev_null.c | 8 ++------\n drivers/baseband/turbo_sw/bbdev_turbo_software.c | 8 ++------\n 3 files changed, 8 insertions(+), 19 deletions(-)", "diff": "diff --git a/drivers/baseband/fpga_lte_fec/fpga_lte_fec.c b/drivers/baseband/fpga_lte_fec/fpga_lte_fec.c\nindex 7e05b94..397ca8f 100644\n--- a/drivers/baseband/fpga_lte_fec/fpga_lte_fec.c\n+++ b/drivers/baseband/fpga_lte_fec/fpga_lte_fec.c\n@@ -2663,13 +2663,10 @@ RTE_PMD_REGISTER_PCI(FPGA_LTE_FEC_VF_DRIVER_NAME, fpga_lte_fec_pci_vf_driver);\n RTE_PMD_REGISTER_PCI_TABLE(FPGA_LTE_FEC_VF_DRIVER_NAME,\n \t\tpci_id_fpga_lte_fec_vf_map);\n \n-RTE_INIT(fpga_lte_fec_init_log)\n-{\n-\tfpga_lte_fec_logtype = rte_log_register(\"pmd.bb.fpga_lte_fec\");\n-\tif (fpga_lte_fec_logtype >= 0)\n+RTE_LOG_REGISTER(fpga_lte_fec_logtype, \"pmd.bb.fpga_lte_fec\",\n #ifdef RTE_LIBRTE_BBDEV_DEBUG\n-\t\trte_log_set_level(fpga_lte_fec_logtype, RTE_LOG_DEBUG);\n+\tRTE_LOG_DEBUG\n #else\n-\t\trte_log_set_level(fpga_lte_fec_logtype, RTE_LOG_NOTICE);\n+\tRTE_LOG_NOTICE\n #endif\n-}\n+\t, RTE_LOGTYPE_PMD);\ndiff --git a/drivers/baseband/null/bbdev_null.c b/drivers/baseband/null/bbdev_null.c\nindex 2f25151..029c308 100644\n--- a/drivers/baseband/null/bbdev_null.c\n+++ b/drivers/baseband/null/bbdev_null.c\n@@ -348,9 +348,5 @@ RTE_PMD_REGISTER_PARAM_STRING(DRIVER_NAME,\n \tBBDEV_NULL_SOCKET_ID_ARG\"=<int>\");\n RTE_PMD_REGISTER_ALIAS(DRIVER_NAME, bbdev_null);\n \n-RTE_INIT(null_bbdev_init_log)\n-{\n-\tbbdev_null_logtype = rte_log_register(\"pmd.bb.null\");\n-\tif (bbdev_null_logtype >= 0)\n-\t\trte_log_set_level(bbdev_null_logtype, RTE_LOG_NOTICE);\n-}\n+RTE_LOG_REGISTER(bbdev_null_logtype, \"pmd.bb.null\",\n+\tRTE_LOG_NOTICE, RTE_LOGTYPE_PMD);\ndiff --git a/drivers/baseband/turbo_sw/bbdev_turbo_software.c b/drivers/baseband/turbo_sw/bbdev_turbo_software.c\nindex f2fe7a2..fb0bbbe 100644\n--- a/drivers/baseband/turbo_sw/bbdev_turbo_software.c\n+++ b/drivers/baseband/turbo_sw/bbdev_turbo_software.c\n@@ -1988,9 +1988,5 @@ RTE_PMD_REGISTER_PARAM_STRING(DRIVER_NAME,\n \tTURBO_SW_SOCKET_ID_ARG\"=<int>\");\n RTE_PMD_REGISTER_ALIAS(DRIVER_NAME, turbo_sw);\n \n-RTE_INIT(turbo_sw_bbdev_init_log)\n-{\n-\tbbdev_turbo_sw_logtype = rte_log_register(\"pmd.bb.turbo_sw\");\n-\tif (bbdev_turbo_sw_logtype >= 0)\n-\t\trte_log_set_level(bbdev_turbo_sw_logtype, RTE_LOG_NOTICE);\n-}\n+RTE_LOG_REGISTER(bbdev_turbo_sw_logtype, \"pmd.bb.turbo_sw\",\n+\tRTE_LOG_NOTICE, RTE_LOGTYPE_PMD);\n", "prefixes": [ "03/11" ] }